September 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR3850: capi2032: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3850

1 0

Re: [PATCH v3 0/1] MR3849: netapi32: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3849

1 0

[PATCH 0/1] MR3864: wined3d: Pass a wined3d_stateblock_state to wined3d_device_validate_device().
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

I wrote this patch some time ago, and I'm not really sure why I did. I don't think it was necessary for any refactoring. Looking at it again, though, I think it does make sense. Device validation is a high-level operation, and I think it's clearer if we're checking the d3d states directly here. This also means we're not unnecessarily applying the stateblock here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3864

2 1

[PATCH 0/3] MR3863: wined3d: Various stateblock refactoring.
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3863

2 3

Re: [PATCH v2 0/1] MR3591: http: Use CRT allocation functions. - approved
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3591

1 0

Re: [PATCH v2 0/1] MR3593: newdev: Use CRT allocation functions. - approved
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3593

1 0

[PATCH 0/1] MR3856: wined3d: Don't validate the frontbuffer's DRAWABLE location in wined3d_swapchain_resize_buffers() when NO3D is set.
by Henri Verbeet (＠hverbeet) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3856

3 2

[PATCH 0/1] MR3853: d3drm: Correctly query for the returned interface
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '23

15 Sep '23

IDirect3DRM2::CreateTextureFromSurface is expected to return an IDirect3DRMTexture2 object. The IDirect3DRMTexture* interfaces aren't derived from each other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3853

3 2

[PATCH v2 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 15 Sep '23

15 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v2: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

4 7

[PATCH 0/1] MR3846: winmm: Handle memory allocation failure in MMDRV_InitPerType (cppcheck).
by Alex Henrie (＠alexhenrie) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3846

4 6

[PATCH 0/8] MR3858: mshtml: Traverse and unlink elements using the dispex vtbl, part 2.
by Gabriel Ivăncescu (＠insn) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3858

4 10

[PATCH 0/4] MR3836: Added definitions and initial tests for FileRenameInformationEx and FileLinkInformationEx
by Joel Holdsworth (＠jhol) 15 Sep '23

15 Sep '23

This patch-set adds the definitions and struct modifications required to eventually implement `FileRenameInformationEx` and `FileLinkInformationEx`. The initial tests are copies of the tests for `FileRenameInformation` and `FileLinkInformation`, but with the `ReplaceIfExists` field replaced with the equivalient `Flag` value: `FILE_RENAME_REPLACE_IF_EXISTS` or `FILE_LINK_REPLACE_IF_EXISTS` respectively. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3836

4 10

[PATCH 0/1] MR3860: dbghelp: Don't insert dwz file map into module's file maps' chain.
by eric pouech (＠epo) 15 Sep '23

15 Sep '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3860

2 1

[PATCH v4 0/2] MR283: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64.
by Jinoh Kang (＠iamahuman) 15 Sep '23

15 Sep '23

-- v4: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64. ntdll/tests: Test for setting x86 / x64 EFLAGS register in context. https://gitlab.winehq.org/wine/wine/-/merge_requests/283

2 2

[PATCH v2 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) 15 Sep '23

15 Sep '23

-- v2: cryptui: Use CertNameToStr(CERT_NAME_STR_NO_QUOTING_FLAG) to disable quoting. crypt32: Add support for CERT_NAME_STR_NO_QUOTING_FLAG to CertNameToStr(). crypt32/tests: Add some tests for quoted RDN values. crypt32: Avoid truncating unicode chars. https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

2 4

[PATCH 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 15 Sep '23

15 Sep '23

This goes on top of MR 320 and 345. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

5 20

[PATCH v4 0/11] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) 15 Sep '23

15 Sep '23

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- v4: wined3d: Don't skip ARB fragment program selection when fog state is dirty. wined3d: Skip acquiring a context for an offscreen resource in texture2d_read_from_framebuffer(). wined3d: Don't force going through a texture when downloading from renderbuffers. wined3d: Handle depth textures in texture2d_read_from_framebuffer(). wined3d: Rename wined3d_context_gl_apply_fbo_state_blit() function. wined3d: Don't setup FBO and draw buffers in wined3d_context_gl_apply_blit_state(). wined3d: Don't call wined3d_texture_load() from wined3d_context_gl_apply_blit_state(). wined3d: Don't bind the FBO to GL_READ_FRAMEBUFFER in wined3d_context_gl_apply_blit_state(). wined3d: Prepare/load the destination resource location in arbfp_blitter_blit(). wined3d: Prepare/load the destination resource location in ffp_blitter_blit(). wined3d: Don't call wined3d_context_gl_apply_blit_state() from texture2d_read_from_framebuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

5 14

[PATCH 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

3 9

[PATCH 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '23

15 Sep '23

Based on patch by Michael Müller. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854

2 1

[PATCH 0/2] MR3843: d3dx9: Handle special adjacency index value in d3dx9_mesh_OptimizeInplace().
by Paul Gofman (＠gofman) 15 Sep '23

15 Sep '23

Avoid crash in d3dx9_mesh_OptimizeInplace(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3843

3 4

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Looks good. I've pointed out a few small corrections. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45501

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + key_data = (BYTE *)key_data + key_size; > + rw_data = (BYTE *)rw_data + rw_size; > + dynamic_data = (BYTE *)dynamic_data + dynamic_size; > + static_data = (BYTE *)static_data + static_size; > + } > + num++; > + } > + fclose(fp); > + } > +#else > FIXME( "not implemented\n" ); > - *count = 0; > - return STATUS_SUCCESS; > + return STATUS_NOT_IMPLEMENTED; > +#endif > + There are some extraneous spaces on this line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45500

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) > + { > + if (!isalnum( *nptr ) || !isalnum( *nptr+1 )) `isxdigit()`? Also, please add a space either side of the `+`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45499

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + { > + memset( dyn, 0, sizeof(*dyn) ); > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) Again something like `sizeof(ret)` instead of `16`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45498

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + struct in6_addr prefix; > + UINT prefix_len; > + struct in6_addr next_hop; > + UINT metric; > + UINT protocol; > + BYTE loopback; > +}; > + > +static void ipv6_forward_fill_entry( struct ipv6_route_data *entry, struct nsi_ipv6_forward_key *key, > + struct nsi_ip_forward_rw *rw, struct nsi_ipv6_forward_dynamic *dyn, > + struct nsi_ip_forward_static *stat ) > +{ > + if (key) > + { > + key->unk = 0; > + memcpy( key->prefix.u.Byte, entry->prefix.s6_addr, 16 ); Please use something like `sizeof(entry->prefix)` instead of `16`. Also for `next_hop` below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45497

1 0

[PATCH 0/1] MR3841: wineps: Fix EMRPOLYDRAW16 printing.
by Piotr Caban (＠piotr) 15 Sep '23

15 Sep '23

It fixes EMRPOLYDRAW16 printing when -O2 option is used (in GCC 12.3.1). The compiler assumes that apts table has 0 or 1 elements and optimizes the loop out. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3841

3 5

[PATCH 0/1] MR3840: wineps: Remove dynamic glyph list.
by Piotr Caban (＠piotr) 15 Sep '23

15 Sep '23

We can't do much without unicode mapping. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3840

3 2

[PATCH 0/7] MR3852: dmusic: Parse instrument waves and download them to the port.
by Rémi Bernon (＠rbernon) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3852

2 7

[PATCH 0/7] MR3851: dmime: Better implement DMUS_PMSG message processing.
by Rémi Bernon (＠rbernon) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3851

3 8

[PATCH 0/1] MR3842: dsound: Get rid of the global device GUID arrays.
by Arek Hiler (＠ivyl) 15 Sep '23

15 Sep '23

They are not used for anything anymore and just impose limit of 10 devices of a given type (capturer / renderer) without doing bound checking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3842

4 3

[PATCH 0/1] MR3847: winmm: Handle memory allocation failure in WINMM_OpenDevice (cppcheck).
by Alex Henrie (＠alexhenrie) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3847

3 2

[PATCH v2 0/4] MR3848: wine{alsa,coreaudio,oss,pulse}: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 15 Sep '23

15 Sep '23

-- v2: winepulse: Ensure unixlib function tables and enum stay in sync. wineoss: Ensure unixlib function tables and enum stay in sync. winecoreaudio: Ensure unixlib function tables and enum stay in sync. winealsa: Ensure unixlib function tables and enum stay in sync. https://gitlab.winehq.org/wine/wine/-/merge_requests/3848

3 5

[PATCH 0/1] MR3850: capi2032: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3850

2 1

[PATCH v2 0/1] MR3849: netapi32: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 15 Sep '23

15 Sep '23

-- v2: netapi32: Ensure unixlib function tables and enum stay in sync. https://gitlab.winehq.org/wine/wine/-/merge_requests/3849

2 1

[PATCH 0/1] MR3849: netapi32: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3849

2 1

[PATCH 0/4] MR3848: wine{alsa,coreaudio,oss,pulse}: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3848

2 4

[PATCH 0/1] MR3844: odbccp32: Handle memory allocation failure in SQLGetInstalledDriversW (cppcheck).
by Alex Henrie (＠alexhenrie) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3844

3 2

[PATCH 0/1] MR3845: ntdll: Fix leave_handler for FreeBSD and NetBSD
by Gerald Pfeifer (＠gerald) 15 Sep '23

15 Sep '23

With recent changes leave_handler writes to some of its parameter's fields (via DS_sig and ES_sig) on FreeBSD and NetBSD - which fails since it is declared const. Accordingly strip const-ness. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3845

2 1

Re: [PATCH v5 0/5] MR3792: Fill in some VMR9 stubs
by Alfred Agrell (＠Alcaro) 14 Sep '23

14 Sep '23

...nope, my VM no longer works. I'm just getting nonsensical errors (why would IVMRSurfaceAllocatorNotify9_SetD3DDevice return E_NOINTERFACE), even from programs that worked last time I tried. I'd suspect some broken update somewhere, GPU stuff has always been finicky in VMs. I'd be happy to fix this test if I could, but without access to a functional Windows installation, there's not much I can do :/ Though I have done some manual testing with some real-world programs, so I'm confident that it's better than the previous stub, at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3792#note_45450

1 0

Re: [PATCH v4 0/2] MR340: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes.
by Giovanni Mascellani (＠giomasce) 14 Sep '23

14 Sep '23

> HLSL_IR_STORE and HLSL_IR_RESOURCE_STORE exist though. I don't think you can use those as HLSL_IR_EXPR sources (right?), but that might not necessarily be obvious. As this MR proves, we're not in an overabundance of documentation about the HLSL IR, that's sure. In my interpretation, the fact that `HLSL_IR_STORE` and `HLSL_IR_RESOURCE_STORE` don't evaluate to a value is of little relevance. Even if they did, they are executed if the control flow reach them, not if their result is used. I realize that my sentence "Nodes purely forward a value and have no side effects" has probably a poor choice of words: of course nodes, which we use essentially as a synonym for "instructions", of course do have side effects (in general, at least). What I wanted to say is probably more like "References purely forward a value [etc]": the act of recalling the value produced by an earlier node/instruction has no side effect, therefore the question if `MOVC` evaluates the operand which is not selected is empty: the operand doesn't bear any side effect, be it selected or not; and the referenced node/instruction is evaluated (possibly with side effects) independently of its value being selected by `MOVC` or not, simply by virtue of being in the control flow; it would have been evaluated even if `MOVC` didn't have it as an operand at all. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/340#note_45445

1 0

Re: [PATCH v4 0/6] MR3795: dmusic: Rewrite collection parsing with the new stream chunk primitives. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3795

1 0

Re: [PATCH v3 0/6] MR3811: dmime: Implement performance time methods and ClonePMsg. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3811

1 0

Re: [PATCH v2 0/1] MR3824: wow64win: Implement wow64_NtUserImmTranslateMessage. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3824

1 0

Re: [PATCH v2 0/1] MR3837: quartz/tests: Fix segfault in changed3ddevice test. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3837

1 0

Re: [PATCH v7 0/2] MR3566: server: Store both contexts in pending context object. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3566

1 0

Re: [PATCH v2 0/1] MR3838: kernel32/tests: Allow a 0 removed entry count in the completion test. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3838

1 0

Re: [PATCH v2 0/2] MR3822: user32/tests: Account for ignored messages during wait. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3822

1 0

Re: [PATCH v9 0/2] MR3736: winmm: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3736

1 0

Re: [PATCH v2 0/2] MR3831: msvcp110: Add _Throw_C_error implementation. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3831

1 0

Re: [PATCH v2 0/2] MR3832: user32: Map WM_CHAR wparam in ASCII to Unicode in IsDialogMessageA() for CJK locales. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3832

1 0

2025

2024

2023

2022

wine-gitlab September 2023