September 2023 - wine-gitlab

Re: [PATCH v2 0/5] MR3805: wined3d: Miscellaneous dead code removal. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3805

1 0

Re: [PATCH v2 0/4] MR3804: wined3d: Various patches related to Vulkan extension checks. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3804

1 0

Re: [PATCH v5 0/1] MR3785: d3drm: Correct D3DRMIMAGE validation - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3785

1 0

Re: [PATCH v2 0/1] MR3835: winscard/tests: Skip tests when SCardListReadersA() returns an empty list. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3835

1 0

Re: [PATCH v2 0/1] MR3834: wpcap/tests: Accept another return value from pcap_can_set_rfmon(). - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3834

1 0

Re: [PATCH v2 0/10] MR3820: mshtml: Traverse and unlink elements using the dispex vtbl, part 1. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3820

1 0

Re: [PATCH v2 0/2] MR3779: d3d9/tests:kwin fixes - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3779

1 0

Re: [PATCH v3 0/5] MR3757: Fix Windows XP d3d test crashes - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3757

1 0

Re: [PATCH v2 0/1] MR3821: dsound: Get rid of DSOUND_capturers and related lock. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3821

1 0

Re: [PATCH v2 0/1] MR3828: winspool.drv: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3828

1 0

Re: [PATCH v2 0/1] MR3827: dwrite: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3827

1 0

Re: [PATCH v2 0/1] MR3830: winegstreamer: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3830

1 0

Re: [PATCH v2 0/1] MR3823: bcrypt: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3823

1 0

Re: [PATCH v2 0/1] MR3826: ws2_32: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3826

1 0

Re: [PATCH v2 0/1] MR3825: msv1_0: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3825

1 0

Re: [PATCH v2 0/1] MR3829: crypt32: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3829

1 0

Re: [PATCH v2 0/10] MR3812: dmusic: Use PARENTSRC to share dmobject with the remaining modules. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3812

1 0

Re: [PATCH v4 0/2] MR340: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/340

1 0

Re: [PATCH v7 0/2] MR328: ci: Run the tests on macOS. - approved
by Alexandre Julliard (＠julliard) 14 Sep '23

14 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/328

1 0

[PATCH v3 0/6] MR3795: dmusic: Rewrite collection parsing with the new stream chunk primitives.
by Rémi Bernon (＠rbernon) 14 Sep '23

14 Sep '23

-- v3: dmusic: Add more parsed instruments traces. dmusic: Parse instrument name from INFO list. dmusic: Rewrite collection DLS chunk parsing. dmusic: Rewrite collection INFO list parsing. dmusic: Rewrite collection ptbl chunk parsing. dmusic: Rewrite collection lins list parsing. https://gitlab.winehq.org/wine/wine/-/merge_requests/3795

3 9

[PATCH v2 0/6] MR3811: dmime: Implement performance time methods and ClonePMsg.
by Rémi Bernon (＠rbernon) 14 Sep '23

14 Sep '23

-- v2: dmime: Implement IDirectMusicPerformance8_ClonePMsg. dmime: Cleanup IDirectMusicPerformance_SendPMsg. dmime: Cleanup IDirectMusicPerformance_FreePMsg. dmime: Cleanup IDirectMusicPerformance_AllocPMsg. dmime: Implement MusicToReferenceTime and ReferenceToMusicTime. dmime: Rewrite IDirectMusicPerformance8_GetTime. https://gitlab.winehq.org/wine/wine/-/merge_requests/3811

4 10

[PATCH v5 0/1] MR321: vkd3d-shader/hlsl: Implement intrinsic tan.
by Petrichor Park (＠petrathekat) 14 Sep '23

14 Sep '23

Now that we can write HLSL intrinsics in HLSL, cleaning up missing functions becomes much easier. This commit also extends the trigonometry tests a little bit to make sure that tan works right. -- v5: vkd3d-shader/hlsl: Implement intrinsic tan. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/321

4 6

[PATCH v3 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 14 Sep '23

14 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- v3: widl: In type_has_full_pointer recurse for pointer types as well widl: Prevent infinite loop when structure contains array of itself https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

4 4

Re: [PATCH v8 0/6] MR3636: winegstreamer: Implement wg_muxer.
by Zebediah Figura (＠zfigura) 14 Sep '23

14 Sep '23

> Without codec_data set, mp4mux element fails. And according to my test, setting codec_data to MF_MT_MPEG_SEQUENCE_HEADER is OK, becuase I finally successfully generate a mp4 file which is able to be played by video player. Yeah, but mp4mux also requires stream-format=avc(3). That's not a coincidence; besides the difference in start codes I mentioned in 3810, the Annex B and AVC formats differ in whether the "codec data" is contained in-band or out-of-band (Annex B has it in-band; AVC has it out-of-band). If you use h264parse to convert Annex B to AVC, it should also supply the correct codec data. I can't explain why the file gets played back correctly in that case—perhaps GStreamer (or whatever player you're using) detects that the data is actually in the Annex B format and plays it back as such, ignoring the incorrect out-of-band codec data? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45360

1 0

[PATCH v3 0/2] MR340: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes.
by Giovanni Mascellani (＠giomasce) 14 Sep '23

14 Sep '23

-- v3: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/340

4 5

[PATCH 0/2] MR345: vkd3d-shader/dxil: Fix a couple of issues.
by Conor McCarthy (＠cmccarthy) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/345

4 7

Re: [PATCH v5 0/5] MR3792: Fill in some VMR9 stubs
by Alfred Agrell (＠Alcaro) 14 Sep '23

14 Sep '23

...actually, it seems that there are at least two bugs nearby. That segfault hits if IVMRSurfaceAllocatorNotify9_SetD3DDevice fails - but if it succeeds (it does on w1121H2_newtb-w11pro64-amd-64 and w1121H2_newtb-w11pro64-nv-64), native Quartz does something different from what I implemented. Unfortunately, trying to run that test on my w10 VM returns vmr9.c:2788: Tests skipped: Direct3D does not support video rendering. vmr9.c:3229: Tests skipped: Direct3D does not support video rendering. vmr9.c:4042: Tests skipped: Got E_FAIL when setting allocator properties. vmr9.c:4365: Tests skipped: Direct3D does not support video rendering. 0a60:vmr9: 2944 tests executed (0 marked as todo, 0 as flaky, 0 failures), 4 skipped. and I'd rather not try to fix that thing via guesswork against your CI system, that's a waste of resources. Some of my test programs can run VMR9 just fine in that VM, so I guess I'll rewrite that test from scratch and see if I can create a more reliable test... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3792#note_45346

1 0

[PATCH v2 0/2] MR340: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes.
by Giovanni Mascellani (＠giomasce) 14 Sep '23

14 Sep '23

-- v2: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes. vkd3d-shader/hlsl: Remove HLSL_OP3_LERP. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/340

4 6

[PATCH 0/1] MR235: include: Add missing constants in d3d12.idl.
by Biswapriyo Nath (＠Biswa96) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/235

4 7

Re: [PATCH v5 0/5] MR3792: Fill in some VMR9 stubs
by Alfred Agrell (＠Alcaro) 14 Sep '23

14 Sep '23

That ... is probably not good. Fixed in https://gitlab.winehq.org/wine/wine/-/merge_requests/3837 , sorry about that. Testing is often more difficult than the actual functionality... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3792#note_45326

1 0

[PATCH 0/5] MR3805: wined3d: Miscellaneous dead code removal.
by Zebediah Figura (＠zfigura) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3805

3 6

[PATCH 0/4] MR3804: wined3d: Various patches related to Vulkan extension checks.
by Zebediah Figura (＠zfigura) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3804

4 6

Re: [PATCH v5 0/5] MR3792: Fill in some VMR9 stubs
by Francois Gouget (＠fgouget) 14 Sep '23

14 Sep '23

This MR causes quartz:vmr9 to crash on all Windows versions: https://test.winehq.org/data/patterns.html#quartz:vmr9 The TestBot actually detected those but somehow the corresponding report was lost: https://www.winehq.org/mailman3/hyperkitty/list/wine-gitlab@winehq.org/mess… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3792#note_45321

1 0

[PATCH 0/2] MR3832: user32: Map WM_CHAR wparam in ASCII to Unicode in IsDialogMessageA() for CJK locales.
by Zhiyi Zhang (＠zhiyi) 14 Sep '23

14 Sep '23

Fix displaying Chinese characters as "??" in some applications with Chinese locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3832

3 3

[PATCH v4 0/1] MR3785: d3drm: Correct D3DRMIMAGE validation
by Alistair Leslie-Hughes (＠alesliehughes) 14 Sep '23

14 Sep '23

-- v4: d3drm: Correct D3DRMIMAGE validation https://gitlab.winehq.org/wine/wine/-/merge_requests/3785

4 3

[PATCH 0/10] MR3820: mshtml: Traverse and unlink elements using the dispex vtbl, part 1.
by Gabriel Ivăncescu (＠insn) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3820

3 11

[PATCH 0/2] MR3779: d3d9/tests:kwin fixes
by Stefan Dösinger (＠stefan) 14 Sep '23

14 Sep '23

kwin resizes hidden windows most of the time. I see the existing flaky markers triggered on Windows 11 occasionally. This MR makes the ddraw-d3d9 tests run reliably on kwin (I tested version 5.27.7) in Xephyr and a real display. This makes the !WS_VISIBLE tests fairly weak since we ignore the random failures we get on Windows and Wine. According to https://marc.info/?l=wine-patches&m=141642450913299&w=2 , the mail to wine-patches behind commit f4d520d6e2, which added this test, those tests intended to cover some differences between d3d9 and d3d9ex, not a specific game behavior. I vaguely remember that I did run into something that needed this behavior, but I can't find out any more what this might have been. The memory of those 9 year old patches is getting blurry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3779

5 5

[PATCH v2 0/5] MR3757: Fix Windows XP d3d test crashes
by Stefan Dösinger (＠stefan) 14 Sep '23

14 Sep '23

This series fixes a few bugs in the d3d tests that cause them to crash on my Windows XP laptop with the r200 GPU (dx8 era). There are plenty more problems on this GPU on Windows. d3d8:visual hangs the entire system. d3d9:device has some failing tests. d3d9:visual crashes, which is probably good because otherwise it would also cause a kernel panic. -- v2: d3d9/tests: Fix skipping ATI2N in test_resource_access. d3d8/tests: Fix skipping ATI2N in test_resource_access. d3d9/tests: Request a 3 mip level cube texture in test_getdc(). d3d8/tests: Zero stride tests crash on Windows XP, r200 GPU. d3d9/tests: Zero stride tests crash on Windows XP, r200 GPU. https://gitlab.winehq.org/wine/wine/-/merge_requests/3757

5 8

Re: [PATCH v8 0/6] MR3636: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 14 Sep '23

14 Sep '23

On Thu Sep 14 07:06:18 2023 +0000, Ziqing Hui wrote: > This was added because mp4mux is requiring it: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/… > Without codec_data set, mp4mux element fails. And according to my test, > setting codec_data to MF_MT_MPEG_SEQUENCE_HEADER is OK, becuase I > finally successfully generate a mp4 file which is able to be played by > video player. I didn't dig into how mp4mux element handle h264 codec_data. But the truth is it do accpet MF_MT_MPEG_SEQUENCE_HEADER. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45304

1 0

Re: [PATCH v8 0/6] MR3636: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 14 Sep '23

14 Sep '23

On Thu Sep 14 07:06:18 2023 +0000, Zebediah Figura wrote: > Hi Ziqing, I've been doing some research, and I believe patch 2/6 > (committed as 320383c594c4) is incorrect. GStreamer's "codec-data" field > is an AVCDecoderConfigurationRecord, as defined by ISO/IEC 14496-15 > (which you can see at [1]). MF_MT_MPEG_SEQUENCE_HEADER, on the other > hand, seems to contain the raw SPS/PPS NALUs, start codes and all. > Since Microsoft uses Annex B everywhere, it shouldn't need the > codec-data anyway, so I'm curious now why this was added—was there a > need for it, or did you just add it on the assumption that the two > attributes mapped to each other? > [1] https://doc-kurento.readthedocs.io/en/latest/knowledge/h264.html#gstreamer-… This was added because mp4mux is requiring it: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/… Without codec_data set, mp4mux element fails. And according to my test, setting codec_data to MF_MT_MPEG_SEQUENCE_HEADER is OK, becuase I finally successfully generate a mp4 file which is able to be played by video player. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45303

1 0

[PATCH 0/1] MR3821: dsound: Get rid of DSOUND_capturers and related lock.
by Arek Hiler (＠ivyl) 14 Sep '23

14 Sep '23

Ever since dcaeb6b4fdf8 ("dsound: Allow multiple buffers to capture from the same device.") it's not used for anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3821

3 3

[PATCH 0/2] MR3831: msvcp110: Add _Throw_C_error implementation.
by Piotr Caban (＠piotr) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3831

2 2

[PATCH 0/1] MR3828: winspool.drv: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3828

4 3

Re: [PATCH v8 0/2] MR3736: winmm: Use CRT allocation functions. - approved
by Huw Davies (＠huw) 14 Sep '23

14 Sep '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3736

1 0

[PATCH 0/1] MR3827: dwrite: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3827

3 2

[PATCH v7 0/2] MR3736: winmm: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 14 Sep '23

14 Sep '23

-- v7: winmm: Use CRT allocation functions. winmm: Avoid explicitly casting the pointer returned from Heap(Re)Alloc. https://gitlab.winehq.org/wine/wine/-/merge_requests/3736

2 2

[PATCH 0/1] MR3830: winegstreamer: Ensure unixlib function tables and enum stay in sync.
by Brendan Shanks (＠bshanks) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3830

3 2

Re: [PATCH v2 0/1] MR3694: d3dcompiler/tests: Avoid interpolation filters in test_samplers().
by Francois Gouget (＠fgouget) 13 Sep '23

13 Sep '23

On Thu Aug 31 18:29:16 2023 +0000, Matteo Bruni wrote: > That's 100% it :rolling_eyes: > But yeah, that's what I mean when I say that d3d QXL test results ought > to be ignored. That sounds like a bug in QXL. Is there a QEmu bug report for this issue? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3694#note_45290

1 0

[PATCH 0/6] MR3811: dmime: Implement performance time methods and ClonePMsg.
by Rémi Bernon (＠rbernon) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3811

3 7

Re: [PATCH v8 0/6] MR3636: winegstreamer: Implement wg_muxer.
by Zebediah Figura (＠zfigura) 13 Sep '23

13 Sep '23

Hi Ziqing, I've been doing some research, and I believe patch 2/6 (committed as 320383c594c4) is incorrect. GStreamer's "codec-data" field is an AVCDecoderConfigurationRecord, as defined by ISO/IEC 14496-15 (which you can see at [1]). MF_MT_MPEG_SEQUENCE_HEADER, on the other hand, seems to contain the raw SPS/PPS NALUs, start codes and all. Since Microsoft uses Annex B everywhere, it shouldn't need the codec-data anyway, so I'm curious now why this was added—was there a need for it, or did you just add it on the assumption that the two attributes mapped to each other? [1] https://doc-kurento.readthedocs.io/en/latest/knowledge/h264.html#gstreamer-… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45288

1 0

2025

2024

2023

2022

wine-gitlab September 2023