September 2023 - wine-gitlab

[PATCH 0/1] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 09 Sep '23

09 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

3 6

Re: [PATCH 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo.
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Sep '23

09 Sep '23

might have gotten the wow64 thunk wrong, so pls tell me how to fix it if that's the case :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3777#note_44800

1 0

[PATCH 0/1] MR3776: server: Support FileStandardInformation for pipes.
by Paul Gofman (＠gofman) 08 Sep '23

08 Sep '23

Crysis 3 Remastered (and 2 probably) in RT mode rely on GetFileSize() returning available read size (more exactly, correctly return 0 when no data is available) on pipe it uses to read the output from child dxc.exe process it creates (and hangs forever trying to read the pipe when we return INVALID_FILE_SIZE). While MSDN explicitly says that "You cannot use the GetFileSize function with a handle of a nonseeking device such as a pipe or a communications device.", if application dares GetFileSize (or NtQueryInformationFile(FileStandardInformation)) actually works for named and unnamed pipes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3776

2 1

[PATCH 0/1] MR3766: uninstaller: Allocate space for null terminator in FetchFromRootKey.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3766

2 2

Re: [PATCH v2 0/1] MR3775: server: Remove the fallback epoll() syscalls. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3775

1 0

Re: [PATCH v8 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

1 0

Re: [PATCH v4 0/6] MR3753: dmsynth: Implement downloading of instruments and waves. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

1 0

Re: [PATCH v3 0/2] MR3755: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3755

1 0

Re: [PATCH v3 0/13] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3773

1 0

Re: [PATCH v2 0/1] MR3754: mshtml: Unstub some implemented event handlers in IHTMLWindow7 interface. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3754

1 0

Re: [PATCH v3 0/3] MR3771: srvsvc: Add LanmanServer stub service. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3771

1 0

Re: [PATCH v2 0/1] MR3772: ntdll: Store the codepage data addresses in both PEBs. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3772

1 0

Re: [PATCH v2 0/2] MR3769: ws2_32/tests: Call GetAdaptersAddresses() in a loop. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3769

1 0

Re: [PATCH v2 0/1] MR3770: include: Add IPackage2 definition in windows.applicationmodel.idl. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3770

1 0

Re: [PATCH v2 0/3] MR3746: test fixes for fvwm3 - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3746

1 0

Re: [PATCH v2 0/1] MR3765: winemenubuilder: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3765

1 0

Re: [PATCH v2 0/1] MR3764: wineboot: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3764

1 0

Re: [PATCH v2 0/1] MR3763: oleview: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3763

1 0

Re: [PATCH v2 0/1] MR3762: extrac32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3762

1 0

Re: [PATCH v2 0/1] MR3761: wintrust: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3761

1 0

Re: [PATCH v2 0/1] MR3760: wintab32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3760

1 0

Re: [PATCH v8 0/1] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3724

1 0

Re: [PATCH v2 0/7] MR3751: dmime/tests: Test performance graph, tools and PMsg methods. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3751

1 0

Re: [PATCH v2 0/1] MR3719: d3d9/tests: Don't fail d3d9ex if the window manager restores focus too soon. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3719

1 0

[PATCH 0/2] MR331: vkd3d-shader/hlsl: Lower matrix swizzles.
by Francisco Casas (＠fcasas) 08 Sep '23

08 Sep '23

As @nsivov pointed out, we are currently parsing matrix swizzles (e.g. mat._m12_m32) and creating an hlsl_ir_swizzle for the matrix itself. We are currently allowing shaders that use these to compile even though they are not working. While our compilation passes don't expect hlsl_ir_swizzles with matrix values, turns out we need them as a parse-time construct because we don't know if they will be used as the lhs of an assignment during parsing, similarly to hlsl_ir_indexes. This patch adds tests and a pass to lower these matrix swizzles. Implementing assignments with matrix swizzles is still pending. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/331

4 6

[PATCH v3 0/1] MR3382: winebuild: Zero space between Wine signature and PE header in "builtin" files.
by Konstantin Demin (＠rockdrilla) 08 Sep '23

08 Sep '23

Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v3: winebuild: Zero space between Wine signature and PE header in "builtin" files. https://gitlab.winehq.org/wine/wine/-/merge_requests/3382

3 8

[PATCH 0/1] MR3535: ntdll: Take LARGE_ADDRESS_AWARE into account for userspace allocation limits.
by Billy Laws (＠bylaws) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3535

3 3

[PATCH 0/1] MR3775: server: Remove the fallback epoll() syscalls.
by Brendan Shanks (＠bshanks) 08 Sep '23

08 Sep '23

epoll was added to glibc 2.3.2, from 2003. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3775

3 2

[PATCH v7 0/1] MR3744: Draft: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) 08 Sep '23

08 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- v7: dwrite: Treat null character as NO_VISUAL in script analyzer. https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

3 3

[PATCH v3 0/3] MR3737: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 08 Sep '23

08 Sep '23

This patch set is part of !3303 -- v3: winegstreamer: Create wg_muxer for media sink. winegstreamer: Implement seeking query for wg_muxer sink pad. winegstreamer: Introduce new wg_muxer struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/3737

4 15

[PATCH v3 0/6] MR3753: dmsynth: Implement downloading of instruments and waves.
by Rémi Bernon (＠rbernon) 08 Sep '23

08 Sep '23

-- v3: dmsynth: Implement IDirectMusicSynth_Download for instrument articulations. dmsynth: Implement IDirectMusicSynth_Download for instrument regions. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for waves. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for instruments. dmusic: Avoid passing invalid handle to IDirectMusicSynth_Unload. dmsynth/tests: Test IDirectMusicSynth_Unload. https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

3 8

[PATCH 0/1] MR3774: gdiplus/tests: extend DrawImage tests
by Bartosz Kosiorek (＠gang65) 08 Sep '23

08 Sep '23

With this commit we proof that PixelOffsetMode None and Fast is implemented correctly. By changing colour of second pixel of bitmap Source, the issues with pixel offset appear for PixelOffsetMode Half and HighQuality. Extending tests is starting point for further improvements of implementation pixel offset modes to match implementation from native gdiplus. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3774

3 4

[PATCH v2 0/2] MR3755: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL.
by Tim Clem (＠tclem) 08 Sep '23

08 Sep '23

If lparam is null, the current code crashes when it hits the memcpy in pack_user_message. -- v2: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL. win32u: Add a test for cross-process WM_GETDLGCODE with a NULL lparam. https://gitlab.winehq.org/wine/wine/-/merge_requests/3755

3 4

[PATCH v2 0/1] MR330: vkd3d-shader/hlsl: Add fwidth() function.
by Nikolay Sivov (＠nsivov) 08 Sep '23

08 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add fwidth() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/330

4 8

[PATCH v3 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 08 Sep '23

08 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v3: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

5 12

[PATCH v2 0/13] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2.
by Gabriel Ivăncescu (＠insn) 08 Sep '23

08 Sep '23

-- v2: mshtml: Use query_interface in the dispex vtbl for HTMLPluginsCollection. mshtml: Use query_interface in the dispex vtbl for HTMLNamespaceCollection. mshtml: Use query_interface in the dispex vtbl for HTMLMimeTypesCollection. mshtml: Use query_interface in the dispex vtbl for HTMLAttributeCollection. mshtml: Use query_interface in the dispex vtbl for HTMLFiltersCollection. mshtml: Use query_interface in the dispex vtbl for HTMLRectCollection. mshtml: Use query_interface in the dispex vtbl for HTMLElementCollection. mshtml: Use query_interface in the dispex vtbl for HTMLDOMChildrenCollection. mshtml: Use query_interface in the dispex vtbl for StyleSheetRules and mshtml: Use query_interface in the dispex vtbl for CSS Styles. mshtml: Use query_interface in the dispex vtbl for HTMLStorage. mshtml: Use query_interface in the dispex vtbl for HTMLLocation. mshtml: Use query_interface in the dispex vtbl for builtin constructors. https://gitlab.winehq.org/wine/wine/-/merge_requests/3773

3 14

[PATCH 0/16] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2.
by Gabriel Ivăncescu (＠insn) 08 Sep '23

08 Sep '23

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3773

2 3

[PATCH 0/1] MR3772: ntdll: Store the codepage data addresses in both PEBs.
by Huw Davies (＠huw) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3772

2 1

[PATCH v2 0/5] MR3686: winewayland.drv: part 6: Handle wl_pointer (mouse) events.
by Alexandros Frantzis (＠afrantzis) 08 Sep '23

08 Sep '23

This MR adds support for handling `wl_pointer` devices: 1. Handle enter/leave/(absolute) motion/button/axis events to allow users to interact with applications using such devices, e.g., a mouse. 2. Update the cursor image used for Wayland surfaces based on the Windows cursor bitmap data. A few notes: 1. A single `wl_seat`/`wl_pointer` is supported for now. 2. Many of the input interactions require window management support that hasn't been implemented yet (e.g., popup positioning, resizing, max/fullscreen). 3. There is some potential for bad interactions between the input event dispatching mechanism and the `win32u` flushing logic for `window_surface` , which can lead to visual glitches. Although I don't think this is blocker for this MR, I would like to start a discussion about the problem and mitigation ideas in a [comment](https://gitlab.winehq.org/wine/wine/-/merge_requests/3686#note_438… below. Thanks! -- v2: winewayland.drv: Implement SetCursor using cursor bitmap data. winewayland.drv: Handle pointer button and scroll events. winewayland.drv: Handle pointer motion events. winewayland.drv: Handle pointer focus events. https://gitlab.winehq.org/wine/wine/-/merge_requests/3686

3 12

[PATCH 0/1] MR3754: mshtml: Unstub some implemented event handlers in IHTMLWindow7 interface.
by Gabriel Ivăncescu (＠insn) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3754

4 3

[PATCH v2 0/3] MR3771: srvsvc: Add LanmanServer stub service.
by Dmitry Timoshkov (＠dmitry) 08 Sep '23

08 Sep '23

-- v2: srvsvc: Add LanmanServer stub service. wevtsvc: Remove duplicate dwControlsAccepted initialization. schedsvc: Remove duplicate dwControlsAccepted initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/3771

2 3

[PATCH 0/1] MR3755: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL.
by Tim Clem (＠tclem) 08 Sep '23

08 Sep '23

If lparam is null, the current code crashes when it hits the memcpy in pack_user_message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3755

3 2

[PATCH 0/3] MR3771: srvsvc: Add LanmanServer stub service.
by Dmitry Timoshkov (＠dmitry) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3771

3 4

[PATCH 0/1] MR3770: include: Add IPackage2 definition in windows.applicationmodel.idl.
by Biswapriyo Nath (＠Biswa96) 08 Sep '23

08 Sep '23

Required for GNOME/glib project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3770

3 2

[PATCH 0/3] MR3746: test fixes for fvwm3
by Stefan Dösinger (＠stefan) 08 Sep '23

08 Sep '23

These tests make the ddraw-d3d9 tests pass inside Xephyr with fvwm3 for me. fvwm3 still randomly fails in a lot of places if it is run on a real display. It also fails in Xephyr if I wiggle the mouse too much. Those two issues might even be related. A virtual X server should be enough for CI though. fvwm2 has a lot of random failures even inside Xephyr or xf86-video-dummy. I will not attempt to fix them. I tested the SW_SHOWMINNOACTIVE in patches 2 and 3 on Windows XP, Windows 11, the testbot, kwin, openbox. It seems to work without breaking any of those systems. With those things being flaky changes though I can never fully gurantee this though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3746

5 8

[PATCH v2 0/3] MR3737: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 08 Sep '23

08 Sep '23

This patch set is part of !3303 -- v2: winegstreamer: Create wg_muxer for media sink. winegstreamer: Implement seeking query for wg_muxer sink pad. winegstreamer: Introduce new wg_muxer struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/3737

3 7

[PATCH 0/1] MR3767: msvcp110: Add std::_Throw_future_error.
by Daniel Lehman (＠dlehman25) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3767

3 2

[PATCH 0/2] MR3769: ws2_32/tests: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3769

2 2

Re: [PATCH v5 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Rémi Bernon (＠rbernon) 08 Sep '23

08 Sep '23

On Fri Sep 8 06:44:32 2023 +0000, Mohamad Al-Jaf wrote: > I've removed it, seems like it's not really necessary to test for it. > Though, I don't understand why Office queries for `IAgileObject`. It's a > Microsoft program so they should know it's not supported. Minecraft also > queries for an interface that returns `E_NOINTERFACE`, it seems bizarre. You should still remove the `broken(...)` condition, it will otherwise let every test succeed silently on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3672#note_44665

1 0

Re: [PATCH v3 0/27] MR332: include: Fill in missing enum/struct/interfaces in vkd3d_d3d12.idl
by Martin Storsjö (＠mstorsjo) 08 Sep '23

08 Sep '23

On Fri Sep 8 06:50:30 2023 +0000, Henri Verbeet wrote: > At first sight this looks fine, thanks. Unfortunately I probably won't > be able to properly review this this week, but I should be able to get > to it early next week. > Note that this currently fails the CI though. Probably because it's > intended to be applied on top of !325, so hopefully that will get > resolved once those patches actually get committed. It still fails CI after !325 was merged (and even before - as it was based on top of !325, those commits were part of this branch so testing would just have iterated over those too) - not quite sure what is wrong here... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/332#note_44664

1 0

2025

2024

2023

2022

wine-gitlab September 2023