September 2023 - wine-gitlab

Re: [PATCH v5 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 08 Sep '23

08 Sep '23

On Thu Sep 7 13:49:19 2023 +0000, Rémi Bernon wrote: > I missed this before, but I think the check_interface check is a bit > pointless as it will always succeed on Windows. > Something like that would be better (using `check_interface_broken` only > where it is needed): > ```suggestion:-14+0 > #define check_interface_broken( obj, iid, supported ) check_interface_( > __LINE__, obj, iid, supported, TRUE ) > #define check_interface( obj, iid, supported ) check_interface_( > __LINE__, obj, iid, supported, FALSE ) > static void check_interface_( unsigned int line, void *obj, const IID > *iid, BOOL supported, BOOL is_broken ) > { > HRESULT hr, expected_hr, broken_hr; > IUnknown *iface = obj; > IUnknown *unk; > expected_hr = supported ? S_OK : E_NOINTERFACE; > broken_hr = supported ? E_NOINTERFACE : S_OK; > hr = IUnknown_QueryInterface( iface, iid, (void **)&unk ); > ok_(__FILE__, line)( hr == expected_hr || broken( is_broken && hr == > broken_hr ), "got hr %#lx.\n", hr ); > if (SUCCEEDED(hr)) IUnknown_Release( unk ); > } > ``` > Or, maybe even better, use the basic `check_interface`, without the > broken result and remove the broken check for IAgileObject interface > which probably doesn't really matter on the factory. I've removed it, seems like it's not really necessary to test for it. Though, I don't understand why Office queries for `IAgileObject`. It's a Microsoft program so they should know it's not supported. Minecraft also queries for an interface that returns `E_NOINTERFACE`, it seems bizarre. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3672#note_44663

1 0

[PATCH v4 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 08 Sep '23

08 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55403 -- v4: appxdeploymentclient: Add IPackageManager2 stub interface. include: Add Windows.Management.Deployment.IPackageManager2 interface definition. appxdeploymentclient: Implement IActivationFactory::ActivateInstance(). appxdeploymentclient: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3672

2 4

[PATCH 0/3] MR3737: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 08 Sep '23

08 Sep '23

This patch set is part of !3303 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3737

4 15

[PATCH 0/1] MR3765: winemenubuilder: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3765

2 1

[PATCH 0/1] MR3764: wineboot: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3764

2 1

[PATCH 0/1] MR3763: oleview: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3763

2 1

[PATCH 0/1] MR3762: extrac32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3762

2 1

[PATCH 0/1] MR3761: wintrust: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3761

2 1

[PATCH 0/1] MR3760: wintab32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3760

2 1

[PATCH v2 0/6] MR3753: dmsynth: Implement downloading of instruments and waves.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- v2: dmsynth: Implement IDirectMusicSynth_Download for instrument articulations. dmsynth: Implement IDirectMusicSynth_Download for instrument regions. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for waves. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for instruments. dmusic: Avoid passing invalid handle to IDirectMusicSynth_Unload. dmsynth/tests: Test IDirectMusicSynth_Unload. https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

3 8

[PATCH v2 0/1] MR3758: ntoskrnl/tests: Use wine/test.h in the driver tests.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- v2: ntoskrnl/tests: Use wine/test.h in the driver tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3758

3 2

[PATCH 0/7] MR3751: dmime/tests: Test performance graph, tools and PMsg methods.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3751

3 8

[PATCH 0/2] MR3759: dinput/tests: Report the driver success and skipped tests counters.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55535 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3759

3 3

[PATCH v2 0/27] MR332: include: Fill in missing enum/struct/interfaces in vkd3d_d3d12.idl
by Martin Storsjö (＠mstorsjo) 07 Sep '23

07 Sep '23

This goes on top of !325 (which was already approved). -- v2: include: Add some misc D3D12 structs/enums. include: Add some D3D12 raytracing specific structs. include: Add the D3D12_BARRIER_GROUP struct. include: Add the ID3D12Tools interface. include: Add the ID3D12VirtualizationGuestDevice interface. include: Add the ID3D12Device10 interface. include: Add the ID3D12Device9 interface. include: Add the ID3D12ShaderCacheSession interface. include: Add the ID3D12GraphicsCommandList4 interface. include: Add the ID3D12MetaCommand interface. include: Add the ID3D12Heap1 interface. include: Add the ID3D12Resource{1,2} interfaces. include: Add the ID3D12Device8 interface. include: Add the structs D3D12_FEATURE_DATA_D3D12_OPTIONS{6,7}. include: Add the ID3D12Device7 interface. include: Add the ID3D12ProtectedResourceSession1 interface. include: Add the ID3D12Device6 interface. include: Add the ID3D12DeviceRemovedExtendedData{,1,2} interfaces. include: Add the ID3D12DeviceRemovedExtendedDataSettings{,1} interfaces. include: Add the ID3D12Device5 interface. include: Add the ID3D12StateObjectProperties interface. include: Add the ID3D12StateObject interface. include: Add the ID3D12LifetimeTracker interface. include: Add the ID3D12SwapChainAssistant interface. include: Add the ID3D12LifetimeOwner interface. include: Add the ID3D12Device4 interface. include: Add the ID3D12PipelineLibrary{,1} interfaces. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/332

1 0

Re: [PATCH v3 0/1] MR3758: ntoskrnl/tests: Use wine/test.h in the driver tests. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3758

1 0

Re: [PATCH v2 0/2] MR3759: dinput/tests: Report the driver success and skipped tests counters. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3759

1 0

[PATCH 0/4] MR3757: Fix Windows XP d3d test crashes
by Stefan Dösinger (＠stefan) 07 Sep '23

07 Sep '23

This series fixes a few bugs in the d3d tests that cause them to crash on my Windows XP laptop with the r200 GPU (dx8 era). There are plenty more problems on this GPU on Windows. d3d8:visual hangs the entire system. d3d9:device has some failing tests. d3d9:visual crashes, which is probably good because otherwise it would also cause a kernel panic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3757

4 8

Re: [PATCH v2 0/3] MR3756: wtsapi32: Improve WTSEnumerateSessions and WTSQuerySessionInformation. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3756

1 0

Re: [PATCH v4 0/6] MR3723: mshtml: Implement a unified QueryInterface on the dispex, part 1. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3723

1 0

Re: [PATCH v2 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

1 0

Re: [PATCH v2 0/4] MR3749: wsdapi: Call GetAdaptersAddresses() in a loop. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3749

1 0

Re: [PATCH v4 0/2] MR3733: urlmon: test using http protocol through CreateBinding - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3733

1 0

Re: [PATCH v8 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod(). - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

1 0

Re: [PATCH v4 0/2] MR325: include: Fill in missing types/interfaces in vkd3d_d3d12.idl - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/325

1 0

Re: [PATCH v4 0/13] MR327: include: Add missing constants in vkd3d_d3d12.idl - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/327

1 0

Re: [PATCH v2 0/1] MR324: vkd3d-shader/hlsl: Add tex1D() function. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/324

1 0

[PATCH 0/1] MR3758: ntoskrnl/tests: Use wine/test.h in the driver tests.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3758

3 2

[PATCH 0/3] MR3756: wtsapi32: Improve WTSEnumerateSessions and WTSQuerySessionInformation.
by Paul Gofman (＠gofman) 07 Sep '23

07 Sep '23

EA Desktop depends on that when tries to run the game with elevated privileges (which is performed from a process started by a service and running in a service session on Windows). The improved stub only returns interactive ("Console") session, while Windows at least starting from Win Vista also always have "Services" session. While we could probably return "Sevices" as well, I think it is safer not to while we don't really have services running in "Services" session (along with all the winstation, token etc. info). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3756

2 3

[PATCH v5 0/9] MR317: vkd3d-shader: Begin validating the generated IR.
by Giovanni Mascellani (＠giomasce) 07 Sep '23

07 Sep '23

The validation code is meant both as a check that the frontend is behaving properly and as a sort of the documentation to establish what is allowed and what is not in the IR. ~~Currently an assertion is thrown if validation fails. I realize this is a rather strong proposal, but it's of course up for debate. In theory asserting here is the right thing, as it is expected that the frontend is generating correct IR code. However vkd3d is already used in production for many programs, and it could very well be that some of those are working properly even if the generated IR is somewhat out of specs; allowing the assertion might cause regressions as soon as enough checks are implemented in the validator. Please let me know your opinions.~~ **Solved in favor of a softer failure, and only when validation is enabled** -- v5: vkd3d-shader: Validate source parameters. vkd3d-shader: Validate destination parameters. vkd3d-shader: Validate register types. vkd3d-shader: Validate instruction handlers. vkd3d-shader: Introduce a boilerplate to validate the generated IR. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/317

4 11

[PATCH 0/1] MR330: vkd3d-shader/hlsl: Add fwidth() function.
by Nikolay Sivov (＠nsivov) 07 Sep '23

07 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/330

3 2

[PATCH v4 0/2] MR3725: urlmon: fix HTTP redirects when auto redirection is disabled
by Yuxuan Shui (＠yshui) 07 Sep '23

07 Sep '23

If DISABLEAUTOREDIRECTS is set in BINDINFO options, urlmon does not set HTTP verb to GET when handling redirections. Although HTTP specification is vague on the correct behaviour here, many web servers expect this. This is what's causing the "400 Bad Request" error when user tries to log into GMail accounts using Outlook. -- v4: urlmon: test redirection of POST requests urlmon: fix HTTP redirects when auto redirection is disabled https://gitlab.winehq.org/wine/wine/-/merge_requests/3725

3 5

Re: [PATCH v6 0/1] MR3744: Draft: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) 07 Sep '23

07 Sep '23

Clicked a wrong button on gitlab. Marking this as draft until I can fix that (as well as something else with this MR I should clean up). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744#note_44575

1 0

[PATCH v3 0/6] MR3723: mshtml: Implement a unified QueryInterface on the dispex, part 1.
by Gabriel Ivăncescu (＠insn) 07 Sep '23

07 Sep '23

This begins the initial implementation of a unified QueryInterface on the dispex. There's a couple of hacks used to make the conversion split up easier, but they're all resolved within this MR. -- v3: mshtml: Trace the object name in dispex methods. mshtml: Use query_interface in the dispex vtbl for XMLHttpRequest. mshtml: Use query_interface in the dispex vtbl for inner windows. mshtml: Introduce query_interface in dispex vtbl and use it for DOM Nodes. mshtml: Return interface directly from node vtbl's QI instead of HRESULT, mshtml: Expose an EventTarget interface on the outer window for events' https://gitlab.winehq.org/wine/wine/-/merge_requests/3723

3 7

[PATCH v3 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 07 Sep '23

07 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55403 -- v3: appxdeploymentclient: Add IPackageManager2 stub interface. include: Add Windows.Management.Deployment.IPackageManager2 interface definition. appxdeploymentclient: Implement IActivationFactory::ActivateInstance(). appxdeploymentclient: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3672

3 7

[PATCH 0/29] MR332: include: Fill in missing enum/struct/interfaces in vkd3d_d3d12.idl
by Martin Storsjö (＠mstorsjo) 07 Sep '23

07 Sep '23

This goes on top of !325 (which was already approved). -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/332

2 1

[PATCH v5 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) 07 Sep '23

07 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- v5: dwrite: Treat null character as NO_VISUAL in script analyzer. https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

4 3

[PATCH v2 0/5] MR3723: mshtml: Implement a unified QueryInterface on the dispex, part 1.
by Gabriel Ivăncescu (＠insn) 07 Sep '23

07 Sep '23

This begins the initial implementation of a unified QueryInterface on the dispex. There's a couple of hacks used to make the conversion split up easier, but they're all resolved within this MR. -- v2: mshtml: Use query_interface in the dispex vtbl for XMLHttpRequest. mshtml: Use query_interface in the dispex vtbl for inner windows. mshtml: Introduce query_interface in dispex vtbl and use it for DOM Nodes. mshtml: Return interface directly from node vtbl's QI instead of HRESULT, mshtml: Expose an EventTarget interface on the outer window for events' https://gitlab.winehq.org/wine/wine/-/merge_requests/3723

3 9

[PATCH v3 0/2] MR3725: urlmon: fix HTTP redirects when auto redirection is disabled
by Yuxuan Shui (＠yshui) 07 Sep '23

07 Sep '23

If DISABLEAUTOREDIRECTS is set in BINDINFO options, urlmon does not set HTTP verb to GET when handling redirections. Although HTTP specification is vague on the correct behaviour here, many web servers expect this. This is what's causing the "400 Bad Request" error when user tries to log into GMail accounts using Outlook. -- v3: urlmon: test redirection of POST requests https://gitlab.winehq.org/wine/wine/-/merge_requests/3725

4 5

[PATCH v5 0/1] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub.
by Helix Graziani (＠TornadoCookie) 07 Sep '23

07 Sep '23

Function is used in MS Edge Webview2 installer. -- v5: wldp: Add WldpQueryWindowsLockdownMode stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3724

2 1

[PATCH 0/6] MR3753: dmsynth: Implement downloading of instruments and waves.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

2 6

[PATCH v4 0/9] MR317: vkd3d-shader: Begin validating the generated IR.
by Giovanni Mascellani (＠giomasce) 07 Sep '23

07 Sep '23

The validation code is meant both as a check that the frontend is behaving properly and as a sort of the documentation to establish what is allowed and what is not in the IR. ~~Currently an assertion is thrown if validation fails. I realize this is a rather strong proposal, but it's of course up for debate. In theory asserting here is the right thing, as it is expected that the frontend is generating correct IR code. However vkd3d is already used in production for many programs, and it could very well be that some of those are working properly even if the generated IR is somewhat out of specs; allowing the assertion might cause regressions as soon as enough checks are implemented in the validator. Please let me know your opinions.~~ **Solved in favor of a softer failure, and only when validation is enabled** -- v4: vkd3d-shader: Validate source parameters. vkd3d-shader: Validate destination parameters. vkd3d-shader: Validate register types. vkd3d-shader: Validator instruction handlers. vkd3d-shader: Introduce a boilerplate to validate the generated IR. vkd3d-shader: Embed the parsing location in vkd3d_shader_instruction. vkd3d-shader: Destroy the SM6 parser on parsing errors. vkd3d-shader: Destroy the SM4 parser on parsing errors. vkd3d-shader: Destroy the SM1 parser on parsing errors. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/317

2 10

Re: [PATCH v4 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Nikolay Sivov (＠nsivov) 07 Sep '23

07 Sep '23

Nikolay Sivov (@nsivov) commented about dlls/dwrite/tests/analyzer.c: > + { > + { 5, { L"\0test", 2, { > + { 0, 1, DWRITE_SCRIPT_SHAPES_NO_VISUAL }, > + { 1, 4, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + } } }, > + { 5, { L"te\0st", 3, { > + { 0, 2, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + { 2, 1, DWRITE_SCRIPT_SHAPES_NO_VISUAL }, > + { 3, 2, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + } } }, > + { 5, { L"test\0", 2, { > + { 0, 4, DWRITE_SCRIPT_SHAPES_DEFAULT }, > + { 4, 1, DWRITE_SCRIPT_SHAPES_NO_VISUAL }, > + } } }, > + }; > const struct sa_test *ptr = sa_tests; Please put this to existing sa_tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744#note_44535

1 0

[PATCH 0/1] MR3752: d2d1: Respect stroke style D2D1_STROKE_TRANSFORM_TYPE_FIXED in DrawGeometry::ID2D1DeviceContext1().
by Dmitry Timoshkov (＠dmitry) 07 Sep '23

07 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54368 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3752

3 3

[PATCH 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages.
by Dmitry Timoshkov (＠dmitry) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

5 6

[PATCH 0/1] MR3750: user32: Listbox shouldn't send WM_COMMAND/LBN_DBLCLK notification if it has no items.
by Dmitry Timoshkov (＠dmitry) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3750

2 1

[PATCH v50 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 07 Sep '23

07 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v50: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/4] MR3749: wsdapi: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3749

2 4

[PATCH v49 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 07 Sep '23

07 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v49: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/1] MR3748: cmd: Reset ignoreBracket to FALSE when moving to the next line.
by Alex Henrie (＠alexhenrie) 07 Sep '23

07 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55528 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3748

2 1

[PATCH v48 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 07 Sep '23

07 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v48: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 9

2025

2024

2023

2022

wine-gitlab September 2023