September 2023 - wine-gitlab

[PATCH v2 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 06 Sep '23

06 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v2: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

2 3

[PATCH 0/5] MR3747: kernelbase: Implement DeriveCapabilitySidsFromName().
by Paul Gofman (＠gofman) 06 Sep '23

06 Sep '23

CEF sometimes uses that during sandbox initialization. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3747

2 6

[PATCH v3 0/2] MR3733: urlmon: test using http protocol through CreateBinding
by Yuxuan Shui (＠yshui) 06 Sep '23

06 Sep '23

-- v3: urlmon: fix NULL dereference in BindProtocol_UnlockRequest urlmon: test http protocol through CreateBinding https://gitlab.winehq.org/wine/wine/-/merge_requests/3733

4 4

Re: [PATCH v2 0/1] MR3745: user32/tests: Check all letters in test_hotkey. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3745

1 0

Re: [PATCH v2 0/3] MR3743: gdiplus: In GdipImageSelectActiveFrame() rely on codec->select_func() to fail. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3743

1 0

Re: [PATCH v3 0/8] MR3740: dmusic: Begin cleanup of collection and instruments parsing. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3740

1 0

Re: [PATCH v5 0/6] MR3738: dmsynth: Better implement sink latency clock and some activation methods. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3738

1 0

Re: [PATCH v2 0/2] MR3623: comctl32/edit: Don't use WM_TIMER to update caret position. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3623

1 0

Re: [PATCH v11 0/2] MR1924: ntoskrnl.exe/tests: Add KeInitializeDpc tests. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1924

1 0

Re: [PATCH v2 0/1] MR3742: dmsynth/tests: Add the trailing linefeed to a win_skip() message. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3742

1 0

Re: [PATCH v6 0/3] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode). - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3312

1 0

Re: [PATCH v2 0/1] MR3734: tools: Use posix_spawn() instead of fork()/execvp(). - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3734

1 0

Re: [PATCH v2 0/2] MR3741: ipconfig: Call GetAdaptersAddresses() in a loop. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3741

1 0

Re: [PATCH v2 0/1] MR3739: makedep: Fix a string format specifier typo. - approved
by Alexandre Julliard (＠julliard) 06 Sep '23

06 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3739

1 0

[PATCH v4 0/2] MR328: ci: Run the tests on macOS.
by Giovanni Mascellani (＠giomasce) 06 Sep '23

06 Sep '23

-- v4: ci: Do not drop artifacts after 1 day. ci: Run the tests on macOS. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/328

2 2

Re: [PATCH v4 0/2] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub.
by Etaash Mathamsetty (＠etaash.mathamsetty) 06 Sep '23

06 Sep '23

On Wed Sep 6 20:27:50 2023 +0000, Helix Graziani wrote: > how do i do that? git rebase -i HEAD~# (# can be any number of commits that aren't merge commits) git rebase <branch> (<branch> is any branch, use it like git merge) in this case I would say the easiest way (that I know of) is to get a diff, reset and then commit the diff, and then force push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3724#note_44471

1 0

[PATCH 0/1] MR3745: user32/tests: Check all letters in test_hotkey.
by Esme Povirk (＠madewokherd) 06 Sep '23

06 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55317 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3745

4 3

Re: [PATCH v4 0/2] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub.
by Helix Graziani (＠TornadoCookie) 06 Sep '23

06 Sep '23

On Wed Sep 6 20:13:16 2023 +0000, Helix Graziani wrote: > ah ok how do i do that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3724#note_44469

1 0

[PATCH 0/3] MR3743: gdiplus: In GdipImageSelectActiveFrame() rely on codec->select_func() to fail.
by Dmitry Timoshkov (＠dmitry) 06 Sep '23

06 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3743

3 4

Re: [PATCH v4 0/2] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub.
by Helix Graziani (＠TornadoCookie) 06 Sep '23

06 Sep '23

On Wed Sep 6 20:13:16 2023 +0000, Etaash Mathamsetty wrote: > btw your pull request isn't squashed and then merged, you have to squash > all the commits into one (since this is just a single stub). > To avoid merge commits use git rebase rather than git merge ah ok -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3724#note_44466

1 0

[PATCH 0/1] MR3742: dmsynth/tests: Add the trailing linefeed to a win_skip() message.
by Francois Gouget (＠fgouget) 06 Sep '23

06 Sep '23

The missing linefeed was causing the test summary line to be garbled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3742

3 2

[PATCH v2 0/8] MR3740: dmusic: Begin cleanup of collection and instruments parsing.
by Rémi Bernon (＠rbernon) 06 Sep '23

06 Sep '23

-- v2: dmusic: Get rid of the IDirectMusicInstrumentImpl typedef. dmusic: Rename IDirectMusicInstrumentImpl method prefix to instrument. dmusic: Simplify and cleanup IDirectMusicInstrument constructor. dmusic: Get rid of struct collection liWavePoolTablePosition member. dmusic: Get rid of struct collection liCollectionPosition member. dmusic: Get rid of the IDirectMusicCollectionImpl typedef. dmusic: Rename IDirectMusicCollectionImpl method prefix to collection. dmusic: Move constructor parameter checks to class factory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3740

4 11

[PATCH v4 0/6] MR3738: dmsynth: Better implement sink latency clock and some activation methods.
by Rémi Bernon (＠rbernon) 06 Sep '23

06 Sep '23

-- v4: dmsynth: Return DMUS_E_SYNTHNOTCONFIGURED when sink fails to activate. dmsynth: Return S_FALSE if IDirectMusicSynth_Activate is no-op. dmsynth: Forward IDirectMusicSynth_GetLatencyClock to the sink. dmsynth: Implement latency IReferenceClock interface on the sink. include: Use IReferenceClock interface from strmif.idl in dmusicc.h. dmsynth: Move constructor parameter checks to class factory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3738

3 7

[PATCH 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 06 Sep '23

06 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

3 3

[PATCH v7 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 06 Sep '23

06 Sep '23

-- v7: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

5 13

[PATCH v6 0/15] MR319: vkd3d-shader: Introduce vkd3d_shader_register.dimension, part 1.
by Francisco Casas (＠fcasas) 06 Sep '23

06 Sep '23

This MR replaces `vkd3d_shader_register.immconst_type` with `vkd3d_shader_register.dimension` which is intended for all register types and not just immconsts. This dimension is parsed in tpf.c, and initialized according to the register type in d3dbc.c. Having this field in vkd3d_shader_register allows us to avoid hardcoding special cases for the register dimensions when writing sm4 bytecode (e.g. for the sampler src register in gather instructions). Also, it allows for some fixes to d3d_asm.c, which are introduced in part 2 (https://gitlab.winehq.org/fcasas/vkd3d/-/commits/add_vkd3d_reg_dim). -- v6: vkd3d-shader/d3dbc: Initialize register dimension for all register types. vkd3d-shader/tpf: Parse register dimension for all register types. vkd3d-shader: Turn vkd3d_shader_register.immconst_type into vkd3d_shader_register.dimension. vkd3d-shader/tpf: Use vsir_register_init() in shader_sm1_parse_dst_param(). vkd3d-shader/tpf: Use vsir_register_init() in shader_sm1_parse_src_param(). vkd3d-shader/tpf: Use vsir_register_init() in shader_sm4_read_param(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_default_control_point_phase(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_resource_declaration(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_sampler_declaration(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_dcl_immediate_constant_buffer(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_cbv_declaration(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_dcl_indexable_temp(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_emit_hull_shader_builtins(). vkd3d-shader/spirv: Use vsir_register_init() in spirv_compiler_get_invocation_id(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/319

4 18

[PATCH v3 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) 06 Sep '23

06 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- v3: dwrite: Treat null character as NO_VISUAL in script analyzer. https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

2 1

Re: [PATCH v2 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Nikolay Sivov (＠nsivov) 06 Sep '23

06 Sep '23

On Wed Sep 6 17:08:48 2023 +0000, Jeffrey Smith wrote: > Are you sure? It appears to be inconsistent with the styling for the > rest of the if condition. All other or-separated terms are using > parenthesis, regardless of whether they contain an &&. You're probably right. Let's leave it as is. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744#note_44449

1 0

[PATCH 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) 06 Sep '23

06 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

3 5

[PATCH 0/1] MR3736: winmm: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 06 Sep '23

06 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3736

3 2

[PATCH 0/2] MR3623: comctl32/edit: Don't use WM_TIMER to update caret position.
by Zhiyi Zhang (＠zhiyi) 06 Sep '23

06 Sep '23

An application subclasses edit control and crashes on unexpected WM_TIMER messages. A timer was added a long time ago and it was for auto scrolling the view when the cursor is outside of the client area. However, with a EDIT_EM_ScrollCaret() call in EDIT_WM_MouseMove(), the view can be scrolled to the correct position automatically. So the timer is not necessary at all. This is tested manually with a long text in the edit control with notepad on XP, Win7 and Win10. Before this patch, the caret will move backwards every 100ms when the clicking the left mouse button on the bottom of the text and then dragging the cursor upwards and outside of the client area. After this, the behavior is the same as native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3623

3 3

[PATCH 0/7] MR3723: mshtml: Implement a unified QueryInterface on the dispex, part 1.
by Gabriel Ivăncescu (＠insn) 06 Sep '23

06 Sep '23

This begins the initial implementation of a unified QueryInterface on the dispex. There's a couple of hacks used to make the conversion split up easier, but they're all resolved within this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3723

3 19

[PATCH 0/5] MR3686: winewayland.drv: part 6: Handle wl_pointer (mouse) events.
by Alexandros Frantzis (＠afrantzis) 06 Sep '23

06 Sep '23

This MR adds support for handling `wl_pointer` devices: 1. Handle enter/leave/(absolute) motion/button/axis events to allow users to interact with applications using such devices, e.g., a mouse. 2. Update the cursor image used for Wayland surfaces based on the Windows cursor bitmap data. A few notes: 1. A single `wl_seat`/`wl_pointer` is supported for now. 2. Many of the input interactions require window management support that hasn't been implemented yet (e.g., popup positioning, resizing, max/fullscreen). 3. There is some potential for bad interactions between the input event dispatching mechanism and the `win32u` flushing logic for `window_surface` , which can lead to visual glitches. Although I don't think this is blocker for this MR, I would like to start a discussion about the problem and mitigation ideas in a comment below. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3686

5 34

[PATCH v3 0/10] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) 06 Sep '23

06 Sep '23

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- v3: wined3d: Don't skip ARB fragment program selection when fog state is dirty. wined3d: Don't force going through a texture when downloading from renderbuffers. wined3d: Handle depth textures in texture2d_read_from_framebuffer(). wined3d: Rename wined3d_context_gl_apply_fbo_state_blit() function. wined3d: Don't setup FBO and draw buffers in wined3d_context_gl_apply_blit_state(). wined3d: Don't call wined3d_texture_load() from wined3d_context_gl_apply_blit_state(). wined3d: Don't bind the FBO to GL_READ_FRAMEBUFFER in wined3d_context_gl_apply_blit_state(). wined3d: Prepare/load the destination resource location in arbfp_blitter_blit(). wined3d: Prepare/load the destination resource location in ffp_blitter_blit(). wined3d: Don't call wined3d_context_gl_apply_blit_state() from texture2d_read_from_framebuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

3 17

[PATCH v4 0/1] MR321: vkd3d-shader/hlsl: Implement intrinsic tan.
by Petrichor Park (＠petrathekat) 06 Sep '23

06 Sep '23

Now that we can write HLSL intrinsics in HLSL, cleaning up missing functions becomes much easier. This commit also extends the trigonometry tests a little bit to make sure that tan works right. -- v4: vkd3d-shader/hlsl: Implement intrinsic tan. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/321

3 4

[PATCH 0/1] MR3725: urlmon: fix HTTP redirects when auto redirection is disabled
by Yuxuan Shui (＠yshui) 06 Sep '23

06 Sep '23

If DISABLEAUTOREDIRECTS is set in BINDINFO options, urlmon does not set HTTP verb to GET when handling redirections. Although HTTP specification is vague on the correct behaviour here, many web servers expect this. This is what's causing the "400 Bad Request" error when user tries to log into GMail accounts using Outlook. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3725

5 16

[PATCH v2 0/2] MR3733: urlmon: test using http protocol through CreateBinding
by Yuxuan Shui (＠yshui) 06 Sep '23

06 Sep '23

-- v2: urlmon: fix NULL dereference in BindProtocol_UnlockRequest urlmon: test http protocol through CreateBinding https://gitlab.winehq.org/wine/wine/-/merge_requests/3733

3 4

[PATCH 0/2] MR3733: urlmon: test using http protocol through CreateBinding
by Yuxuan Shui (＠yshui) 06 Sep '23

06 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3733

3 6

[PATCH v5 0/3] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by eric pouech (＠epo) 06 Sep '23

06 Sep '23

Since dcf0bf1f, one could no longer kill a GUI application launched from unix shell (with start.exe /exec) with ctrl-c. (depends on https://gitlab.winehq.org/wine/wine/-/merge_requests/3310 to be fully functional). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v5: programs/cmd: Better handle ctrl-c events. ntdll: Unconditionally forward console events to kernelbase. kernel32/console: Add tests for GenerateConsoleCtrlEvent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3312

5 6

[PATCH 0/2] MR3741: ipconfig: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 06 Sep '23

06 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3741

2 2

[PATCH 0/8] MR3740: dmusic: Begin cleanup of collection and instruments parsing.
by Rémi Bernon (＠rbernon) 06 Sep '23

06 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3740

3 9

[PATCH v4 0/3] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by eric pouech (＠epo) 06 Sep '23

06 Sep '23

Since dcf0bf1f, one could no longer kill a GUI application launched from unix shell (with start.exe /exec) with ctrl-c. (depends on https://gitlab.winehq.org/wine/wine/-/merge_requests/3310 to be fully functional). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v4: programs/cmd: Better handle ctrl-c events. ntdll,server: Terminate GUI programs launched from unix shell. kernel32/console: Add tests for GenerateConsoleCtrlEvent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3312

3 6

[PATCH v3 0/6] MR3738: dmsynth: Better implement sink latency clock and some activation methods.
by Rémi Bernon (＠rbernon) 06 Sep '23

06 Sep '23

-- v3: dmsynth: Return DMUS_E_SYNTHNOTCONFIGURED when sink fails to activate. dmsynth: Return S_FALSE if IDirectMusicSynth_Activate is no-op. dmsynth: Forward IDirectMusicSynth_GetLatencyClock to the sink. dmsynth: Implement latency IReferenceClock interface on the sink. include: Use IReferenceClock interface from strmif.idl in dmusicc.h. dmsynth: Simplify and cleanup class constructors. https://gitlab.winehq.org/wine/wine/-/merge_requests/3738

3 8

[PATCH 0/1] MR3739: makedep: Fix a string format specifier typo.
by Rémi Bernon (＠rbernon) 06 Sep '23

06 Sep '23

Sorry about that, I don't understand how this passed the tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3739

2 1

[PATCH 0/6] MR3738: dmsynth: Better implement sink latency clock and some activation methods.
by Rémi Bernon (＠rbernon) 06 Sep '23

06 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3738

2 6

Re: [PATCH v2 0/2] MR3735: user32/tests: Wait for GetMessage call to complete. - approved
by Alexandre Julliard (＠julliard) 05 Sep '23

05 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3735

1 0

Re: [PATCH v2 0/5] MR3731: dmsynth: Implement semi-stub sink activate and time conversion methods. - approved
by Alexandre Julliard (＠julliard) 05 Sep '23

05 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3731

1 0

Re: [PATCH v4 0/11] MR3722: dmusic: Test and implement port download interface. - approved
by Alexandre Julliard (＠julliard) 05 Sep '23

05 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3722

1 0

Re: [PATCH v9 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan - approved
by Alexandre Julliard (＠julliard) 05 Sep '23

05 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

1 0

Re: [PATCH v2 0/2] MR3732: mshtml: Implement querySelector(All) for document fragments - approved
by Alexandre Julliard (＠julliard) 05 Sep '23

05 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3732

1 0

2025

2024

2023

2022

wine-gitlab September 2023