September 2023 - wine-gitlab

[PATCH 0/2] MR3067: mf: Shutdown handling of activate objects in session.
by Bernhard Kölbl (＠besentv) 27 Oct '23

27 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3067

4 11

[PATCH v3 0/2] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) 22 Oct '23

22 Oct '23

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- v3: shell32: Increase timeout for long URLs https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 5

[PATCH v10 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v10: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit from abort_thread. ntdll: Avoid calling abort_thread from the signal stack. ntdll: Use is_inside_syscall more consistently. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 9

[PATCH v3 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) 18 Oct '23

18 Oct '23

-- v3: cryptui: Use CertNameToStr(CERT_NAME_STR_NO_QUOTING_FLAG) to disable quoting. crypt32: Add support for CERT_NAME_STR_NO_QUOTING_FLAG to CertNameToStr(). crypt32/tests: Add some tests for quoted RDN values. crypt32: Avoid truncating unicode chars. https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

2 5

[PATCH v2 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo.
by Etaash Mathamsetty (＠etaash.mathamsetty) 14 Oct '23

14 Oct '23

Rainbow 6 Siege and some other games require this. Type is printed in the FIXME to determine which type the application requires. -- v2: gdi32: Add stub for D3DKMTQueryAdapterInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/3777

4 3

[PATCH 0/3] MR3839: kernel32: Add structure size checks to CreateActCtx().
by Dmitry Timoshkov (＠dmitry) 13 Oct '23

13 Oct '23

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3839

4 12

[PATCH 0/2] MR343: Draft: vkd3d-shader/hlsl: Make deref->data_type available for the whole deref's lifetime.
by Francisco Casas (＠fcasas) 10 Oct '23

10 Oct '23

I marked this a draft because it may be a somewhat orthogonal step, but IRRC @giomasce suggested it. While a deref's data type can be computed from the variable's data type as long as the deref is still represented as a path (as we did with hlsl_deref_get_type()), we need the deref.data_type field for when the deref is represented as an offset. While we could get rid of this deref.data_type in the future, if we manage to transform the HLSL IR instructions directly to VSIR withot requiring lowering the derefs to their offset representation, this would take a while. So, this patch makes the deref.data_type field available during the whole lifetime of the deref. Which makes deref.data_type easier to understand (since it can be used anytime now) and we no longer have to call hlsl_deref_get_type(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/343

4 8

[PATCH v2 0/6] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.
by Ziqing Hui (＠zhui) 09 Oct '23

09 Oct '23

-- v2: winegstreamer: Implement wg_muxer_push_sample. winegstreamer: Implement ProcessSample for media sink. winegstreamer: Implement wg_muxer_start. winegstreamer: Implement wg_muxer_add_stream. winegstreamer: Introduce link_src_to_sink. winegstreamer: Use NTSTATUS value in wg_muxer_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/3810

3 19

[PATCH v2 0/1] MR3955: mf: Avoid a double free of presentation clock timers.
by Zhiyi Zhang (＠zhiyi) 09 Oct '23

09 Oct '23

In clock_change_state() when a clock is running, a timer is removed from clock->timers. The same timer is then used to create an async result, which will eventually calls present_clock_timer_callback_Invoke() and removes the same timer. -- v2: mf: Avoid a double free of presentation clock timers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3955

3 4

[PATCH v4 0/2] MR3806: combase: Create implicit MTA in STA apartment in RoGetActivationFactory().
by Paul Gofman (＠gofman) 09 Oct '23

09 Oct '23

Fixes Starfield not being able to take photos in photo mode (due to failing to creating windowscodecs' image factory due to COM apartment being initialized). Turns out on Windows RoGetActivationFactory() initializes implicit MTA apartment when called from STA thread, and so after that called once COM is implicitly uninitialized for any (new) thread until COM is uninitialized in the thread which called RoGetActivationFactory (or that thread exited). This is not the case on Win8 (where the function was first introduced) but looks consistent after that. -- v4: combase: Ensure MTA existence in RoGetActivationFactory(). combase/tests: Add tests for implicit MTA with RoGetActivationFactory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3806

3 4

[PATCH 0/1] MR3416: ieframe: Forward WM_PAINT messages to the document host and all its child windows.
by Torge Matthies (＠tmatthies) 09 Oct '23

09 Oct '23

Windows gives this content special protection from being painted over, by some means that I have not investigated yet. Emulate this protection for the trivial case of an InvalidateRect(...); call on the parent window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3416

4 9

[PATCH 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 06 Oct '23

06 Oct '23

- Make it present some frames - Make it check that the frames are from the new device, instead of checking TerminateDevice count; fixes https://bugs.winehq.org/show_bug.cgi?id=55649 - Make it check for and avoid some absurd crash on Windows I tried everything I could think of, but Windows absolutely refuses to present a frame after changing the D3D device, instead choosing to return various absurd errors (segfaults, deadlocks, out of memory, etc). I suspect the VMR9 is haunted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970

3 7

[PATCH 0/4] MR229: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 2
by Francisco Casas (＠fcasas) 06 Oct '23

06 Oct '23

Support for relative addressing in SM4. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/229

6 27

[PATCH 0/5] MR3975: Improve module's debug information.
by eric pouech (＠epo) 06 Oct '23

06 Oct '23

This series: - fixes a couple of issues in mach-o modules support (getting information from system modules in wow setups, machine information...) - stops hiding information in some fields between dbghelp and winedbg (using an extensible solution, where more information can be shared in the future) - display elf/mach-o in winedbg (previously mach-o was reported as elf) - display PE native vs builtin module information in winedbg -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3975

3 9

[PATCH 0/1] MR3599: riched20: Remove unnecessary make_string and heap_string_free functions.
by Alex Henrie (＠alexhenrie) 06 Oct '23

06 Oct '23

It'll be easier to convert this code to use CRT allocation functions if we don't have to worry about the function pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3599

3 4

[PATCH v8 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo.
by Etaash Mathamsetty (＠etaash.mathamsetty) 06 Oct '23

06 Oct '23

Rainbow 6 Siege and some other games require this. Type is printed in the FIXME to determine which type the application requires. -- v8: gdi32: Add stub for D3DKMTQueryAdapterInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/3777

3 2

[PATCH 0/1] MR3939: riched20: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 06 Oct '23

06 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3939

3 2

[PATCH v2 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 06 Oct '23

06 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Initial support for 'switch' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

3 13

[PATCH v3 0/5] MR358: vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers.
by Nikolay Sivov (＠nsivov) 05 Oct '23

05 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/tpf: Output interpolation modifiers for input declarations. vkd3d-shader/hlsl: Propagate structure fields modifiers when copying shader inputs. vkd3d-shader/hlsl: Allow interpolation modifiers on structure fields. vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers. tests: Add a test for interpolation modifiers specified on structure fields. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/358

4 12

[PATCH v6 0/4] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) 05 Oct '23

05 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v6: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader/hlsl: Handle 'continue' statements. vkd3d-shader/hlsl: Allow 'break' instructions in loops. tests: Add some tests for 'break'/'continue' in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

4 11

[PATCH 0/1] MR384: Draft: vkd3d: Introduce a thread-local descriptor object cache.
by Conor McCarthy (＠cmccarthy) 05 Oct '23

05 Oct '23

A TLS index is allocated for each device object. We could use a global TLS, but that would share caches for all devices. I'm not sure if that's a problem. One index per device means freed indices must be recycled, which requires a global mutex, but a global TLS index would also need a global mutex. This currently leaks cache memory when a device is freed. To fix this, allocations must be tracked. A global cache is more difficult to free, which is not normally an issue, but it is when using valgrind. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

4 6

[PATCH 0/1] MR3973: winsock: Map EDESTADDRREQ to STATUS_INVALID_CONNECTION.
by Paul Gofman (＠gofman) 05 Oct '23

05 Oct '23

Fixes Nascar Heat 5 not being able to connect to multiplayer lobby. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3973

4 3

[PATCH v34 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 05 Oct '23

05 Oct '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v34: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

4 3

[PATCH 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration.
by Zhiyi Zhang (＠zhiyi) 04 Oct '23

04 Oct '23

Test that there is a ~1.5s timer after entering fullscreen mode and restores WS_EX_TOPMOST if it's missing when the timer times out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3915

4 7

[PATCH v3 0/8] MR1684: d3d10/effect: Further improvements to expressions support.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

-- v3: d3d10/effect: Add 'ceil' instruction for expressions. d3d10/effect: Add 'dot' instruction support for expressions. d3d10/effect: Add trigonometric instructions support for expressions. d3d10/effect: Add support for shift instructions. d3d10/effect: Add 'or' instruction support for expressions. d3d10/effect: Add more integer instructions for expressions. d3d10/effect: Add signed integer compare instructions for expressions. d3d10/effect: Implement instructions used for signed integer division. https://gitlab.winehq.org/wine/wine/-/merge_requests/1684

3 14

[PATCH 0/2] MR381: vkd3d-shader/tpf: Handle "COLOR" semantic the same way as "sv_target" in the parser.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

6 15

[PATCH 0/1] MR375: vkd3d-shader/hlsl: Remove conditional branching when condition is a compile time constant.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/375

5 4

[PATCH v2 0/1] MR368: vkd3d-shader: Add constant folding for 'rsq'.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader: Add constant folding for 'rsq'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/368

5 5

[PATCH v2 0/4] MR363: vkd3d-shader/hlsl: Add constant folding for logical 'not', for bools.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add constant folding for binary complement operator. vkd3d-shader/hlsl: Add constant folding for rshift. vkd3d-shader/hlsl: Add constant folding for lshift. vkd3d-shader/hlsl: Add constant folding for logical 'not', for bools. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/363

5 10

[PATCH 0/5] MR342: vkd3d-shader/hlsl: Stop using hlsl_type_get_regset().
by Francisco Casas (＠fcasas) 04 Oct '23

04 Oct '23

As has been pointed out a couple of times, mainly by @zfigura, hlsl_type_get_regset() is not defined for structs. So it is responsibility of the programmer to ensure that the data type in question belongs to a single regset before calling that function. Turns out that when we call this function we either have to handle the possibility of the type spanning across multiple regsets, or we want the regset of a single component or vector, so this MR replaces the calls to hlsl_type_get_regset() with either a for loop that goes through all the pertaining regsets, hlsl_type_get_component_offset(), or hlsl_type_get_regset(). hlsl_type_get_regset() is still needed in the implementation of these functions, so it is downgraded to a static function for hlsl.c instead of being completely removed. The tests in 3/5 (structs with multiple register reservations) are to explain why it makes sense to iterate over the regsets in 4/5 even if we don't have a proper implementation for register reservations on structs that span across mutiple regsets yet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/342

5 8

[PATCH v3 0/1] MR330: vkd3d-shader/hlsl: Add fwidth() function.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/hlsl: Add fwidth() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/330

5 5

[PATCH 0/3] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 03 Oct '23

03 Oct '23

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

6 14

[PATCH 0/1] MR3979: wined3d: Reference the push constant buffers.
by Stefan Dösinger (＠stefan) 03 Oct '23

03 Oct '23

--- I came across this in my attempts to implement nooverwrite maps based on sysmem staging buffers when buffer storage is not available. My debug modifications broke the fast path for update_sub_resource and the wined3d_resource_wait() didn't do its job for the push constant buffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3979

4 5

[PATCH v3 0/5] MR3987: d3d10/effect: Add support for 'buge'/'bult' instructions.
by Nikolay Sivov (＠nsivov) 02 Oct '23

02 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d3d10/effect: Add support for 'dot' instruction. d3d10/effect: Add support for 'floor' instruction. d3d10/effect: Add support for 'ceil' instruction. d3d10/tests: Compact returned arrays checks. d3d10/effect: Add support for 'buge'/'bult' instructions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3987

3 9

[PATCH v18 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 02 Oct '23

02 Oct '23

This goes on top of MR 345. -- v18: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

3 11

[PATCH 0/1] MR3025: include: Add missing interfaces in wia_lh.idl
by Biswapriyo Nath (＠Biswa96) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3025

3 5

[PATCH 0/1] MR383: tests: Destroy the test context in test_readback_map_stability().
by Conor McCarthy (＠cmccarthy) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/383

4 3

[PATCH v3 0/1] MR380: vkd3d-dxbc: Print section offsets.
by Giovanni Mascellani (＠giomasce) 02 Oct '23

02 Oct '23

-- v3: vkd3d-dxbc: Print section offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/380

3 2

[PATCH 0/1] MR385: vkd3d-shader: Fix compiler warning.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '23

02 Oct '23

vkd3d-shader/tpf.c:3810:39: warning: passing argument 2 of ‘sm4_register_from_node’ from incompatible pointer type [-Wincompatible-pointer-types] vkd3d-shader/tpf.c:4750:59: warning: passing argument 3 of ‘sm4_register_from_deref’ from incompatible pointer type [-Wincompatible-pointer-types] The other option is to change the parameter to a DWORD but this is a larger change. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385

4 4

[PATCH 0/3] MR382: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 4.
by Francisco Casas (＠fcasas) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/382

4 5

[PATCH v3 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results.
by eric pouech (＠epo) 02 Oct '23

02 Oct '23

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55658 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: winemac.drv: Use NtCallbackReturn to send back app's icons to unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3974

3 2

[PATCH v3 0/11] MR3907: ntdll: Initial implementation of File{Rename,Link}InformationEx
by Joel Holdsworth (＠jhol) 01 Oct '23

01 Oct '23

-- v3: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS. ntdll: Factored out get_inode_open_sharing. ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS. ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS. ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE. server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}. ntdll/test: Add tests for FILE_LINK_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Add tests for FILE_RENAME_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Use FileDispositionInformationEx to delete files and directories. ntdll: Initial implementation of FileLinkInformationEx. ntdll: Initial implementation of FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3907

4 19

[PATCH v6 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 01 Oct '23

01 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v6: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Handle format changes better in Quartz. winegstreamer: Implement CLSID_CMpegVideoCodec. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

5 13

[PATCH v9 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 01 Oct '23

01 Oct '23

Used in some .NET apps for theming purposes. -- v9: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

4 8

[PATCH v2 0/1] MR3988: winetts: Add stub dll.
by Shaun Ren (＠shaunren) 30 Sep '23

30 Sep '23

-- v2: winetts: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3988

4 3

[PATCH 0/1] MR3989: user32/tests: Print regions in test_hvredraw failure case.
by Esme Povirk (＠madewokherd) 30 Sep '23

30 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3989

2 1

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > + /* Call ShouldSystemUseDarkMode() and check for errors */ > + SetLastError(ERROR_SUCCESS); /* Clear error buffer so that we can detect if an error occurred. */ > + function_result = pShouldSystemUseDarkMode(); > + last_error = GetLastError(); > + ok(last_error == ERROR_SUCCESS, "ShouldSystemUseDarkMode failed (?) with error %ld.\n", > + last_error); > + > + /* Expect same value as key */ > + ok(function_result == !system_uses_light_theme, "Expected value %d, got %d.\n", > + !system_uses_light_theme, function_result); > + > + ls = RegDeleteValueA(hk, "AppsUseLightTheme"); > + ok(ls == 0, "RegDeleteValueA failed: %ld.\n", ls); > + > + /* Call ShouldSystemUseDarkMode() and check for errors with deleted value */ > + SetLastError(ERROR_SUCCESS); /* Clear error buffer so that we can detect if an error occurred. */ For the last error code. You can SetLastError(0xdeadbeef) before the call and check that the last error is set to ERROR_SUCCESS after the call. And then you set the last error code in the ShouldSystemUseDarkMode() implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47274

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > UnregisterUserApiHook(); > return TRUE; > } > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. Shouldn't `system/app` be `system`? because there is a ShouldAppsUseDarkMode() as you said previously. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47273

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > UnregisterUserApiHook(); > return TRUE; > } > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); You can remove the system_uses_ prefix. These codes are in ShouldSystemUseDarkMode() so it's already known that it's for querying system settings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47272

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); > + /* Persists between calls, in windows it might look up some internal table. */ > + static DWORD system_uses_light_theme = TRUE; > + > + /* We don't necessarily care that this might fail because it doesn't affect > + * system_uses_light_theme if it does. > + */ > + RegGetValueA(HKEY_CURRENT_USER, Please use RegGetValueW() instead so that we don't have to do ASCII/Unicode conversion every time this gets called. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47271

1 0

2025

2024

2023

2022

wine-gitlab September 2023