September 2023 - wine-gitlab

[PATCH 0/1] MR3932: d3dcompiler: Add support for matrix majority compiler flags.
by Nikolay Sivov (＠nsivov) 22 Sep '23

22 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3932

3 2

[PATCH 0/4] MR362: Draft: ci: Build vkd3d with MinGW too.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

For the moment this MR is just to run the pipeline and check the result. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/362

2 4

[PATCH 0/3] MR2325: d3d10/effect: Implement instructions used for signed integer division.
by Nikolay Sivov (＠nsivov) 22 Sep '23

22 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2325

4 15

Re: [PATCH v2 0/1] MR3921: ws2_32/tests: Add more tests for SO_REUSEADDR - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3921

1 0

Re: [PATCH v2 0/1] MR3927: include: Add ID3D12VideoDecoder in d3d12video.idl. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3927

1 0

[PATCH v4 0/1] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Myah Caron (＠qsniyg) 22 Sep '23

22 Sep '23

Fixes https://bugs.winehq.org/show_bug.cgi?id=55640. The lightening/darkening values are loosely based on Qt 6's fallback code: https://github.com/qt/qtbase/blob/ba98644180bcaf40341a9005abe93575cf45cc5a/…. The values are not perfect, technically it should use Software\Microsoft\Windows\DWM\AccentColor. But since to my knowledge, wine doesn't use AccentColor in any way, this should do the trick for now. `COLOR_HIGHLIGHT` should be roughly the same color as the accent color in most cases. Qt 6 uses the accent color as its highlight color anyways. -- v4: windows.ui: Support accent colors in uisettings3_GetColorValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3931

2 1

Re: [PATCH v3 0/1] MR3923: mfreadwrite/tests: Call CoInitialize at the start of tests. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3923

1 0

Re: [PATCH v6 0/1] MR3172: vkd3d: Import from upstream - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3172

1 0

Re: [PATCH v2 0/1] MR3924: mshtml: Remove unused functions. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3924

1 0

Re: [PATCH v2 0/1] MR3920: winecoreaudio: Use os_unfair_lock when available instead of OSSpinLock. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3920

1 0

Re: [PATCH v3 0/2] MR3896: d3d10/effect: Implement instructions used for signed integer division. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3896

1 0

[PATCH v2 0/143] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Myah Caron (＠qsniyg) 22 Sep '23

22 Sep '23

Fixes https://bugs.winehq.org/show_bug.cgi?id=55640. The lightening/darkening values are loosely based on Qt 6's fallback code: https://github.com/qt/qtbase/blob/ba98644180bcaf40341a9005abe93575cf45cc5a/…. The values are not perfect, technically it should use Software\Microsoft\Windows\DWM\AccentColor. But since to my knowledge, wine doesn't use AccentColor in any way, this should do the trick for now. `COLOR_HIGHLIGHT` should be roughly the same color as the accent color in most cases. Qt 6 uses the accent color as its highlight color anyways. -- v2: dmime: Implement DirectMusicSeqTrack IPersistStream_Load. dmime: Get rid of the IDirectMusicSeqTrack typedef. dmband: Rewrite band track IPersistStream_Load. dmband: Rewrite band track DBMT chunk parsing. dmband: Rewrite band track lbdl/lbnd lists parsing. msado15: Recordset::Open - Correctly update count/index values. winecoreaudio: Stop using the deprecated kAudioObjectPropertyElementMaster constant. user32/tests: Fix WM_WINDOWPOSCHANGED entries. uiautomationcore: Handle EVENT_SYSTEM_ALERT in IProxyProviderWinEventHandler::RespondToWinEvent() for MSAA providers. uiautomationcore: Add stub IProxyProviderWinEventHandler implementation for MSAA providers. uiautomationcore: Implement IRawElementProviderFragmentRoot::GetFocus for MSAA providers. uiautomationcore: Pass through failure HRESULTS on MSAA accState based property IDs for MSAA providers. uiautomationcore/tests: Increase wait timeout for cross-process event with navigation. dmusic: Keep the original instrument patch in the entry. dmusic/tests: Fixup chunk alignment in steam_end_chunk. dmime/tests: Test band track and DMUS_PATCH_PMSG. dmime/tests: Test sequence track and DMUS_NOTE_PMSG. dmime/tests: Test wave segments and DMUS_WAVE_PMSG. dmime/tests: Add some DMUS_NOTIFICATION_PMSG tests. msvcp90: Silence FIXME in _Locinfo::_Locinfo_ctor and _Locinfo::_Locinfo_Addcats functions. mshtml: Use the event_target vtbl's handle_event for all nodes. mshtml: Use the dispex's invoke for all nodes. mshtml: Use the dispex's get_name for all nodes. mshtml: Use the dispex's get_dispid for all nodes. mshtml: Use the dispex's destructor for all nodes. d3d10core/tests: Test performing a full clear after a draw. wined3d: Pass a wined3d_stateblock_state to wined3d_device_validate_device(). d3d11/tests: Properly mark the indexed sample position test as succeeding with the Vulkan backend. wined3d: Don't validate the frontbuffer's DRAWABLE location in wined3d_swapchain_resize_buffers() when NO3D is set. d3drm: Correctly query for the returned interface. dsound: Use malloc and free instead of _recalloc. wineps.drv: Don't crash if specified font is missing required table in T42_download_header. wineps.drv: Remove unused hmtx_tab field from TYPE42 structure. kernel32/tests: Update dll characteristics to make the module loadable on ARM64. kernel32/tests: Unaligned SRW locks crash on ARM platforms. kernel32/tests: Don't make assumptions about argv[0] of the main process. kernel32/tests: Comment out one more test that can crash on Windows. ntdll: Remove unneeded SEH annotations in Unix code. vcomp: Add SEH annotations to ARM64 assembly code. rpcrt4: Add SEH annotations to ARM64 assembly code. oleaut32: Add SEH annotations to ARM64 assembly code. winmm/tests: Avoid truncating the handle passed to waveInGetDevCapsW(). msi: Use CreateFileW() for handling path from cabinet_open() instead. wshom: Use the wcsdup function instead of reimplementing it. shell32: Use the wcsdup function instead of reimplementing it. ncrypt: Use the wcsdup function instead of reimplementing it. msvfw32: Use CRT allocation functions. mciwave: Use CRT allocation functions. gameux: Use CRT allocation functions. advpack: Use CRT allocation functions. oleaut32: Use CRT allocation functions in typelib.c. oleaut32: Use CRT allocation functions in olepicture.c. oleaut32: Use CRT allocation functions in hash.c. oleaut32: Use CRT allocation functions in connpt.c. ntdll: Allow empty application nodes in actctx. msvcp140_atomic_wait: Add __std_acquire_shared_mutex_for_instance implementation. uiautomationcore: Don't return oleacc proxy IAccessibles from GetIAccessible for MSAA providers. uiautomationcore: Implement IRawElementProviderFragment::get_FragmentRoot for MSAA providers. uiautomationcore: Add a common helper function for querying IServiceProvider on IAccessible interfaces. uiautomationcore: Add stub IRawElementProviderFragmentRoot implementation for MSAA providers. uiautomationcore/tests: Add support for debug printing Provider method calls. uiautomationcore/tests: Add support for debug printing Accessible method calls. uiautomationcore/tests: Add method expect definitions for all Accessible test interfaces. dmime: Use segment_append_track in Clone and parse_track_form. dmime: Rewrite segment IDirectMusicSegment_RemoveTrack. dmime: Rewrite segment IDirectMusicSegment_InsertTrack. dmime: Rewrite segment IDirectMusicSegment_GetTrackGroup. dmime: Rewrite segment IDirectMusicSegment_GetTrack. dmime: Avoid leaking tracks in IDirectMusicSegment_Release. dmime: Get rid of the IDirectMusicSegmentImpl typedef. dmime: Use one-liners for segment parameter checks. dmime: Rename IDirectMusicSegment8Impl method prefix to segment. dmband: Rewrite band IPersistStream_Load. dmband: Rewrite band dmbd chunk parsing. dmband: Rewrite band lbil list parsing. dmband: Rewrite band lbin list parsing. dmband: Avoid leaking collection on band release. dmband: Avoid leaking bands on band track Release. dmband: Get rid of the IDirectMusicBandTrack typedef. dmband: Get rid of the IDirectMusicBandImpl typedef. dmband: Rename IDirectMusicBandImpl prefix to band. mshtml: Use the dispex's query_interface for the remaining nodes. mshtml: Use the dispex's query_interface for DOMTextNodes. mshtml: Use the dispex's query_interface for Document nodes and fragments. mshtml: Use the dispex's query_interface for DocumentType nodes. mshtml: Use specific dispex for each SVG element. mshtml: Use specific dispex vtbls for remaining HTML elements. ntdll/tests: Test both FileLinkInformation and FileLinkInformationEx in test_file_link_information. include: Add flags to FILE_LINK_INFORMATION used by FileLinkInformationEx. ntdll/tests: Test both FileRenameInformation and FileRenameInformationEx in test_file_rename_information. include: Add flags to FILE_RENAME_INFORMATION used by FileRenameInformationEx. user32: Add hotpatchable wrapper for GetWindowLongA. user32: Make CallWindowProcA hotpatchable. gdi32: Make GetStockObject hotpatchable. include: Update the d3d12 headers from vkd3d. winebuild: Make the syscall thunks position-independent on ARM64. winebuild: Add a few more SEH annotations. winebuild: Remove unnecessary .cfi_startproc/endproc annotations. winebuild: Add a separate helper for .seh annotations. include: Move RTL functions that belong in winnt.h from winternl.h to winnt.h. gdiplus: Fix GdipCreateFont character set initialization. gdiplus/tests: Test GdipCreateFont character set initialization. msvcr110: Use Context blocking functions in _StructuredTaskCollection class. msvcr110: Simplify _StructuredTaskCollection finished task counter updating. msvcp110: Add _Winerror_map implementation. mshtml: Get rid of useless element destructors. mshtml: Move node vtbl destructor methods down. mshtml: Move node vtbl QI methods around. mshtml: Move some SelectElement methods up. mshtml: Move some ObjectElement methods up. mshtml: Move some IFrame methods down. mshtml: Move some FrameElement methods down. mshtml: Move some FormElement methods up. mshtml: Move some AreaElement methods up. mshtml: Move some AnchorElement methods up. mshtml: Move some Element methods around. dmime: Pass the DMUS_PMSG through the performance graph. dmime: Rename DMUS_PMSGToItem to message_from_DMUS_PMSG. dmime: Remove unnecessary struct message members. dmime: Use a struct list to keep performance messages. dmime: Get rid of the DMUS_PMSGItem typedef. dmime: Convert DMUS_PMSG music and reference times in SendPMsg. dmime/tests: Test that SendPMsg also converts reference time. dbghelp: Check that dwarf unwinder did actually unwind. include: Add missing WinEvent definitions. server: Return WSAEOPNOTSUPP on listen() if the socket's type is SOCK_DGRAM. user32/tests: Account for some messages from dual-monitor setups. mfreadwrite/reader: Update to IMFSourceReaderEx. wbemprox: Fix out-of-bounds access caused by codepoints above U+00FF. d3d10/effect: Implement 'mov' opcode for expressions. dmusic: Implement instrument articulation downloads. dmusic: Parse instrument regions articulation lists. dmusic: Implement downloading wave to port. dmusic: Keep an internal ref on the instrument's collection. dmusic: Parse collection wave lists. dmusic: Parse collection wave table. dmusic: Rewrite downloading instrument to port. dmusic: Avoid swallowing collection Load failures. gdiplus: Copy the compound array in GdipClonePen(). uiautomationcore: Implement UiaHasServerSideProvider. uiautomationcore: Add a common helper function for creating HUIANODEs. uiautomationcore: Add UiaHasServerSideProvider stub. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3931

1 0

Re: [PATCH v2 0/2] MR357: vkd3d: Fix a few tests on Intel. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/357

1 0

Re: [PATCH v4 0/2] MR354: tests: Avoid some crashes on MoltenVK. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/354

1 0

Re: [PATCH v2 0/4] MR344: tests: Compile more HLSL shaders at runtime. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/344

1 0

Re: [PATCH v3 0/3] MR341: vkd3d-shader/hlsl: Add constant folding for 'fract'. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/341

1 0

Re: [PATCH v3 0/2] MR338: vkd3d-shader/hlsl: Correctly fold casts from float. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/338

1 0

Re: [PATCH v6 0/2] MR336: vkd3d-shader/hlsl: Fix float modulus for vector arguments. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/336

1 0

Re: [PATCH v10 0/13] MR317: vkd3d-shader: Begin validating the generated IR. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/317

1 0

Re: [PATCH v2 0/1] MR315: vkd3d: Add ID3D12Device2 interface. - approved
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/315

1 0

[PATCH 0/1] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Myah Caron (＠qsniyg) 22 Sep '23

22 Sep '23

Fixes https://bugs.winehq.org/show_bug.cgi?id=55640. The lightening/darkening values are loosely based on Qt 6's fallback code: https://github.com/qt/qtbase/blob/ba98644180bcaf40341a9005abe93575cf45cc5a/…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3931

2 1

[PATCH 0/1] MR3930: d3d10/tests: Add some tests for D3D10.1 blend state in effects.
by Nikolay Sivov (＠nsivov) 22 Sep '23

22 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3930

4 8

[PATCH 0/2] MR3926: Fix FileLinkInformationEx and FileRenameInformationEx test failures on older Windows versions.
by Joel Holdsworth (＠jhol) 22 Sep '23

22 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3926

3 3

[PATCH v25 0/4] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 22 Sep '23

22 Sep '23

This comes from behavioral study of Windows, which doesn't seem to check if the lock is actually exclusively held, and just simply decrement the value stored in the lock. This fixes a dead lock which prevents WeCom from starting up. -- v25: ntdll: wake up SRWLOCK waiters by thread id ntdll: allow SRWLOCKs to be quickly re-acquired ntdll: An implementation of SRWLOCK that closer matches Windows'. include: add atomic read/write of pointers https://gitlab.winehq.org/wine/wine/-/merge_requests/3504

3 20

[PATCH v2 0/1] MR3923: mfreadwrite/tests: Call CoInitialize at the start of tests.
by Alistair Leslie-Hughes (＠alesliehughes) 22 Sep '23

22 Sep '23

-- v2: mfreadwrite/tests: Move test_interfaces after test_factory. https://gitlab.winehq.org/wine/wine/-/merge_requests/3923

3 2

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 22 Sep '23

22 Sep '23

On Fri Sep 22 16:09:26 2023 +0000, eric pouech wrote: > it has an exception handler around it, so > * either the field is not on a readable page and the exception will be > fired, and you'll get a NULL pointer (SAFE) > * or the field is on a readable page but with a wrong magic value, and > you'll get a NULL pointer (SAFE) > * or the field is on a readable page, with the expected magic value, and > you'll a non NULL pointer, that you can check if it fits or not in > mapped view before reading into it (SAFE) Oh! Okay, I will use `RtlImageNtHeader` and then do the bounds checks afterwards :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46369

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 15:55:16 2023 +0000, Aidan Khoury wrote: > You're right, I checked again and this exception is captured and > gracefully fails with the last error code set to 0xE0000001. So, I will > remove this and just set the last error 0xE0000001 with a failing return > value. I'll add some tests for this case. this can also be done by setting an exception handler inside some functions (in badly written pseudo code): ``` try { // do the expected stuff // setting ret & last error in case of error } catch (exception e) { throw exception(0xE0000001); ret = FALSE; SetLastError(0xE0000001); } return ret; ``` but that doesn't prevent from releasing the resources between the throw and this handler (we're not using RAEII and the current exception handling even for C code requires compiler support that we don't have) so perhaps the safest solution is to return error codes internally (no exception) and throw the exception on top level functions that's not nice for sure, but I fear we don't have many other options -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46367

1 0

[PATCH v5 0/1] MR3172: vkd3d: Import from upstream
by Alexandre Julliard (＠julliard) 22 Sep '23

22 Sep '23

-- v5: vkd3d: Import upstream release 1.9. https://gitlab.winehq.org/wine/wine/-/merge_requests/3172

3 2

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Thu Sep 21 22:33:18 2023 +0000, Aidan Khoury wrote: > This `rebase_image` implementation could still be adapted as an imghelp > internal function, could it not? Though that would be better to be done > as a separate MR, I think. I gave ReBaseImage a quick look at how it behaves in windows and it has some likely unwanted behavior (like hard to really force a new rebase address), so it's fine to leave it aside for now -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46359

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 15:46:59 2023 +0000, Aidan Khoury wrote: > The native RtlImageHeader does not have boundary checks. I cannot do > this check on RtlImageHeader's return value safely since that would be > after RtlImageHeader has already potentially accessed an invalid address. it has an exception handler around it, so * either the field is not on a readable page and the exception will be fired, and you'll get a NULL pointer (SAFE) * or the field is on a readable page but with a wrong magic value, and you'll get a NULL pointer (SAFE) * or the field is on a readable page, with the expected magic value, and you'll a non NULL pointer, that you can check if it fits or not in mapped view before reading into it (SAFE) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46358

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:40:36 2023 +0000, eric pouech wrote: > (my question was unclear: I meant does native throw this exception?) > what does native do if the exception is continued? (I doubt this helper > can be DECLSPEC_NOTRETURN) You're right, I checked again and this exception is captured and gracefully fails with the last error code set to 0xE0000001. So, I will remove this and just set the last error 0xE0000001 with a failing return value. I'll add some tests for this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46356

1 0

[PATCH 0/7] MR3922: dmloader: Simplify loader stream implementation.
by Rémi Bernon (＠rbernon) 22 Sep '23

22 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3922

2 8

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:50:36 2023 +0000, eric pouech wrote: > this raises the questions does native ntdll.RtlImageHeader check for > e_lfanew being within image boundary? if so, it builtin implementation > has to be fixed (with test case please) > and if it doesn't you can still add the check on RtlImageHeader's > returned value The native RtlImageHeader does not have boundary checks. I cannot do this check on RtlImageHeader's return value safely since that would be after RtlImageHeader has already potentially accessed an invalid address. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46353

1 0

[PATCH 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 22 Sep '23

22 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

2 2

[PATCH 0/1] MR3927: include: Add ID3D12VideoDecoder in d3d12video.idl.
by Biswapriyo Nath (＠Biswa96) 22 Sep '23

22 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3927

2 1

[PATCH 0/1] MR3925: Draft: serialui:confdlg: Simple test failure.
by Francois Gouget (＠fgouget) 22 Sep '23

22 Sep '23

Check whether GitLab still takes the TestBot failures into account. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3925

3 2

[PATCH 0/4] MR358: vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers.
by Nikolay Sivov (＠nsivov) 22 Sep '23

22 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/358

5 14

[PATCH 0/1] MR3923: mfreadwrite/tests: Call CoInitialize at the start of tests.
by Alistair Leslie-Hughes (＠alesliehughes) 22 Sep '23

22 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3923

3 4

[PATCH 0/1] MR3924: mshtml: Remove unused functions.
by Jacek Caban (＠jacek) 22 Sep '23

22 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3924

3 2

Re: [PATCH v7 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 22 Sep '23

22 Sep '23

For some bizarre reason not immediately obvious, using the `ID3D10Blob_Release()` macro on an IDxcBlob caused `vkd3d_test_state.skip_count` to be decremented. `WIDL_C_INLINE_WRAPPERS` fixes this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346#note_46323

1 0

[PATCH v3 0/3] MR359: ci: Build crosstests in a dedicate CI job.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

Mostly to avoid polluting other logs and artifacts, and also to avoid recompiling crosstests over and over. -- v3: ci: Wrap complex commands in CI scripts. ci: Build crosstests with -Wno-array-bounds. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/359

2 4

[PATCH v2 0/1] MR359: ci: Build crosstests in a dedicate CI job.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

Mostly to avoid polluting other logs and artifacts, and also to avoid recompiling crosstests over and over. -- v2: ci: Build crosstests in a dedicate CI job. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/359

2 1

[PATCH 0/2] MR359: ci: Build crosstests in a dedicate CI job.
by Giovanni Mascellani (＠giomasce) 22 Sep '23

22 Sep '23

Mostly to avoid polluting other logs and artifacts, and also to avoid recompiling crosstests over and over. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/359

3 4

[PATCH v7 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 22 Sep '23

22 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- v7: windows.applicationmodel: Implement IStorageItem::get_Path(). windows.applicationmodel/tests: Add IStorageItem::get_Path() tests. windows.applicationmodel: Add IStorageItem stub interface. windows.applicationmodel: Implement IPackage::get_InstalledLocation(). windows.applicationmodel: Implement IPackageStatics::get_Current(). windows.applicationmodel: Add IPackageStatics stub interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

3 9

[PATCH v3 0/1] MR2498: msado15: Implement _Recordset Find
by Alistair Leslie-Hughes (＠alesliehughes) 22 Sep '23

22 Sep '23

Find only supports one Column to filter on. The parser for this will be the same for both Find/Filter with the only different is the Filter supports multiple columns. In trying to keep this patch small, only WSTR/BSTR/Integer have been supported. (The Common cases). -- v3: msado15: Implement _Recordset Find https://gitlab.winehq.org/wine/wine/-/merge_requests/2498

2 1

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management - approved
by Rémi Bernon (＠rbernon) 22 Sep '23

22 Sep '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:50:36 2023 +0000, Aidan Khoury wrote: > `RtlImageNtHeader` lacks proper image boundary checks for e_lfanew, so > using it in this case is not safe. this raises the questions does native ntdll.RtlImageHeader check for e_lfanew being within image boundary? if so, it builtin implementation has to be fixed (with test case please) and if it doesn't you can still add the check on RtlImageHeader's returned value -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46285

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Thu Sep 21 20:03:38 2023 +0000, Aidan Khoury wrote: > No, but if you supply invalidly formed images to the mspatcha.dll APIs > it will raise an exception with code 0xE0000001. I made this a separate > function so I could mark it as `DECLSPEC_NORETURN`. (my question was unclear: I meant does native throw this exception?) what does native do if the exception is continued? (I doubt this helper can be DECLSPEC_NOTRETURN) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46284

1 0

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) 22 Sep '23

22 Sep '23

> What about If I changed the commit message to winmm: MCI_MapMsgAtoW return error code directly instead of a boolean. That's my point: it doesn't currently return a boolean, it returns a tri-state. One of those values tells the caller to skip calling `MCI_UnmapMsgAtoW()`. Your change gets rid of this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_46283

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:33:23 2023 +0000, Aidan Khoury wrote: > Updated in https://gitlab.winehq.org/wine/wine/-/merge_requests/3870/diffs?diff_id=709… > :thumbsup: actually, if there's a bug in imagehlp.CalcCheckSum, the general way of handling is to write a test case that demonstrate the bug, and implement the fix in the offending function -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46282

1 0

2025

2024

2023

2022

wine-gitlab September 2023