September 2023 - wine-gitlab

[PATCH v2 0/1] MR3708: loader: Don't return from __stack_chk_fail() stub (which GCC expects to be noreturn) in preloader.
by Jinoh Kang (＠iamahuman) 02 Sep '23

02 Sep '23

GCC expects __stack_chk_fail() to be noreturn[^1]. Returning from __stack_chk_fail() can thus lead to subtle failures. When crashing, use a volatile NULL pointer dereference. Ideally we would like to "abort()" here, but doing so would require two more syscall definitions just for a cold function. After all, the function isn't even used at all if -fno-stack-protector is specified. Also, don't say "stack smashing" (unlike glibc). The preloader currently initializes the stack canary value to a fixed value (0), which serves little value in protecting against actual buffer overrun attacks. [^1]: https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gccint/Stack-Smashing-Protection.h… -- v2: loader: Don't return from __stack_chk_fail() stub in preloader. https://gitlab.winehq.org/wine/wine/-/merge_requests/3708

2 1

[PATCH 0/1] MR3708: loader: Don't return from __stack_chk_fail() stub (which GCC expects to be noreturn) in preloader.
by Jinoh Kang (＠iamahuman) 02 Sep '23

02 Sep '23

GCC expects __stack_chk_fail() to be noreturn[^1]. Returning from __stack_chk_fail() can thus lead to subtle failures. When crashing, use a volatile NULL pointer dereference. Ideally we would like to "abort()" here, but doing so would require two more syscall definitions just for a cold function. After all, the function isn't even used at all if -fno-stack-protector is specified. Also, don't say "stack smashing" (unlike glibc). The preloader currently initializes the stack canary value to a fixed value (0), which serves little value in protecting against actual buffer overrun attacks. [^1]: https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gccint/Stack-Smashing-Protection.h… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3708

2 1

[PATCH 0/1] MR3706: loader: Fix address move for TLS initialization in Linux x86-64 preloader.
by Jinoh Kang (＠iamahuman) 02 Sep '23

02 Sep '23

Fixes: ac1761d1dae8bf114a05e28ed6886deba6c2c860 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55508 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3706

2 1

[PATCH v4 0/6] MR306: vkd3d-shader: Fix UAV coherence.
by Conor McCarthy (＠cmccarthy) 02 Sep '23

02 Sep '23

-- v4: vkd3d-shader/spirv: Handle thread group UAV barriers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/306

3 8

[PATCH v2 0/6] MR3643: windows.applicationmodel: Add stub DLL and packaged application execution tests.
by Rémi Bernon (＠rbernon) 01 Sep '23

01 Sep '23

This can then be used to run tests in an appx context, for instance for https://gitlab.winehq.org/wine/wine/-/merge_requests/3548 -- v2: windows.applicationmodel/tests: Test executing a WinRT package application. windows.applicationmodel/tests: Test IPackageManager_RegisterPackageAsync. makedep: Support generating .exe TESTDLL resources. makedep: Use #pragma makedep testdll for TESTDLL resources. windows.applicationmodel/tests: Add some IPackageManager tests. windows.applicationmodel: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3643

4 8

[PATCH v3 0/1] MR321: vkd3d-shader/hlsl: Implement intrinsic tan.
by Petrichor Park (＠petrathekat) 01 Sep '23

01 Sep '23

Now that we can write HLSL intrinsics in HLSL, cleaning up missing functions becomes much easier. This commit also extends the trigonometry tests a little bit to make sure that tan works right. -- v3: vkd3d-shader/hlsl: Implement intrinsic tan. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/321

4 7

[PATCH 0/2] MR323: vkd3d-shader: Fix descriptor scan regressions.
by Conor McCarthy (＠cmccarthy) 01 Sep '23

01 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/323

4 4

[PATCH 0/1] MR3125: include: Use visibility hidden attribute on w64-mingw32-clang.
by Alex Henrie (＠alexhenrie) 01 Sep '23

01 Sep '23

w64-mingw32-gcc does not support it, but w64-mingw32-clang does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3125

4 4

Re: [PATCH v2 0/1] MR3702: wldp: add WldpGetLockdownPolicy stub - approved
by Alexandre Julliard (＠julliard) 01 Sep '23

01 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3702

1 0

Re: [PATCH v2 0/1] MR3693: msvcrt: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 01 Sep '23

01 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3693

1 0

2025

2024

2023

2022

wine-gitlab September 2023