On Fri Sep 22 06:40:36 2023 +0000, eric pouech wrote:
> (my question was unclear: I meant does native throw this exception?)
> what does native do if the exception is continued? (I doubt this helper
> can be DECLSPEC_NOTRETURN)
You're right, I checked again and this exception is captured and gracefully fails with the last error code set to 0xE0000001. So, I will remove this and just set the last error 0xE0000001 with a failing return value. I'll add some tests for this case.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46356
On Fri Sep 22 06:50:36 2023 +0000, eric pouech wrote:
> this raises the questions does native ntdll.RtlImageHeader check for
> e_lfanew being within image boundary? if so, it builtin implementation
> has to be fixed (with test case please)
> and if it doesn't you can still add the check on RtlImageHeader's
> returned value
The native RtlImageHeader does not have boundary checks. I cannot do this check on RtlImageHeader's return value safely since that would be after RtlImageHeader has already potentially accessed an invalid address.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46353