September 2023 - wine-gitlab

[PATCH v22 0/8] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v22: mspatcha: Use string comparison for section names mspatcha: Use unaligned typedefs mspatcha: Relocate PE/COFF image functions mspatcha: Add support for 32-bit file image patch transforms mspatcha: Add implementations for GetFilePatchSignature* routines mspatcha: Add support for 32-bit file normalizing https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 9

[PATCH v4 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 21 Sep '23

21 Sep '23

This goes on top of MR 320 and 345. -- v4: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 12

[PATCH v21 0/17] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v21: mspatcha: Remove useless unused parameter annotation mspatcha: Fix check for if patch was necessary mspatcha: Fix normalize_old_file_image result if no old file is supplied mspatcha: Use string comparison for section names mspatcha: Use unaligned typedefs mspatcha: Remove useless result variable in NormalizeFileForPatchSignature mspatcha: Relocate PE/COFF image functions mspatcha: Cleanup normalize_old_file_image return logic mspatcha: Fix new file buffer local variable assignment mspatcha: Fix relocation block enumeration mspatcha: Fix progress callback behaviour mspatcha: Fix binary to hex string conversions for GetFilePatchSignatureByBuffer mspatcha: Add support for 32-bit file image patch transforms mspatcha: Add implementations for GetFilePatchSignature* routines mspatcha: Add support for 32-bit file normalizing mspatcha/tests: Add additional unit tests for ApplyPatchToFileByBuffers mspatcha/tests: Add unit tests for NormalizeFileForPatchSignature and GetFilePatchSignature* This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

1 0

[PATCH v20 0/17] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v20: mspatcha: Remove useless unused parameter annotation This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

1 8

[PATCH v3 0/14] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 21 Sep '23

21 Sep '23

This goes on top of MR 320 and 345. -- v3: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. vkd3d-shader/dxil: Do not compile compute shaders. vkd3d-shader/dxil: Do not access null code blocks on failure. vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader inputs. vkd3d-shader/dxbc: Load input signatures also from ISG1 chunks. vkd3d-shader/spirv: Build undefined values once. vkd3d-shader/spirv: Introduce a Static Single Assignment register type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 14

Re: [PATCH v19 0/17] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

On Thu Sep 21 05:34:32 2023 +0000, Zebediah Figura wrote: > I assume you mean -Wunused-parameter, since -Wunused-variable alone > shouldn't warn on parameters. > I don't think -Wunused-parameter is reasonable to enable for Wine. The > Windows API has far, far too many unused parameters for annotating them > all to be worthwhile. Yes, sorry you are correct, I meant `-Wunused-parameter`. I'll just remove this line then -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46134

1 0

Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 21 Sep '23

21 Sep '23

On Thu Sep 21 05:19:42 2023 +0000, Jeffrey Smith wrote: > At each commit along the patch set, all tests need to run clean. > Anything that fails on Wine should be marked as such with `todo_wine` or > `todo_wine_if` as appropriate. > So you would start with commit(s) adding tests, generally including > (marked) failing tests. Then any commit that changes/fixes a test > result should adjust/remove the todo markers in the same commit. Ah okay, that would have been great to know before I removed all the todo's lol. This is going to be a mess to cleanup, got any tips? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46133

1 0

[PATCH v2 0/14] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 21 Sep '23

21 Sep '23

This goes on top of MR 320 and 345. -- v2: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 14

Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Jeffrey Smith (＠whydoubt) 21 Sep '23

21 Sep '23

At each commit along the patch set, all tests need to run clean. Anything that fails on Wine should be marked as such with `todo_wine` or `todo_wine_if` as appropriate. So you would start with commit(s) adding tests, generally including failing tests. Then any commit that changes/fixes a test result should adjust/remove the todo markers in the same commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46130

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Dallas Strouse (＠orowith2os) 21 Sep '23

21 Sep '23

> I.e. server side decorations can be used as a primary option and if it's not available, Wine can fall back to libdecor. That is how it's intended to be used, yes, but it is a workaround for applications or libraries that can't provide suitable window decorations themselves. The idea that it's a workaround for GNOME isn't wrong, but it isn't right either. There are plenty of reasons why window decorations might not be supported, be it because the compositor needs to be as fast as possible, or it's just not technically possible. I'm purely proposing libdecor here so that the experience on GNOME, Weston, and whatever desktops result from this migration and don't have xdg-decoration are able to integrate more "nicely", being subjective. Again, I'm fine with it not having libdecor. In fact, using a library like that might even pose some technical challenges with things like web browsers running in Wine, which like to embed window decorations *in* their window, like libadwaita likes to do. The performance hit with libdecor is more theoretical than anything, and would need to be confirmed before using it as a fact. It might even be fixable with some consultation with GTK folks on how to work with subsurfaces in a GTK context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46127

1 0

2025

2024

2023

2022

wine-gitlab September 2023