September 2023 - wine-gitlab

[PATCH v6 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 18 Sep '23

18 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v6: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

2 4

[PATCH v5 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 18 Sep '23

18 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v5: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

5 9

[PATCH v27 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v27: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

4 6

[PATCH v5 0/2] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v5: gdiplus/tests: add tests of InterpolationMode Bilinear for GdipDrawImagePointsRect gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 6

[PATCH v3 0/4] MR3836: Added definitions and initial tests for FileRenameInformationEx and FileLinkInformationEx
by Joel Holdsworth (＠jhol) 18 Sep '23

18 Sep '23

This patch-set adds the definitions and struct modifications required to eventually implement `FileRenameInformationEx` and `FileLinkInformationEx`. The initial tests are copies of the tests for `FileRenameInformation` and `FileLinkInformation`, but with the `ReplaceIfExists` field replaced with the equivalient `Flag` value: `FILE_RENAME_REPLACE_IF_EXISTS` or `FILE_LINK_REPLACE_IF_EXISTS` respectively. -- v3: ntdll/tests: Test both FileLinkInformation and FileLinkInformationEx in test_file_link_information. include: Add flags to FILE_LINK_INFORMATION used by FileLinkInformationEx. ntdll/tests: Test both FileRenameInformation and FileRenameInformationEx in test_file_rename_information. https://gitlab.winehq.org/wine/wine/-/merge_requests/3836

4 7

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Jeffrey Smith (＠whydoubt) 18 Sep '23

18 Sep '23

On Mon Sep 18 17:52:49 2023 +0000, Zebediah Figura wrote: > Why are we adding one here? That doesn't look right. I think I see what the intent is, but it is unnecessarily 'clever'. It would be clearer to use something like a `BOOL modified`, and ultimately `return modified ? NORMALIZE_RESULT_SUCCESS_MODIFIED : NORMALIZE_RESULT_SUCCESS;` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45774

1 0

[PATCH v3 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 18 Sep '23

18 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v3: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

3 6

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pecoff.h: > +ULONG image_rva_to_file_offset( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, ULONG rva, PUCHAR image_base, ULONG image_size); > + > +ULONG image_directory_rva_and_size( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_header, USHORT directory_entry, ULONG *directory_size, > + PUCHAR image_base, ULONG image_size); > + > +ULONG image_directory_offset_and_size( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_header, USHORT directory_entry, ULONG *directory_size, > + PUCHAR image_base, ULONG image_size); > + > +PVOID image_rva_to_mapped_address( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, ULONG rva, PVOID image_base, ULONG image_size); > + > +PVOID image_directory_mapped_address( > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers, USHORT directory_entry, ULONG *directory_size, I don't think we need another C or header file for these. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45765

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + } > + } > + > + for (i = 0; i < retain_range_count; ++i) { > + if (retain_range_array[i].OffsetInOldFile <= old_file_size > + && (retain_range_array[i].OffsetInOldFile + retain_range_array[i].LengthInBytes) <= old_file_size) > + { > + memset(&old_file_buffer[retain_range_array[i].OffsetInOldFile], > + 0, > + retain_range_array[i].LengthInBytes); > + result = NORMALIZE_RESULT_SUCCESS; > + } > + } > + } > + > + return result + 1; Why are we adding one here? That doesn't look right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45764

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + BYTE *old_file_buffer, ULONG old_file_size, > + ULONG option_flags, PATCH_OPTION_DATA *option_data, > + ULONG new_image_base, ULONG new_image_time, > + const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count, > + const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count) > +{ > + int result = 0; > + ULONG i; > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers; > + > + UNREFERENCED_PARAMETER(option_data); > + > + TRACE("normalizing image at 0x%p with options 0x%lX, new base 0x%lX, new time %lu", > + old_file_buffer, option_flags, new_image_base, new_image_time); > + > + if (old_file_buffer && old_file_size) Early return would save you a level of indentation here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45763

1 0

2025

2024

2023

2022

wine-gitlab September 2023