Now that we can write HLSL intrinsics in HLSL, cleaning up missing
functions becomes much easier.
This commit also extends the trigonometry tests a little bit to make
sure that tan works right.
--
v5: vkd3d-shader/hlsl: Implement intrinsic tan.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/321
> Without codec_data set, mp4mux element fails. And according to my test, setting codec_data to MF_MT_MPEG_SEQUENCE_HEADER is OK, becuase I finally successfully generate a mp4 file which is able to be played by video player.
Yeah, but mp4mux also requires stream-format=avc(3). That's not a coincidence; besides the difference in start codes I mentioned in 3810, the Annex B and AVC formats differ in whether the "codec data" is contained in-band or out-of-band (Annex B has it in-band; AVC has it out-of-band). If you use h264parse to convert Annex B to AVC, it should also supply the correct codec data.
I can't explain why the file gets played back correctly in that case—perhaps GStreamer (or whatever player you're using) detects that the data is actually in the Annex B format and plays it back as such, ignoring the incorrect out-of-band codec data?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45360
...actually, it seems that there are at least two bugs nearby. That segfault hits if IVMRSurfaceAllocatorNotify9_SetD3DDevice fails - but if it succeeds (it does on w1121H2_newtb-w11pro64-amd-64 and w1121H2_newtb-w11pro64-nv-64), native Quartz does something different from what I implemented.
Unfortunately, trying to run that test on my w10 VM returns
vmr9.c:2788: Tests skipped: Direct3D does not support video rendering.
vmr9.c:3229: Tests skipped: Direct3D does not support video rendering.
vmr9.c:4042: Tests skipped: Got E_FAIL when setting allocator properties.
vmr9.c:4365: Tests skipped: Direct3D does not support video rendering.
0a60:vmr9: 2944 tests executed (0 marked as todo, 0 as flaky, 0 failures), 4 skipped.
and I'd rather not try to fix that thing via guesswork against your CI system, that's a waste of resources.
Some of my test programs can run VMR9 just fine in that VM, so I guess I'll rewrite that test from scratch and see if I can create a more reliable test...
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3792#note_45346