January 2024 - wine-gitlab

Re: [PATCH v2 0/2] MR4811: ntdll: Avoid hanging when a thread is terminated while holding a pthread mutex.
by Jinoh Kang (＠iamahuman) 09 Jan '24

09 Jan '24

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/server.c: > * > * Read data from the reply buffer; helper for wait_reply. > */ > -static void read_reply_data( void *buffer, size_t size ) > +static unsigned int read_reply_data( void *buffer, size_t size ) `read_reply_data` can now return failure. Shall we update its only caller, `wait_reply`, to handle it? The abandoned thread, detached from the server, is no longer forcibly aborted and thus let loose to do whatever it wants as long as it doesn't involve a server call, and in case of abnormally terminated server, a SIGQUIT might not have even arrived. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4811#note_56996

1 0

[PATCH v6 0/1] MR4809: Draft: wip! winewayland.drv: Try to support smooth scroll events
by Ray Strode (＠halfline) 09 Jan '24

09 Jan '24

Wayland has 3 types of scrolling events: - axis. Used for e.g., touchpad 2 finger smooth scrolling - axis_discrete. Used for mouse scroll wheels (i.e., notches) - axis_value120. Used for high resolution input devices Wine currently only supports axis_discrete, meaning that 2 finger scroll events get ignored. This commit tries to add basic support for axis scrolling events, by translating the smooth motion in scroll increments using some primitive assumptions about line height and number of lines to scroll. -- v6: wip! winewayland.drv: Try to support smooth scroll events https://gitlab.winehq.org/wine/wine/-/merge_requests/4809

4 4

[PATCH v8 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) 09 Jan '24

09 Jan '24

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v8: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

4 5

[PATCH v3 0/4] MR537: vkd3d-shader/ir: Expand index range write masks to cover all element masks.
by Conor McCarthy (＠cmccarthy) 09 Jan '24

09 Jan '24

-- v3: vkd3d-shader/tpf: Validate sysvals in index range declarations. vkd3d-shader/ir: Trim non-arrayable sysvals from the last element of an index range. tests: Test punned array access in patch constant functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/537

2 7

[PATCH v5 0/1] MR4809: Draft: wip! winewayland.drv: Try to support smooth scroll events
by Ray Strode (＠halfline) 09 Jan '24

09 Jan '24

Wayland has 3 types of scrolling events: - axis. Used for e.g., touchpad 2 finger smooth scrolling - axis_discrete. Used for mouse scroll wheels (i.e., notches) - axis_value120. Used for high resolution input devices Wine currently only supports axis_discrete, meaning that 2 finger scroll events get ignored. This commit tries to add basic support for axis scrolling events, by translating the smooth motion in scroll increments using some primitive assumptions about line height and number of lines to scroll. -- v5: wip! winewayland.drv: Try to support smooth scroll events https://gitlab.winehq.org/wine/wine/-/merge_requests/4809

3 3

[PATCH v4 0/1] MR4809: Draft: wip! winewayland.drv: Try to support smooth scroll events
by Ray Strode (＠halfline) 09 Jan '24

09 Jan '24

Wayland has 3 types of scrolling events: - axis. Used for e.g., touchpad 2 finger smooth scrolling - axis_discrete. Used for mouse scroll wheels (i.e., notches) - axis_value120. Used for high resolution input devices Wine currently only supports axis_discrete, meaning that 2 finger scroll events get ignored. This commit tries to add basic support for axis scrolling events, by translating the smooth motion in scroll increments using some primitive assumptions about line height and number of lines to scroll. -- v4: wip! winewayland.drv: Try to support smooth scroll events https://gitlab.winehq.org/wine/wine/-/merge_requests/4809

3 2

[PATCH 0/1] MR4812: user32: Fix the number of characters processed by DrawTextExW.
by 江仪陈 (＠meshine) 09 Jan '24

09 Jan '24

Description: When flags does not include DT_CALCRECT, since len is calculated in the middle, it will be reduced to zero. Resulting in the length of the processed string that is finally returned to zero and the non-processing string length is unchanged. But some application taking the non-processing string length to zero as the loop end condition. Log: Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: Icc0f250f5f4faba1bee8326fc911a4fc9cd7c012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4812

2 1

[PATCH 0/2] MR4811: ntdll: Avoid hanging when a thread is terminated while holding a pthread mutex.
by Zebediah Figura (＠zfigura) 09 Jan '24

09 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4811

2 3

[PATCH 0/1] MR4797: dmsynth: Leave critical section when out of memory (Coverity)
by Fabian Maurer (＠DarkShadow44) 08 Jan '24

08 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4797

3 3

[PATCH v7 0/5] MR463: hlsl: Fix some type handling for ternaries.
by Zebediah Figura (＠zfigura) 08 Jan '24

08 Jan '24

-- v7: vkd3d-shader/hlsl: Allow non-numeric types in the ternary operator. vkd3d-shader/hlsl: Separate an add_ternary() helper. tests: Add many more tests for ternary expressions. vkd3d-shader/hlsl: Do not try to lower ternaries of types other than scalar or vector. vkd3d-shader/hlsl: Remove a redundant definition of the "float" type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/463

2 6

2025

2024

2023

2022

wine-gitlab January 2024