January 2024 - wine-gitlab

[PATCH 0/6] MR606: Constant buffer reflection
by Zebediah Figura (＠zfigura) 28 Mar '24

28 Mar '24

This is an attempt to invent a vkd3d-shader interface, and begin to implement the relevant parts of ID3D12ShaderReflection in vkd3d-utils. This series is missing most Doxygen documentation, mostly because I feel very uncertain about this interface and don't want to put in the significant effort to write documentation until I'm sure it's settled. This series also has tests for bindings but not the implementation, mainly because I didn't want to bother splitting those tests out to a separate patch right now, and I see no harm in having them already there and marked todo... Here is a long list of already open questions: * As always, should anything be named differently? * In particular, I've decided to give the variables names that make it clear this is d3d-specific code. I think trying to make this generic enough to work for other shader types is a fool's errand. * Should we even try to use this interface for sm1? It's mostly already a subset of dxbc; the only addition is the constant register set... * Should we bother with interfaces? These count as "constant buffers", they have a distinct type, and they have some extra data that we'd need to account for. * Should we bother with lib_* targets? This mostly means allowing for a single shader to hold multiple sets of reflection data. Note that this would also affect descriptor info and STAT info, although not signature info. * I've tried to pass through most data directly, partly out of a concern that that's what d3dcompiler probably does, and so trying to interpret it could break an extremely hypothetical and unlikely application. More saliently, converting to a more sensible representation just to convert back is extra work that I'm not really sure I see a point for. But if we want to change the interface regardless, here are some ideas: - enum vkd3d_shader_d3d_buffer_type could just be more flags. - I think a buffer's size is redundant and can be calculated from its contained variables. Same for field offsets (unless packoffset affects this?) - "constant_register" could be flags too? But we already have a type for them, so I don't think that's better. - The kind/type interface is weird in several ways. Majority could be a type or var flag; objects could be classes... * Fields of struct vkd3d_shader_d3d_type could be 16-bit (like they are in the RDEF section). The main reason I didn't do this is because we can't force a 16-bit enum, although we could define the field as uint16_t. But we could also just define the other "count" fields as 16-bit. * I suspect I already know the answer to this one, but... If this is all going to be d3d specific anyway... do we really care about having this in vkd3d-shader? Or, alternatively, we could provide an interface that's friendlier than COM, but still use the d3d struct types instead of copy-pasting and changing all the names to vkd3d-shader (which is a bit exhausting, honestly—not just because of rewriting but because of documentation. The latter is certainly a self-created problem, but so is the former.) * vkd3d_shader_d3d_field currently has a hole in it on LP64; is that a problem? (I think it's the only structure with a hole in it.) * As long as this is a d3d interface, should we go ahead and make it "scan_d3d_info" and add all the d3d-specific STAT block stuff? One extra anticipatory note on how this differs from Wine's implementation: This implementation does *not* store types in an rbtree, nor deduplicate them. The main reason for this is that native doesn't deduplicate types (I have tests for this, later in my local branch) and it avoids what seems like a significant complication to the vkd3d-shader interface. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/606

6 37

[PATCH v2 0/4] MR2000: ws2_32/tests: Try to disable firewall before testing with any addr.
by Jinoh Kang (＠iamahuman) 20 Mar '24

20 Mar '24

test_reuseaddr and test_exclusiveaddruse bind to the wildcard address (0.0.0.0 or [::]). This may trigger a firewall alert on Windows 7, and the alert UI window may interfere with user32:msg tests. Fix this by trying to disable the firewall, and skipping the wildcard address tests if it fails. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53891 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54202 -- v2: ws2_32/tests: Try to disable firewall before testing with any addr. ws2_32/tests: Factor out test_exclusiveaddruse from test_reuseaddr. ws2_32/tests: Do ANY address tests in a separate loop in test_reuseaddr. webservices/tests: Move firewall code to a common header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2000

5 8

[PATCH v3 0/5] MR4656: quartz: Implement VMR7 renderless mode.
by Zebediah Figura (＠zfigura) 19 Mar '24

19 Mar '24

This isn't all of what Rewrite needs, but it's the large and risky part that would be inappropriate for code freeze. -- v3: quartz/tests: Add some tests for VMR7 renderless mode. quartz: Return S_OK from IVMRSurfaceAllocator_PrepareSurface(). quartz: Implement IVMRSurfaceAllocatorNotify::AdviseSurfaceAllocator(). quartz: Reimplement the VMR7 using the VMR7 presenter. https://gitlab.winehq.org/wine/wine/-/merge_requests/4656

2 7

[PATCH 0/5] MR2615: d3dx10: Forward some functions from d3dx11 and sync tests.
by Zebediah Figura (＠zfigura) 19 Mar '24

19 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2615

4 11

[PATCH 0/1] MR1269: wined3d: Disable CSMT when running on a single core.
by Anton Baskanov (＠baskanov) 17 Mar '24

17 Mar '24

- Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45893 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47767 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44546 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1269

6 11

[PATCH 0/1] MR1228: wined3d: support direct3d shader model 1,2,3
by Fan WenJie (＠fanwenjie) 16 Mar '24

16 Mar '24

vkd3d_shader_compile_info::source_type can not hard write to VKD3D_SHADER_SOURCE_DXBC_TPF, it is decided by magic number of shader source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1228

4 5

[PATCH 0/1] MR1981: shell32: Handle NULL sPathTarget in all places before copying it.
by Gabriel Ivăncescu (＠insn) 13 Mar '24

13 Mar '24

This can crash if you parse, for example, "/" with the desktop IShellFolder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1981

2 3

[PATCH 0/1] MR667: win32u: Ignore SetWindowPos() if it is trying to change topmost state for child window.
by Paul Gofman (＠gofman) 03 Mar '24

03 Mar '24

I think the behaviour of SetWindowPos() in this case is partially explained by the fact that topmost state is not strictly applicable to child windows and so Windows denies such requests. Child window can still end up with WS_EX_TOPMOST style if it was set at window creation (doesn't work this way in Wine now) or, e. g., like in the test added in the patch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=20190 Also fixes game load dialog in Indiana Jones and the Infernal Machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/667

6 6

[PATCH v3 0/9] MR4533: winex11: Detach / attach vulkan window surfaces as needed.
by Rémi Bernon (＠rbernon) 29 Feb '24

29 Feb '24

This is some preparatory work for vulkan child window and other features which currently live in Proton. I think this could be upstream already, and it will make rebasing patches on top of it simpler. To get vulkan child window upstream we'd probably still need to rework it a bit and maybe try to move the wait and blit to `vkQueuePresent` somehow. The idea here is also that although Vulkan spec does not allow multiple active swapchains for the same window, Windows tends to allow it especially with D3D, and we also need to support the case where multiple APIs are use to draw onto the same window surface (as we implement D3D on top of GL/Vk for instance). -- v3: winex11: Rename X11DRV_FLUSH_GL_DRAWABLE to X11DRV_PRESENT_DRAWABLE. winex11: Put detached client windows surfaces offscreen. winex11: Re-attach vulkan surfaces when images are acquired. winevulkan: Add vkAcquireNextImage(2)KHR driver entries. winex11: Resize detached vulkan surfaces when window is resized. winex11: Detach the vulkan surfaces when their HWND is destroyed. winex11: Detach vulkan client windows before destroying them. winex11: Introduce a new detach_client_window helper. winex11: Add traces to vulkan surface grab / release. https://gitlab.winehq.org/wine/wine/-/merge_requests/4533

3 34

[PATCH v4 0/1] MR2274: ntdll: Add source file and line to debug traces.
by Rémi Bernon (＠rbernon) 29 Feb '24

29 Feb '24

-- v4: ntdll: Add source and return address information to debug traces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2274

2 3

2025

2024

2023

2022

wine-gitlab January 2024