January 2024 - wine-gitlab

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 23 Jan '24

23 Jan '24

On Tue Jan 23 16:39:13 2024 +0000, Esme Povirk wrote: > Now that I'm looking closer, I'm even more confused. As far as I can > tell from the tests, the parameter size of RedEyeCorrectionEffect should > always be sizeof(RedEyeCorrectionEffect). So, why does > GdipGetEffectParameterSize return something different? > And if a different size is allowed to be passed in, there should be > tests for it. I have tested it, it always includes the size of the numareas. I have tested it, it throws InvalidParameter errors. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58668

1 0

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) 23 Jan '24

23 Jan '24

On Tue Jan 23 16:34:02 2024 +0000, Esme Povirk wrote: > I don't see anything changed that would address this. Now that I'm looking closer, I'm even more confused. As far as I can tell from the tests, the parameter size of RedEyeCorrectionEffect should always be sizeof(RedEyeCorrectionEffect). So, why does GdipGetEffectParameterSize return something different? And if a different size is allowed to be passed in, there should be tests for it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58667

1 0

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) 23 Jan '24

23 Jan '24

On Mon Jan 22 20:37:06 2024 +0000, Vijay Kiran Kamuju wrote: > I have changed the structure of the CGpEffect and with it some > functionality. Please re-check. I don't see anything changed that would address this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58666

1 0

[PATCH 0/1] MR592: vkd3d-shader/spirv: Emit DISCARD as a function call.
by Conor McCarthy (＠cmccarthy) 23 Jan '24

23 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/592

4 3

[PATCH v2 0/3] MR591: vkd3d-shader/dxil: Do not use ascii_strcasecmp().
by Conor McCarthy (＠cmccarthy) 23 Jan '24

23 Jan '24

-- v2: vkd3d-shader/dxil: Use strcmp() to find the handle type. vkd3d-shader/dxil: Use strcmp() to find function names. vkd3d-shader/dxil: Use strcmp() to check the entry point name. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/591

3 4

[PATCH v3 0/5] MR577: hlsl: Improve condition type validation.
by Zebediah Figura (＠zfigura) 23 Jan '24

23 Jan '24

-- v3: tests: Add tests for valid conditional types. vkd3d-shader/hlsl: Always cast to bool in if() statements. vkd3d-shader/hlsl: Validate that condition expressions are numeric. vkd3d-shader/hlsl: Validate the condition data type for loops as well. vkd3d-shader/hlsl: Copy some missing fields in hlsl_type_clone(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/577

4 9

[PATCH v3 0/3] MR574: vkd3d-shader/ir: Refactor VSIR passes.
by Giovanni Mascellani (＠giomasce) 23 Jan '24

23 Jan '24

-- v3: vkd3d-shader/ir: Remove DCL_TEMPS instructions. vkd3d-shader/ir: Run tracing and validation for DXIL code too. vkd3d-shader/ir: Refactor return code checking in vkd3d_shader_normalise(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/574

4 4

[PATCH v5 0/2] MR572: vkd3d-shader/dxil: Implement DX intrinsic Binary.
by Conor McCarthy (＠cmccarthy) 23 Jan '24

23 Jan '24

-- v5: vkd3d-shader/dxil: Implement DX intrinsic Binary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/572

3 3

[PATCH v4 0/8] MR565: vkd3d-shader/hlsl: Add passes variables to the techniques.
by Nikolay Sivov (＠nsivov) 23 Jan '24

23 Jan '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader/fx: Add initial support for writing passes for fx_2_0. vkd3d-shader/fx: Add initial support for writing fx_2_0 binaries. vkd3d-shader/fx: Check technique type in global scope as well. vkd3d-shader/hlsl: Allow annotations on techniques. vkd3d-shader/hlsl: Allow annotations on passes. vkd3d-shader/hlsl: Add passes variables to the techniques. vkd3d-shader/hlsl: Add initial support for parsing annotations. tests/hlsl: Add some tests for annotations. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/565

4 10

[PATCH v9 0/4] MR559: vkd3d-shader/ir: Validate block-based CF, part 2.
by Giovanni Mascellani (＠giomasce) 23 Jan '24

23 Jan '24

~~Other validation stuff I plan to send as soon as !450 and !550 are in.~~ ~~I guess the CI is going to timeout because of too many commits, so I'll preemptively stop it.~~ -- v9: vkd3d-shader/ir: Validate PHI instructions. vkd3d-shader/ir: Do not allow IMMCONST and IMMCONST64 as destination registers. vkd3d-shader/ir: Refactor register-type-specific code in parameter validation. vkd3d-shader/ir: Check that all instructions appear in a block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/559

3 5

2025

2024

2023

2022

wine-gitlab January 2024