January 2024 - wine-gitlab

[PATCH 0/1] MR4861: win32u: Preserve rawinput device instance ID case in add_device().
by Nicholas Tay (＠ntay) 17 Jan '24

17 Jan '24

In ntoskrnl.exe, when a PnP device interface is registered, the interface path casing is retained, with only the hardware ID being upper case. Thus, this patch looks to align the behaviour between PnP and rawinput, particularly for games that seem to rely on these two strings being consistent for hotplug. This updated behaviour also seems consistent with Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4861

2 1

[PATCH 0/1] MR4860: ntdll: Add NtCompareTokens() stub.
by Dmitry Timoshkov (＠dmitry) 17 Jan '24

17 Jan '24

SQL Native Client ODBC driver fails to load if GetProcAddress("NtCompareTokens") returns NULL, however it never calls it. Important: Run 'tools/make_specfiles' after applying the patch to update the syscalls list. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4860

4 3

[PATCH v4 0/9] MR564: Draft: vkd3d-shader/ir: Transform clip/cull signature elements into an array.
by Conor McCarthy (＠cmccarthy) 17 Jan '24

17 Jan '24

Goes atop !537. -- v4: tests/d3d12: Test multiple clip distance inputs in test_clip_distance(). tests/d3d12: Use 5 clip distances for the multiple test in test_clip_distance(). vkd3d-shader/ir: Transform clip/cull outputs and patch constants into arrays. vkd3d-shader/ir: Transform clip/cull inputs into an array. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564

2 9

[PATCH 0/5] MR4859: win32u: Move ImeToAsciiEx implementation from winex11.
by Rémi Bernon (＠rbernon) 17 Jan '24

17 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4859

3 6

[PATCH v3 0/9] MR564: Draft: vkd3d-shader/ir: Transform clip/cull signature elements into an array.
by Conor McCarthy (＠cmccarthy) 17 Jan '24

17 Jan '24

Goes atop !537. -- v3: tests/d3d12: Test multiple clip distance inputs in test_clip_distance(). tests/d3d12: Use 5 clip distances for the multiple test in test_clip_distance(). vkd3d-shader/ir: Transform clip/cull outputs and patch constants into arrays. vkd3d-shader/ir: Transform clip/cull inputs into an array. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564

2 9

[PATCH 0/2] MR4775: win32u: Change foreground in SetFocus when desktop window is foreground.
by Rémi Bernon (＠rbernon) 17 Jan '24

17 Jan '24

We should probably change the foreground window even if a different window is already foreground, tracking the last user input time for instance, but this would be a much larger impacting change. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56073 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4775

3 5

[PATCH 0/1] MR4854: ntdll: Reimplement set_native_thread_name() for macOS
by Marc-Aurel Zent (＠mzent) 17 Jan '24

17 Jan '24

This reworks `set_native_thread_name()` for macOS to not rely on mach thread ports returned server side (which were potentially colliding cross-process anyways) and re-implements what `pthread_setname_np()` would do on wines side, with additionally allowing setting threadnames cross-process. On the kernel side `bsd_setthreadname()` is apparently "known to race with regards to the contents of the thread name", so that is only exposed for the thread calling it on itself. Since the pthread struct is private, the location of the thread name is determined at runtime (although in practice, it is constant (80 bytes) from at least 10.15 up to 14.0). This has an effect on both `pthread_getname_np()` and the `NSThread` implementation on top a native library would use. Cross-thread naming is only not visible to external debuggers, which have acquired a mach port right and calling `thread_info()` with `THREAD_EXTENDED_INFO` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4854

3 2

[PATCH v2 0/4] MR4711: Fix Toad for Oracle F3 find next function not working properly
by Zhiyi Zhang (＠zhiyi) 17 Jan '24

17 Jan '24

Fix Toad for Oracle F3 find next function not working properly because its WH_KEYBOARD hook gets called too many times. There is another case that could cause WH_CBT HCBT_CLICKSKIPPED hooks to get called recursively as the tests show. I will send patches for that after the code freeze. -- v2: user32/tests: Add recursive WM_SETCURSOR message tests. win32u: Avoid calling WH_CBT HCBT_CLICKSKIPPED hooks recursively. https://gitlab.winehq.org/wine/wine/-/merge_requests/4711

3 6

[PATCH v2 0/3] MR4857: gdi32,win32u: Implement D3DKMTEnumAdapters2.
by Krzysztof Bogacki (＠Saancreed) 17 Jan '24

17 Jan '24

An alternative approach to `EnumAdapters2` that does not directly call to GDI driver and therefore does not require GDI driver functions to be expanded. The implementation now lives in `sysparams.c` to make it closer to win32u caches it accesses. It still uses `OpenAdapterFromLuid` internally because that's where adapter handles are actually assigned and to make sure returned handles are usable with other functions that rely on GDI driver being aware of what the handle represents to be able to function correctly (like `QueryVideoMemoryInfo`). See !4791 for some background and why this version might be preferable over the one submitted there. -- v2: win32u: Implement NtGdiDdDDIEnumAdapters2. gdi32,win32u: Add stubs for D3DKMTEnumAdapters2 and NtGdiDdDDIEnumAdapters2. gdi32/tests: Add D3DKMTEnumAdapters2 tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4857

2 3

[PATCH v14 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 16 Jan '24

16 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v14: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

2 2

2025

2024

2023

2022

wine-gitlab January 2024