November 2024 - wine-gitlab

Re: [PATCH v9 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

You can remove `dlls/` from `dlls/wintypes` in the commit message subjects. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86592

1 0

Re: [PATCH v9 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Zhiyi Zhang (＠zhiyi) 05 Nov '24

05 Nov '24

Please keep merge requests small and each commit atomic, ~5 patches or so for an MR would be best. Each MR should ideally have its corresponding tests. That will help with the reviewing. Note that there are CI build failures. You will need to address that as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_86591

1 0

[PATCH v8 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 05 Nov '24

05 Nov '24

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v8: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Chunhao Hung (＠otakuxtom) 05 Nov '24

05 Nov '24

This cause wineserver crash after merged, revert those two commit will fix the crash -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498#note_86577

1 0

[PATCH v2 0/1] MR6481: dplayx: Merge IDirectPlayLobby3A into IDirectPlayLobby3
by Alistair Leslie-Hughes (＠alesliehughes) 05 Nov '24

05 Nov '24

Use the unicode interface by default and return the same value as before this change. There are a few locations, that called W->A. It will return the same value as before for the Ansi version but the unicode one will now report an error. -- v2: dplayx: Merge IDirectPlayLobby3A into IDirectPlayLobby3 https://gitlab.winehq.org/wine/wine/-/merge_requests/6481

3 2

[PATCH 0/1] MR6769: mountmgr.sys: Stub StorageDeviceSeekPenaltyProperty query.
by Paul Gofman (＠gofman) 04 Nov '24

04 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6769

2 2

Re: [PATCH v11 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Joel Holdsworth (＠jhol) 04 Nov '24

04 Nov '24

:tada: :tada: :tada: Big step forward for Msys2 support! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498#note_86567

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 04 Nov '24

04 Nov '24

On Mon Nov 4 18:51:22 2024 +0000, Alanas wrote: > > In your winehq test, 0xffff0000u seems like a special value. > No, you can replace it with `0u` and get same (except addresses) output > but `foo5.exe` runs very slow. handling is simpler if toolbar thinks parent wants unicode notifications `nmhdr->hwndFrom` is not accessed and no overwriting `nmhdr->code` (tested all `nmhdr->code`s): - https://bugs.winehq.org/attachment.cgi?id=77361&action=edit - https://bugs.winehq.org/attachment.cgi?id=77363&action=edit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86566

1 0

[PATCH v32 0/5] MR6621: winebth.sys part 1: Introduce Bluetooth driver.
by Vibhav Pant (＠vibhavp) 04 Nov '24

04 Nov '24

This MR is the first of multiples MRs adding support for the Bluetooth stack API in Wine: 1. The winebth.sys driver, which talks to BlueZ and implements several key IOCTLs for communicating with Bluetooth devices and radios. 2. A bthserv service, which is responsible for keeping track of the authentication agent, and relaying authentication requests and responses to and from the driver. 3. Userspace APIs (bluetoothapis.dll, bthprops.cpl, Windows.Devices.Bluetooth, etc). winebth.sys is split into two "sub" drivers: `winebth.sys`: The main entrypoint, loaded by winedevice. It listens for changes to Bluetooth devices and radios and authentication events on BlueZ, passing them on the bthenum. It also handles most IOCTL operations on Bluetooth radio PDOs. `bthenum`: Responsible for creating nodes for discovered Bluetooth devices and associated services. It also tries to validate any IOCTLs relating to bluetooth devices before passing them to winebth.sys. (Not in this MR, likely in part 2) The unix code is split between dbus.c, unixlib.c and winebluetooth.c, where winebluetooth is a simple wrapper around unixlib for the sake of organization. -- v32: dlls/winebth.sys: Register and enable BTHPORT_DEVICE and BLUETOOTH_RADIO interfaces for radio PDOs. dlls/winebth.sys: Derive a unique hardware ID for radio PDOs from their corresponding BlueZ object path. dlls/winebth.sys: Create radio PDOs from the list of org.bluez.Adapter1 objects on BlueZ. dlls/winebth.sys: Add a basic unixlib stub using DBus. dlls/winebth.sys: Add base winebth.sys driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/6621

2 5

Re: [PATCH v2 0/1] MR6768: ntdll: Do not queue completion for a synchronous file. - approved
by Alexandre Julliard (＠julliard) 04 Nov '24

04 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6768

1 0

2025

2024

2023

2022

wine-gitlab November 2024