December 2024 - wine-gitlab

[PATCH v67 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 03 Feb '25

03 Feb '25

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v67: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

8 20

[PATCH 0/1] MR7028: ntdll: Remove manifest name filtering.
by Dmitry Timoshkov (＠dmitry) 03 Feb '25

03 Feb '25

Componenets installed by winetricks have "deadbeef.manifest" trailer in their manifests, so it's not clear that filtering logic works. On the other hand when manifests for versions 1.2.3.4 and 1.2.3.10 are installed and application exe needs version 1.2.0.0 and later uses LoadLibrary() to load a plugin.dll that needs 1.2.3.7, version 1.2.3.4 gets loaded with an .exe (because manifest for version 1.2.3.10 is ignored) and version 1.2.3.10 gets loaded with a plugin.dll, and this leads to crashes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7028

3 5

[PATCH v6 0/5] MR6889: threadpoolwinrt: Implement IAsyncAction and IAsyncInfo.
by Vibhav Pant (＠vibhavp) 01 Feb '25

01 Feb '25

This MR adds an implementation for the `IAsyncAction` and `IAsyncInfo` interfaces exported by `Windows.System.Threading`, including support for setting `IAsyncActionCompletedHandler` values for an `IAsyncAction`. It also re-writes (or factors?) the `IAsyncOperation<boolean>` implementation in dlls/cryptowinrt to use `ThreadPoolStatics::RunAsync`, by introducing a type-punning variant of `AsyncOperationCompletedHandler<T>` (similar to `WineAsyncOperationCompletedHandler`), which is a wrapper around the `IAsyncAction` returned by `RunAsync`. The new `IAsyncOperation<T>` implementation is simpler, and if merged, can be exported to other dlls (windows.gaming.input and windows.security.credentials.ui.userconsentverifier for now). -- v6: cryptowinrt: Rewrite IAsyncOperation using Windows.System.Threading. https://gitlab.winehq.org/wine/wine/-/merge_requests/6889

3 9

[PATCH v5 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu (＠insn) 31 Jan '25

31 Jan '25

-- v5: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

3 9

[PATCH 0/1] MR7084: inetcpl: Make security zone names and descriptions translatable.
by Alex Henrie (＠alexhenrie) 29 Jan '25

29 Jan '25

Windows ignores the names and descriptions in the registry when populating the Security tab in Internet Options. Do the same in Wine. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27245 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7084

4 6

[PATCH v7 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 29 Jan '25

29 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v7: ntdll: Update NtQueryDirectoryFile to purge cache if scan is reset with a new mask ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

5 19

[PATCH 0/1] MR3109: imm32: Don't export internal variables.
by Alex Henrie (＠alexhenrie) 24 Jan '25

24 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3109

6 22

[PATCH 0/6] MR6849: quartz: Simplify DirectSound Renderer Filter sample handling.
by Rémi Bernon (＠rbernon) 24 Jan '25

24 Jan '25

This has been in Proton for two years at least, it helped reduce buffer underruns and induced cracking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6849

3 9

[PATCH 0/2] MR6679: winetest: Compress embedded test executables.
by Rémi Bernon (＠rbernon) 24 Jan '25

24 Jan '25

Reducing `winetest.exe` size from ~240MB to ~80MB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6679

3 6

[PATCH 0/12] MR5680: win32u: Implement per-monitor DPI scaling for virtual display modes.
by Rémi Bernon (＠rbernon) 24 Jan '25

24 Jan '25

For winewayland display modes emulation, instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/5057. Also this could be a move toward implementing some kind of fshack upstream. (Also includes !5679, I'll rebase it when it is merged). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5680

4 16

2025

2024

2023

2022

wine-gitlab December 2024