Fixes the following warning on clang-15:
```
dlls/ntdll/unix/dwarf.h:915:45: warning: taking the absolute value of unsigned type 'ULONG_PTR' (aka 'unsigned long') has no effect [-Wabsolute-value]
case DW_OP_abs: stack[sp] = labs(stack[sp]); break;
^
dlls/ntdll/unix/dwarf.h:915:45: note: remove the call to 'labs' since unsigned values cannot be negative
case DW_OP_abs: stack[sp] = labs(stack[sp]); break;
^~~~
```
Despite what it says the existing code was functioning correctly already though AFAICT.
--
v2: ntdll: Fix DW_OP_abs absolute value warning on labs() for clang.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5056
There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached.
Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not.
--
v24: dmime: Create a band track for MIDI segments.
dmime/tests: wip test for midi play
dmime: Implement IDirectMusicTrack_Play for MIDI tracks.
dmime: Parse MIDI tracks.
https://gitlab.winehq.org/wine/wine/-/merge_requests/4982
On Thu Feb 8 18:34:03 2024 +0000, Rémi Bernon wrote:
> Yes
since playing midi tracks turned out to be more involved, let's do this piecemeal like you said.
i made this MR just about parsing, is this mergeable?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4982#note_60649
Stream sink such as evr can't be prerolled a second time, and when we are
restarting from a paused state, those stream sink will already be prerolled
so don't preroll them again. Otherwise we will be waiting for Prerolled
events that will never come.
Split from !4545, splitting the fix from the tests because turns out the tests are contentious.
--
v2: mf: Only preroll when starting from stopped state.
https://gitlab.winehq.org/wine/wine/-/merge_requests/4828