February 2024 - wine-gitlab

[PATCH 0/1] MR5019: user32/tests: Fix test_recursive_messages() test failures on win7.
by Zhiyi Zhang (＠zhiyi) 04 Feb '24

04 Feb '24

Windows 7 has a lower maximum depth for recursive hooks. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56293 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5019

3 2

[PATCH 0/1] MR5014: wbemprox: Add property 'Caption' to Win32_PnPEntity.
by Louis Lenders (＠xe) 03 Feb '24

03 Feb '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56291 Note: On windows powershell something like "Get-WmiObject win32_pnpentity -property name" gives exact same results as "Get-WmiObject win32_pnpentity -property caption" so I used same string for caption as for name in the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5014

4 3

[PATCH 0/1] MR5018: user32/tests: Accept EM_GETPASSWORDCHAR when edit is focused.
by Esme Povirk (＠madewokherd) 03 Feb '24

03 Feb '24

Should fix the failures on win22H2_newtb-w1064-tsign-64 that started on Jan 23. It's not clear to me *why* this message started appearing on that machine, but it seems to be very consistent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5018

2 1

[PATCH v4 0/3] MR5016: winevulkan: Update to VK spec version 1.3.277.
by Georg Lehmann (＠DadSchoorse) 03 Feb '24

03 Feb '24

-- v4: winevulkan: Enable VK_ARM_render_pass_striped. winevulkan: Update to VK spec version 1.3.277. winevulkan: Prepare for VK_KHR_calibrated_timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/5016

2 3

[PATCH v3 0/3] MR5016: winevulkan: Update to VK spec version 1.3.277.
by Georg Lehmann (＠DadSchoorse) 03 Feb '24

03 Feb '24

-- v3: winevulkan: Enable VK_ARM_render_pass_striped. winevulkan: Update to VK spec version 1.3.277. winevulkan: Prepare for VK_KHR_calibrated_timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/5016

2 3

[PATCH v2 0/3] MR5016: winevulkan: Update to VK spec version 1.3.277.
by Georg Lehmann (＠DadSchoorse) 03 Feb '24

03 Feb '24

-- v2: winevulkan: Enable VK_ARM_render_pass_striped. winevulkan: Update to VK spec version 1.3.277. winevulkan: Prepare for VK_KHR_calibrated_timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/5016

2 3

[PATCH 0/3] MR5016: winevulkan: Update to VK spec version 1.3.277.
by Georg Lehmann (＠DadSchoorse) 03 Feb '24

03 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5016

2 3

[PATCH 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 03 Feb '24

03 Feb '24

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

2 1

[PATCH 0/6] MR4518: ntdll: Integrate with GDB using systemtap rtld probes.
by Rémi Bernon (＠rbernon) 03 Feb '24

03 Feb '24

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

3 10

[PATCH v2 0/9] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) 03 Feb '24

03 Feb '24

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- v2: shlwapi/tests: Add many more tests for UrlCanonicalize(). kernelbase: Use scheme_is_opaque() in UrlIs(). kernelbase: Reimplement UrlCanonicalize(). kernelbase: Do not canonicalize the relative part in UrlCombine(). shlwapi/tests: Move UrlCombine() error tests out of the loop. shlwapi/tests: Use winetest_push_context() in test_UrlCanonicalizeA(). shlwapi/tests: Remove the unused "wszExpectUrl" variable from check_url_canonicalize(). shlwapi/tests: Move the UrlCanonicalize() tests into test_UrlCanonicalizeA(). urlmon/tests: Add basic tests for CoInternetParseUrl(PARSE_CANONICALIZE). https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

3 10

2025

2024

2023

2022

wine-gitlab February 2024