February 2024 - wine-gitlab

[PATCH 0/1] MR4737: configure: On aarch64 align PE binaries to 64k pages
by Fabian Maurer (＠DarkShadow44) 06 Feb '24

06 Feb '24

It still works using lower page sizes while also allowing page sizes > 4k Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52715 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4737

5 10

[PATCH v5 0/3] MR5016: winevulkan: Update to VK spec version 1.3.277.
by Georg Lehmann (＠DadSchoorse) 06 Feb '24

06 Feb '24

-- v5: winevulkan: Enable VK_ARM_render_pass_striped. winevulkan: Update to VK spec version 1.3.277. winevulkan: Prepare for VK_KHR_calibrated_timestamps. https://gitlab.winehq.org/wine/wine/-/merge_requests/5016

3 5

Re: [PATCH v7 0/3] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 06 Feb '24

06 Feb '24

Any feedback regarding this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3105#note_60351

1 0

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 06 Feb '24

06 Feb '24

Any news on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_60349

1 0

[PATCH v2 0/2] MR5025: explorer: Don't pop start menu on "minimize all windows" systray command.
by Paul Gofman (＠gofman) 06 Feb '24

06 Feb '24

Fixes "True Reporter. Mystery of Mistwood" broken startup from launcher when the launcher wants to minimize all windows (which is probably not strictly necessary) but we instead pop Start menu. -- v2: explorer: Don't pop start menu on "undo minimize all windows" systray command. explorer: Don't pop start menu on "minimize all windows" systray command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5025

4 5

[PATCH v11 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 06 Feb '24

06 Feb '24

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v11: mf/tests: Test IMFMediaSession::Start(). mf: Support seeking while a session is started. mf/tests: Add a create_test_topology() helper. mf: Add a session_flush_nodes() helper. mf: Make session_get_node_object() more robust. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

3 8

[PATCH 0/1] MR5015: d2d1: Compile vertex shaders with D3DCompile().
by Giovanni Mascellani (＠giomasce) 06 Feb '24

06 Feb '24

Unfortunately the pixel shader cannot be compiled yet because `Buffer` is not yet supported. If https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569 is accepted in vkd3d 1.11, next month we'll be able to get rid of the binary pixel shader too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5015

3 2

[PATCH 0/1] MR5023: quartz: Release critical section before IVideoWindow_put_Visible
by CKolle (＠CKolle) 06 Feb '24

06 Feb '24

The IVideoWindow_put_Visible runs the NtUserShowWindow which may trigger the VideoWindow_NotifyOwnerMessage with a WM_PAINT message and afterwards try to send a WM_ERASEBKND. This will cause the VideoWindow_NotifyOwnerMessage to be stuck waiting on the lock. This causes a deadlock because the IVideoWindow_put_Visible is never able to return, as it is waiting for the WM_ERASEBKND message to go through in the send_erase function, which can only go through once the WM_PAINT has returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5023

3 4

[PATCH 0/1] MR5038: dmusic: Fix loading wave data from soundfont.
by Yuxuan Shui (＠yshui) 06 Feb '24

06 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5038

4 3

[PATCH v3 0/3] MR5035: Change SetLastError to RestoreLastError if appropriate
by Alfred Agrell (＠Alcaro) 06 Feb '24

06 Feb '24

Theoretically, this allows debuggers to tell them apart. https://devblogs.microsoft.com/oldnewthing/20110429-00/?p=10803 But in practice, this is more about cleanliness than anything else; I'm not aware of anyone running SetLastError-aware debuggers in Wine. Feel free to reject if this is a waste of time. The changeable SetLastError calls were found by this script: ```python #!/usr/bin/env python3 import os import re for (dirpath, dirnames, filenames) in os.walk("."): for fn in filenames: if not fn.endswith(".c") and not fn.endswith(".h"): continue text = open(dirpath+"/"+fn,"rt").read() text = text.replace("RtlSetLastWin32Error","SetLastError") text = text.replace("RtlGetLastWin32Error","GetLastError") if "SetLastError" not in text: continue varname = None for line in text.split("\n"): if "GetLastError" in line: if m := re.search(r"([A-Za-z0-9_]+) *= *GetLastError", line): prevline = line varname = m[1] if line == "}": varname = None if varname is not None and "SetLastError" in line: if m := re.search(r"SetLastError\( *([A-Za-z0-9_]+) *\)", line): if m[1] == varname: print(dirpath+"/"+fn, prevline, line) ``` The script also flags https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/mpr/wnet.c#L2811, which is half set and half restore; I chose to left it unchanged. Idea from https://gitlab.winehq.org/wine/wine/-/merge_requests/5020/diffs#6c845445f68… -- v3: win32u: Use RtlRestoreLastWin32Error instead of RtlSetLastWin32Error if appropriate everywhere: Change SetLastError to RestoreLastError if appropriate https://gitlab.winehq.org/wine/wine/-/merge_requests/5035

3 5

2025

2024

2023

2022

wine-gitlab February 2024