March 2024 - wine-gitlab

[PATCH 0/8] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 15 Mar '24

15 Mar '24

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

2 8

[PATCH 0/1] MR5315: dbghelp: Fix PDB processing using the FPO stream instead of FPOEXT
by Kyrylo Babikov (＠dank_meme) 15 Mar '24

15 Mar '24

Since wine 9.3 (particularly [this commit](https://gitlab.winehq.org/wine/wine/-/commit/552bc893e17a0e046c2f59…), `pdb_process_internal` mistakenly sets `fpoext_stream` to the FPO stream (`sub_streams[PDB_SIDX_FPO]`) instead of the FPOEXT stream (`sub_streams[PDB_SIDX_FPOEXT]`), causing the PDB file to be improperly processed. This merge request fixes that oversight. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5315

4 3

[PATCH v8 0/7] MR631: Draft: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v8: tests: Trace more info on buffer creation failure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 7

Re: [PATCH v2 0/5] MR5294: mfplat: Implement better VIDEOINFOHEADER2 support.
by Rémi Bernon (＠rbernon) 15 Mar '24

15 Mar '24

On Fri Mar 15 07:55:52 2024 +0000, Rémi Bernon wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5294/diffs?diff_id=105317&start_sha=bda0dbe0b9086716616731c86c81b550162e8811#f44c614b47a01be8d6d29ad07f7a5616e1ae60ec_26_26) Indeed, fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5294#note_64866

1 0

[PATCH 0/1] MR5258: d3d9/tests: Skip desktop window tests if device creation fails.
by Robin Kertels (＠K0bin) 15 Mar '24

15 Mar '24

DXVK fails to create a device for the desktop window which causes the test to crash. Instead of crashing, it should just skip the remaining desktop window tests if device creation fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5258

4 8

[PATCH 0/1] MR5298: wined3d: Do not check the input signature element count for sm4+ shaders in shader_spirv_compile_arguments_init().
by Henri Verbeet (＠hverbeet) 15 Mar '24

15 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5298

5 4

[PATCH 0/3] MR5317: win32u: Fix a possible condition that makes EnumDisplayMonitors() not reporting any monitors.
by Zhiyi Zhang (＠zhiyi) 15 Mar '24

15 Mar '24

When there are two monitors and they are mirrored, both of them are considered primary. When the first primary monitor happens to be a clone, EnumDisplayMonitors() ends up not reporting any monitors because should_enumerate_monitor() returns FALSE and we break out the loop to enumerate primary monitors after that. This is a regression from b59619d and my review comments. My indent was to break out of the loop after finding the *master* primary monitor, not cloned primary monitors, to avoid unnecessary iterations. However, the primary monitor count is small and it's cleaner this way so let's break when should_enumerate_monitor() returns TRUE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5317

3 4

[PATCH 0/1] MR5305: ddraw: Release only valid texture parents on ddraw_texture_init failure.
by Andrew Nguyen (＠arethusa) 15 Mar '24

15 Mar '24

When ddraw_texture_init needs to clean up on failure, it will call the wined3d_texture_get_sub_resource_parent function on draw_texture in order to retrieve its parent for a IDirectDrawSurface release call. However, if draw_texture is NULL, then the function call will crash due to a null pointer dereference. Therefore, on failure cleanup, the release operation on the texture parent should only be performed if draw_texture is not NULL. This fixes a crash in the Virtual Insanity game demo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5305

5 5

[PATCH v7 0/7] MR631: Draft: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v7: tests: Trace more info on buffer creation failure. vkd3d: Support aliased tile binding if available. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for textures. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for buffers. vkd3d: Pre-bind sparse texture mip tails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 7

[PATCH v3 0/5] MR718: vkd3d-shader/dxil: Implement miscellaneous arithmetic DX intrinsics.
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v3: vkd3d-shader/dxil: Implement DX intrinsic Saturate. vkd3d-shader/dxil: Implement DX intrinsic FAbs. vkd3d-shader/dxil: Implement DX intrinsics FMa, FMad, IMad and UMad. vkd3d-shader/spirv: Use dst register data type in spirv_compiler_emit_imad(). tests/hlsl: Add tests for mad() and fma(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/718

2 5

2025

2024

2023

2022

wine-gitlab March 2024