March 2024 - wine-gitlab

Re: [PATCH v6 0/4] MR537: vkd3d-shader/ir: Expand index range write masks to cover all element masks.
by Giovanni Mascellani (＠giomasce) 08 Mar '24

08 Mar '24

Test `test_hull_shader_punned_array()` currently emits this validation error: ``` VUID-RuntimeSpirv-OpEntryPoint-08743(ERROR / SPEC): msgNum: -1986897773 - Validation Error: [ VUID-RuntimeSpirv-OpEntryPoint-08743 ] Object 0: handle = 0x270000000027, type = VK_OBJECT_TYPE_SHADER_MODULE; Object 1: handle = 0x280000000028, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x89925893 | vkCreateGraphicsPipelines(): pCreateInfos[0] (SPIR-V Interface) VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT declared input at Location 2 Component 3 but it is not an Output declared in VK_SHADER_STAGE_VERTEX_BIT. The Vulkan spec states: Any user-defined variables shared between the OpEntryPoint of two shader stages, and declared with Input as its Storage Class for the subsequent shader stage, must have all Location slots and Component words declared in the preceding shader stage's OpEntryPoint with Output as the Storage Class (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.ht…) ``` It might or might not be related to this MR, I haven't debugged yet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/537#note_64015

1 0

[PATCH v2 0/7] MR698: Draft: vkd3d-shader/ir: Introduce a better CFG structurizer, part 4.
by Giovanni Mascellani (＠giomasce) 08 Mar '24

08 Mar '24

This applies on top of !672, the last three commits belong here. Here we compute additional "synthetic" loops that will be used to implement non-trivial forward edges using (possibly conditional) `break` instructions. -- v2: vkd3d-shader/ir: Sort loop intervals. vkd3d-shader/ir: Generate synthetic intervals for forward edges. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/698

2 7

[PATCH 0/2] MR5263: win32u: Only send mouse input in ReleaseCapture() when a window is captured.
by Zhiyi Zhang (＠zhiyi) 08 Mar '24

08 Mar '24

Fix a regression from "bb496ea8 - server: Always queue mouse messages delivered to another window." Fix ETHER VAPOR Remaster (214570) launches to black screen when the cursor is in the game window. The game calls ReleaseCapture() when handling WM_MOUSEMOVE. After bb496ea8, WM_MOUSEMOVE is always queued because the message window is NULL. So ReleaseCapture() ends up queuing another WM_MOUSEMOVE. So the game ends up handling infinite WM_MOUSEMOVE messages at startup and is not able to do anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5263

4 5

[PATCH v3 0/4] MR5220: win32u: Move vulkan d3dkmt implementation out of winex11.
by Rémi Bernon (＠rbernon) 08 Mar '24

08 Mar '24

-- v3: win32u: Move D3DKMT vulkan implementation out of winex11. win32u: Open adapters in NtGdiDdDDIEnumAdapters2 outside of the display devices lock. win32u: Move D3DKMTSetVidPnSourceOwner / D3DKMTCheckVidPnExclusiveOwnership out of winex11. win32u: Move D3DKMT functions to a new d3dkmt.c source. https://gitlab.winehq.org/wine/wine/-/merge_requests/5220

3 7

[PATCH 0/7] MR698: Draft: vkd3d-shader/ir: Introduce a better CFG structurizer, part 4.
by Giovanni Mascellani (＠giomasce) 08 Mar '24

08 Mar '24

This applies on top of !672, the last three commits belong here. Here we compute additional "synthetic" loops that will be used to implement non-trivial forward edges using (possibly conditional) `break` instructions. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/698

2 8

[PATCH v6 0/1] MR5186: win32u: fix NtGdiExtCreateRegion implementation
by Bartosz Kosiorek (＠gang65) 08 Mar '24

08 Mar '24

-- v6: win32u: fix NtGdiExtCreateRegion implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/5186

4 4

Re: [PATCH v15 0/6] MR553: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) 08 Mar '24

08 Mar '24

On Fri Mar 8 09:47:03 2024 +0000, Giovanni Mascellani wrote: > Yeah, right. Even for SM6 the current code is likely to produce bad > results, because AFAIU many signature elements can be merged in a single > one using `register_count`. I think the appropriate action right now is > to emit the signature only for SM4-5, and leave the rest to the future > if the need will arise. I will submit a MR for that. Mmh, I'm probably confused about SM6. At least for the moment these metadata are meant to represent whatever is stored in the DXBC container, so it shouldn't change anything with SM6. I'll just disable for SM1-3. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553#note_63977

1 0

Re: [PATCH v15 0/6] MR553: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) 08 Mar '24

08 Mar '24

On Fri Mar 8 09:47:03 2024 +0000, Henri Verbeet wrote: > Should we output input/output signatures for d3dbc shaders? Currently we > do, and there's something to be said for that, but it does complicate > things in a couple of ways: > - We wouldn't be able to assemble such signatures in any meaningful > way for d3dbc targets. I.e., the assembler would largely just have to > ignore them. > - The register names are slightly different. E.g. ps_2_0 has t# > texture coordinate inputs and oC# colour outputs. Yeah, right. Even for SM6 the current code is likely to produce bad results, because AFAIU many signature elements can be merged in a single one using `register_count`. I think the appropriate action right now is to emit the signature only for SM4-5, and leave the rest to the future if the need will arise. I will submit a MR for that. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553#note_63974

1 0

[PATCH v5 0/1] MR5186: win32u: fix NtGdiExtCreateRegion implementation
by Bartosz Kosiorek (＠gang65) 08 Mar '24

08 Mar '24

-- v5: win32u: fix NtGdiExtCreateRegion implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/5186

3 2

[PATCH 0/7] MR5262: win32u: Refactor monitor cache to only store the necessary information.
by Rémi Bernon (＠rbernon) 08 Mar '24

08 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5262

3 8

2025

2024

2023

2022

wine-gitlab March 2024