April 2024 - wine-gitlab

[PATCH 0/1] MR5353: ddraw: Allow table to grow
by David Kahurani (＠ReDress) 03 Jun '24

03 Jun '24

This table doesn't really grow when the total number of handles exceeds the initial size. It will instead try to wrap and lead to an access violation. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5353

6 9

[PATCH 0/1] MR4773: ntdll: Derive not readable DMI's serial numbers from machine's GUID.
by eric pouech (＠epo) 03 Jun '24

03 Jun '24

Project Kunai associates cloud account with a mix of various items, including board serial number, resulting in several machines being bound to the same cloud account because the momo serial number is always empty. Note: this patch doesn't follow the systemd guidelines of not exposing directly /etc/machine-id content (but Wine already exposes /etc/machine-id as Windows machine GUID). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4773

2 2

[PATCH v12 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 30 May '24

30 May '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v12: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). include: Add d3d9on12.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

4 13

[PATCH 0/1] MR4837: Draft: DEBUG Check if GitLab takes PARENTSRC into account.
by Francois Gouget (＠fgouget) 28 May '24

28 May '24

It should run the xaudio2_7:xaudio2 test when xaudio2_8/tests/xaudio2.c is modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4837

5 4

[PATCH v3 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v3: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 31

[PATCH v21 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

-- v21: rtworkq: Release cancelled work items. mfplat/tests: Validate MFCancelWorkItem releases the callback. rtworkq: Avoid use-after-free. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

4 7

[PATCH 0/1] MR5542: win32u: Enable dibdrv wglDescribePixelFormat through p_get_pixel_formats.
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5542

3 2

[PATCH v2 0/1] MR5553: wined3d: Fix GLSL version comparison.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v2: wined3d: Fix GLSL version comparison. https://gitlab.winehq.org/wine/wine/-/merge_requests/5553

5 4

[PATCH v3 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- v3: ddraw/tests: Test GetVertexBufferDesc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

5 7

[PATCH v3 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- v3: wined3d: Submit command buffers after 512 draw or dispatch commands. wined3d: Retrieve the VkCommandBuffer from wined3d_context_vk after executing RTV barriers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

4 4

2025

2024

2023

2022

wine-gitlab April 2024