April 2024 - wine-gitlab

Re: [PATCH v6 0/9] MR744: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 5. - approved
by Alexandre Julliard (＠julliard) 09 Apr '24

09 Apr '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/744

1 0

[PATCH v16 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 09 Apr '24

09 Apr '24

-- v16: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

4 5

[PATCH 0/1] MR771: vkd3d-shader/d3d-asm: Reset indent level on HS phases.
by Giovanni Mascellani (＠giomasce) 09 Apr '24

09 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/771

3 3

[PATCH 0/3] MR759: vkd3d-shader/dxil: TGSM part 4.
by Conor McCarthy (＠cmccarthy) 09 Apr '24

09 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/759

4 5

[PATCH v6 0/2] MR733: vkd3d-shader/dxil: Implement DX intrinsic CalculateLOD.
by Conor McCarthy (＠cmccarthy) 09 Apr '24

09 Apr '24

-- v6: vkd3d-shader/dxil: Implement DX intrinsic CalculateLOD. tests/hlsl: Add tests for CalculateLevelOfDetail(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/733

4 4

[PATCH 0/3] MR772: vkd3d: Add two more resource description/state validations.
by Conor McCarthy (＠cmccarthy) 09 Apr '24

09 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/772

4 5

[PATCH v4 0/5] MR767: vkd3d-shader/dxil: Tessellation part 1.
by Conor McCarthy (＠cmccarthy) 09 Apr '24

09 Apr '24

Doesn't support tessellation yet, but adds some requirements. -- v4: vkd3d-shader/ir: Validate tessellation declarations. vkd3d-shader/dxil: Implement DX intrinsic PrimitiveID. vkd3d-shader/dxil: Load hull shader properties. vkd3d-shader/dxil: Load domain shader properties. tests/hlsl: Add a tessellation test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/767

5 17

[PATCH v3 0/5] MR765: tests: Do not crash on llvmpipe.
by Giovanni Mascellani (＠giomasce) 09 Apr '24

09 Apr '24

-- v3: ci: Build Mesa for release. tests: Pop the test context when leaving its scope. tests: Add llvmpipe among the Mesa drivers. tests: Skip tests that crash on llvmpipe. tests: Do not crash on some test failures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/765

3 7

Re: [PATCH v3 0/1] MR761: tests/shader_runner: Report compilation errors on the block's starting line.
by Henri Verbeet (＠hverbeet) 09 Apr '24

09 Apr '24

> > This seems a little fragile. > > I don't think it is that fragile, currently we handle directives in 3 points in run_shader_tests(): > > 1. The first switch, where we detect that we stopped reading the block because a new block starts or the file ended. > 2. The reading of the tags at the beginning of new blocks. > 3. The reading of individual lines using a second switch. > > We don't need to call update_line_number_context() in 1, and we always have to call it in 2 so we don't have to worry about forgetting to do so we add new functionalities. > > It is only in 3 that we have to remember to call update_line_number_context() for the switch cases when we want to update the line number context for each line instead of presenting it at the beginning of the block, but even if we forget, the error will be reported at the beginning of the block because of 2. Sure, the impact of messing up isn't going to very bad. Fundamentally though, this commit puts the burden of calling update_line_number_context() on the "normal" cases instead of on the exceptional cases. > > Could we just track the starting line for things touching "shader_source" and then setup/restore the test context in e.g. compile_shader()? > > Here is a patch for that proposal (how I see it), but I find it more complex. > > [0001-tests-shader-runner-Report-compilation-errors-on-the.patch](https://gi… I think that's closer to what I had in mind. How do you feel about [this patch](/uploads/e4b238bc14f76573c5eea824d660402f/patch.diff)? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/761#note_67388

1 0

[PATCH v7 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) 09 Apr '24

09 Apr '24

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v7: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 1

2025

2024

2023

2022

wine-gitlab April 2024