April 2024 - wine-gitlab

[PATCH v5 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- v5: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 3

[PATCH v4 0/2] MR5519: setupapi: use INF parser to read class GUID and class name
by Tuomas Räsänen (＠tuomasjjrasanen) 28 May '24

28 May '24

Previously, `SetupDiGetINFClassW()` read INF files with `GetPrivateProfileString()`, which does not substitute %strkey% tokens. This caused device installation to fail for devices which had driver INF files using %strkey% tokens in Version section. An example of such device is Vernier LabQuest Mini (08f7:0008) for which Vernier's LoggerPro application includes a driver. The INF file in question adds a new device setup class and has following entries in Version section: ``` Class = %ClassName% ClassGuid = %DeviceClassGUID% ``` Strings section includes following entries: ``` DeviceClassGUID = "{6B8429BF-10AD-4b66-9FBA-2FE72B891721}" ClassName = "VST_WinUSB" ``` Previously, when LoggerPro was installed and LabQuest Mini was hotplugged, device installation failed with the following error: ``` fixme:setupapi:SetupDiGetINFClassW failed to convert "L"%DeviceClassGUID"" into a guid ``` This caused GUID_NULL to be used and Class was not set to the registry for the device. With this commit, correct class GUID and names are set to the device registry entry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56579 -- v4: setupapi: use INF parser to read class GUID and class name setupapi/tests: add tests for reading INF class with %strkey% tokens https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

3 9

[PATCH v11 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

-- v11: explorer: Restore display settings on process exit. winex11.drv: Process RRNotify events in xrandr14_get_id. user32/tests: Test that display settings are restored on process exit. https://gitlab.winehq.org/wine/wine/-/merge_requests/5060

3 8

[PATCH v3 0/6] MR5491: win32u: Move most vulkan surface code out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: win32u: Move host surface destruction out of the drivers. win32u: Pass HWND directly to vulkan surface creation driver callback. win32u: Rename vulkan surface creation/destroy driver callbacks. winevulkan: Pass win32u surface wrappers for each vkQueuePresent swapchain. win32u: Introduce a new VkSurfaceKHR wrapping structure. win32u: Introduce a distinct vulkan interface between win32u and the user drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5491

3 9

[PATCH 0/2] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

At least CryptSetKeyParam(KP_X) should accept NULL pbData. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

3 3

[PATCH 0/2] MR5534: cryptnet, crypt32: OCSP revocation check improvements.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5534

3 4

[PATCH v4 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- v4: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 3

[PATCH v4 0/1] MR5437: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v4: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set. https://gitlab.winehq.org/wine/wine/-/merge_requests/5437

3 2

[PATCH v66 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 May '24

28 May '24

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v66: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

7 22

[PATCH v2 0/11] MR5491: win32u: Move most vulkan surface code out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v2: winex11: Remove now unnecessary surface wrapper struct. win32u: Move thread detach from winex11. win32u: Introduce a per-window vulkan surface list. winewayland: Get rid of the now unnecessary surface wrapper. win32u: Return the host surface directly from vulkan_surface_create. win32u: Move host surface destruction out of the drivers. win32u: Pass HWND directly to vulkan surface creation driver callback. win32u: Rename vulkan surface creation/destroy driver callbacks. winevulkan: Pass win32u surface wrappers for each vkQueuePresent swapchain. win32u: Introduce a new VkSurfaceKHR wrapping structure. win32u: Introduce a distinct vulkan interface between win32u and the user drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5491

4 14

2025

2024

2023

2022

wine-gitlab April 2024