May 2024 - wine-gitlab

Re: [PATCH v4 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

1 0

Re: [PATCH v2 0/6] MR5638: wined3d: Remove texture NPOT fixup. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5638

1 0

Re: [PATCH v2 0/9] MR5653: wbemprox: Get processor information from the SMBIOS table. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5653

1 0

Re: [PATCH v2 0/1] MR5655: msvcrt/tests: Don't link to _wcsicmp_l and _create_locale. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5655

1 0

Re: [PATCH v2 0/3] MR5648: d2d1/tests: Add some vertex buffer tests. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5648

1 0

[PATCH v2 0/2] MR5634: win32u: Ignore WM_MOUSEMOVE when tracking scrollbar and arrow/track is clicked
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

This fixes a regression from bb496ea8. Also closer mimics windows behavior, moving the mouse should not reset the scrolling timer. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56582 -- v2: win32u: Only set scroll timer if it's not running win32u: Refactor out scroll timer handling https://gitlab.winehq.org/wine/wine/-/merge_requests/5634

2 3

[PATCH v2 0/1] MR5650: msvcrt,winedump: Demandle std::nullptr_t datatype.
by eric pouech (＠epo) 28 May '24

28 May '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: msvcrt,winedump: Demangle std::nullptr_t datatype. https://gitlab.winehq.org/wine/wine/-/merge_requests/5650

4 3

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 15:19:50 2024 +0000, eric pouech wrote: > to go one step further native also unmangles without whining something > like `"?AU?$my_iter@H$0A@$$VJ@@"` into `struct my_iter<int,0,long>` > (which doesn't make any sense in a C++ way either) > so it looks like the $$V sequence is just a marker for the end of a > variadic template, that is unmangled into nothing, and doesn't seem to > have (at least the ucrtbase version I've used) other visible action > so the attached patch should be enough > [err](/uploads/977e89694bc0fcda26a3ba0f1ccb46b7/err) This marker is specific to templates so it doesn't really belong to `demangle_datatype` function. The patch you have proposed e.g. incorrectly demangles `??__K_l@@YA?AUCC@@I$$VI@Z`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70553

1 0

[PATCH v3 0/5] MR5604: Draft: winemac.drv: Some dock icon hiding improvements
by Tim Clem (＠tclem) 28 May '24

28 May '24

The most important thing here is a workaround for an OS bug: rapidly hiding and showing the dock icon can result in multiple icons for the same app, and those icons will ignore NSApp.applicationIconImage. Making sure transitions happen no less than 1 second apart from one another seems to fix it. *Edit:* v2 update: 0.5 seconds is not always long enough. A good test case is the Notepad++ installer: after you select a language, it rapidly hides and shows some windows, and without a longer delay the icon will wind up with the default system terminal-looking icon. One second is probably overkill, but this ought to be a somewhat uncommon case. Also, hiding a dock icon will deactivate an app. That's not desirable if it still has visible windows, so attempt to force a reactivation. That's often not successful on Sonoma due to the cooperative app activation heuristics, but it's the best we can do, and it should be a rare case. Also, there is some logic in -transformProcessToForeground: that we often want to happen regardless of whether the app is getting a dock icon (e.g. App Nap and activation). So I've renamed that function to more accurately communicate what it does, and consolidate it with -tryToActivateIgnoringOtherApps:. -- v3: winemac.drv: Consolidate foregrounding and dock icon behavior. winemac.drv: Remove incorrect documentation for orderBelow: and rename a parameter. winemac.drv: Reactivate the app if needed after hiding its dock icon. winemac.drv: Enforce a delay between dock icon hides and shows. winemac.drv: Factor menu creation out of transformProcessToForeground:. https://gitlab.winehq.org/wine/wine/-/merge_requests/5604

2 7

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

On Wed May 15 13:11:30 2024 +0000, Piotr Caban wrote: > I forgot to mention that native accepts multiple $$V sequences, so e.g. > `?AU?$my_iter@H$0A@$$V$$V@@` is also parsed (but probably doesn't make > sense and nothing is mangled this way). to go one step further native also unmangles without whining something like `"?AU?$my_iter@H$0A@$$VJ@@"` into `struct my_iter<int,0,long>` (which doesn't make any sense in a C++ way either) so it looks like the $$V sequence is just a marker for the end of a variadic template, that is unmangled into nothing, and doesn't seem to have (at least the ucrtbase version I've used) other visible action so the attached patch should be enough [err](/uploads/977e89694bc0fcda26a3ba0f1ccb46b7/err) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70538

1 0

[PATCH 0/6] MR5656: mshtml: Use DISPEX_IDISPATCH_IMPL (part 3)
by Jacek Caban (＠jacek) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5656

4 8

[PATCH v6 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v6: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 13

Re: [PATCH v3 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix. - approved
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

This merge request was approved by Matteo Bruni. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 12:40:06 2024 +0000, Piotr Caban wrote: > Yes I was thinking about something like you have attached first but I > didn't like few things: > - it requires adding new flag > - it's a special marker that is only valid in template, it can't be > used as datatype in other places > - your code is also not eating final '@' correctly but it can be > addressed easily I forgot to mention that native accepts multiple $$V sequences, so e.g. `?AU?$my_iter@H$0A@$$V$$V@@` is also parsed (but probably doesn't make sense and nothing is mangled this way). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70526

1 0

[PATCH 0/6] MR5638: wined3d: Remove texture NPOT fixup.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5638

4 8

[PATCH 0/9] MR5653: wbemprox: Get processor information from the SMBIOS table.
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This fixes the reported information on ARM platforms. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5653

4 11

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 12:16:18 2024 +0000, eric pouech wrote: > [err](/uploads/6c39c40a566da58e25661ae18e455f1c/err) Yes I was thinking about something like you have attached first but I didn't like few things: - it requires adding new flag - it's a special marker that is only valid in template, it can't be used as datatype in other places - your code is also not eating final '@' correctly but it can be addressed easily -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70520

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

On Wed May 15 10:08:14 2024 +0000, Piotr Caban wrote: > I can't see the patch, could you please fix the link? [err](/uploads/6c39c40a566da58e25661ae18e455f1c/err) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70517

1 0

[PATCH v2 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix.
by Connor McAdams (＠cmcadams) 28 May '24

28 May '24

-- v2: d3dx9: Fix destination rectangles passed from D3DXLoadSurfaceFromMemory() to d3dx_load_image_from_memory(). d3dx9: Only do direct copies of full blocks for compressed formats. d3dx9/tests: Add a new compressed surface loading test. d3dx9/tests: Add a test for negative values in the source rectangle passed to D3DXLoadSurfaceFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

3 7

[PATCH 0/1] MR5650: msvcrt,winedump: Demandle std::nullptr_t datatype.
by eric pouech (＠epo) 28 May '24

28 May '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5650

5 4

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 08:07:21 2024 +0000, eric pouech wrote: > that test looks very strange at that place while we already have > handling of other types starting with "$$" in demangle_datatype. > it calls for having a proper identification about end of list (didn't > include the function arg one, but we could well do it) > I think we could rather use something like the attached patch. > [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ I can't see the patch, could you please fix the link? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70505

1 0

[PATCH v2 0/5] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- v2: win32u: Enumerate offscreen vulkan devices as GPU devices. win32u: Query GPU memory from vulkan physical device. win32u: Match driver GPUs with vulkan GPUS from their ids, or index. win32u: Keep a list of vulkan GPUS in the device manager context. win32u: Fix default_update_display_devices return type to NTSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

4 9

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

eric pouech (@epo) commented about dlls/msvcrt/undname.c: > sym->current++; > break; > } > + /* Handle empty list in variadic template */ > + if (!z_term && sym->current[0] == '$' && sym->current[1] == '$' && sym->current[2] == 'V') that test looks very strange at that place while we already have handling of other types starting with "$$" in demangle_datatype. it calls for having a proper identification about end of list (didn't include the function arg one, but we could well do it) I think we could rather use something like the attached patch. [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70497

1 0

[PATCH 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix.
by Connor McAdams (＠cmcadams) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

4 8

Re: [PATCH v2 0/1] MR5636: opengl32: Prefer formats with depth if unspecified in wglChoosePixelFormat(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5636

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646

1 0

Re: [PATCH v2 0/1] MR5645: winebuild: Use .drectve section for exports on ARM64EC. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5645

1 0

Re: [PATCH v2 0/3] MR5594: winemac.drv: Some display mode fixes - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5594

1 0

Re: [PATCH v3 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607

1 0

Re: [PATCH v2 0/1] MR5635: ntdll: Allocate crit section debug info by default for Windows versions before 8. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5635

1 0

Re: [PATCH v3 0/8] MR5640: odbc32: Add Wow64 thunks - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5640

1 0

Re: [PATCH v2 0/1] MR5637: dinput: Don't include every version of DirectInputCreate in every DLL. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5637

1 0

Re: [PATCH v2 0/3] MR5643: winebus: Implement Sony controllers report fixups for the iohid backend. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5643

1 0

Re: [PATCH v3 0/6] MR5642: mshtml: Use DISPEX_IDISPATCH_IMPL macro in more places. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5642

1 0

[PATCH 0/1] MR5636: opengl32: Prefer formats with depth if unspecified in wglChoosePixelFormat().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Descent 3 depends on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5636

4 4

[PATCH 0/1] MR5634: win32u: Ignore WM_MOUSEMOVE when tracking scrollbar and arrow/track is clicked
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

This fixes a regression from bb496ea8. Also closer mimics windows behavior, moving the mouse should not reset the scrolling timer. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56582 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5634

4 7

[PATCH v5 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v5: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

2 12

[PATCH 0/3] MR5594: winemac.drv: Some display mode fixes
by Tim Clem (＠tclem) 28 May '24

28 May '24

Fixing up some issues seen with display modes reported from the Apple Studio Display: - It has some pairs of modes that differ only in whether they are "usable for desktop." Switching to one of the modes that isn't results in an error. All other things being equal, we should prefer modes that are "usable for desktop" over those that aren't. - display_get_modes was returning multiple identical DEVMODEs. This is because we consider the kDisplayModeValidFlag and kDisplayModeSafeFlag values as making a display mode unique (and thus not comparable to other modes with the same resolution). Like above, the Studio Display has mode pairs that are identical except that one is "unsafe." We should compare modes with the same resolution, regardless of the safe and valid flags, and prefer safe and valid ones over the alternatives. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5594

3 4

[PATCH v4 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v4: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 13

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Oh, it is probably this one: > xaudio2_8 > xaudio2.c:865: Test failed: CreateSubmixVoice failed: 88960001 > 0a44:xaudio2: unhandled exception c0000005 at 00007FF795004307 Thanks, I will take a look now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588#note_70415

1 0

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This is breaking the tests on Windows, could you please have a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588#note_70414

1 0

[PATCH 0/6] MR5626: mfreadwrite: Support MFVideoFormat_ABGR32 output.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This format is used by many Unity games, with D3D-enabled source reader. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5626

4 9

[PATCH 0/6] MR5642: mshtml: Use DISPEX_IDISPATCH_IMPL macro in more places.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5642

4 9

[PATCH 0/1] MR5633: win32u: Fallback to default script if vert/vrt2 is not found.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

Also changed to use `DFLT` instead of `dflt` as the default script tag. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56658 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

4 4

[PATCH 0/1] MR5637: dinput: Don't include every version of DirectInputCreate in every DLL.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

DirectInputCreate(A|W|Ex) is only needed in dinput.dll, and DirectInput8Create is only needed in dinput8.dll. Excluding the unnecessary functions reduces the size of each DLL by about 4 KB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5637

4 3

[PATCH v2 0/8] MR5640: odbc32: Add Wow64 thunks
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v2: odbc32/tests: Add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5640

3 10

[PATCH v2 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- v2: winedump: Fail on NULL funcs in dump_dir_exceptions(). winedump: Use offsetof() for string position calculations. https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

5 7

[PATCH 0/5] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

3 7

Re: [PATCH v3 0/7] MR5622: wined3d: Remove the no longer usable shader and FFP backends. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5622

1 0

Re: [PATCH v3 0/4] MR5609: Rewrite of cmd command engine (part III). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5609

1 0

2025

2024

2023

2022

wine-gitlab May 2024