May 2024 - wine-gitlab

Re: [PATCH v2 0/1] MR5624: po: Add a missing \t in the Simplified Chinese translation. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5624

1 0

Re: [PATCH v4 0/2] MR5611: winegstreamer: Fix audio decoding support checks. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

1 0

Re: [PATCH v3 0/1] MR5613: winegstreamer: Pass filename to wg_parser when available. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5613

1 0

Re: [PATCH v3 0/2] MR5618: mountmgr.sys: Ignore hidden and system volumes on macOS - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5618

1 0

Re: [PATCH v2 0/3] MR5630: mshtml: Introduce DISPEX_IDISPATCH_IMPL. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5630

1 0

Re: [PATCH v3 0/1] MR5629: d3dx9/tests: Use trace instead of printf. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5629

1 0

[PATCH v36 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v36: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. win32u: Open the global session shared mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 11

[PATCH v3 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v3: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 31

[PATCH v3 0/2] MR5611: winegstreamer: Fix audio decoding support checks.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

Fixes: cc82780c22db31fed4da8b84e85c01652a995490 -- v3: winegstreamer: Add missing format fields to WMA support check. winegstreamer: Recognize MFAudioFormat_MPEG and MFAudioFormat_MP3. https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

4 6

Re: [PATCH v2 0/1] MR5613: winegstreamer: Pass filename to wg_parser when available. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5613

1 0

[PATCH 0/1] MR5623: po: Add a missing \t in the Simplified Chinese translation.
by Hongxin Zhao (＠zhaohongxin) 28 May '24

28 May '24

Align the Chinese text output of wine cmd before: ![before.png](/uploads/903d871e44394d1ad9e9f032cc6941bd/before.png) after: ![after.png](/uploads/f155f2d59a9663ea67497002e24d7708/after.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5623

4 4

[PATCH v2 0/2] MR5618: mountmgr.sys: Ignore hidden and system volumes on macOS
by Tim Clem (＠tclem) 28 May '24

28 May '24

Non-"browsable" volumes or those without filesystem mount points are invisible to users and should not be reflected automatically into Wine. -- v2: mountmgr.sys: Do not add drive letters or volumes for macOS volumes without mount paths. mountmgr.sys: Do not create drive letters or volumes for unbrowsable macOS volumes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5618

4 4

[PATCH 0/3] MR5630: mshtml: Introduce DISPEX_IDISPATCH_IMPL.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5630

4 6

[PATCH v2 0/1] MR5629: d3dx9/tests: Use trace instead of printf.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

Fixes Clang warning on 32-bit platforms. Clang is more strict about `-Wformat` than GCC. For `%I`, it expects the exact `size_t` type, which is `int` on 32-bit targets, while `SIZE_T` is `long`. For that reason, we currently disable those warnings by not using format attribute on MSVC targets. This is not enough for printf, which is a builtin and has the attribute applied anyway. Using trace, like we do in all other cases, "fixes" it. I plan to make clang less strict about those cases, which would also fix this problem and allow us to enable format attribute in all relevant functions. However, on current versions of clang, this is one of the last few blockers to support `-Werror`, so it would be nice to have it fixed one way or another. If `printf` is preferred here for some reason, we could also just add an explicit `size_t` cast when printing the size. -- v2: d3dx9/tests: Remove xfile dumping functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/5629

3 4

[PATCH 0/1] MR5629: d3dx9/tests: Use trace instead of printf.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

Fixes Clang warning on 32-bit platforms. Clang is more strict about `-Wformat` than GCC. For `%I`, it expects the exact `size_t` type, which is `int` on 32-bit targets, while `SIZE_T` is `long`. For that reason, we currently disable those warnings by not using format attribute on MSVC targets. This is not enough for printf, which is a builtin and has the attribute applied anyway. Using trace, like we do in all other cases, "fixes" it. I plan to make clang less strict about those cases, which would also fix this problem and allow us to enable format attribute in all relevant functions. However, on current versions of clang, this is one of the last few blockers to support `-Werror`, so it would be nice to have it fixed one way or another. If `printf` is preferred here for some reason, we could also just add an explicit `size_t` cast when printing the size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5629

4 3

[PATCH v35 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v35: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

4 18

[PATCH 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

4 7

[PATCH v2 0/5] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- v2: winewayland.drv: Populate vkey to wchar entry for VK_DECIMAL. server: Send numpad virtual keys if NumLock is active. win32u: Store the full KBD vkey information in kbd_tables_init_vsc2vk. win32u: Allow drivers to send only the scan code for keyboard events. https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 12

[PATCH 0/1] MR5624: po: Add a missing \t in the Simplified Chinese translation.
by Hongxin Zhao (＠zhaohongxin) 28 May '24

28 May '24

Align the Chinese text output of wine cmd before: ![before.png](/uploads/aed02f6947ef757cac0c335aed48104f/before.png) after: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5624

4 3

[PATCH v2 0/4] MR5609: Rewrite of cmd command engine (part III).
by eric pouech (＠epo) 28 May '24

28 May '24

This is the third serie related to rewriting cmd's command engine. Currently, cmd stores block of commands as a linked list of CMD_LIST. Even for nested commands (like 'if' command inside a 'for' command), it's parsed as a single list of commands, using a 'depth' attribute and marker for end of block to describe the structure. This leads to several issues: - parsing for nested commands is not 100% robust, - chaining of commands (and its precedence) is not handled, - no separation between parsing and execution (esp. for 'IF' and 'FOR' commands, which behave slightly differently than regular commands when dealing with variables with delayed expansion), - data model doesn't 100% fit native behavior (eg redirections can apply to a block of commands, whereas redirections are attached to individual commands) - ... The final goal is to replace this with: - a tree of commands: + binary nodes for command chaining, + 'IF' and 'FOR' commands being parsed and stored as such + leaf being a command It will require a couple more series to reach that goal, so this series puts in place the basic building bits: - introducing a new structure CMD_NODE to hold that each node of such a tree, - moving the chaining operator into that CMD_NODE (meaning that we move from a linked list to a binary tree degenerated into a list: left is command, right is next node). -- v2: programs/cmd: Move operator from CMD_COMMAND to CMD_NODE. programs/cmd: Add helpers to handle list in degenerated binary tree. programs/cmd: Introduce CMD_NODE structure. programs/cmd: Remove malloc attribute from xrealloc. https://gitlab.winehq.org/wine/wine/-/merge_requests/5609

3 6

[PATCH 0/1] MR5621: Update zh_CN.po to align output text
by Hongxin Zhao (＠zhaohongxin) 28 May '24

28 May '24

The original help info of MKLINK lacks **\\t** which makes the output text of wine cmd not fully aligned. ![before](/uploads/659f487299f8b25ab4211e111323a5c3/before.png){width="587" height="330"} ![after](/uploads/0c3a6b7dc1a5326555fe033fdf522953/after.png){width="586" height="330"} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5621

3 5

Re: [PATCH v3 0/4] MR5612: d3d9/tests: Various tests related to vertex declarations.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

I've noticed for some time that my merge requests are intermittently not getting assigned to Jan. This is one example. @julliard, is there anything that can be done about this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5612#note_70212

1 0

Re: [PATCH v3 0/4] MR5612: d3d9/tests: Various tests related to vertex declarations. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5612

1 0

Re: [PATCH v2 0/1] MR5620: winevulkan: Update to VK spec version 1.3.285. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5620

1 0

Re: [PATCH v2 0/5] MR5617: gdiplus: Removing gdi32 objects from gdiplus objects. (part 2) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5617

1 0

Re: [PATCH v22 0/3] MR4243: rtworkq: free cancelled work items - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

1 0

Re: [PATCH v2 0/11] MR5614: mfplat: Test and support FORMAT_MPEGVideo and FORMAT_MPEG2Video. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5614

1 0

Re: [PATCH v3 0/1] MR5603: win32u: Update last message time in NtUserGetRawInputBuffer(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5603

1 0

Re: [PATCH v3 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

1 0

Re: [PATCH v3 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

1 0

Re: [PATCH v2 0/2] MR5610: d2d1/tests: Add a test for effect output image interface query. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5610

1 0

Re: [PATCH v2 0/1] MR5542: win32u: Enable dibdrv wglDescribePixelFormat through p_get_pixel_formats. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5542

1 0

Re: [PATCH v2 0/5] MR5606: wined3d: Remove code related to backbuffer ORM. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5606

1 0

Re: [PATCH v2 0/1] MR5595: bcrypt: Support RSA/PKCS1 signatures with unspecified hash algorithm. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5595

1 0

Re: [PATCH v2 0/1] MR5605: winemac.drv: Fix warning in macdrv_get_pixel_formats. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5605

1 0

Re: [PATCH v2 0/4] MR5600: Second part of cmd engine rewrite.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

Brendan Shanks (@bshanks) commented about programs/cmd/wcmd.h: > void WCMD_execute (const WCHAR *orig_command, const WCHAR *redirects, > CMD_LIST **cmdList, BOOL retrycall); > > -void *xalloc(size_t) __WINE_ALLOC_SIZE(1) __WINE_DEALLOC(free) __WINE_MALLOC; > +void *xrealloc(void *, size_t) __WINE_ALLOC_SIZE(2) __WINE_DEALLOC(free) __WINE_MALLOC; `realloc` should not use `__WINE_MALLOC`/`attribute((malloc))`. From [the docs](https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html): "functions like realloc do not have this property, as they may return pointers to storage containing pointers to existing objects" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5600#note_70159

1 0

[PATCH v21 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

-- v21: rtworkq: Release cancelled work items. mfplat/tests: Validate MFCancelWorkItem releases the callback. rtworkq: Avoid use-after-free. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

4 7

[PATCH 0/11] MR5614: mfplat: Test and support FORMAT_MPEGVideo and FORMAT_MPEG2Video.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5614

3 12

[PATCH 0/5] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 8

[PATCH v2 0/1] MR5603: win32u: Update last message time in NtUserGetRawInputBuffer().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: win32u: Update last message time in NtUserGetRawInputBuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5603

4 3

[PATCH v2 0/2] MR5611: winegstreamer: Recognize MFAudioFormat_MPEG and MFAudioFormat_MP3.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

Fixes: 067d4f047247b39a5866c1d7b22b5f16b5187d5b -- v2: winegstreamer: Add missing format fields to WMA support check. https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

2 3

[PATCH v2 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This fixes a regression introduced in: f74900ad1a580eda8fd4923cbd4881b42b042733 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56655 -- v2: winex11.drv: Increment mode_idx in {xrandr10,xf86vm}_get_modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

3 3

Re: [PATCH v2 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

I thought some Windows modules are built against ucrtbase? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607#note_70072

1 0

Re: [PATCH v2 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase.
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Not directly related to this MR, but maybe we could switch all modules to msvcrt, like Windows does it? I'm probably missing a point as to why we deliberately differ in this aspect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607#note_70068

1 0

[PATCH v2 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- v2: msvcrt/tests: Add tests for _wcsicmp_l. https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

3 3

[PATCH v2 0/3] MR5578: Draft: msvcp140_atomic_wait: Partially implement __std_tzdb functions.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

OpenImageViewer requires all of these functions for the file information menu to work. This implementation references the open-source (Apache 2.0) STL code: https://github.com/microsoft/STL/blob/main/stl/src/tzdb.cpp -- v2: msvcp140_atomic_wait/tests: Add tests for the __std_tzdb functions. msvcp140_atomic_wait: Partially implement __std_tzdb_*_leap_seconds(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5578

3 7

[PATCH 0/1] MR5542: win32u: Enable dibdrv wglDescribePixelFormat through p_get_pixel_formats.
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5542

3 2

[PATCH 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This fixes a regression introduced in: f74900ad1a580eda8fd4923cbd4881b42b042733 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56655 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

3 2

[PATCH 0/5] MR5606: wined3d: Remove code related to backbuffer ORM.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5606

3 6

[PATCH 0/1] MR5595: bcrypt: Support RSA/PKCS1 signatures with unspecified hash algorithm.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Apex Legends now depends on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5595

4 3

2025

2024

2023

2022

wine-gitlab May 2024