May 2024 - wine-gitlab

[PATCH v4 0/1] MR5509: Add tests to MF Media Engine
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This MR adds two tests for additional test coverage in preparation of an update to MF Media Engine to use a dedicated Video Sink instead of the Sample Grabber -- v4: mfmediaengine/tests: Add test for audio only. https://gitlab.winehq.org/wine/wine/-/merge_requests/5509

3 3

[PATCH 0/1] MR5605: winemac.drv: Fix warning in macdrv_get_pixel_formats.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

Fix a warning introduced with fbf81662ba5b861e52a15c103cfe36a585f718dd: ``` ../dlls/winemac.drv/opengl.c:4605:54: warning: incompatible pointer types passing 'struct wgl_pixel_format *' to parameter of type 'PIXELFORMATDESCRIPTOR *' (aka 'struct tagPIXELFORMATDESCRIPTOR *') [-Wincompatible-pointer-types] describe_pixel_format(&pixel_formats[i], &formats[i]); ^~~~~~~~~~~ ../dlls/winemac.drv/opengl.c:4306:82: note: passing argument to parameter 'descr' here static void describe_pixel_format(const pixel_format *pf, PIXELFORMATDESCRIPTOR *descr) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5605

3 2

Re: [PATCH v2 0/4] MR5600: Second part of cmd engine rewrite. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5600

1 0

Re: [PATCH v2 0/1] MR5602: user32/tests: Offset child CS_PARENTDC window from parent to make more bugs visible. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5602

1 0

Re: [PATCH v2 0/1] MR5598: maintainers: Change the full form of my name. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5598

1 0

Re: [PATCH v2 0/1] MR5596: msvcrt/tests: Add result for Turkish_Türkiye.1254. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5596

1 0

Re: [PATCH v2 0/3] MR5558: winegstreamer: Introduce new check_(audio|video)_transform_support helpers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5558

1 0

Re: [PATCH v2 0/1] MR5597: winegstreamer/video_decoder: Make output_plane_align specific to h264. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5597

1 0

Re: [PATCH v8 0/4] MR5459: mfreadwrite: Implement D3D awareness support with the video processor. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5459

1 0

Re: [PATCH v4 0/1] MR5589: ntdll: Don't restore PC from LR after unwinding through frame switches. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5589

1 0

Re: [PATCH v2 0/5] MR5593: gdiplus: Start bracketing Graphics HDC uses. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5593

1 0

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588

1 0

[PATCH 0/1] MR5603: win32u: Update last message time in NtUserGetRawInputBuffer().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5603

3 3

[PATCH 0/1] MR5598: maintainers: Change the full form of my name.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

For those concerned, this only reflects the full form of my name, which I use for contributions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5598

3 4

[PATCH 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

3 2

[PATCH 0/1] MR5597: winegstreamer/video_decoder: Make output_plane_align specific to h264.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

If we set output align to wmv decoder, it will fail at copy_video_buffer(). The output size will larger than the sample we provided due to alignment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5597

3 3

[PATCH 0/1] MR5596: msvcrt/tests: Add result for Turkish_Türkiye.1254.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

ran into these on one of my machines: https://test.winehq.org/data/a27b95511be1cb6076b4a91027d14dd139ba3744/win22… https://test.winehq.org/data/a27b95511be1cb6076b4a91027d14dd139ba3744/win22… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5596

3 2

[PATCH 0/4] MR5585: Arek Hiler's avatar mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Arek Hiler (＠ivyl) 28 May '24

28 May '24

This is based on work done by Andrew Eikum. It has been in some form in Proton for the last 4 years. If server's sampling rate is not 48kHz **DOOM Eternal** will try to set it 48kHz for the streams using the implemented interface. There's a whole class of audio devices that use 44.1kHz sampling rate and at least PulseAudio / PipeWire tends to inherit the value from the hardware to avoid resampling. The value can also be overridden by the user via the audio server's config files. In such cases, if the interface is not present or stubbed, this results in **audio underruns and noticeable crackling**. It's easy to test with pipewire-pulse: ``` $ cat /etc/pipewire/pipewire.conf.d/sample-rate.conf context.properties = { default.clock.rate = 41100 } ``` With PulseAudio this should be doable via setting `default-sample-rate = 41100` in `/etc/pulse/daemon.conf`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585

4 10

[PATCH 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588

3 3

Re: [PATCH v2 0/5] MR5592: Rewrite of cmd.exe's command engine (part I) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5592

1 0

Re: [PATCH v2 0/1] MR5591: winecrt0: Support __os_arm64x_dispatch_call symbol on ARM64EC. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5591

1 0

Re: [PATCH v5 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

1 0

Re: [PATCH v3 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

1 0

Re: [PATCH v3 0/2] MR5579: win32u: Write / read available display modes as a single binary blob. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5579

1 0

Re: [PATCH v2 0/1] MR5590: kernelbase: Add support for FileDispositionInfoEx to SetFileInformationByHandle(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5590

1 0

Re: [PATCH v3 0/1] MR5553: wined3d: Fix GLSL version comparison. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5553

1 0

Re: [PATCH v4 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

1 0

Re: [PATCH v4 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

1 0

Re: [PATCH v4 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

1 0

[PATCH v4 0/1] MR4418: cmd: Delay variable substitution until after the if clause is parsed.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- v4: cmd: Delay variable substitution until after the if clause is parsed. https://gitlab.winehq.org/wine/wine/-/merge_requests/4418

3 2

[PATCH v2 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- v2: win32u: Use GDI blit to implement partial or other process presentation. winex11: Return an offscreen HDC from vulkan_surface_detach. win32u: Pass a HDC parameter to vulkan_surface_detach. winex11: Create a window surface even when there is client window. winex11: Also attach child client windows to their toplevel window. win32u: Make sure vulkan windows have a pixel format selected. win32u: Detach vulkan surfaces that aren't fully visible. win32u: Detach vulkan surfaces that are offscreen or for another process. win32u: Move vulkan surfaces to their new parent when reparenting. win32u: Introduce a new vulkan offscreen surfaces list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

5 19

[PATCH v2 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

In order to implement the patch discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5491#note_67907 -- v2: win32u: Return STATUS_ALREADY_COMPLETE from UpdateDisplayDevices. win32u: Pass gdi_gpu structure members as add_gpu parameters. win32u: Remove driver-specific id from struct gdi_gpu. win32u: Use struct pci_id in struct gdi_gpu. win32u: Remove now unnecessary reset_display_manager_ctx. https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

3 8

[PATCH v2 0/2] MR5579: win32u: Write / read available display modes as a single binary blob.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Reduces the time needed to write them from 20ms to 2ms and to read them from 10ms to 1ms, as well as reducing the number of wineserver requests by a lot. -- v2: win32u: Read / write source modes as a single registry blob. winex11: Only request display modes driver data when needed. https://gitlab.winehq.org/wine/wine/-/merge_requests/5579

3 7

[PATCH 0/1] MR5586: configure: Test PE compilers after setting their target argument.
by Billy Laws (＠bylaws) 28 May '24

28 May '24

clang will default to the host if no target is specified, which causes compile test failures if arch-specific CFLAGS are used for a non-host arch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5586

3 2

[PATCH v2 0/1] MR5553: wined3d: Fix GLSL version comparison.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v2: wined3d: Fix GLSL version comparison. https://gitlab.winehq.org/wine/wine/-/merge_requests/5553

5 4

[PATCH v3 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- v3: ddraw/tests: Test GetVertexBufferDesc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

5 7

[PATCH 0/2] MR5579: win32u: Write / read available display modes as a single binary blob.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Reduces the time needed to write them from 20ms to 2ms and to read them from 10ms to 1ms, as well as reducing the number of wineserver requests by a lot. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5579

3 5

[PATCH 0/5] MR5570: win32u: Some more refactor in preparation for vulkan-only GPU enumeration.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

In order to implement the patch discussed in https://gitlab.winehq.org/wine/wine/-/merge_requests/5491#note_67907 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5570

4 8

[PATCH v3 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- v3: wined3d: Submit command buffers after 512 draw or dispatch commands. wined3d: Retrieve the VkCommandBuffer from wined3d_context_vk after executing RTV barriers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

4 4

[PATCH v3 0/1] MR5589: ntdll: Don't restore PC from LR after unwinding through frame switches.
by Billy Laws (＠bylaws) 28 May '24

28 May '24

Fixes unwinds from within a consolidation callback on ARM64EC, as the context frame could be x64 with UNWOUND_TO_CALL set, in which case LR contains garbage. See: https://github.com/dotnet/runtime/blob/71abc26cf8f14f5d15665d7f580365ddfa29… -- v3: ntdll: Don't restore PC from LR after unwinding through frame switches. https://gitlab.winehq.org/wine/wine/-/merge_requests/5589

2 2

Re: [PATCH v2 0/1] MR5580: ntdll/unix: Fix building on musl by explicitly including asm/ioctls.h
by Fotios Valasiadis (＠fvalasiad) 28 May '24

28 May '24

@zfigura Whoops, my bad! I see Alexandre fixed it for me, thanks! Best of luck! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580#note_69737

1 0

[PATCH v3 0/10] MR5559: include: Fix another 13 typoed GUIDs
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- v3: include: Fix a typoed GUID include: Fix a typoed GUID include: Fix two typoed GUIDs include: Fix two typoed GUIDs include: Fix two typoed GUIDs include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID include: Fix a typoed GUID https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

3 13

Re: [PATCH v2 0/1] MR5587: ntdll: Allocate wow64 environment block within the 32-bit AS. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5587

1 0

Re: [PATCH v2 0/1] MR5581: include: Fix name conflict with access modifier in mfmediaengine.idl. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5581

1 0

Re: [PATCH v2 0/1] MR5580: ntdll/unix: Fix building on musl by explicitly including asm/ioctls.h - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580

1 0

[PATCH 0/1] MR5580: ntdll/unix: Fix building on musl by explicitlyy including asm/ioctls.h
by Fotios Valasiadis (＠fvalasiad) 28 May '24

28 May '24

After commit 898ab8dab19d498c17859f39a55e317ee7e367a5 wine would no longer build on musl. Issue is that apparently TCSETS2 isn't defined when including sys/ioctl.h. A little digging shows that glibc goes ahead and includes asm/ioctls.h in sys/ioctl.h, providing said macro. Musl on the other hand doesn't and relies on bits/ioctl.h, which lacks said macro. Since there is no mention in the manpage about the need to include asm/ioctls.h, uncertain if that's an issue with musl or the manpage, would like some help on that front so I can go open PRs to fix that respectively. Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5580

3 3

[PATCH v34 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v34: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 16

[PATCH 0/1] MR5583: explorer: Fallback to wayland when x11 fails.
by Etaash Mathamsetty (＠etaash.mathamsetty) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5583

2 2

[PATCH v2 0/1] MR5070: win32u: Cache is_virtual_desktop.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

It can be substantially faster in some cases. Notepad++ (with several plugins) start up goes down from around ~1.03 sec to ~0.61 sec on my machine (with wineprefix active). 9b7669592d6f8b40976b571b70f8543777d35167 is what introduced this performance regression. I don't know why exactly, but it made my Notepad++ noticeably slower when launched from a file manager (so it's not just at wineprefix startup overhead), which is very annoying. -- v2: win32u: Cache is_virtual_desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5070

3 7

Re: [PATCH v2 0/2] MR5555: mf/tests: Add some broken tests results. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5555

1 0

2025

2024

2023

2022

wine-gitlab May 2024