May 2024 - wine-gitlab

Re: [PATCH v2 0/2] MR5576: winex11: Avoid leaking foreign window data if it was already created. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5576

1 0

Re: [PATCH v2 0/1] MR5575: winex11: Don't call x11drv_xinput2_disable for foreign windows. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5575

1 0

Re: [PATCH v4 0/1] MR5562: wined3d: Added missing GTX 3080 & 1070M - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5562

1 0

Re: [PATCH v3 0/1] MR5577: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5577

1 0

Re: [PATCH v2 0/1] MR5572: winemac.drv: Fix use-after-free in macdrv_copy_pasteboard_types. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5572

1 0

[PATCH v2 0/1] MR5577: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- v2: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl. https://gitlab.winehq.org/wine/wine/-/merge_requests/5577

3 3

[PATCH v6 0/4] MR5459: mfreadwrite: Implement D3D awareness support with the video processor.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v6: mfreadwrite/reader: Pass the device manager to the stream transforms. winegstreamer/video_processor: Implement D3D awareness. mf/tests: Test video processor D3D11 awareness. mfreadwrite/tests: Add some source reader D3D11 awareness tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5459

2 5

[PATCH 0/1] MR5577: winhttp: Use GlobalAlloc to allocate lpszProxy in WinHttpGetProxyForUrl.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5577

3 3

[PATCH 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

4 13

[PATCH v4 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) 28 May '24

28 May '24

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v4: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications user32: Add tests for WM_INPUT_DEVICE_CHANGE messages https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

3 4

[PATCH 0/3] MR5383: oleaut32: Load bitmap as DIB.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5383

3 8

[PATCH 0/1] MR5572: winemac.drv: Fix use-after-free in macdrv_copy_pasteboard_types.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

ObjC dictionary literals are autoreleased, meaning BitmapOutputTypeMap was released at the end of the first call to macdrv_copy_pasteboard_types. Any call after that was liable to crash, depending on whether it was overwritten. More complex objects on the clipboard (like a file copied in the Finder) seemed to trigger a crash, which manifested as explorer.exe taking 100% of CPU (since the main thread crashed, then the SEGV handler crashed because it's not a Wine thread). Fixes a regression from bb2e02ab66c5c602d635722cf3a5820d6b366006. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5572

3 4

[PATCH v3 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56576 -- v3: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5523

2 2

[PATCH v3 0/1] MR5333: vcruntime140_1: Pass original frame to catch block on stack.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56451 local variables with alignas(32) or higher may cause the unwinding code to fetch the original frame from a different spot on the stack from where the catch block code places it -- v3: vcruntime140_1: Pass original frame to catch block on stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/5333

3 3

Re: [PATCH v3 0/1] MR5568: windowscodecs: Avoid implicit cast changing value. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

1 0

Re: [PATCH v2 0/5] MR5571: win32u: Post device arrival messages in NtUserRegisterRawInputDevices. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5571

1 0

Re: [PATCH v2 0/1] MR5569: win32u: Fix corrupted list in vulkan_detach_surfaces. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5569

1 0

Re: [PATCH v2 0/1] MR5565: msvcp140_atomic_wait: Implement __std_*_crt(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5565

1 0

Re: [PATCH v12 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5060

1 0

Re: [PATCH v2 0/1] MR5566: pdh: Add PdhConnectMachineA stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5566

1 0

Re: [PATCH v2 0/1] MR5567: shell32: Add SHAssocEnumHandlersForProtocolByApplication stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5567

1 0

[PATCH v2 0/1] MR5568: windowscodecs: Avoid implicit cast changing value.
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

This appear to be introduced with commit 12f73ed9d851. When This->stride is negative (bottom up image) it converts the multiplication to an UINT. Thus causing the pointer to be incorrect when y > 0. -- v2: windowscodecs: Avoid implicit cast changing value. https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

5 4

[PATCH 0/5] MR5571: win32u: Post device arrival messages in NtUserRegisterRawInputDevices.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Superseding https://gitlab.winehq.org/wine/wine/-/merge_requests/2120 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5571

4 7

[PATCH 0/1] MR5569: win32u: Fix corrupted list in vulkan_detach_surfaces.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5569

3 2

[PATCH 0/1] MR5568: windowscodecs: Avoid implicit cast changing value.
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

This appear to be introduced with commit 12f73ed9d851. When This->stride is negative (bottom up image) it converts the multiplication to an UINT. Thus causing the pointer to be incorrect when y > 0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

3 2

[PATCH 0/1] MR5565: msvcp140_atomic_wait: Implement __std_*_crt().
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

OpenImageViewer also requires some __std_tzdb functions to make the image properties menu work (but that is for another MR). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5565

4 3

[PATCH 0/5] MR5564: mmdevapi: Adjust timing in AudioClient_Initialize, removing related code from drivers.
by Davide Beatrici (＠davidebeatrici) 28 May '24

28 May '24

Trace output with PulseAudio: ``` 0230:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0230:trace:mmdevapi:adjust_timing Device periods: 100000 default and 30000 minimum 0230:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5564

2 6

Re: [PATCH v4 0/5] MR5551: win32u: Get rid of most drivers vulkan surface wrappers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5551

1 0

Re: [PATCH v3 0/1] MR5563: mshtml: Move iface_wrapper_t IUnknown implementation to htmlobject.c. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5563

1 0

Re: [PATCH v3 0/1] MR5540: wined3d: Added missing GTX 1650 - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5540

1 0

Re: [PATCH v6 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l](). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

1 0

Re: [PATCH v3 0/1] MR5494: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5494

1 0

Re: [PATCH v10 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

1 0

Re: [PATCH v4 0/2] MR5560: winegstreamer: Fix wow64 support for wg_parser_connect - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5560

1 0

Re: [PATCH v4 0/3] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

1 0

Re: [PATCH v2 0/1] MR5540: wined3d: Added missing GTX 1650 - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5540

1 0

[PATCH 0/1] MR5562: wined3d: Added missing GTX 3080 & 1070M
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5562

3 2

[PATCH v5 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- v5: msvcrt: Implement _mbsncpy_s[_l](). https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

4 5

[PATCH v3 0/5] MR5551: win32u: Get rid of most drivers vulkan surface wrappers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: winex11: Remove now unnecessary surface wrapper struct. win32u: Move thread detach from winex11. win32u: Introduce a per-window vulkan surface list. winewayland: Get rid of the now unnecessary surface wrapper. win32u: Return the host surface directly from vulkan_surface_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/5551

4 8

Re: [PATCH v2 0/1] MR5549: winegstreamer/wg_parser: add wow64 func for wg_parser_connect
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

Included in https://gitlab.winehq.org/wine/wine/-/merge_requests/5560. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5549#note_69336

1 0

Re: [PATCH v2 0/1] MR5549: winegstreamer/wg_parser: add wow64 func for wg_parser_connect - closed
by Johnson Peter (＠peterjc123) 28 May '24

28 May '24

This merge request was closed by Johnson Peter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5549

1 0

Re: [PATCH v9 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

On Wed May 1 00:08:18 2024 +0000, Alistair Leslie-Hughes wrote: > That's really not a solution. This was working without issues for many > years. So, forcing our users to upgrade our product isn't always an option. > Also, how backward compatible is that solution going to be? We still > have users on *cough* wine 5, will it work for them? Can you tell me what the actual use case is? I believe the bug report is about `start.exe`, which this MR should fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5400#note_69335

1 0

[PATCH v9 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v9: win32u: Introduce a new add_virtual_modes helper. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

3 5

[PATCH 0/1] MR5559: include: Fix another 13 typoed GUIDs
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

4 5

Re: [PATCH v33 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos. - approved
by Huw Davies (＠huw) 28 May '24

28 May '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

1 0

[PATCH 0/1] MR5556: msvcr80/tests: Fix errno access in tests.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5556

2 3

[PATCH v4 0/2] MR5547: msvcrt: Implement _mbsncpy_s[_l]().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

ucrtbase._mbsncpy_s is used by Marvel vs Capcom when trying to create multiplayer lobby. The functions are also present in msvcrt (unlike msvcr70, msvcr71) where I didn't add it because it behaves differently: there is at least one weirdness when it doubles the number of characters to copy ('n' parameter, not buffer size). I suppose we don't need to explore and deal with this specific until something needs those functions from msvcrt. -- v4: msvcrt: Implement _mbsncpy_s[_l](). https://gitlab.winehq.org/wine/wine/-/merge_requests/5547

4 5

[PATCH v3 0/3] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

At least CryptSetKeyParam(KP_X) should accept NULL pbData. -- v3: advapi32: CryptSetKeyParam() should accept NULL pbData. rsaenh: Validate pbData in CPSetKeyParam(). dssenh: Add CPSetKeyParam() stub implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

4 6

[PATCH v2 0/3] MR5535: advapi32: CryptSetKeyParam() should accept NULL pbData.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

At least CryptSetKeyParam(KP_X) should accept NULL pbData. -- v2: advapi32: CryptSetKeyParam() should accept NULL pbData. rsaenh: Validate pbData in CPSetKeyParam(). dssenh: Add CPSetKeyParam() stub implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5535

4 6

[PATCH v8 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v8: win32u: Introduce a new add_virtual_modes helper. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. win32u: Set the virtual desktop display frequency to 60Hz. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

4 8

2025

2024

2023

2022

wine-gitlab May 2024