May 2024 - wine-gitlab

Re: [PATCH v2 0/1] MR5515: mfreadwrite: Store result of object activation in stream transform. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5515

1 0

Re: [PATCH v2 0/3] MR5505: wined3d: Introduce the "glsl-vkd3d" shader backend. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5505

1 0

Re: [PATCH v2 0/2] MR5511: winegstreamer: Respond to URI query. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5511

1 0

Re: [PATCH v2 0/5] MR5504: winegstreamer: Merge wg_format video fields together. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5504

1 0

Re: [PATCH v2 0/4] MR5527: d2d1: Update to newer device interfaces. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5527

1 0

Re: [PATCH v2 0/1] MR5526: winevulkan: Allocate commited memory for placed mappings. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5526

1 0

[PATCH v6 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v6: shell32: Restore the ability of running native unix programs with ShellExecute https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

2 4

[PATCH 0/4] MR5481: widl: Make automatic dispid generation scheme better match what midl does.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5481

4 7

[PATCH v2 0/6] MR5517: Draft: RFC: Move wglDescribePixelFormat implementation to opengl32
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

As an intermediate step on the way to !5388, I wanted to focus on the infrastructure that will allow us to pass pixel format information from the driver to the PE side. This MR introduces the mechanism to perform this information exchange and uses it to implement `wglDescribePixelFormat` on the PE side. In the current RFC state this MR: 1. Introduces `p_get_pixel_format` driver API to allow drivers to provide pixel format information. 2. Implements `wglDescribePixelFormat` on the PE side using the pixel format information. If the driver doesn't implement `p_get_pixel_format` we fall back to the `wglDescribePixelFormat` driver implementation (temporary measure until all drivers are updated). 3. Caches pixel format information in `NtCurrentTeb()->glReserved1[]`. 4. Implements `p_get_pixel_format` API and removes the custom `wglDescribePixelFormat` for winewayland. At this point would like to get some more feedback about this approach and the technical details. If the direction seems promising, here are the next steps to get to a final MR: 1. Implement `p_get_pixel_format` for winex11, winemac and dibdrv and remove their custom `wglDescribePixelFormat` implementations. 2. Remove the `wglDescribePixelFormat` driver API. Thanks! -- v2: winex11.drv: Remove unnecessary parameter from describe_pixel_format. winex11.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. winewayland.drv: Enable wglDescribePixelFormat through p_get_pixel_formats. opengl32: Cache driver pixel format information. opengl32: Implement wglDescribePixelFormat using new driver API get_pixel_formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5517

3 11

[PATCH v4 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v4: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

2 2

[PATCH v3 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v3: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

3 4

[PATCH 0/1] MR5515: mfreadwrite: Store result of object activation in stream transform.
by Danyil Blyschak (＠blyss) 28 May '24

28 May '24

In source_reader_create_transform(), store the result of IMFActivate_ActivateObject() so that in the event of failure, resources are freed and an appropriate HRESULT is returned. Previously, if every object's activation failed, the last part of the function was not aware of this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5515

5 5

[PATCH 0/3] MR5505: wined3d: Introduce the "glsl-vkd3d" shader backend.
by Henri Verbeet (＠hverbeet) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5505

3 4

[PATCH 0/1] MR5490: setupapi: Don't set RequiredSize when SetupDiGetClassDescription* fails.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Discovered while investigating Bug 56551. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5490

3 2

[PATCH 0/2] MR5511: winegstreamer: Respond to URI query.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

The default behaviour for gstreamer is to use the URI to create the stream-id. Without this, gstreamer creates a random stream-id per pad which can cause inconsistent ordering on the decodebin src pads. This in turn can cause issues, for example, with audio stream selection. The first commit is a partial cherry-pick of eda34f74c6ad from Proton. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5511

3 4

[PATCH 0/5] MR5504: winegstreamer: Merge wg_format video fields together.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5504

3 7

Re: [PATCH v2 0/1] MR5525: shell32/shellpath: fix UserPinned and QuickLaunch KnownFolderPaths. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5525

1 0

Re: [PATCH v3 0/1] MR5518: windowscodecs: Support 32-bit ABGR bitfields bitmaps. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5518

1 0

Re: [PATCH v2 0/1] MR5524: mscoree: Update Wine Mono to 9.1.0. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5524

1 0

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Shmerl (＠shmerl) 28 May '24

28 May '24

On Mon Apr 22 09:02:12 2024 +0000, Alexandros Frantzis wrote: > Hi @shmerl, I have already reviewed and approved this MR (and cannot > merge myself). I guess it has fallen through the cracks, or perhaps > @julliard and/or @rbernon would like to review themselves? Yeah, may be some mix up about who can approve it for the final merge. See [here](https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_65890) > It's perhaps instead that approval only show up if the person is assigned as a reviewer, or that it was overlooked. It would be good to merge it for the next release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68466

1 0

[PATCH v2 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- v2: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

3 4

[PATCH 0/4] MR5517: Draft: RFC: Move wglDescribePixelFormat implementation to opengl32
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

As an intermediate step on the way to !5388, I wanted to focus on the infrastructure that will allow us to pass pixel format information from the driver to the PE side. This MR introduces the mechanism to perform this information exchange and uses it to implement `wglDescribePixelFormat` on the PE side. In the current RFC state this MR: 1. Introduces `p_get_pixel_format` driver API to allow drivers to provide pixel format information. 2. Implements `wglDescribePixelFormat` on the PE side using the pixel format information. If the driver doesn't implement `p_get_pixel_format` we fall back to the `wglDescribePixelFormat` driver implementation (temporary measure until all drivers are updated). 3. Caches pixel format information in `NtCurrentTeb()->glReserved1[]`. 4. Implements `p_get_pixel_format` API and removes the custom `wglDescribePixelFormat` for winewayland. At this point would like to get some more feedback about this approach and the technical details. If the direction seems promising, here are the next steps to get to a final MR: 1. Implement `p_get_pixel_format` for winex11, winemac and dibdrv and remove their custom `wglDescribePixelFormat` implementations. 2. Remove the `wglDescribePixelFormat` driver API. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5517

3 7

[PATCH v5 0/3] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v5: shell32: Restore the ability of running native unix programs with ShellExecute https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

5 11

[PATCH 0/10] MR5508: Draft: winestreamer/video_decoder: Use video_decoder to implement wmv decoder.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

based on !5504 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5508

4 13

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

On Mon Apr 22 09:02:12 2024 +0000, Shmerl wrote: > @afrantzis: A gentle ping. Can you please review and merge this? Hi @shmerl, I have already reviewed and approved this MR (and cannot merge myself). I guess it has fallen through the cracks, or perhaps @julliard and/or @rbernon would like to review themselves? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68401

1 0

[PATCH v2 0/1] MR5518: windowscodecs: Support 32-bit ABGR bitfields bitmaps.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- v2: windowscodecs: Support 32-bit ABGR bitfields bitmaps. https://gitlab.winehq.org/wine/wine/-/merge_requests/5518

3 3

Re: [PATCH v8 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by Shmerl (＠shmerl) 28 May '24

28 May '24

@afrantzis: A gentle ping. Can you please review and merge this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5178#note_68246

1 0

[PATCH 0/1] MR5518: windowscodecs: Support 32-bit ABGR bitfields bitmaps.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5518

3 2

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

> > > I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. > > Maybe, yeah. Though I'd be surprised if a ddraw application did that... That was basically the original idea behind vertex buffers: to hold static data in video memory so that's faster to access by the GPU (mostly in the sense of avoiding data transfers from SYSMEM). Similar idea behind ProcessVertices(). If you wanted to draw with dynamic data, you'd use the non-VB Draw[Indexed]Primitive variant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68209

1 0

[PATCH 0/1] MR5519: setupapi: use INF parser to read class GUID and class name
by Tuomas Räsänen (＠tuomasjjrasanen) 28 May '24

28 May '24

Previously, `SetupDiGetINFClassW()` read INF files with `GetPrivateProfileString()`, which does not substitute %strkey% tokens. This caused device installation to fail for devices which had driver INF files using %strkey% tokens in Version section. An example of such device is Vernier LabQuest Mini (08f7:0008) for which Vernier's LoggerPro application includes a driver. The INF file in question adds a new device setup class and has following entries in Version section: ``` Class = %ClassName% ClassGuid = %DeviceClassGUID% ``` Strings section includes following entries: ``` DeviceClassGUID = "{6B8429BF-10AD-4b66-9FBA-2FE72B891721}" ClassName = "VST_WinUSB" ``` Previously, when LoggerPro was installed and LabQuest Mini was hotplugged, device installation failed with the following error: ``` fixme:setupapi:SetupDiGetINFClassW failed to convert "L"%DeviceClassGUID"" into a guid ``` This caused GUID_NULL to be used and Class was not set to the registry for the device. With this commit, correct class GUID and names are set to the device registry entry. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56579 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5519

3 2

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

> It may be worth including a call to GetVertexBufferDesc() in the tests. As Matteo mentioned in an earlier comment, the docs seem to suggest that omitting D3DVBCAPS_SYSTEMMEMORY allows the driver/runtime to place the buffer as it sees fit. I mentioned earlier that GetVertexBufferDesc() never returns anything other than the flags used to create the buffer. That holds for both cards. I'll add a test the the suite. > I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. Maybe, yeah. Though I'd be surprised if a ddraw application did that... > Can you check D3DDEVICEDESC.dwMaxVertexCount on these cards? Regardless of what we do with these two patches I think we should reduce it to whatever Windows reports. (1024 in my case on Windows 11) For both cards, the RGB device has 0 in the HAL caps, and 2021 in the HEL caps. The NVidia card has 32768 (both HAL and HEL), and the ATI card has 2048 (both HAL and HEL). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68208

1 0

[PATCH 0/1] MR5516: wintrust: Add support for the PE image hash in CryptCATAdminCalcHashFromFileHandle().
by Hans Leidekker (＠hans) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5516

4 5

[PATCH v3 0/1] MR5231: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example) on the Linux side can lead to some games under Wine failing to load (so treat that variable as special). -- v3: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

2 2

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Thu Apr 18 23:08:03 2024 +0000, Aida Jonikienė wrote: > Has the memory leak been fixed? 🫗️ Patch 4/5 handles it, yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68162

1 0

Re: [PATCH v2 0/1] MR5513: ntdll: Use mangled function names in ARM64EC assembly. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5513

1 0

Re: [PATCH v9 0/1] MR5188: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

1 0

Re: [PATCH v2 0/2] MR5514: kernel32/tests: fixes for export forwarder test - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5514

1 0

Re: [PATCH v2 0/2] MR5510: light.msstyles: Use #fefefe instead of #ffffff for scrollbar parts. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5510

1 0

Re: [PATCH v4 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Stefan Dösinger (＠stefan) 28 May '24

28 May '24

> At the same time, I haven't seen any evidence that a modern GPU will ever perform better with a vertex buffer not in sysmem unless it's using the streaming pattern I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. Can you check D3DDEVICEDESC.dwMaxVertexCount on these cards? Regardless of what we do with these two patches I think we should reduce it to whatever Windows reports. (1024 in my case on Windows 11) Conceptually the two patches have my blessing though, regardless of specifics of what PoP3D is doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68141

1 0

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

On Thu Apr 18 23:08:03 2024 +0000, Jinoh Kang wrote: > @rbernon Thanks for your review! Right now I'm tentatively putting this > MR on hold until I find a solution for a memory leak: a new (redundant) > dependency edge is added every time the application calls > `GetProcAddress()` on a forwarded ref. Has the memory leak been fixed? 🫗️ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68140

1 0

[PATCH 0/4] MR4424: ntdll: Implement reading multiple entries in NtQueryDirectoryObject. (#52585)
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4424

5 11

Re: [PATCH v8 0/1] MR5188: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. - approved
by Sven Baars (＠sbaars) 28 May '24

28 May '24

This merge request was approved by Sven Baars. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

1 0

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Henri Verbeet (＠hverbeet) 28 May '24

28 May '24

It may be worth including a call to GetVertexBufferDesc() in the tests. As Matteo mentioned in an earlier comment, the docs seem to suggest that omitting D3DVBCAPS_SYSTEMMEMORY allows the driver/runtime to place the buffer as it sees fit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68109

1 0

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Jan Sikorski (＠jsikorski) 28 May '24

28 May '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

[PATCH 0/2] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

6 15

Re: [PATCH v6 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx() - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

1 0

Re: [PATCH v6 0/1] MR5380: netapi32: Add NetRemoteTOD stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5380

1 0

Re: [PATCH v2 0/1] MR5506: gdiplus: Fix IWICBitmapFrameDecode reference leak in decode_frame_wic. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5506

1 0

Re: [PATCH v2 0/1] MR5467: ntdll: Return STATUS_NO_YIELD_PERFORMED from NtYieldExecution() on Linux if no yield was performed. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5467

1 0

2025

2024

2023

2022

wine-gitlab May 2024