May 2024 - wine-gitlab

Re: [PATCH v4 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

Yet another four files with the same "issue": server/change.c, server/thread.c, server/process.c and server/queue.c. This time found by fgrep(1), so no more similar files left in server directory, I believe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_68027

1 0

Re: [PATCH v3 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

It turned out that the `master_socket_fd_ops` in server/request.c has the same "issue". Therefore, 1c68e8ed960 (Fix initialization of the master_socket_fd_ops, 2024-04-17) was added into this merge request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_68012

1 0

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

Re: [PATCH v2 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

I've just get-rebase(1)'d my branch, because it was outdated comparing to the \`master' branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67986

1 0

[PATCH v6 0/1] MR5369: winegstreamer: Refactor wg_format.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

Since we are adding more and more media formats to wg_format, the current wg_format struct is getting ugly. Everytime we add a video format, we need to duplicate width, height, fps. Everytime we add a audio format, we need to duplicate channels, rate. So it would be better if we could share width, height, fps fields between different video formats, also share channels and rate fields between different audio formats. What makes me found the current wg_format is not in a good shape is when I was writting code for Proton, I found that I need to write some code like this if want to get width/height/fps from a wg_format: ``` static bool get_video_info_from_wg_format(struct wg_format *format, int32_t *width, int32_t *height, uint32_t *fps_n, uint32_t *fps_d) { switch (format->major_type) { case WG_MAJOR_TYPE_VIDEO: *width = format->u.video.width; *height = format->u.video.height; *fps_n = format->u.video.fps_n; *fps_d = format->u.video.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_CINEPAK: *width = format->u.video_cinepak.width; *height = format->u.video_cinepak.height; *fps_n = format->u.video_cinepak.fps_n; *fps_d = format->u.video_cinepak.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_H264: *width = format->u.video_h264.width; *height = format->u.video_h264.height; *fps_n = format->u.video_h264.fps_n; *fps_d = format->u.video_h264.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_WMV: *width = format->u.video_wmv.width; *height = format->u.video_wmv.height; *fps_n = format->u.video_wmv.fps_n; *fps_d = format->u.video_wmv.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_INDEO: *width = format->u.video_indeo.width; *height = format->u.video_indeo.height; *fps_n = format->u.video_indeo.fps_n; *fps_d = format->u.video_indeo.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_MPEG1: *width = format->u.video_mpeg1.width; *height = format->u.video_mpeg1.height; *fps_n = format->u.video_mpeg1.fps_n; *fps_d = format->u.video_mpeg1.fps_d; return true; default: GST_ERROR("Type %d is not a video format.\n", format->major_type); return false; } } ``` Apparently, the code above is ugly. By refactoring wg_format, we can avoid code like this. This patch is a draft now, it only contains unixlib.h code. Zeb, I'd like to confirm that if this refactoring would be acceptable for you. If do, I'll continue finishing the remaining parts. -- v6: winegstreamer: Refactor wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/5369

4 8

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

On Tue Apr 16 22:41:34 2024 +0000, Elizabeth Figura wrote: > This is now causing a test failure in test_swapchain_resize() due to a > no longer skipped test; I imagine we want to add a todo_wine there (and > possibly change the skip to a win_skip). Thanks, that should be fixed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484#note_67974

1 0

Re: [PATCH v2 0/2] MR5501: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5501

1 0

Re: [PATCH v8 0/8] MR5419: quartz: Fixes for the BURIKO visual novel engine's videos - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5419

1 0

Re: [PATCH v3 0/4] MR5471: wined3d: Dynamic pipeline state, part 3: EXT_extended_dynamic_state3. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5471

1 0

Re: [PATCH v4 0/3] MR5438: winegstreamer: Merge audio field togther. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5438

1 0

Re: [PATCH v3 0/1] MR5454: winegstreamer: Ensure stream format change notification on size change in h264 decoder. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5454

1 0

Re: [PATCH v2 0/4] MR5476: winegstreamer: Introduce new wg_transform buffer copy helpers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5476

1 0

Re: [PATCH v2 0/1] MR5495: explorer: Fix font handle leaks in virtual desktop. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5495

1 0

[PATCH v2 0/1] MR5426: user32/tests: Mark test todo only on Mac and X11 drivers.
by Esme Povirk (＠madewokherd) 28 May '24

28 May '24

-- v2: user32/tests: Mark test todo only on Mac and X11 drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5426

4 4

Re: [PATCH 0/6] MR5503: Fix initialization of the handler_fd_ops
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

On Tue Apr 16 19:49:05 2024 +0000, Ruslan Garipov wrote: > > I don't know if there is anything preventing using them in the server > Should I update my patch using designated initializers? That would be a question for @julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67941

1 0

Re: [PATCH 0/6] MR5503: Fix initialization of the handler_fd_ops
by Ruslan Garipov (＠ruslangaripov) 28 May '24

28 May '24

> I don't know if there is anything preventing using them in the server Should I update my patch using designated initializers? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67940

1 0

Re: [PATCH 0/6] MR5503: Fix initialization of the handler_fd_ops
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Designated initializers will make this more readable and easier to verify. We are using them in various places now, including parts built as unixlibs. I don't know if there is anything preventing using them in the server, apart from being in different style. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5503#note_67938

1 0

[PATCH v4 0/5] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v4: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

3 9

[PATCH v2 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- v2: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

4 22

Re: [PATCH v2 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

On Tue Apr 16 14:47:32 2024 +0000, Elizabeth Figura wrote: > 1/3 is unfortunately causing some (strange) test failures here: > 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 5 > 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 1 > amstream.c:512: Test failed: Got hr 0. > I see this on the CI too. Got it. I'll take a look. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430#note_67920

1 0

[PATCH v2 0/2] MR5502: notepad: Use wide character string literals
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

-- v2: notepad: Use wide character string literals in dialog.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/5502

3 3

[PATCH 0/1] MR5495: explorer: Fix font handle leaks in virtual desktop.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56133 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5495

3 2

[PATCH v2 0/4] MR5471: wined3d: Dynamic pipeline state, part 3: EXT_extended_dynamic_state3.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v2: wined3d: Use dynamic state for rasterizer state if possible. wined3d: Use dynamic state for blend state if possible. wined3d: Use dynamic state for multisample state if possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/5471

4 6

Re: [PATCH v2 0/5] MR5493: Extend minidump support in winedump. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5493

1 0

Re: [PATCH v13 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/364

1 0

Re: [PATCH v4 0/4] MR5488: win32u: Add display device cache modes all at once. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

1 0

Re: [PATCH v2 0/1] MR5489: win32u: Also reset the unnamed values in prepare_devices. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5489

1 0

Re: [PATCH v2 0/2] MR5492: Embed thread names in minidump. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5492

1 0

Re: [PATCH v3 0/1] MR5499: mscms: Add stub for WcsGetDefaultColorProfile. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5499

1 0

Re: [PATCH v3 0/1] MR5498: krnl386.exe16: Start DOSVM timer on GET_SYSTEM_TIME - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5498

1 0

Re: [PATCH v3 0/3] MR5438: winegstreamer: Merge audio field togther. - approved
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5438

1 0

[PATCH v2 0/1] MR5454: winegstreamer: Ensure stream format change notification on size change in h264 decoder.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: winegstreamer: Destroy wg_transform in video_decoder/transform_SetInputType(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5454

4 4

Re: [PATCH v2 0/2] MR5430: winegstreamer: Seek to the end after MPEG splitter connection.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

1/3 is unfortunately causing some (strange) test failures here: 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 5 00f0:fixme:quartz:mpeg_splitter_filter_init_gst unexpected format 1 amstream.c:512: Test failed: Got hr 0. I see this on the CI too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430#note_67851

1 0

[PATCH 0/4] MR5476: winegstreamer: Introduce new wg_transform buffer copy helpers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5055. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5476

3 5

[PATCH v2 0/6] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. ntdll/tests: Work around exception test failures on Wine WoW. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

3 11

[PATCH 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

Microsoft Flight Simulator (2020) requires IDXGISwapChain4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

4 5

[PATCH v11 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 28 May '24

28 May '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v11: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

4 6

[PATCH 0/10] MR4652: wined3d: A few more old-GL fixes.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

Here are 5 more patches on top of !4624, mostly along the same lines. I realize it's super late, no need to rush reviewing :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4652

4 16

[PATCH 0/1] MR5494: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Should help with Overwatch 2 random crashes after some time of playing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5494

3 4

Re: [PATCH v3 0/3] MR5500: d3d9: Add a few swapchain tests
by Robin Kertels (＠K0bin) 28 May '24

28 May '24

Thanks for the review. > They fail on my Windows XP box, r250 GPU, see the attached log file. It seems that It doesn't follow the alpha = 0xff behavior of newer GPUs and just returns alpha 0x0 in either case. The window positioning test needlessly depends on it. If I mask out the alpha channel in test_get_front_buffer_data_windowed_positioning() it passes. Interesting. I'd be perfectly fine with dropping the separate alpha test entirely. I also meant to mask out the alpha but I guess I forgot it there or lost it during rebase/cleanup. > if (foo) { something(); } > Please put the { on a new line consistently. Ah, I'm trying. I thought I got it right but I guess old habits die hard. I use the same line { in every other project, so not surprised that I slipped up a couple of times. I'll fix that. > test_swapchain_buffer_swapping() and test_get_front_buffer_data_alpha() leak your initial device, the one you use to populate present_parameters > In the case of test_swapchain_buffer_swapping I don't see why you need to call IDirect3D9::CreateDevice yourself - what prevents you from using the device returned by create_device? Oops, that's a leftover of my original approach. I originally meant to create a new device for each test case and pass the required presentation params but later changed it to just use a single device created using `create_device` and reset that as needed. I meant to get rid of the second device that's created manually. I will also look into using the current monitor resolution for the fullscreen tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500#note_67838

1 0

[PATCH 0/2] MR5501: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub.
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Refer to !5269 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5501

4 9

Re: [PATCH v3 0/3] MR5500: d3d9: Add a few swapchain tests
by Stefan Dösinger (＠stefan) 28 May '24

28 May '24

The tests pass on my Windows 11 machine with a Radeon 560 GPU. They fail on my Windows XP box, r250 GPU, see the attached log file. It seems that It doesn't follow the alpha = 0xff behavior of newer GPUs and just returns alpha 0x0 in either case. The window positioning test needlessly depends on it. If I mask out the alpha channel in test_get_front_buffer_data_windowed_positioning() it passes. I haven't looked closely at the code yet - I see some style inconsistencies, like if (foo) { something(); } Please put the { on a new line consistently. Rather than hardcoding the positions to check in the windowed mode tests please call GetWindowRect after creating the device and calculate the checked positions relative to it. There are window managers on the Linux side that don't allow applications to decide their placement and will break this kind of test. I suspect fvwm2 will cause you trouble otherwise. test_swapchain_buffer_swapping() and test_get_front_buffer_data_alpha() leak your initial device, the one you use to populate present_parameters. The other unfortunate side effect of initializing present_parameters like that is that you switch the screen to 640x480 fullscreen mode. I recommend to use EnumDisplaySettingsW(ENUM_CURRENT_SETTINGS) to retrieve the current mode and use it to create a fullscreen device that doesn't change the mode. Changing the mode moves around Windows on Windows 10/11 and most Linux desktops. In the case of test_swapchain_buffer_swapping I don't see why you need to call IDirect3D9::CreateDevice yourself - what prevents you from using the device returned by create_device? [r200-xp.txt](/uploads/5f577583ec5703e2a040077de884faf3/r200-xp.txt) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500#note_67826

1 0

[PATCH v2 0/1] MR5499: mscms: Add stub for WcsGetDefaultColorProfile.
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56554 -- v2: mscms: Add stub for WcsGetDefaultColorProfile. https://gitlab.winehq.org/wine/wine/-/merge_requests/5499

3 2

[PATCH v3 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. This will also make it easier to write the mode list to the registry as a single binary blob, although it is a larger change that could be done later. -- v3: win32u: Add all display device source modes at once. win32u: Keep the primary current mode in the device manager context. win32u: Remove fake source creation when adding display mode. win32u: Close device manager source key in write_source_to_registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

3 5

[PATCH 0/6] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

4 9

[PATCH v4 0/2] MR5269: Add NtQueryInformationProcess(ProcessQuotaLimits) stub
by Gijs Vermeulen (＠gverm) 28 May '24

28 May '24

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 -- v4: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) tests. ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/5269

5 8

[PATCH v5 0/2] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- v5: wow64: Add NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

2 3

[PATCH v3 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

Should resolve a crash in `libogg` in the game "Cabal Online" -- v3: ntdll: Implement NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

3 2

Re: [PATCH v8 0/2] MR2552: wineboot: Add env variable to hide wait window - closed
by Isaac Marovitz (＠IsaacMarovitz) 28 May '24

28 May '24

This merge request was closed by Isaac Marovitz. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2552

1 0

[PATCH 0/10] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

4 26

2025

2024

2023

2022

wine-gitlab May 2024