May 2024 - wine-gitlab

Re: [PATCH v8 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

v8: - Remove all new TESTDLLs (forward*.dll, sforward.dll) - Generate all test DLLs in runtime -- https://gitlab.winehq.org/wine/wine/-/merge_requests/364#note_67735

1 0

[PATCH v2 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. This will also make it easier to write the mode list to the registry as a single binary blob, although it is a larger change that could be done later. -- v2: win32u: Add all display device source modes at once. win32u: Keep the primary current mode in the device manager context. win32u: Remove fake source creation when adding display mode. win32u: Close device manager source key in write_source_to_registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

3 6

[PATCH 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

3 10

[PATCH 0/1] MR5489: win32u: Also reset the unnamed values in prepare_devices.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56551 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5489

3 2

Re: [PATCH v3 0/1] MR5445: mmdevapi: Implement SAC_IsAudioObjectFormatSupported(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5445

1 0

Re: [PATCH v2 0/1] MR5486: makedep: Use hybrid ARM64X images for ARM64EC. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5486

1 0

Re: [PATCH v5 0/3] MR5462: Ucrtbase's stderr is now always unbuffered. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

1 0

Re: [PATCH v2 0/1] MR5479: imm32: Add CtfImmIsCiceroEnabled stub - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5479

1 0

Re: [PATCH v2 0/3] MR5485: d2d1: Implement GetEffectProperties(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5485

1 0

Re: [PATCH v2 0/2] MR5487: winemac.drv: Update OpenGL context immediately after the window content view is visible. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5487

1 0

Re: [PATCH v5 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5482

1 0

[PATCH 0/2] MR5487: winemac.drv: Update OpenGL context immediately after the window content view is visible.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Fix errors such as GL_FRAMEBUFFER_UNDEFINED and GL_INVALID_FRAMEBUFFER_OPERATION for OpenGL functions when the default framebuffer 0 is bound on macOS. These errors happen because the NSOpenGLContext doesn't have a view bound at the time of an OpenGL call. The view could not be set for the NSOpenGLContext because the window or view can still be invisible. Setting an invisible view for the NSOpenGLContext can generate invalid drawable messages as 682ed910 has shown. Thus setting the view could be deferred because the NSOpenGLContext needs a visible view. However, right after the window becomes visible, an OpenGL function that involves the default framebuffer can be called. And when the view is still not set at the time of the OpenGL call, errors such as GL_FRAMEBUFFER_UNDEFINED and GL_INVALID_FRAMEBUFFER_OPERATION could happen and result in rendering errors such as black screen. So we need to set the view for the NSOpenGLContext as soon as the view becomes visible. It's possible that the window and view are still invisible when OpenGL functions involving the default framebuffer get called. In such cases, I think errors like GL_FRAMEBUFFER_UNDEFINED are justified on macOS. Fix Active Trader Pro black screen at launch on macOS. The application creates a d3d9 device with an invisible window. And then it shows the window before calling d3d9_swapchain_Present(). So all the [NSOpenGLContext setView] opportunities are missed and no view is set. Then when glBlitFramebuffer() gets called, GL_FRAMEBUFFER_UNDEFINED happens and so nothing is rendered. The application only renders one frame before login so the window remains black. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5487

3 3

[PATCH v4 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This introduces a custom `VkPresentSurfacesInfoWine` struct to the driver queue present. It could very well be a separate vkQueuePresent parameter, now that the driver interface is manually written. For now it provides the swapchains HWND, for vulkan_surface_presented, which is mostly just for winewayland purposes. Later I intend to change it to pass win32u surfaces wrappers. -- v4: winevulkan: Remove now unnecessary vkCreateSwapchainKHR driver entry. winevulkan: Remove now unnecessary vkDestroySwapchain driver entry. win32u: Move vkQueuePresent implementation out of the user drivers. winewayland: Remove now unnecessary swapchain wrapper. winewayland: Remove now unnecessary swapchain extents checks. win32u: Introduce a new vulkan_surface_presented driver entry. winevulkan: Pass surface info for each vkQueuePresent swapchain to win32u. https://gitlab.winehq.org/wine/wine/-/merge_requests/5482

4 10

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Mon Apr 22 12:40:26 2024 +0000, Zhiyi Zhang wrote: > What is this fake source supposed to do now? Virtual desktop has its own > virtual source. Was it ever related to virtual desktop mode? I don't know what it was for, I'm fine dropping it altogether. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67597

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Changing maximum to primary seems more appropriate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67594

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Calling write_current_mode() in add_gpu seems weird. Not to mention write_current_mode() actually writes the current mode for the last source. write_current_mode() is also called at multiple places. It just seems that it should be called at one appropriate place and that's it. Also, why is this patch necessary? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67593

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

'add_physical_source' here just doesn't look consistent with other functions in device_manager. Maybe add a "BOOL is_physical" or something in struct device_manager_ctx so that when both is_physical and is_virtual_desktop() are TRUE we report sources as detached. Then we set is_physical to FALSE and start adding sources for the virtual desktop. Use your best judgment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67592

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

What's the point of writing these modes for physical sources/monitors? We are not going to use them anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67591

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Put this to where the old update_display_devices() was so the diff is clearer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67590

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

I don't think These physical sources should be visible in EnumDisplayDevices(). If you report a physical source, doesn't that mean I can attach it? by calling ChangeDisplaySettings() with a valid mode? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67589

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

What is this fake source supposed to do now? Virtual desktop has its own virtual source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67588

1 0

Re: [PATCH v3 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers.
by Jacek Caban (＠jacek) 28 May '24

28 May '24

> It could very well be a separate vkQueuePresent parameter, now that the driver interface is manually written. I think it would be nicer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5482#note_67565

1 0

[PATCH 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This introduces a custom `VkPresentSurfacesInfoWine` struct to the driver queue present. It could very well be a separate vkQueuePresent parameter, now that the driver interface is manually written. For now it provides the swapchains HWND, for vulkan_surface_presented, which is mostly just for winewayland purposes. Later I intend to change it to pass win32u surfaces wrappers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5482

2 9

[PATCH v3 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: win32u: Split virtual desktop modes to a add_virtual_modes helper. win32u: Delay writing current display settings to the registry. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

3 9

[PATCH 0/1] MR5418: winewayland: Move wayland_surface_ensure_contents to wayland_vkCreateWin32SurfaceKHR.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

I would like to get rid of the driver-specific swapchain code and this is getting in the way. Any reason not to do that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5418

3 11

[PATCH 0/1] MR5479: imm32: Add CtfImmIsCiceroEnabled stub
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56538 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5479

4 4

[PATCH v30 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v30: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

4 24

Re: [PATCH v2 0/3] MR5478: winegcc/winebuild: Add -marm64x option support. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5478

1 0

Re: [PATCH v2 0/1] MR5452: winegstreamer: Try to handle broken IStream_Stat implementation in WM reader OpenStream(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5452

1 0

Re: [PATCH v8 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427

1 0

Re: [PATCH v2 0/1] MR5468: windows.ui: Return success in IInputPane2::TryShow(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5468

1 0

Re: [PATCH v2 0/3] MR5469: d2d1/effect: Zero value buffer on size or type mismatch. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5469

1 0

Re: [PATCH v2 0/5] MR5465: winevulkan: Introduce a vkQueuePresent wrapper and return VK_SUBOPTIMAL_KHR after resize. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5465

1 0

Re: [PATCH v3 0/2] MR5460: mfmediaengine: Allow decoders to be resolved before optional effect nodes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5460

1 0

Re: [PATCH v2 0/4] MR5458: widl: Add support for interfaces to SLTG typelib generator. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5458

1 0

Re: [PATCH v2 0/1] MR5472: winecoreaudio: Correctly handle devices whose UID contains non-ASCII characters. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5472

1 0

Re: [PATCH v2 0/2] MR5473: wow64: Mind generic xstate in a couple of missed places. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5473

1 0

Re: [PATCH v2 0/3] MR5474: winhttp: Receive response timeout and connection caching. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5474

1 0

Re: [PATCH v2 0/1] MR5475: msi: Install global assemblies before running deferred custom actions. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5475

1 0

Re: [PATCH v2 0/3] MR5477: msi/tests: Try restarting tests elevated. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5477

1 0

Re: [PATCH v7 0/5] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5464

1 0

[PATCH v4 0/3] MR5462: Ucrtbase's stderr is now always unbuffered.
by eric pouech (＠epo) 28 May '24

28 May '24

Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered whatever the type of the underlying fd (previously, native only set it to unbuffered when attached to character fd (console, NUL...)). This serie adds also tests for msvcrt & ucrtbase to show the discrepancies. Note: ucrtbase's tests also include a reversed engineered structure layout for FILE. _get_stream_buffer_pointers already gives base, ptr and cnt, and toying with setvbuf gave easily the rest of the fields. Didn't spend time in guessing the flags meaning: which look different from msvcrt's. Related to https://bugs.winehq.org/show_bug.cgi?id=56459 @piotr: I can share the details (the access to the test result in the bug report is limited). -- v4: ucrtbase: Let stderr be always be unbuffered. ucrtbase/tests: Add tests for checking buffering state of standard streams. msvcrt/tests: Add tests for check buffering state of standard streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

3 4

[PATCH 0/4] MR5471: wined3d: Dynamic pipeline state, part 3: EXT_extended_dynamic_state3.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5471

5 10

[PATCH 0/3] MR5246: cmd/tests: Add tests for calling special excuteable files.
by Haidong Yu (＠yhd986) 28 May '24

28 May '24

Signed-off-by: Haidong Yu <yuhaidong(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5246

4 5

[PATCH v3 0/3] MR5462: Ucrtbase's stderr is now always unbuffered.
by eric pouech (＠epo) 28 May '24

28 May '24

Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered whatever the type of the underlying fd (previously, native only set it to unbuffered when attached to character fd (console, NUL...)). This serie adds also tests for msvcrt & ucrtbase to show the discrepancies. Note: ucrtbase's tests also include a reversed engineered structure layout for FILE. _get_stream_buffer_pointers already gives base, ptr and cnt, and toying with setvbuf gave easily the rest of the fields. Didn't spend time in guessing the flags meaning: which look different from msvcrt's. Related to https://bugs.winehq.org/show_bug.cgi?id=56459 @piotr: I can share the details (the access to the test result in the bug report is limited). -- v3: ucrtbase: Let stderr be always be unbuffered. ucrtbase/tests: Add tests for checking buffering state of standard streams. msvcrt/tests: Add tests for check buffering state of standard streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

3 9

[PATCH v6 0/5] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Wine incorrectly inserts a sample copier. D3D awareness is handled per node, and each node will have their own sample allocator created from the D3D device manager provided by the session. -- v6: mf/tests: Test device manager handling in the topology loader. mf/tests: Test D3D awareness handling in the topology loader. mf/tests: Split topology loader tests to a new file. mf/tests: Fix printf format warning. include: Add MFTOPOLOGY_DXVA_MODE enum definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/5464

4 10

[PATCH v2 0/5] MR5463: mfreadwrite: Test and fix some reference leaks.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

These were probably the cause of crashes of https://gitlab.winehq.org/wine/wine/-/merge_requests/5459 runs on 32bit Linux VMs. Also included some test fixes that were in https://gitlab.winehq.org/wine/wine/-/merge_requests/5459. -- v2: mfreadwrite/reader: Avoid leaking the stream transform service MFT. mfreadwrite/tests: Shutdown the test stream event queues on source shutdown. mfreadwrite/tests: Avoid using MFCreateMediaBufferFromMediaType. mfreadwrite/tests: Do not accept MFVideoFormat_RGB32 in the test transform. mf/tests: Fix printf format warning. https://gitlab.winehq.org/wine/wine/-/merge_requests/5463

2 8

[PATCH 0/3] MR5474: winhttp: Receive response timeout and connection caching.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5474

3 5

[PATCH v5 0/3] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Wine incorrectly inserts a sample copier. D3D awareness is handled per node, and each node will have their own sample allocator created from the D3D device manager provided by the session. -- v5: mf/tests: Test device manager handling in the topology loader. mf/tests: Test D3D awareness handling in the topology loader. include: Add MFTOPOLOGY_DXVA_MODE enum definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/5464

3 8

[PATCH v2 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- v2: wined3d: Submit command buffers that are built for longer than 2 ms. wined3d: Retrieve the VkCommandBuffer from wined3d_context_vk after executing RTV barriers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

7 15

2025

2024

2023

2022

wine-gitlab May 2024