May 2024 - wine-gitlab

[PATCH 0/5] MR5399: mfreadwrite: Pass the D3D device manager to the stream transforms.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5399

3 11

[PATCH 0/2] MR5421: gdiplus: Search microsoft platform names first in load_ttf_name_id().
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Search names in fonts in the order of Microsoft, Mac and finally Unicode platform. This is also the order win32u uses to load font names. Fix Granado Espada Japan (1219160) launcher crashes at start in the Japanese locale. The game ships a font with a broken name record of Mac platform and encoding ID 0 (Roman) but the name string is in code page 10001 (Japanese). This broken name record is placed before the name records for the Microsoft platform so it gets selected first. Then the name … [View More]

5 10

Re: [PATCH v6 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger. - approved
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427

1 0

Re: [PATCH v6 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > Also, in the commit message subject. Not just the MR subject. OK, I think I got it ! I'll keep these in mind for next time. [image](/uploads/233f99f4dd99c94026b9161be7194eb4/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66885

1 0

Re: [PATCH v5 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > We usually add a dot at the end of the message subject. Please do that > as well. Also, in the commit message subject. Not just the MR subject. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66877

1 0

Re: [PATCH v5 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Sam Joan Roque-Worcel wrote: > Woops! That's what you get for coding late at night. I've hopefully > addressed it now We usually add a dot at the end of the message subject. Please do that as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66876

1 0

Re: [PATCH v4 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > Also, https://bugs.winehq.org/show_bug.cgi?id=56485 is the wrong link. > Please delete it from this MR. Woops! That's what you get for coding late at night. I've hopefully addressed it now -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66873

1 0

[PATCH 0/1] MR5432: ddraw: Actually flip in IDirectDrawSurface::Flip().
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5432

7 10

Re: [PATCH v2 0/1] MR5451: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5451

1 0

Re: [PATCH v3 0/4] MR5436: win32u: Replace sprintf with snprintf to avoid deprecation warnings on macOS. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5436

1 0

Re: [PATCH v2 0/1] MR5448: mfreadwrite/reader: Keep the output subtypes when propagating media types. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5448

1 0

Re: [PATCH v2 0/4] MR5446: d2d1/effect: Implement more builtin transform types. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5446

1 0

Re: [PATCH v3 0/2] MR5435: wined3d: Require GLSL 1.20 support. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5435

1 0

Re: [PATCH v4 0/5] MR5397: widl: Add support for structures. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5397

1 0

[PATCH 0/1] MR5447: Add U+FF0B U+25BC U+2715, fix visual issue in Notepad++
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

Addresses this issue: https://bugs.winehq.org/show_bug.cgi?id=53985#add_comment This is done by adding three characters into Tahoma that are missing. I achieved this by replacing the characters with similar shape from within the same font (e.g. + for U+FF0B) or by getting the font from a font that had an open source license (liberation2) in the case of U+25BC. Once I had that done, I regenerated the font by running the following command: ``` fontforge -script fonts/genttf.ff fonts/tahoma.sfd … [View More]

4 4

[PATCH v2 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v2: win32u: Split virtual desktop modes to a add_virtual_modes helper. win32u: Delay writing current display settings to the registry. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

2 6

[PATCH v2 0/4] MR5436: win32u: Replace sprintf with snprintf to avoid deprecation warnings on macOS.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

The call in freetype.c:expand_mac_font() would be a good candidate for asprintf(), but I'm planning to send a patch soon to remove that resource-fork font extraction anyway. -- v2: win32u: Replace sprintf with snprintf to avoid deprecation warnings on macOS. win32u: Use PATH_MAX for Unix paths instead of MAX_PATH (from Win32). win32u: Enlarge buffer size in format_date. win32u: Enlarge buffer size in _CDS_flags. https://gitlab.winehq.org/wine/wine/-/merge_requests/5436

4 6

[PATCH 0/1] MR5448: mfreadwrite/reader: Keep the output subtypes when propagating media types.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5448

3 4

Re: [PATCH v3 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > I meant the commit message subject, not the merge request subject. You > can use 'git commit --amend' and then force push. > And please squash those two patches into one. Also, https://bugs.winehq.org/show_bug.cgi?id=56485 is the wrong link. Please delete it from this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66779

1 0

Re: [PATCH v3 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Sam Joan Roque-Worcel wrote: > Ah! Thank you! I've added that in there now. Thank you for the reminder. I meant the commit message subject, not the merge request subject. You can use 'git commit --amend' and then force push. And please squash those two patches into one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66777

1 0

Re: [PATCH v3 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

@zhiyi I've addressed your feedback and rebased the branch, PR re-up :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66773

1 0

Re: [PATCH v2 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

On Wed Apr 3 09:52:58 2024 +0000, Sam Joan Roque-Worcel wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5427/diffs?diff_id=108367&start_sha=a41a4147bacc2bd3a64d582fb8918630ff795f1d#1309fd48153be56cdd4228d6e4bc8022a837b2de_39_39) Good spotting! No worries, thank you for taking the time to review it! I've changed the value to 17 :thumbsup: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66770

1 0

Re: [PATCH v2 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > Please change the subject to "win32u: Make SCROLL_MIN_THUMB larger." and > add a "Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54759" in the > commit message body. Other than that, this looks good to me. Thanks for > looking into this. Ah! Thank you! I've added that in there now. Thank you for the reminder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66769

1 0

Re: [PATCH v2 0/2] MR5435: wined3d: Require GLSL 1.20 support. - approved
by Jan Sikorski (＠jsikorski) 28 May '24

28 May '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5435

1 0

[PATCH v3 0/5] MR5397: widl: Add support for structures.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

-- v3: widl: Add support for VT_USERDEFINED to SLTG typelib generator. widl: Properly align name table entries. widl: Add support for structures. widl: Add more traces. widl: Use generic 'struct sltg_data' for collecting data. https://gitlab.winehq.org/wine/wine/-/merge_requests/5397

4 14

[PATCH 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

3 6

[PATCH 0/1] MR5436: win32u: Replace sprintf with snprintf to avoid deprecation warnings on macOS.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

The call in freetype.c:expand_mac_font() would be a good candidate for asprintf(), but I'm planning to send a patch soon to remove that resource-fork font extraction anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5436

3 12

Re: [PATCH v2 0/2] MR5435: wined3d: Require GLSL 1.20 support.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

FWIW, gitlab claims that a fast-forward merge is not possible despite there being no intervening commits to the relevant files. I've observed this behaviour on other merge requests as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5435#note_66733

1 0

Re: [PATCH v2 0/1] MR5437: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

On Tue Apr 2 07:23:54 2024 +0000, Aida Jonikienė wrote: > I wonder if the lack of tests could be a problem merging this (I've been > thinking of using a TRY/EXCEPT block to test the behavior of this flag > but this might not be right) I don't think tests are useful here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5437#note_66713

1 0

Re: [PATCH v2 0/4] MR5443: wmic: Handle multiple properties separated by whitespace. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5443

1 0

Re: [PATCH v3 0/1] MR5441: wbemprox: Zero-initialize table data. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5441

1 0

Re: [PATCH v2 0/9] MR5442: d2d1/effect: Partially implement transform graph node handling. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5442

1 0

Re: [PATCH v2 0/1] MR5410: mfreadwrite/reader: Avoid accessing an invalid stream index. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5410

1 0

Re: [PATCH v3 0/4] MR5412: mfreadwrite/tests: More source reader transform tests. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5412

1 0

Re: [PATCH v2 0/1] MR5429: wbemprox: Add property 'Status' to Win32_BIOS. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5429

1 0

[PATCH v2 0/4] MR5400: shell32: Tying up some loose ends
by Yuxuan Shui (＠yshui) 28 May '24

28 May '24

Follow up to !5342. This adds the last missing piece for fixing how `ShellExecute` finds files, and restore the ability of running native unix programs with `ShellExecute` -- v2: shell32: Accept ".so" as a valid program extension. https://gitlab.winehq.org/wine/wine/-/merge_requests/5400

4 11

[PATCH 0/3] MR5430: winegstreamer: Seek to the end after MPEG splitter connection.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

RE:D Cherish depends on this. To demonstrate the difference in behavior, we need a special MPEG program stream that is at least 32kB over in size. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56485 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5430

4 6

[PATCH 0/1] MR5410: mfreadwrite/reader: Avoid accessing an invalid stream index.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Fixes d6c9ac94d2fc92d86639e74699ef470b1d8a9861. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5410

3 3

[PATCH v2 0/4] MR5412: mfreadwrite/tests: More source reader transform tests.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

First change also avoids a leak of classes (later activates) when the transform is successfully connected. The use of MFTEnumEx is necessary so that the tests work, as they use a locally registered transform. -- v2: mfreadwrite/tests: Test the D3D awareness of source reader transforms. mfreadwrite/tests: Test the source reader stream change events. mfreadwrite/reader: Make the GetTransformForStream category parameter optional. mfreadwrite/reader: Use MFTEnumEx to enumerate … [View More]

3 13

Re: [PATCH v2 0/2] MR5424: faudio: Fix deadlock in voice callbacks
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

I'll plan on merging 24.05 when it's released. Please remind me if I forget. Thanks for the fix! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5424#note_66638

1 0

[PATCH 0/1] MR5429: wbemprox: Add property 'Status' to Win32_BIOS.
by Louis Lenders (＠xe) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56361 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5429

3 2

Re: [PATCH v2 0/2] MR5424: faudio: Fix deadlock in voice callbacks
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

To clarify, I don't know if it will be merged by hand right when 24.05 is released, but once it's out you can comment on linked bug report, explaining the situation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5424#note_66635

1 0

Re: [PATCH v2 0/2] MR5424: faudio: Fix deadlock in voice callbacks - closed
by Stanislau Tsitsianok (＠tsmx) 28 May '24

28 May '24

This merge request was closed by Stanislau Tsitsianok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5424

1 0

Re: [PATCH v2 0/2] MR5424: faudio: Fix deadlock in voice callbacks
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Thanks for the update. It doesn't happen automatically, no. It's manually merged from time to time, and I think only at a point of tagged releases. For FAudio that would mean next 24.05 release, in about a month. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5424#note_66634

1 0

[PATCH v2 0/1] MR4634: ntdll: Support Ctrl-C stop debuggee and attach 32-bit process in wow64 mode.
by JiangYi Chen (＠meshine) 28 May '24

28 May '24

Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> -- v2: wow64: Add TokenIntegrityLevel surpport to wow64_NtSetInformationToken as NtSetInformationToken does. https://gitlab.winehq.org/wine/wine/-/merge_requests/4634

2 2

Re: [PATCH v2 0/2] MR5424: faudio: Fix deadlock in voice callbacks
by Stanislau Tsitsianok (＠tsmx) 28 May '24

28 May '24

Merged to upstream. Do I have to do anything else or is there someone/something that imports upstream releases automatically? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5424#note_66632

1 0

Re: [PATCH v2 0/1] MR5437: kernelbase: Do not start the debugger if SEM_NOGPFAULTERRORBOX is set.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

I wonder if the lack of tests could be a problem merging this (I've been thinking of using a TRY/EXCEPT block to test the behavior of this flag but this might not be right) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5437#note_66619

1 0

[PATCH 0/1] MR4567: kernelbase: Silently handle exceptions if SEM_NOGPFAULTERRORBOX is set.
by Aida Jonikienė (＠DodoGTA) 28 May '24

28 May '24

This finally solves a FIXME that was added back in 1997. NFS High Stakes (and Motor City Online) both emit a 0x190 access violation on startup (according to game's strings this was meant to be debugger detection; I think this was done to interfere in a DRM bypass but I'm probably wrong). But anyway that feature causes a Wine Debugger dialog to appear when starting the games (if you click "Show Details" though they suddenly start working normally but this is an extra annoyance for average … [View More]

3 5

[PATCH 0/3] MR3193: winegstreamer: Make wg_parser be able to output compressed samples.
by Ziqing Hui (＠zhui) 28 May '24

28 May '24

This patch set now has 24 test failures in wmvcore/tests/wmvcore.c: test_async_reader_streaming(). So it won't be merged now. But I'd like to have it reviewed to see if I was doing things in the right direction. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3193

5 13

[PATCH v6 0/2] MR4811: ntdll: Avoid hanging when a thread is terminated while holding a pthread mutex.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- v6: ntdll: Raise SIGQUIT instead of aborting immediately if the server pipe is broken. https://gitlab.winehq.org/wine/wine/-/merge_requests/4811

3 5

2025

2024

2023

2022

wine-gitlab May 2024