May 2024 - wine-gitlab

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 28 May '24

28 May '24

On Mon May 13 19:14:17 2024 +0000, Gabriel Ivăncescu wrote: > > They could potentially be just indices, the association between name > and ID may be easily done on MSHTML side (it's already doing that now). > I don't think I follow. The name is used for jscript prop lookup, not > mshtml. We absolutely need it for hash and standard name lookup. It's > not an internal thing. PROP_PROXY doesn't care what name it has, it only > stores the DISPID (index basically) to access it from mshtml. But > looking it up **does** require name, because the prop has a name, so we > do need dispex_prop_t, just like builtins. To be fair I'm talking about > **being accessed by name via jscript**, nothing to do with mshtml internals. > Think of window props, for example. I'm not talking about simple dynamic > props on the window, which can be stored in jscript as simple values > (and will be, later though, not in my branch yet, as I said I don't want > to overcomplicate it). Instead, think of the other "global_props" (from > mshtml's meaning of it) on the window, such as other scripts, elements, > etc. Those need PROP_PROXY to get accessed… > > I think I can live with it, but note that the requirement to create a > function object instance for all MSHTML builtin functions that are used > is not exactly optimal. It would be possible to optimize that in the > future, hopefully without full rewrite of the interface. Just like we do > for jscript builtin functions. > We can save that for later, but I believe it's as optimal as builtins > right now. That is, they get allocated on demand (when needed), but > otherwise we need them as functions, because even builtins had to be > converted from builtins into actual functions at some point. Only the > "value prop" builtins still remain as such (it's same with PROP_PROXY). > > Sure, although... it's by no means something for now, but I could > imagine getting rid of `PROP_BUILTIN` and use the same 'external' > properties for them instead, just like other external props (MSHTML and > indexed props in the current proposal). > How would that work? Builtins have a name, so we can't just use the same > as indexed props because such name needs to have a DISPID mapping to it > and be looked up by hash. We could use an extra layer of mapping for > builtins of course, but I think that's overkill and likely slower > (instead of just one hash lookup, now it's two lookups). > It also complicates it because, for instance, builtins can be deleted, > and then we have to actually implement every prop behavior on them > instead of relying on dispex_prop_t facilities. Right now if they get > deleted, the prop remains as PROP_DELETED and so can be easily replaced > by something else. But yeah, maybe it's worth it way later though, we'll > need measurements I guess. After rebasing more of my patches, I found a problem with the IID approach, when it comes to weird prototype chains. For example the HTMLCurrentStyle shares an "abstract" common prototype with HTMLStyle, even though some of those methods don't work on it. But some are exposed in multiple interfaces, for instance the `zoom` prop setter (not getter). The IID would have the IHTMLStyle3 interface (which is correct), but when looking the "zoom" prop up on HTMLCurrentStyle via DISPID, it would get the one from CSSStyleDeclaration, which has different behavior. Yes, it's weird as hell, and my explanation isn't that great either. Anyway, the IID isn't that useful, mshtml already queries the IID for the respective function. Instead I'm now using a mixed approach where I have a new method (but a normal method in the vtbl like PropInvoke rather than a function pointer callback) that uses a "func_ctx" which is basically the `func_info_t` (it's opaque to jscript, it doesn't care). This way there's zero ambiguity as to which function is actually used, and the prototype chain fiasco is cleanly solved. All tests pass now. Anyway, this is not very related to this MR, is there something I can do to get this moving? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_71566

1 0

[PATCH v2 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 28 May '24

28 May '24

Also: Add new timeouts to NETCON calls impacted by change Timeout values are able to be set on all hInternet handles, so they should be able to set in a unified way. Submitting what I have so far for review. Known TODO: Tests, verify timeouts are set where NETCON is used, verify ULONG vs DWORD usage rules. -- v2: wininet: unify timeout values closer to hInternet https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

2 1

[PATCH 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 28 May '24

28 May '24

Also: Add new timeouts to NETCON calls impacted by change Timeout values are able to be set on all hInternet handles, so they should be able to set in a unified way. Submitting what I have so far for review. Known TODO: Tests, verify timeouts are set where NETCON is used, verify ULONG vs DWORD usage rules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

3 5

[PATCH 0/1] MR5743: user32/tests: Add a test to show that SendMessage(LB_SETCOUNT) adds a scrollbar.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

In addition to existing tests this shows that the call SendMessage(listbox, LB_SETCOUNT, 100, 0); adds a scrollbar to the listbox however it doesn't add a nonclient area to an update region because the call ValidateRect(listbox, NULL); validates a client area, and after that a window no longer has an update region. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5743

2 1

[PATCH 0/4] MR5639: comctl32/syslink: Don't delete font when destroying the control.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

The font set by WM_SETFONT is not owned by syslink so it shouldn't be deleted when handling WM_DESTROY for the control. Fix Toad for Oracle text gets reset to the system font after installing Team Coding. The application creates a font and set it to a syslink. Then after the syslink destroys itself, the font becomes invalid so other controls using the font end up falling back to the system font. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5639

4 6

Re: [PATCH v2 0/1] MR5706: comctl32/rebar: Hide chevron if the full width of rebar is displayed
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Please give two screenshots demonstrating the changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_71557

1 0

Re: [PATCH v3 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Tue May 28 10:12:25 2024 +0000, Rémi Bernon wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/5738/diffs?diff_id=115405&start_sha=837a51a59c0de7dd45a2c7da92545ca8d18da2e2#85770a8b187bd82db4dbb9a2b8a5f34616049d0f_4787_4787) Dropped that change for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71550

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Tue May 28 10:20:03 2024 +0000, Alexandre Julliard wrote: > I don't think we can do that until the drivers support window scaling. Hmm, right thanks. That was mostly meant to fix the tests, but I see now that it breaks things. Still not clear to me why or how. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71547

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

Alexandre Julliard (@julliard) commented about dlls/win32u/sysparams.c: > > /* FIXME: what do the DpiScalingVer flags mean? */ > get_dword_entry( (union sysparam_all_entry *)&entry_DPISCALINGVER, 0, &dpi_scaling, 0 ); > - if (!dpi_scaling) NtUserSetProcessDpiAwarenessContext( NTUSER_DPI_PER_MONITOR_AWARE, 0 ); I don't think we can do that until the drivers support window scaling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71546

1 0

Re: [PATCH v2 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

> If you wish to have me removed as maintainer of winegstreamer, please propose that directly, rather than abusing GitLab to get your patches committed. This is not an automated process and I don't think I'm abusing any mechanism here. > I'm sorry for not reviewing I find it very difficult to want to review promptly when my review is invariably met with argument, insistence that there is only one correct way to do things, and inability or unwillingness to view things from my perspective. Despite this, I am sorry, and I will try to renew my efforts to review better. I could say the very same thing the other way, I don't see how that would help us though. I've been working on this for almost two years straight now, and yet, I still have to nag people to get ~5 patches reviewed in a week and still have to argue almost every time that my approach is as good as another. So yes, the more I'm doing it, the less I'm interested in rewriting things over. Note that this has now also been tested in length, and every large change requested is also waste of all the time that's been spend there too. Yes, of course, incorrectness needs to be addressed, but internal implementation details shouldn't matter as much as external behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667#note_71545

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

v2: Fix some wineandroid build failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71544

1 0

[PATCH 0/2] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

Re: [PATCH v4 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Huw Davies (＠huw) 28 May '24

28 May '24

Huw Davies (@huw) commented about dlls/riched20/para.c: > COPY_FIELD(PFM_ALIGNMENT, wAlignment); > if (dwMask & PFM_TABSTOPS) > { > - para->fmt.cTabCount = pFmt->cTabCount; > - memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, pFmt->cTabCount*sizeof(LONG)); > + para->fmt.cTabCount = max(0, min(pFmt->cTabCount, MAX_TAB_STOPS)); /* Clamp between 0 and MAX_TAB_STOPS */ > + memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, para->fmt.cTabCount*sizeof(LONG)); ```suggestion:-1+0 /* Clamp between 0 and MAX_TAB_STOPS */ para->fmt.cTabCount = max(0, min(pFmt->cTabCount, MAX_TAB_STOPS)); memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, para->fmt.cTabCount * sizeof(LONG)); ``` Otherwise, looks fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71529

1 0

[PATCH 0/2] MR5740: Inlcude updates
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

Two patches to add two new interfaces and one to fix an existing one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5740

2 2

[PATCH 0/4] MR5735: win32u: Some fixes for Vulkan GPUs.
by Krzysztof Bogacki (＠Saancreed) 28 May '24

28 May '24

A bunch of fixes and improvements related to Vulkan GPUs in win32u. The first commit fixes a bug with enumeration of multiple GPUs, the next two are supposed to improve logging, the last one gets rid of unused variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5735

3 5

Re: [PATCH 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

```suggestion:-0+0 if (vulkan_uuid && !IsEqualGUID( vulkan_uuid, &empty_uuid )) ctx->gpu.vulkan_uuid = *vulkan_uuid; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5736#note_71523

1 0

Re: [PATCH 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

```suggestion:-0+0 static const GUID empty_uuid; ``` As it's static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5736#note_71522

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Mon May 27 20:37:43 2024 +0000, Elizabeth Figura wrote: > I'm not sure I see how? If a type is just declared in an import, and > defined in the main IDL, then we still want to define it. I don't see > how to distinguish those two cases. Can this really happen? If that's the case then sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71521

1 0

[PATCH 0/1] MR5706: comctl32/rebar: Hide chevron if the full width of rebar is displayed
by Ilia Docin (＠IDocin) 22 May '24

22 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706

2 1

[PATCH 0/10] MR5703: mshtml: Use DISPEX_IDISPATCH_IMPL (part 6)
by Jacek Caban (＠jacek) 22 May '24

22 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5703

2 10

[PATCH 0/5] MR5700: gdiplus: Removing gdi32 objects from gdiplus objects. (part 6)
by Esme Povirk (＠madewokherd) 21 May '24

21 May '24

Final part of https://gitlab.winehq.org/wine/wine/-/merge_requests/5593 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5700

2 5

[PATCH 0/1] MR5699: dinput: Dynamically allocate the internal device / event arrays.
by Rémi Bernon (＠rbernon) 21 May '24

21 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5699

2 1

[PATCH 0/1] MR5698: shcore: Check optional pointer in filestream_CopyTo() before writing to it.
by Danyil Blyschak (＠blyss) 21 May '24

21 May '24

Check that the 'written' parameter in this function is non-null before incrementing it by 'written_chunk'. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5698

2 1

[PATCH 0/6] MR5697: Use DISPEX_IDISPATCH_IMPL (part 5)
by Jacek Caban (＠jacek) 21 May '24

21 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5697

2 6

[PATCH 0/1] MR5693: ntdll: Don't warn on macOS and FreeBSD when xattr doesn't exist.
by Brendan Shanks (＠bshanks) 20 May '24

20 May '24

Linux getxattr returns ENODATA when the attribute doesn't exist, but macOS and FreeBSD both return ENOATTR in that case. Avoids warnings like `0050:warn:file:get_file_info Failed to get extended attribute user.DOSATTRIB from "<..>/dosdevices/c:/windows/system32/rpcss.exe". errno 93 (Attribute not found)` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5693

2 1

[PATCH v3 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 20 May '24

20 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v3: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

2 1

[PATCH 0/1] MR5689: gitlab: Add unzip to build image.
by Esme Povirk (＠madewokherd) 18 May '24

18 May '24

I would like to reuse this build image for the Wine Mono CI process (so that I don't have to separately maintain an image that can run current Wine), but I need unzip to download and extract artifacts from Wine's CI process. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5689

2 1

[PATCH 0/1] MR5682: maintainers: Remove Andrew Eikum.
by Huw Davies (＠huw) 17 May '24

17 May '24

This leaves 'Media format conversion' unmaintained. If somebody would like to take it over, now is a good time to speak up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5682

2 1

[PATCH 0/5] MR5681: gdiplus: Removing gdi32 objects from gdiplus objects. (part 4)
by Esme Povirk (＠madewokherd) 17 May '24

17 May '24

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/5593 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5681

2 5

[PATCH 0/3] MR5679: win32u: Set DEVMODEW dmSize field.
by Rémi Bernon (＠rbernon) 17 May '24

17 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56674 Now that we write all the display modes as a blob, we also write their header to the registry. This includes the dmSize field which is later used to iterate the modes after they've been read from the registry. The virtual desktop mode and some drivers were not setting it properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5679

2 3

[PATCH v5 0/6] MR5601: Draft: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 17 May '24

17 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- v5: winewayland.drv: Populate vkey to wchar entry for VK_DECIMAL. user32/tests: Add tests for SendInput with numpad scancodes. server: Send numpad virtual keys if NumLock is active. win32u: Store the full KBD vkey information in kbd_tables_init_vsc2vk. win32u: Allow drivers to send only the scan code for keyboard events. win32u: Emit number characters for numpad virtual keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

2 6

[PATCH 0/1] MR5678: ntdll: Don't use gmtime() concurrently.
by Piotr Caban (＠piotr) 17 May '24

17 May '24

The function may be called by NtQuerySystemInformation(SystemTimeOfDayInformation) and NtQuerySystemInformation(SystemCurrentTimeZoneInformation) concurrenly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5678

2 1

[PATCH 0/1] MR5677: ntdll: Use assembly wrapper for unixlib calls on ARM64EC.
by Jacek Caban (＠jacek) 17 May '24

17 May '24

Instead of using inderect C calls, which need to go through the call dispatcher. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5677

2 1

[PATCH v6 0/5] MR5626: Draft: mfreadwrite: Support MFVideoFormat_ABGR32 output.
by Rémi Bernon (＠rbernon) 17 May '24

17 May '24

This format is used by many Unity games, with D3D-enabled source reader. -- v6: mfreadwrite/reader: Fixup MFVideoFormat_ABGR32 subtype to enumerate the video processor. winegstreamer: Support MFVideoFormat_ABGR32 output in the video processor. mfreadwrite/tests: Add tests with MFVideoFormat_ABGR32 output format. mf/tests: Add video processor tests with MFVideoFormat_ABGR32 format. mfplat: Add MFVideoFormat_ABGR32 format information. https://gitlab.winehq.org/wine/wine/-/merge_requests/5626

3 6

[PATCH 0/1] MR5676: nsi/tests: Use NSI_IP_COMPARTMENT_TABLE instead of hard coding the integer.
by Huw Davies (＠huw) 17 May '24

17 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5676

2 1

[PATCH 0/3] MR5674: quartz: AVI decompressor fixes.
by Anton Baskanov (＠baskanov) 17 May '24

17 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5674

3 4

[PATCH 0/1] MR5673: mmdevapi: Remove unused ACImpl typedef.
by Huw Davies (＠huw) 17 May '24

17 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5673

2 1

[PATCH 0/5] MR5670: gdiplus: Removing gdi32 objects from gdiplus objects. (part 3)
by Esme Povirk (＠madewokherd) 16 May '24

16 May '24

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/5593. Removing HBITMAP objects revealed some bugs in the software path for linecaps. It also led to using the stride passed in (instead of using the stride a DIB would have), which is actually invalid in one of our tests and native ignores it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5670

2 5

[PATCH 0/2] MR5669: d2d1/effect: Implement SetPassthroughGraph().
by Nikolay Sivov (＠nsivov) 16 May '24

16 May '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5669

2 2

[PATCH v2 0/5] MR5626: mfreadwrite: Support MFVideoFormat_ABGR32 output.
by Rémi Bernon (＠rbernon) 16 May '24

16 May '24

This format is used by many Unity games, with D3D-enabled source reader. -- v2: mfreadwrite/reader: Fixup MFVideoFormat_ABGR32 subtype to enumerate the video processor. winegstreamer: Support MFVideoFormat_ABGR32 output in the video processor. mfreadwrite/tests: Add tests with MFVideoFormat_ABGR32 output format. mf/tests: Add video processor tests with MFVideoFormat_ABGR32 format. mfplat: Add MFVideoFormat_ABGR32 format information. https://gitlab.winehq.org/wine/wine/-/merge_requests/5626

3 6

[PATCH 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Rémi Bernon (＠rbernon) 16 May '24

16 May '24

For https://gitlab.winehq.org/wine/wine/-/merge_requests/5615. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667

2 4

[PATCH v4 0/2] MR5652: user32/tests: Skip affected keyboard tests if a spurious layout change is detected.
by Alexandros Frantzis (＠afrantzis) 16 May '24

16 May '24

In some Win10 testbot images (notably jp and cn), we can get a spurious layout change after creating the test window and also when explicitly activating the offending layout. Detect such behavior and skip tests whose assumptions are invalidate by this spurious change. --- Landing this MR will unblock https://gitlab.winehq.org/wine/wine/-/merge_requests/5601. The testbot run for the latest version of this MR (v3) is https://testbot.winehq.org/JobDetails.pl?Key=145591. There are two new failures for the Win11 images, but they don't seem related to the changes here. I have been trying to investigate what's going with the Win10 (jp/cn) testbots but I don't think I can make more progress at this point. I will document my findings in a comment below in case they prove useful to anyone wishing to investigate further. -- v4: user32/tests: Remove workaround for SendInput keyboard tests on zh_CN. user32/tests: Skip affected keyboard tests if a spurious layout change is detected. https://gitlab.winehq.org/wine/wine/-/merge_requests/5652

2 2

[PATCH 0/5] MR5665: For a CS_PARENTDC child use parent for visible region calculations.
by Dmitry Timoshkov (＠dmitry) 16 May '24

16 May '24

These patches fix painting in an application that draws outside of a CS_PARENTDC child client area in its WM_PAINT handler. Comments and suggestions are welcome. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5665

3 6

[PATCH 0/1] MR5664: opengl32: Remove the wglDescribePixelFormat driver entry point.
by Alexandros Frantzis (＠afrantzis) 16 May '24

16 May '24

All drivers have now switched to the get_pixel_formats entry point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5664

3 2

[PATCH 0/1] MR5660: winemac.drv: Exclude dictation when looking for input methods.
by Tim Clem (＠tclem) 15 May '24

15 May '24

After a recent OS update, the dictation input source remains "selected" in *all* apps for about 10 minutes after it is activated, even when it is not in use. There doesn't seem to be any way to determine whether it's actually active or just lingering, and sending input to it regardless means that we falsely process input as if it was going to an IME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5660

3 2

[PATCH v2 0/2] MR5652: Draft: user32: Skip SendInput keyboard tests if a layout change is detected.
by Alexandros Frantzis (＠afrantzis) 15 May '24

15 May '24

In some Win10 testbot images (notably jp and cn), we can get a spurious layout change after creating the test window. Detect this and skip the tests since the test expectations (e.g., wchar mappings) are now invalid. -- v2: user32: Remove workaround for SendInput keyboard tests on zh_CN. user32: Skip affected keyboard tests if a spurious layout change is detected. https://gitlab.winehq.org/wine/wine/-/merge_requests/5652

3 3

[PATCH v7 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 15 May '24

15 May '24

-- v7: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 12

[PATCH 0/1] MR5657: Revert "winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows."
by Tim Clem (＠tclem) 15 May '24

15 May '24

This hits some OS-level bugs, and while I think it's a valuable user experience improvement, it seems best to just revert it for now. Issues I've uncovered since it was merged: 1. Rapidly hiding and showing a dock icon results in multiple icons for the same app. Those icons persist after the app exits, and if you click on them then, they disappear. I've seen this in a few applications, most reliably the Notepad++ installer, after selecting a language in the first dialog. 2. Removing a dock icon deactivates the app and reactivates the most recently active one. If it still has windows open, those move behind whatever app becomes active. And, we can't reliably work around that because... 3. With the cooperative app activation added in Sonoma, any requests to bring forward an app with no dock icon seem to fail. One illustratively bad case is Notepad++'s in-app modal update message box. It's from another process (which gets no taskbar icon on Windows and thus no dock icon with this patch). But since it can't be brought forward, and since it's modal, the result is that the Notepad++ main window is disabled for no apparent reason, and there's no way to select the dialog. This reverts commit f0efb2e46a7fb2a00f85196a4a06bd50eda560b2. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5657

3 2

[PATCH 0/1] MR5654: include: Add missing D3D12_FEATURE_DATA_D3D12_OPTIONS* types
by Alistair Leslie-Hughes (＠alesliehughes) 15 May '24

15 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5654

3 2

[PATCH 0/1] MR5655: msvcrt/tests: Don't link to _wcsicmp_l and _create_locale.
by Piotr Caban (＠piotr) 15 May '24

15 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56682 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5655

2 1

2025

2024

2023

2022

wine-gitlab May 2024