May 2024 - wine-gitlab

Re: [PATCH v3 0/1] MR5719: vbscript: fix test error clear
by Alexandre Julliard (＠julliard) 30 May '24

30 May '24

Please use your full name in your Gitlab profile and in the commit info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5719#note_71747

1 0

Re: [PATCH v3 0/1] MR5719: vbscript: fix test error clear - approved
by Jacek Caban (＠jacek) 30 May '24

30 May '24

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5719

1 0

[PATCH v3 0/2] MR5692: shell32: Fix ShellExecute for non-filespec paths
by Yuxuan Shui (＠yshui) 30 May '24

30 May '24

I was going to reimplement path resolution in ShellExecute, but half way through I realized that's very unnecessary. Since what I wanted is a version of `PathResolve` that behaves differently _only_ for filespec paths, I ended up duplicating a lot of code, then I realized I can still pass filespec paths onto `PathResolve` and only deal with non-filespec paths. -- v3: shell32: Fix ShellExecute for non-filespec paths. shell32: Make sure array passed to PathResolve is big enough. https://gitlab.winehq.org/wine/wine/-/merge_requests/5692

2 2

[PATCH 0/2] MR5754: server: Don't send raw input events for unicode inputs.
by Alexandros Frantzis (＠afrantzis) 30 May '24

30 May '24

The first commit adds some test infrastructure to be able check raw input keyboard events, along with a few tests relevant to the code paths in this MR. The second commit fixes raw input behavior with unicode inputs, and adds regression tests. Note that it was difficult to express the current Wine behavior with TODOs in the expected sequence, that's why I didn't introduce these regression tests independently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5754

4 7

[PATCH v5 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Aric Stewart (＠aricstewart) 30 May '24

30 May '24

Presently the wine file explorer has a create shortcut entry that does nothing. This implements the FCIDM_SHVIEW_CREATELINK command. This is a patch that was first submitted in 2017 and I unfortunately let the revision request fall unimplemented. -- v5: shell32: Implement FCIDM_SHVIEW_CREATELINK https://gitlab.winehq.org/wine/wine/-/merge_requests/5373

3 9

[PATCH v3 0/6] MR5564: mmdevapi: Adjust timing in AudioClient_Initialize, removing related code from drivers.
by Davide Beatrici (＠davidebeatrici) 30 May '24

30 May '24

Trace output with PulseAudio: ``` 0230:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0230:trace:mmdevapi:adjust_timing Device periods: 100000 default and 30000 minimum 0230:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v3: winepulse: Remove superfluous timing adjustment. wineoss: Remove superfluous timing adjustment. winecoreaudio: Remove superfluous timing adjustment. winealsa: Remove superfluous timing adjustment. mmdevapi: Adjust timing in AudioClient_Initialize. winealsa: Return minimum period in get_device_period if requested. https://gitlab.winehq.org/wine/wine/-/merge_requests/5564

3 8

Re: [PATCH v3 0/1] MR5719: vbscript: fix test error clear
by Francis DB (＠francisdb) 30 May '24

30 May '24

@jacek message updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5719#note_71721

1 0

[PATCH 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 30 May '24

30 May '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

2 1

[PATCH v12 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 30 May '24

30 May '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v12: d3d9/tests: Add Direct3DCreate9On12() tests. d3d9: Implement Direct3DCreate9On12(). include: Add d3d9on12.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

4 13

[PATCH v2 0/7] MR5666: d3dx9: Introduce d3dx_resource structures for use in code sharing.
by Connor McAdams (＠cmcadams) 29 May '24

29 May '24

This series of patches introduces a new set of structures and functions that will enable code to be re-used across various functions in d3dx9, and eventually d3dx10-d3dx11. It might be possible to split this further, but I feel like this initial set gives better context as to where things are heading. I have a [branch](https://gitlab.winehq.org/cmcadams/wine/-/commits/WIP/d3dx-shared-s… that uses these structures and functions in d3dx10 if further context would be useful. There are a lot of changes here, but after playing around with different approaches this was the best/cleanest way I could come up with for code sharing. I'm sure there will be things I missed or potentially ways to improve this, I'm open to suggestions of course. :) -- v2: d3dx9: Use d3dx_load_pixels_from_pixels() in D3DXLoadVolumeFromMemory(). d3dx9: Use d3dx_pixels structure in decompression helper function. d3dx9: Introduce d3dx_load_pixels_from_pixels() helper function. d3dx9: Use d3dx_image structure in D3DXLoadSurfaceFromFileInMemory(). d3dx9: Introduce d3dx_image structure for use in D3DXGetImageInfoFromFileInMemory(). d3dx9: Refactor WIC image info retrieval code in D3DXGetImageInfoFromFileInMemory(). d3dx9: Refactor WIC GUID to D3DXIMAGE_FILEFORMAT conversion code. https://gitlab.winehq.org/wine/wine/-/merge_requests/5666

3 30

[PATCH 0/1] MR5582: explorer: Finish wide-string literal migration.
by Aida Jonikienė (＠DodoGTA) 29 May '24

29 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5582

3 2

[PATCH v3 0/3] MR5740: Inlcude updates
by Alistair Leslie-Hughes (＠alesliehughes) 29 May '24

29 May '24

Two patches to add two new interfaces and one to fix an existing one. -- v3: include: Correct IRowsetNotify HROW parameter type include: Add IPreviewHandler* interfaces include: shtypes.idl - Add LOGFONTA/W typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/5740

2 3

Re: [PATCH v6 0/1] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

1 0

Re: [PATCH v4 0/7] MR5747: win32u: Introduce a wrapper to flush window surfaces. - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

1 0

Re: [PATCH v4 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones. - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5736

1 0

Re: [PATCH v3 0/5] MR5745: wined3d: Remove miscellaneous unused definitions, part 3/4. - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5745

1 0

Re: [PATCH v6 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727

1 0

Re: [PATCH v2 0/2] MR5740: Inlcude updates
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

Alexandre Julliard (@julliard) commented about include/shobjidl.idl: > + LONG lfWidth; > + LONG lfEscapement; > + LONG lfOrientation; > + LONG lfWeight; > + BYTE lfItalic; > + BYTE lfUnderline; > + BYTE lfStrikeOut; > + BYTE lfCharSet; > + BYTE lfOutPrecision; > + BYTE lfClipPrecision; > + BYTE lfQuality; > + BYTE lfPitchAndFamily; > + WCHAR lfFaceName[LF_FACESIZE]; > + } LOGFONTW, *PLOGFONTW, *LPLOGFONTW; > +cpp_quote("#endif /* _WINGDI_ */") > + It looks like this belongs in shtypes.idl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5740#note_71685

1 0

Re: [PATCH 0/1] MR5719: vbscript: fix test error clear
by Jacek Caban (＠jacek) 29 May '24

29 May '24

It looks good, but please use the canonical commit message, something like: "vbscript/tests: Fix error clear call." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5719#note_71681

1 0

[PATCH v5 0/1] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 29 May '24

29 May '24

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v5: win32u: Implement EVENT_SYSTEM_FOREGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

3 2

[PATCH v4 0/2] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 29 May '24

29 May '24

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v4: user32: Run tests that notice focus changes early. win32u: Implement EVENT_SYSTEM_FOREGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 10

[PATCH v2 0/1] MR5749: Draft: gitlab: Update configuration for the new Mac runner.
by Tim Clem (＠tclem) 29 May '24

29 May '24

Two main changes: - VM configuration in build.yml for the executor. - The build-mac script is now architecture-agnostic. -- v2: gitlab: Update configuration for the new Mac runner. https://gitlab.winehq.org/wine/wine/-/merge_requests/5749

3 7

[PATCH 0/1] MR5750: ntdll: Add stub RtlLookupGenericTableAvl function.
by Vijay Kiran Kamuju (＠infyquest) 29 May '24

29 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56736 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5750

2 1

[PATCH 0/1] MR5749: Draft: gitlab: Update configuration for the new Mac runner.
by Tim Clem (＠tclem) 29 May '24

29 May '24

Two main changes: - VM configuration in build.yml for the executor. - The build-mac script is now architecture-agnostic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5749

2 1

[PATCH v3 0/7] MR5747: win32u: Introduce a wrapper to flush window surfaces.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v3: win32u: Use a helper to flush window surface, factor locking and bounds reset. wineandroid: Hold the lock while reading window surface bits. winemac: Get rid of unnecessary blit_data / drawn surface members. win32u: Move window surface bounds to the window_surface base struct. win32u: Use helpers to lock/unlock window surfaces. win32u: Move the window surface mutex to the surface header. win32u: Introduce a new window_surface_init helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

3 9

[PATCH v2 0/6] MR5747: win32u: Introduce a wrapper to flush window surfaces.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v2: win32u: Use a helper to flush window surface, factor locking and bounds reset. winemac: Get rid of unnecessary blit_data / drawn surface members. win32u: Move window surface bounds to the window_surface base struct. win32u: Use helpers to lock/unlock window surfaces. win32u: Move the window surface mutex to the surface header. win32u: Introduce a new window_surface_init helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

4 9

Re: [PATCH v4 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 29 May '24

29 May '24

I looked a bit at mmdevice properties, turns out device strings are available directly from property store, using this key: {9c119480-ddc2-4954-a150-5bd240d454ad},1 The only problem is it's not documented in SDK. But the idea would be to populate property store with setupapi, or use setupapi/cfgmgr directly. Anyway, mentioning this in case we'll even need it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71634

1 0

[PATCH v2 0/5] MR5564: mmdevapi: Adjust timing in AudioClient_Initialize, removing related code from drivers.
by Davide Beatrici (＠davidebeatrici) 29 May '24

29 May '24

Trace output with PulseAudio: ``` 0230:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0230:trace:mmdevapi:adjust_timing Device periods: 100000 default and 30000 minimum 0230:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v2: winepulse: Remove superfluous timing adjustment. wineoss: Remove superfluous timing adjustment. winecoreaudio: Remove superfluous timing adjustment. winealsa: Remove superfluous timing adjustment. mmdevapi: Adjust timing in AudioClient_Initialize. https://gitlab.winehq.org/wine/wine/-/merge_requests/5564

4 12

Re: [PATCH v4 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Huw Davies (＠huw) 29 May '24

29 May '24

It looks like most of the issues @nsivov pointed out [here](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.org… are yet to be addressed. A few other things: - `pidlFQ` should be freed with `ILFree()` - Let's call it something less opaque like `full_pidl` - Switch to using `malloc()` / `free()` - If we really need the string functions, let's use `wcscpy()` etc -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_71626

1 0

[PATCH 0/6] MR5747: win32u: Introduce a wrapper to flush window surfaces.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

3 7

[PATCH v5 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 29 May '24

29 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56730 -- v5: riched20: In para_set_fmt protect against out of bound cTabStop values https://gitlab.winehq.org/wine/wine/-/merge_requests/5727

4 3

Re: [PATCH v2 0/5] MR5745: wined3d: Remove miscellaneous unused definitions, part 3/4. - approved
by Jan Sikorski (＠jsikorski) 29 May '24

29 May '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5745

1 0

[PATCH v3 0/4] MR5584: mf: Fixes the missing MESessionClosed event in various scenarios.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

Killsquad sends a MESessionClose at various times depending on user input. It always expects a MESessionClosed event and will wait indefinitely if not received. There are currently a number of scenarios where we don't report the MESessionClose event. This MR attempts to fix that. -- v3: mf: Handle Source/Sink shutdown whilst waiting for an event. mf: Handle an error during Media Session Close. mf: Handle MediaSession Close when state is SESSION_STATE_RESTARTING_SOURCES. mf/tests: Add additional tests for MESessionClosed event. https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

3 5

[PATCH v3 0/3] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- v3: server: Don't always return STATUS_OBJECT_NAME_INVALID on ENOTDIR. https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

Re: [PATCH v4 0/3] MR5737: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

On Tue May 28 08:16:35 2024 +0000, Brendan McGrath wrote: > I just tested on Windows, and that's exactly what it does. I'll update > the MR. Thanks for taking a look @nsivov. I think I've fixed it in the right spot now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737#note_71615

1 0

[PATCH v2 0/3] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- v2: server: Don't return STATUS_OBJECT_NAME_INVALID on ENOTDIR. ntdll/tests: Test error code when NtOpenFile uses file as directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

[PATCH v3 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones.
by Krzysztof Bogacki (＠Saancreed) 29 May '24

29 May '24

Currently, when GPUs are being added and display driver only provides a fake one (like e.g. winex11.drv does on Xwayland), its default name and empty UUID and PCI IDs will be preferred over ones reported by Vulkan. When Vulkan-only GPUs are added later, the resulting list will look like so: ``` Xrandr GPU 0x0000:0x0000 {00000000-0000-0000-0000-000000000000} NVIDIA GeForce RTX 4080 Laptop GPU 0x10de:0x27e0 {13938ad6-4925-b628-c068-30558bc4b489} ``` Instead, when default or empty properties were provided, we should prefer ones from Vulkan as they are more likely to be accurate: ``` Intel(R) Graphics (RPL-S) 0x8086:0xa788 {a7888086-0004-0000-0002-000000000000} NVIDIA GeForce RTX 4080 Laptop GPU 0x10de:0x27e0 {13938ad6-4925-b628-c068-30558bc4b489} ``` This is important for LUIDs to be later correctly assigned by winevulkan which searches for matching GPU by UUID. I'm not exactly sure if this implementation is the way to go (especially reporting and checking name for `"Wine GPU"`) but it's probably one of the simplest possible. Let me know if we already have some empty UUID around I could use for the comparison. -- v3: win32u: Prefer Vulkan UUIDs over empty ones. win32u: Prefer Vulkan PCI IDs over empty ones. win32u: Use common name for fake GPUs and prefer Vulkan name over it. https://gitlab.winehq.org/wine/wine/-/merge_requests/5736

3 4

[PATCH v5 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v5: win32u: Only keep DPI awareness context with window objects. win32u: Fix SetThreadDpiAwarenessContext. win32u: Pass the DPI awareness context in win_proc_params. win32u: Get the thread DPI context instead of the awareness. https://gitlab.winehq.org/wine/wine/-/merge_requests/5738

4 6

[PATCH 0/1] MR5704: makedep: Silence Clang warnings in bison-generated files.
by Jacek Caban (＠jacek) 29 May '24

29 May '24

Depending on bison version and Clang config, generated files cause various warnings. In gitlab CI, there is an unused function in wbemprox. I don't see it on newer bison and LLVM, but there are other -Wunused-but-set-variable warning instead. This was partially fixed in upstream bison: https://git.savannah.gnu.org/cgit/bison.git/commit/?id=a166d5450e3f47587b98… The fix does not take into account MSVC targets, I tried upstreaming a fix for that, with no success: https://savannah.gnu.org/patch/?10420 https://lists.gnu.org/archive/html/bison-patches/2023-11/msg00000.html Together with !5628, this allows enabling `-Werror` in out CI. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5704

5 5

[PATCH v4 0/5] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) 29 May '24

29 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 I'm not hugely satisfied with some of those changes (especially how looping avi_decompressor_source_get_media_type now takes O(n^2) calls to ICDecompressQuery), but it gets the video in that issue working. If you've got a better idea for how to implement this stuff, do tell. -- v4: msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Try DTS if PTS is absent. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

3 6

[PATCH 0/5] MR5745: wined3d: Remove miscellaneous unused definitions, part 3/4.
by Elizabeth Figura (＠zfigura) 29 May '24

29 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5745

2 5

[PATCH v2 0/1] MR5720: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found.
by Danyil Blyschak (＠blyss) 29 May '24

29 May '24

There is a check earlier in the PSDRV_MergeDevmodes/merge_devmodes functions to update dmDefaultSource if a slot is found, and so this member should not be updated again with no such check. -- v2: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found. https://gitlab.winehq.org/wine/wine/-/merge_requests/5720

4 3

[PATCH 0/1] MR5742: programs/conhost: Fix display of font preview (in 64bit mode).
by eric pouech (＠epo) 29 May '24

29 May '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5742

3 2

[PATCH v3 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Paul Gofman (＠gofman) 29 May '24

29 May '24

-- v3: mf: Implement audio capture device enumeration in MFEnumDeviceSources(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5734

4 5

[PATCH 0/1] MR5741: Draft: server: Implement key auto-repeat.
by Alexandros Frantzis (＠afrantzis) 29 May '24

29 May '24

This is an early draft of an implementation of key auto-repeat in wineserver to get some feedback. Some open questions: 1. queue_keyboard_message requires a `current` thread, but we don't get one in timeout callbacks. At the moment I am manually setting `current` to the foreground thread, but I am wondering if that's acceptable or we should explore other ways forward (also see TODO in code). 2. This draft introduces a new server request to configure auto-repeat (`enable/delay/period`). I am thinking that for more straightforward integration with the keyboard repeat SPI parameters, the request should only support the `enable` flag and the server should query the SPI registry values to get `delay` and `period` when needed. I am wondering if there any caveats here since I don't see other code in the server querying registry values (well, except to implement the registry requests themselves). Also, I would hope that opening and caching the `HKCU\Control Panel\Keyboard` hkey would remove most of the cost of performing this operation (if that's even a concern at all). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5741

4 9

[PATCH v2 0/7] MR5665: For a CS_PARENTDC child use parent for visible region calculations.
by Dmitry Timoshkov (＠dmitry) 29 May '24

29 May '24

These patches fix painting in an application that draws outside of a CS_PARENTDC child client area in its WM_PAINT handler. Comments and suggestions are welcome. -- v2: win32u: Use parent rectangle for visible region calculations of a CS_PARENTDC child. win32u: Don't clip update region to the window client rectangle. win32u: GetUpdateRgn() should clip update region to the window client area. win32u: GetUpdateRect() should clip update rectangle to the window client area. win32u: Clip PAINTSTRUCT.rcPaint to the window client area. server: For a CS_PARENTDC child use parent for visible region calculations. server: If the being validated region covers whole window then validate everything. https://gitlab.winehq.org/wine/wine/-/merge_requests/5665

3 8

[PATCH v4 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v4: win32u: Only keep DPI awareness context with window objects. win32u: Fix SetThreadDpiAwarenessContext. win32u: Pass the DPI awareness context in win_proc_params. win32u: Get the thread DPI context instead of the awareness. https://gitlab.winehq.org/wine/wine/-/merge_requests/5738

4 6

[PATCH v2 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones.
by Krzysztof Bogacki (＠Saancreed) 29 May '24

29 May '24

Currently, when GPUs are being added and display driver only provides a fake one (like e.g. winex11.drv does on Xwayland), its default name and empty UUID and PCI IDs will be preferred over ones reported by Vulkan. When Vulkan-only GPUs are added later, the resulting list will look like so: ``` Xrandr GPU 0x0000:0x0000 {00000000-0000-0000-0000-000000000000} NVIDIA GeForce RTX 4080 Laptop GPU 0x10de:0x27e0 {13938ad6-4925-b628-c068-30558bc4b489} ``` Instead, when default or empty properties were provided, we should prefer ones from Vulkan as they are more likely to be accurate: ``` Intel(R) Graphics (RPL-S) 0x8086:0xa788 {a7888086-0004-0000-0002-000000000000} NVIDIA GeForce RTX 4080 Laptop GPU 0x10de:0x27e0 {13938ad6-4925-b628-c068-30558bc4b489} ``` This is important for LUIDs to be later correctly assigned by winevulkan which searches for matching GPU by UUID. I'm not exactly sure if this implementation is the way to go (especially reporting and checking name for `"Wine GPU"`) but it's probably one of the simplest possible. Let me know if we already have some empty UUID around I could use for the comparison. -- v2: win32u: Prefer Vulkan UUIDs over empty ones. https://gitlab.winehq.org/wine/wine/-/merge_requests/5736

4 8

[PATCH v2 0/7] MR5470: win32u: Get rid of the window surface recursive mutex.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v2: winex11: Stop using a recursive mutex for the window surfaces. winewayland: Stop using a recursive mutex for the window surfaces. winemac: Stop using a recursive mutex for the window surfaces. wineandroid: Stop using a recursive mutex for the window surfaces. win32u: Stop using a recursive mutex for the offscreen surface. win32u: Remove surface recursive locking requirement. win32u: Flush window surface when it is fully unlocked. https://gitlab.winehq.org/wine/wine/-/merge_requests/5470

4 10

[PATCH 0/2] MR5739: wineandroid: Fix some build errors.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5739

3 3

2025

2024

2023

2022

wine-gitlab May 2024