May 2024 - wine-gitlab

[PATCH 0/5] MR5723: wined3d: Remove miscellaneous unused definitions, part 2/4.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5723

3 6

Re: [PATCH v2 0/1] MR5743: user32/tests: Add a test to show that SendMessage(LB_SETCOUNT) adds a scrollbar. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5743

1 0

Re: [PATCH v3 0/1] MR5720: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5720

1 0

Re: [PATCH v2 0/1] MR5742: programs/conhost: Fix display of font preview (in 64bit mode). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5742

1 0

Re: [PATCH v2 0/4] MR5639: comctl32/syslink: Don't delete font when destroying the control. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5639

1 0

Re: [PATCH v4 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734

1 0

Re: [PATCH v3 0/5] MR5723: wined3d: Remove miscellaneous unused definitions, part 2/4. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5723

1 0

Re: [PATCH v3 0/7] MR5470: win32u: Get rid of the window surface recursive mutex. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5470

1 0

Re: [PATCH v2 0/2] MR5739: wineandroid: Fix some build errors. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5739

1 0

Re: [PATCH v2 0/4] MR5735: win32u: Some fixes for Vulkan GPUs. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5735

1 0

Re: [PATCH v4 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Mon May 27 22:52:31 2024 +0000, Fabian Maurer wrote: > changed this line in [version 4 of the diff](/wine/wine/-/merge_requests/5721/diffs?diff_id=115350&start_sha=80b9dbaa0c76d90fc6b4f987d33f6b2c436a792f#57bb2b547892dd309f08905368f813aa2c01e879_525_524) Thanks! I assume you meant `TOKEN_MANDATORY_LABEL32` here, but sorry for missing that copy paste error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71491

1 0

[PATCH v5 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

This doesn't fix the bug, but should to be a step in the right direction. -- v5: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel https://gitlab.winehq.org/wine/wine/-/merge_requests/5721

3 2

Re: [PATCH v3 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

Thanks! A few nits and you're good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71485

1 0

Re: [PATCH v3 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

```suggestion:-1+0 case TokenIntegrityLevel: /* TOKEN_MANDATORY_LABEL */ if (len >= sizeof(TOKEN_MANDATORY_LABEL)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71484

1 0

Re: [PATCH v3 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

(nit) indent ```suggestion:-0+0 SID_AND_ATTRIBUTES32 Label; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71483

1 0

Re: [PATCH v2 0/1] MR5733: comctl32/tests: Create a fully updated ListView window. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5733

1 0

Re: [PATCH v2 0/1] MR5713: win32u: Use NtGdiDdDDICreateDCFromMemory for gdi16 DIBDRV. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5713

1 0

Re: [PATCH v2 0/6] MR5731: win32u: More DPI related functions tests and fixes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5731

1 0

Re: [PATCH v2 0/1] MR5725: userenv: Add CreateAppContainerProfile stub - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5725

1 0

Re: [PATCH v2 0/1] MR5716: ntdll: Fix UNC path handling in alloc_module. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5716

1 0

Re: [PATCH v2 0/1] MR5726: dxdiagn: Add AGP properties. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5726

1 0

Re: [PATCH v2 0/1] MR5722: dxdiagn: Add bIsD3DDebugRuntime property. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5722

1 0

Re: [PATCH v2 0/3] MR5710: win32u: Get rid of the UpdatedDisplayDevices force parameter. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5710

1 0

Re: [PATCH v2 0/2] MR5730: Various Include changes - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5730

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

On Mon May 27 20:51:49 2024 +0000, Nikolay Sivov wrote: > It's unlikely those device strings need to be constructed in client > library here, I'd expect those id to come from setupapi > (DEVPKEY_Device_InstanceId?), if they are not present in mmdevice > property store already. If application really depends on those > attributes we could add them here as a temporary solution, but if it > doesn't, I'd rather prefer a fixme. Device symlink is required for video > sources I think, but for mmdevapi you'd use an endpoint id. I didn't find a straightforward way to get it from mmdevapi. No, I don't know that anything (that is, the only app I came through) is using that link (although I think it is possible to create mmdevapi device using that path with, e. g., ActivateAudioInterfaceAsync). I will look a bit more and if no obvious way I will remove this field for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71444

1 0

Re: [PATCH v2 0/2] MR5729: Fix SQLSetConnectOptionW prototype - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5729

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

On Mon May 27 20:51:50 2024 +0000, Nikolay Sivov wrote: > What does "sac" stand for? Source Audio Capture. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71442

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/mf/sac.c: > + > + hr = IMMDevice_OpenPropertyStore(device, STGM_READ, &ps); > + IMMDevice_Release(device); > + if (FAILED(hr)) > + goto done; > + hr = IPropertyStore_GetValue(ps, (const PROPERTYKEY*)&DEVPKEY_Device_FriendlyName, &pv); > + IPropertyStore_Release(ps); > + if (FAILED(hr)) > + goto done; > + if (pv.vt != VT_LPWSTR) > + { > + PropVariantClear(&pv); > + goto done; > + } > + IMFActivate_SetString(sources[i], &MF_DEVSOURCE_ATTRIBUTE_FRIENDLY_NAME, pv.pwszVal); > + PropVariantClear(&pv); I think cascading checks for hr are better here than multiple jumps. And if property store becomes useful for instance id, we could have a helper that checks value types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71440

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/mf/main.c: > - FIXME("%p, %p, %p.\n", attributes, sources, count); > + GUID source_type; > + HRESULT hr; > + > + TRACE("%p, %p, %p.\n", attributes, sources, ret_count); > > - if (!attributes || !sources || !count) > + if (!attributes || !sources || !ret_count) > return E_INVALIDARG; > > - *count = 0; > + if (FAILED(hr = IMFAttributes_GetGUID(attributes, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE, &source_type))) > + return hr; > > - return S_OK; > + if (IsEqualIID(&source_type, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE_VIDCAP_GUID)) It makes no difference in practice, but IsEqualGUID() is a better fit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71439

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/mf/main.c: > + HRESULT hr; > + > + TRACE("%p, %p, %p.\n", attributes, sources, ret_count); > > - if (!attributes || !sources || !count) > + if (!attributes || !sources || !ret_count) > return E_INVALIDARG; > > - *count = 0; > + if (FAILED(hr = IMFAttributes_GetGUID(attributes, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE, &source_type))) > + return hr; > > - return S_OK; > + if (IsEqualIID(&source_type, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE_VIDCAP_GUID)) > + { > + FIXME("Not implementted for video capture devices.\n"); Typo here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71438

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/mf/Makefile.in: > mf.rc \ > quality.c \ > samplegrabber.c \ > + sac.c \ What does "sac" stand for? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71437

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/mf/sac.c: > + if (FAILED(hr = IMMDeviceCollection_GetCount(devices, &count))) > + goto done; > + sources = CoTaskMemAlloc(count * sizeof(*sources)); > + for (i = 0; i < count; ++i) > + { > + WCHAR symbolic_link[256]; > + IPropertyStore *ps; > + IMMDevice *device; > + PROPVARIANT pv; > + WCHAR *str; > + > + if (FAILED(hr = create_activation_object(NULL, &audio_capture_activate_funcs, &sources[i]))) > + goto done; > + ++created_count; > + > + IMFActivate_SetGUID(sources[i], &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE_AUDCAP_GUID); To handle failures in individual Set methods we have things like mediatype_set_guid() in mfplat, that take &hr argument to set error code appropriately without introducing more cleanup conditions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71436

1 0

Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/mf/sac.c: > +static void audio_capture_free_private(void *user_context) > +{ > + TRACE("%p.\n", user_context); > +} > + > +static const struct activate_funcs audio_capture_activate_funcs = > +{ > + audio_capture_create_object, > + audio_capture_shutdown_object, > + audio_capture_free_private, > +}; > + > +HRESULT enum_audio_capture_sources(IMFAttributes *attributes, IMFActivate ***ret_sources, UINT32 *ret_count) > +{ > + static const WCHAR devinterface_audio_capture_wstr[] = L"{2eef81be-33fa-4800-9670-1cd474972c3f}"; > + static const WCHAR mmdev_path_prefix[] = L"\\\\?\\SWD#MMDEVAPI"; It's unlikely those device strings need to be constructed in client library here, I'd expect those id to come from setupapi (DEVPKEY_Device_InstanceId?), if they are not present in mmdevice property store already. If application really depends on those attributes we could add them here as a temporary solution, but if it doesn't, I'd rather prefer a fixme. Device symlink is required for video sources I think, but for mmdevapi you'd use an endpoint id. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71435

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

On Mon May 27 09:51:12 2024 +0000, Rémi Bernon wrote: > What about decoupling this from the definition status? Something like `is_imported`? I'm not sure I see how? If a type is just declared in an import, and defined in the main IDL, then we still want to define it. I don't see how to distinguish those two cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71433

1 0

Re: [PATCH v4 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Looks fine to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71432

1 0

Re: [PATCH v2 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

> I'm sorry but I've wasted enough time on this. I believe I'm still leaving more than enough time to give some feedback, either commenting on the code or even rejecting the changes for whatever reason you might find appropriate. I'm sorry for not reviewing I find it very difficult to want to review promptly when my review is invariably met with argument, insistence that there is only one correct way to do things, and inability or unwillingness to view things from my perspective. Despite this, I am sorry, and I will try to renew my efforts to review better. If you wish to have me removed as maintainer of winegstreamer, please propose that directly, rather than abusing GitLab to get your patches committed. As far as comment on this patch goes, I'm sorry if this is not quite as baked as I'd like it to be, but: * Renaming "preferred" to "current" is certainly true as far as the functionality of the code is, but it goes against its intent. The point of the "preferred" format is that it should be the one that does not require videoconvert, and therefore offers the best latency. (I know you come at things with a Media Foundation perspective, where the format is pretty much always specified by the application, but for DirectShow it's quite common to plug in a file and autoplug system components up to and including the renderer, so using GStreamer's preferred format is often perfectly feasible.) Hence I would rather see the code fixed so that the "preferred" caps remains what it is, and is not updated. * From what I've understood, getting rid of wg_format by itself does not save that many LoC. I'm still not convinced that it's a desirable change to make. I've already told you my intentions for wg_format, and despite the fact that you dismissed them as false, claiming it's an ad-hoc struct, I still believe that it's a desirable IR. I'm not convinced that the tradeoffs that you're trying to make are good ones. I'm not convinced they're *not*, either, which is part of why I hadn't said anything yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667#note_71430

1 0

Re: [PATCH 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Squad depends on that to properly fill audio capture device list for voice chat and handle capture device name change. The game uses mmdevapi objects for actual capturing so that fully works with this implementation (which is yet missing the actual media source implementation). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71429

1 0

Re: [PATCH v3 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > If you don't want to go through all the hassle, but still want to go "in > the right direction," please read my first comment. How's this? I don't think I need to translate the the SID itself -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71426

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > The `TOKEN_MANDATORY_LABEL` structure pointed by `ptr`, with length > `len`. This is documented in https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_in…. > You need to define both `TOKEN_MANDATORY_LEVEL32` (with ULONG in place > of pointers) and `TOKEB_MANDATORY_LABEL` (with actual pointers). > Also, don't assume `ptr` is not "used." Maybe *right now,* but ntdll and > wow64 are still separate components that can get out of sync without tests. If you don't want to go through all the hassle, but still want to go "in the right direction," please read my first comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71423

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > @iamahuman There is no parameters used so what should I translate? The `TOKEN_MANDATORY_LABEL` structure pointed by `ptr`, with length `len`. This is documented in https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_in…. You need to define both `TOKEN_MANDATORY_LEVEL32` (with ULONG in place of pointers) and `TOKEB_MANDATORY_LABEL` (with actual pointers). Also, don't assume `ptr` is not "used." Maybe *right now,* but ntdll and wow64 are still separate components that can get out of sync without tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71422

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > @DarkShadow44 you also have to translate 32bit struct parameter to 64bit > before passing to native. @iamahuman There is no parameters used so what should I translate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71421

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > Alright, updated @DarkShadow44 you also have to translate 32bit struct parameter to 64bit before passing to native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71414

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > struct location where; > unsigned int ignore : 1; > unsigned int defined : 1; > + unsigned int defined_in_import : 1; What about decoupling this from the definition status? Something like `is_imported`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71400

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/typetree.c: > error_loc("type %s already defined at %s:%d\n", type->name, type->where.input_name, type->where.first_line ); > > type->defined = TRUE; > + init_location(&type->where, NULL, NULL); It would be better to pass the explicit token location from the parser instead of relying on the implicit global last location. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71399

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > > struct location where; > > - unsigned int declonly : 1; > + /* Should we define the UDT in this var, when writing a header? */ > + bool define; This is the first and only use of `bool` in widl. Later, you're also introducing a new `unsigned int :1` field elsewhere. I think something like `is_definition` is also more appropriate for an object property. Same below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71398

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/parser.y: > tVOID { $$ = type_new_void(); } > | base_type { $$ = $1; } > | enumdef { $$ = $1; } > - | tENUM aIDENTIFIER { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > + | tENUM typename { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > | structdef { $$ = $1; } > - | tSTRUCT aIDENTIFIER { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > + | tSTRUCT typename { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > | uniondef { $$ = $1; } > - | tUNION aIDENTIFIER { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > + | tUNION typename { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > | tSAFEARRAY '(' type ')' { $$ = make_safearray($3); } > | aKNOWNTYPE { $$ = find_type_or_error(current_namespace, $1); } > ; As you're changing tabs into space, could you fix them in the entire `unqualified_type` rule? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71397

1 0

Re: [PATCH 0/2] MR5729: Fix SQLSetConnectOptionW prototype - approved
by Hans Leidekker (＠hans) 28 May '24

28 May '24

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5729

1 0

Re: [PATCH 0/1] MR5720: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found.
by Huw Davies (＠huw) 28 May '24

28 May '24

We'll want to keep both copies of `merge_devmode()` in sync, so please combine these two commits into one. Also, the subject of the commit message seems to have word-wrapped - please keep it as a single line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5720#note_71393

1 0

Re: [PATCH 0/3] MR5710: win32u: Get rid of the UpdatedDisplayDevices force parameter. - approved
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5710

1 0

Re: [PATCH v3 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Sun May 26 17:37:57 2024 +0000, Nikolay Sivov wrote: > I think this is would be better if done in para_set_fmt(). Instead of 32 > please use MAX_TAB_STOPS or ARRAY_SIZE(). Thanks, updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71383

1 0

2025

2024

2023

2022

wine-gitlab May 2024