May 2024 - wine-gitlab

Re: [PATCH v2 0/6] MR5697: Use DISPEX_IDISPATCH_IMPL (part 5) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5697

1 0

Re: [PATCH v2 0/1] MR5694: msvcrt: Fix _kbhit ignoring the last event. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5694

1 0

Re: [PATCH v8 0/6] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

1 0

Re: [PATCH v2 0/1] MR5695: odbc32: Allow null handle for SQLSetEnvAttr. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5695

1 0

[PATCH v2 0/1] MR5683: ntdll: Fill object pointer in NtQueryInformation( SystemHandleInformation / SystemExtendedHandleInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: ntdll: Fill object pointer in NtQueryInformation( SystemHandleInformation / SystemExtendedHandleInformation ). https://gitlab.winehq.org/wine/wine/-/merge_requests/5683

2 3

[PATCH 0/4] MR5641: Cmd engine rewrite (part IV)
by eric pouech (＠epo) 28 May '24

28 May '24

This is the fourth part in cmd.exe's engine rewrite. It concerns: - start of decoupling parsing from execution by introducing ad hoc structure to hold parsing result to be passed for execution (done here for redirection, and if conditions), - refactor execution code with putting into helpers: + change of input/output streams + save / restore of input/output streams before / after execution Note: - the handling of fd > 2 is clearly wrong, but it just mimics the current implementation. More work will be required afterwards (likely using directly CRT low level I/O), - I kept a few specific debug channels in place. They will be removed (or simplified at some point), but they could be useful to debug remaining issues. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5641

4 8

[PATCH v3 0/6] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- v3: win32u: Enumerate offscreen vulkan devices as GPU devices. win32u: Query GPU memory from vulkan physical device. win32u: Match driver GPUs with vulkan GPUS from their ids, or index. win32u: Keep a list of vulkan GPUS in the device manager context. win32u: Load the graphics driver vulkan functions lazily. win32u: Fix default_update_display_devices return type to NTSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

4 18

[PATCH 0/1] MR5694: msvcrt: Fix _kbhit ignoring the last event.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56697 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5694

3 2

[PATCH 0/1] MR5683: ntdll: Fill object pointer in NtQueryInformation( SystemHandleInformation / SystemExtendedHandleInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5683

3 5

[PATCH v6 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v6: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

2 2

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Tue May 21 09:53:24 2024 +0000, eric pouech wrote: > using strtol would be better and save you the str_is_number helper I can switch to strtol, but how does it save the `str_is_number` helper? It returns 0, which is a valid (if useless) timeout value for the native program. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71016

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Tue May 21 12:09:30 2024 +0000, eric pouech wrote: > I'd rather see this outside the do/while loop (and moreover, the second > count down shall be printed after this message) Yes, but it only overrides the "Waiting for %s seconds" part, which mostly matches Windows' behavior (from the cursor position). The only difference is that Windows will end at "Waiting for N". While it's possible to replicate this, I believe it may cause issues with translations. I can move it outside the do/while loop though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71014

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Tue May 21 10:23:40 2024 +0000, eric pouech wrote: > why do you need float operations here? (int)(ticks_remaining / 1000) > should do It needs to be rounded because otherwise it will start with printing "Waiting for N-1 seconds" due to one or more ticks having elapsed (at least on my machine). But yes, I could do an int roundup instead (`(ticks_remaining + 500) / 1000`). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71013

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

eric pouech (@epo) commented about programs/timeout/timeout_main.c: > + > +#include <stdio.h> > +#include <stdlib.h> > +#include <string.h> > +#include <conio.h> > +#include <math.h> > + > +#include <windows.h> > + > +#include "resources.h" > + > +#include <wine/debug.h> > + > +WINE_DEFAULT_DEBUG_CHANNEL(timeout); > + > +static char* get_string(int which) a couple of remarks here (about the helpers for printing): - returning ASCII strings could lose some bits in conversion, so you'd be safer keeping unicode string - also usage of (w)printf can lack flexibility in translations (it assumes all parameters have the same order whatever the translation). FormatMessage brings more flexibility as you can change the order of parameters in output. - and likely RPRINTF_VA could be rewritten as a function and not a macro -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71012

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

I don't think this brings lots of info. Using GetStdHandle(STD_INPUT_HANDLE) throughout the code doesn't change much -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71011

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

please check GetNumberofConsoleInputEvents() return value -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71010

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

you're leaking records in case of failure -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71009

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

On Tue May 21 09:53:24 2024 +0000, eric pouech wrote: > to be pedantic, native only allows one timeout value and prints error > when two are given using strtol would be better and save you the str_is_number helper -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71008

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

eric pouech (@epo) commented about programs/timeout/timeout_main.c: > + > + do > + { > + ticks_remaining = end_ticks - GetTickCount64(); > + > + wait_millis = ticks_remaining; > + if (wait_millis > 1000) > + wait_millis = 1000; > + > + printf("\r"); > + pad_number(padded_timeout, (int)roundf(ticks_remaining / 1000.), digits); > + RPRINTF_VA(STRING_WAITING_FOR_SECONDS, padded_timeout); > + > + if (!nobreak) > + { > + if (!printed_action_key) I'd rather see this outside the do/while loop (and moreover, the second count down shall be printed after this message) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71007

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

why do you need float operations here? (int)(ticks_remaining / 1000) should do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71006

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) 28 May '24

28 May '24

actually, timeout_main.c in a bit redundant as a filename (timeout.c or main.c should be enough) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71005

1 0

[PATCH v3 0/4] MR5674: quartz: AVI decompressor fixes.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

-- v3: quartz: Hold the streaming lock while calling ICDecompressEnd. quartz: Use the correct stride when calculating image size in AVIDec. quartz: Get output format from source, not sink in AVIDec. quartz/tests: Use unaligned width in AVIDec tests to expose incorrect stride calculation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5674

3 7

[PATCH 0/1] MR5695: odbc32: Allow null handle for SQLSetEnvAttr.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

can be null for SQL_ATTR_CONNECTION_POOLING -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5695

3 2

Re: [PATCH v4 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Mon May 20 21:34:08 2024 +0000, eric pouech wrote: > agreed (except perhaps for the padding of the N seconds... not that it > would make sense to replicate the padding, but I'm not sure the printf > has a trailing whitespace so that it erases the last visible char when > the width of N is reduced) I've added the padding, and replicated the behavior of the native program by only updating the "Waiting for N seconds" text. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_70991

1 0

Re: [PATCH v2 0/1] MR5693: ntdll: Don't warn on macOS and FreeBSD when xattr doesn't exist. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5693

1 0

Re: [PATCH v2 0/2] MR5662: oleaut32: Handle cases where invoking a get-only property with... - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5662

1 0

Re: [PATCH v3 0/1] MR5664: opengl32: Remove the wglDescribePixelFormat driver entry point. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5664

1 0

Re: [PATCH v2 0/1] MR5684: win32u: Remove external fonts from the registry before writing to it. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5684

1 0

Re: [PATCH v2 0/5] MR5688: gdiplus: Removing gdi32 objects from gdiplus objects. (part 5) - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5688

1 0

Re: [PATCH v2 0/1] MR5689: gitlab: Add unzip to build image. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5689

1 0

Re: [PATCH v2 0/1] MR5686: wine.inf: Add InstallationType field to CurrentVersion. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5686

1 0

[PATCH v2 0/3] MR5674: quartz: AVI decompressor fixes.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

-- v2: quartz: Hold the streaming lock while calling ICDecompressEnd. quartz: Use the correct stride when calculating image size in AVIDec. quartz: Get output format from source, not sink in AVIDec. https://gitlab.winehq.org/wine/wine/-/merge_requests/5674

3 5

[PATCH 0/2] MR5687: ddraw: Set dwMaxVertexCount to 2048.
by Stefan Dösinger (＠stefan) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44863 The bug has been fixed already by moving ddraw4 vertex buffers into system memory. Changing this value makes the game create a smaller buffer, which makes the game fast on video memory buffers. I think we should stay close to what Windows drivers report even though we mitigated the original issue in a different way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5687

3 7

[PATCH v7 0/6] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- v7: winewayland.drv: Populate vkey to wchar entry for VK_DECIMAL. user32/tests: Add tests for SendInput with numpad scancodes. server: Send numpad virtual keys if NumLock is active. win32u: Store the full KBD vkey information in kbd_tables_init_vsc2vk. win32u: Allow drivers to send only the scan code for keyboard events. https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 10

[PATCH 0/5] MR5688: gdiplus: Removing gdi32 objects from gdiplus objects. (part 5)
by Esme Povirk (＠madewokherd) 28 May '24

28 May '24

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/5593 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5688

2 6

[PATCH v6 0/6] MR5601: Draft: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- v6: winewayland.drv: Populate vkey to wchar entry for VK_DECIMAL. user32/tests: Add tests for SendInput with numpad scancodes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 12

[PATCH v2 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v2: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

3 5

[PATCH 0/2] MR5662: oleaut32: Handle cases where invoking a get-only property with...
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

oleaut32: Handle cases where invoking a get-only property with INVOKE_PROPERTYPUT returns DISP_E_BADPARAMCOUNT. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56666 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5662

4 4

[PATCH 0/1] MR4837: Draft: DEBUG Check if GitLab takes PARENTSRC into account.
by Francois Gouget (＠fgouget) 28 May '24

28 May '24

It should run the xaudio2_7:xaudio2 test when xaudio2_8/tests/xaudio2.c is modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4837

5 4

[PATCH 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

3 12

[PATCH 0/1] MR5684: win32u: Remove external fonts from the registry before writing to it.
by Danyil Blyschak (＠blyss) 28 May '24

28 May '24

In update_external_font_keys(), remove the fonts from the registry immediately after we mark them for deletion, and then proceed to add or update values in the registry. This prevents a font from being marked as deleted, then being updated in the registry, and then removed from the registry regardless. When this happened, the registry would not contain the value for this font that we intended to update it with. This function would need to run again for this value to be added to the registry, but since this function runs during initialization, this means that a subsequent launch of wine was necessary. By removing the old value from the registry first, and then adding the new one, the initialization process becomes idempotent starting from the first run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5684

3 2

[PATCH v2 0/1] MR5664: opengl32: Remove the wglDescribePixelFormat driver entry point.
by Alexandros Frantzis (＠afrantzis) 28 May '24

28 May '24

All drivers have now switched to the get_pixel_formats entry point. -- v2: opengl32: Remove the wglDescribePixelFormat driver entry point. https://gitlab.winehq.org/wine/wine/-/merge_requests/5664

3 2

[PATCH 0/1] MR5690: secur32: Allow overriding GnuTLS debug level.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5690

3 2

[PATCH v2 0/1] MR5633: win32u: Fallback to default script if vert/vrt2 is not found.
by Akihiro Sagawa (＠sgwaki) 28 May '24

28 May '24

Also added and prioritized `DFLT` as the default script tag, with `dflt` as a secondary option. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56658 -- v2: win32u: Fallback to default script if vert/vrt2 is not found. https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

4 5

Re: [PATCH v2 0/4] MR5675: Unmangling fixes.
by eric pouech (＠epo) 28 May '24

28 May '24

On Sat May 18 08:22:49 2024 +0000, Piotr Caban wrote: > Did you consider changing `get_args` prototype to something like: > `static char* get_args(struct parsed_symbol* sym, BOOL func)`? I think > that `z_term` argument name is not very descriptive. `open_char` and > `close_char` seems to be redundant. yes I thought about it (with same reasoning as yours). Didn't do it at once because I wondered where to put the open/closing argument (keep it inside get_args() as it is today or move it to caller site) and I wanted to cover the throw clauses that we don't handle yet first (to check the impacts -if any- in handling of end of parameters' type list marker). will include in next round if it fits well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5675#note_70879

1 0

[PATCH 0/1] MR5686: wine.inf: Add InstallationType field to CurrentVersion.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5686

3 3

Re: [PATCH v5 0/2] MR5634: win32u: Ignore WM_MOUSEMOVE when tracking scrollbar and arrow/track is clicked - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5634

1 0

Re: [PATCH v2 0/1] MR5673: mmdevapi: Remove unused ACImpl typedef. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5673

1 0

Re: [PATCH v2 0/1] MR5682: maintainers: Remove Andrew Eikum. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5682

1 0

Re: [PATCH v2 0/4] MR5675: Unmangling fixes. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5675

1 0

2025

2024

2023

2022

wine-gitlab May 2024