May 2024 - wine-gitlab

[PATCH v5 0/1] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 29 May '24

29 May '24

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v5: win32u: Implement EVENT_SYSTEM_FOREGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

3 2

[PATCH v4 0/2] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 29 May '24

29 May '24

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v4: user32: Run tests that notice focus changes early. win32u: Implement EVENT_SYSTEM_FOREGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 10

[PATCH v2 0/1] MR5749: Draft: gitlab: Update configuration for the new Mac runner.
by Tim Clem (＠tclem) 29 May '24

29 May '24

Two main changes: - VM configuration in build.yml for the executor. - The build-mac script is now architecture-agnostic. -- v2: gitlab: Update configuration for the new Mac runner. https://gitlab.winehq.org/wine/wine/-/merge_requests/5749

3 7

[PATCH 0/1] MR5750: ntdll: Add stub RtlLookupGenericTableAvl function.
by Vijay Kiran Kamuju (＠infyquest) 29 May '24

29 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56736 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5750

2 1

[PATCH 0/1] MR5749: Draft: gitlab: Update configuration for the new Mac runner.
by Tim Clem (＠tclem) 29 May '24

29 May '24

Two main changes: - VM configuration in build.yml for the executor. - The build-mac script is now architecture-agnostic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5749

2 1

[PATCH v3 0/7] MR5747: win32u: Introduce a wrapper to flush window surfaces.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v3: win32u: Use a helper to flush window surface, factor locking and bounds reset. wineandroid: Hold the lock while reading window surface bits. winemac: Get rid of unnecessary blit_data / drawn surface members. win32u: Move window surface bounds to the window_surface base struct. win32u: Use helpers to lock/unlock window surfaces. win32u: Move the window surface mutex to the surface header. win32u: Introduce a new window_surface_init helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

3 9

[PATCH v2 0/6] MR5747: win32u: Introduce a wrapper to flush window surfaces.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- v2: win32u: Use a helper to flush window surface, factor locking and bounds reset. winemac: Get rid of unnecessary blit_data / drawn surface members. win32u: Move window surface bounds to the window_surface base struct. win32u: Use helpers to lock/unlock window surfaces. win32u: Move the window surface mutex to the surface header. win32u: Introduce a new window_surface_init helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

4 9

Re: [PATCH v4 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 29 May '24

29 May '24

I looked a bit at mmdevice properties, turns out device strings are available directly from property store, using this key: {9c119480-ddc2-4954-a150-5bd240d454ad},1 The only problem is it's not documented in SDK. But the idea would be to populate property store with setupapi, or use setupapi/cfgmgr directly. Anyway, mentioning this in case we'll even need it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71634

1 0

[PATCH v2 0/5] MR5564: mmdevapi: Adjust timing in AudioClient_Initialize, removing related code from drivers.
by Davide Beatrici (＠davidebeatrici) 29 May '24

29 May '24

Trace output with PulseAudio: ``` 0230:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0230:trace:mmdevapi:adjust_timing Device periods: 100000 default and 30000 minimum 0230:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v2: winepulse: Remove superfluous timing adjustment. wineoss: Remove superfluous timing adjustment. winecoreaudio: Remove superfluous timing adjustment. winealsa: Remove superfluous timing adjustment. mmdevapi: Adjust timing in AudioClient_Initialize. https://gitlab.winehq.org/wine/wine/-/merge_requests/5564

4 12

Re: [PATCH v4 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Huw Davies (＠huw) 29 May '24

29 May '24

It looks like most of the issues @nsivov pointed out [here](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.org… are yet to be addressed. A few other things: - `pidlFQ` should be freed with `ILFree()` - Let's call it something less opaque like `full_pidl` - Switch to using `malloc()` / `free()` - If we really need the string functions, let's use `wcscpy()` etc -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_71626

1 0

2025

2024

2023

2022

wine-gitlab May 2024