May 2024 - wine-gitlab

Re: [PATCH v4 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Nikolay Sivov (＠nsivov) 29 May '24

29 May '24

I looked a bit at mmdevice properties, turns out device strings are available directly from property store, using this key: {9c119480-ddc2-4954-a150-5bd240d454ad},1 The only problem is it's not documented in SDK. But the idea would be to populate property store with setupapi, or use setupapi/cfgmgr directly. Anyway, mentioning this in case we'll even need it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71634

1 0

[PATCH v2 0/5] MR5564: mmdevapi: Adjust timing in AudioClient_Initialize, removing related code from drivers.
by Davide Beatrici (＠davidebeatrici) 29 May '24

29 May '24

Trace output with PulseAudio: ``` 0230:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0230:trace:mmdevapi:adjust_timing Device periods: 100000 default and 30000 minimum 0230:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v2: winepulse: Remove superfluous timing adjustment. wineoss: Remove superfluous timing adjustment. winecoreaudio: Remove superfluous timing adjustment. winealsa: Remove superfluous timing adjustment. mmdevapi: Adjust timing in AudioClient_Initialize. https://gitlab.winehq.org/wine/wine/-/merge_requests/5564

4 12

Re: [PATCH v4 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Huw Davies (＠huw) 29 May '24

29 May '24

It looks like most of the issues @nsivov pointed out [here](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.org… are yet to be addressed. A few other things: - `pidlFQ` should be freed with `ILFree()` - Let's call it something less opaque like `full_pidl` - Switch to using `malloc()` / `free()` - If we really need the string functions, let's use `wcscpy()` etc -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_71626

1 0

[PATCH 0/6] MR5747: win32u: Introduce a wrapper to flush window surfaces.
by Rémi Bernon (＠rbernon) 29 May '24

29 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

3 7

[PATCH v5 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 29 May '24

29 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56730 -- v5: riched20: In para_set_fmt protect against out of bound cTabStop values https://gitlab.winehq.org/wine/wine/-/merge_requests/5727

4 3

Re: [PATCH v2 0/5] MR5745: wined3d: Remove miscellaneous unused definitions, part 3/4. - approved
by Jan Sikorski (＠jsikorski) 29 May '24

29 May '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5745

1 0

[PATCH v3 0/4] MR5584: mf: Fixes the missing MESessionClosed event in various scenarios.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

Killsquad sends a MESessionClose at various times depending on user input. It always expects a MESessionClosed event and will wait indefinitely if not received. There are currently a number of scenarios where we don't report the MESessionClose event. This MR attempts to fix that. -- v3: mf: Handle Source/Sink shutdown whilst waiting for an event. mf: Handle an error during Media Session Close. mf: Handle MediaSession Close when state is SESSION_STATE_RESTARTING_SOURCES. mf/tests: Add additional tests for MESessionClosed event. https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

3 5

[PATCH v3 0/3] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- v3: server: Don't always return STATUS_OBJECT_NAME_INVALID on ENOTDIR. https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

Re: [PATCH v4 0/3] MR5737: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

On Tue May 28 08:16:35 2024 +0000, Brendan McGrath wrote: > I just tested on Windows, and that's exactly what it does. I'll update > the MR. Thanks for taking a look @nsivov. I think I've fixed it in the right spot now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737#note_71615

1 0

[PATCH v2 0/3] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 29 May '24

29 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- v2: server: Don't return STATUS_OBJECT_NAME_INVALID on ENOTDIR. ntdll/tests: Test error code when NtOpenFile uses file as directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

2025

2024

2023

2022

wine-gitlab May 2024