May 2024 - wine-gitlab

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 12:16:18 2024 +0000, eric pouech wrote: > [err](/uploads/6c39c40a566da58e25661ae18e455f1c/err) Yes I was thinking about something like you have attached first but I didn't like few things: - it requires adding new flag - it's a special marker that is only valid in template, it can't be used as datatype in other places - your code is also not eating final '@' correctly but it can be addressed easily -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70520

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

On Wed May 15 10:08:14 2024 +0000, Piotr Caban wrote: > I can't see the patch, could you please fix the link? [err](/uploads/6c39c40a566da58e25661ae18e455f1c/err) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70517

1 0

[PATCH v2 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix.
by Connor McAdams (＠cmcadams) 28 May '24

28 May '24

-- v2: d3dx9: Fix destination rectangles passed from D3DXLoadSurfaceFromMemory() to d3dx_load_image_from_memory(). d3dx9: Only do direct copies of full blocks for compressed formats. d3dx9/tests: Add a new compressed surface loading test. d3dx9/tests: Add a test for negative values in the source rectangle passed to D3DXLoadSurfaceFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

3 7

[PATCH 0/1] MR5650: msvcrt,winedump: Demandle std::nullptr_t datatype.
by eric pouech (＠epo) 28 May '24

28 May '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5650

5 4

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by Piotr Caban (＠piotr) 28 May '24

28 May '24

On Wed May 15 08:07:21 2024 +0000, eric pouech wrote: > that test looks very strange at that place while we already have > handling of other types starting with "$$" in demangle_datatype. > it calls for having a proper identification about end of list (didn't > include the function arg one, but we could well do it) > I think we could rather use something like the attached patch. > [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ I can't see the patch, could you please fix the link? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70505

1 0

[PATCH v2 0/5] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- v2: win32u: Enumerate offscreen vulkan devices as GPU devices. win32u: Query GPU memory from vulkan physical device. win32u: Match driver GPUs with vulkan GPUS from their ids, or index. win32u: Keep a list of vulkan GPUS in the device manager context. win32u: Fix default_update_display_devices return type to NTSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

4 9

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template.
by eric pouech (＠epo) 28 May '24

28 May '24

eric pouech (@epo) commented about dlls/msvcrt/undname.c: > sym->current++; > break; > } > + /* Handle empty list in variadic template */ > + if (!z_term && sym->current[0] == '$' && sym->current[1] == '$' && sym->current[2] == 'V') that test looks very strange at that place while we already have handling of other types starting with "$$" in demangle_datatype. it calls for having a proper identification about end of list (didn't include the function arg one, but we could well do it) I think we could rather use something like the attached patch. [err](/uploads/8c2f1adecffbfe57c3d3bf924bf1755a/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70497

1 0

[PATCH 0/4] MR5644: d3dx9: New tests and a compressed image loading bugfix.
by Connor McAdams (＠cmcadams) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5644

4 8

Re: [PATCH v2 0/1] MR5636: opengl32: Prefer formats with depth if unspecified in wglChoosePixelFormat(). - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5636

1 0

Re: [PATCH v2 0/2] MR5646: ucrtbase: Handle empty list in variadic template. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5646

1 0

2025

2024

2023

2022

wine-gitlab May 2024