Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered
whatever the type of the underlying fd (previously, native only set it to
unbuffered when attached to character fd (console, NUL...)).
This serie adds also tests for msvcrt & ucrtbase to show the discrepancies.
Note: ucrtbase's tests also include a reversed engineered structure layout
for FILE.
_get_stream_buffer_pointers already gives base, ptr and cnt, and toying with
setvbuf gave easily the rest of the fields.
Didn't spend time in guessing the flags meaning: which look different
from msvcrt's.
Related to https://bugs.winehq.org/show_bug.cgi?id=56459
@piotr: I can share the details (the access to the test result in the bug
report is limited).
--
v2: msvcrt: Let stderr be always be unbuffered.
ucrtbase/tests: Add tests for checking buffering state of standard streams.
msvcrt/tests: Add tests for check buffering state of standard streams.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5462
On Thu Apr 4 03:18:16 2024 +0000, Sam Joan Roque-Worcel wrote:
> Correct! In Windows, these are missing in Tahoma, but are present in MS Gothic.
> Things I considered doing:
> - I attempted to find a suitable, metric-compatible font capable of
> replacing MS Gothic but it is very particular, and nothing fits the bill
> - I thought about creating a metric compatible font, but I'm not sure
> that this approach would be the best as it is very time consuming.
> - I thought about creating a bare-bones font and shipping it with Wine,
> which contains only these three glyphs. This would potentially break
> Wine for users who have installed Microsoft's font, depending of the
> order of precedence in font loading (I'm not sure about this one)
> So as a workaround, I added them to Tahoma which doesn't have any of
> those disadvantages. If you can suggest a better approach though please
> let me know and I will look into it.
Hmm I thought the tests I was getting were flakey, but it seems that my changes here are causing failing tests. I may ask in IRC if anyone can think of a better approach.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5447#note_67123
The BURIKO visual novel engine (as seen in, for example, https://store.steampowered.com/app/1200720/MakingLovers/) demands that the upstream filter tries to connect with a MPEG format type.
Then it memorizes the resolution, rejects the connection, and expects upstream to try RGB32 or RGB24 instead.
It also passes an empty string as filename, and demands this exact error code.
I have no idea why.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56491
--
v6: quartz: Fix memory leak on failure path.
quartz/tests: Test the new error codes.
quartz: Fix error code on empty filename.
quartz/tests: Test that compressed formats are offered for MPEGs.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5419