June 2024 - wine-gitlab

[PATCH v19 0/5] MR820: Implement application hives
by Santino Mazza (＠tati1454) 31 May '25

31 May '25

-- v19: kernelbase: Implement RegLoadAppKey. ntdll: Implement REG_APP_HIVE flag server: Create \REGISTRY\A hive. ntdll: Rename NtLoadKeyEx parameters. ntdll: Pass filename to server in NtLoadKeyEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/820

5 15

[PATCH v6 0/2] MR4812: user32: Fix the number of characters processed by DrawTextExW.
by JiangYi Chen (＠meshine) 29 May '25

29 May '25

Description: When flags does not include DT_CALCRECT, since len is calculated in the middle, it will be reduced to zero. Resulting in the length of the processed string that is finally returned to zero and the non-processing string length is unchanged. But some application taking the non-processing string length to zero as the loop end condition. Log: Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: Icc0f250f5f4faba1bee8326fc911a4fc9cd7c012 -- v6: user32: Fix the number of characters processed by DrawTextExW. user32/tests: Add tests for DrawTextExW. https://gitlab.winehq.org/wine/wine/-/merge_requests/4812

3 5

[PATCH v11 0/1] MR4809: Draft: wip! winewayland.drv: Try to support smooth scroll events
by Ray Strode (＠halfline) 21 May '25

21 May '25

Wayland has 3 types of scrolling events: - axis. Used for e.g., touchpad 2 finger smooth scrolling - axis_discrete. Used for mouse scroll wheels (i.e., notches) - axis_value120. Used for high resolution input devices Wine currently only supports axis_discrete, meaning that 2 finger scroll events get ignored. This commit tries to add basic support for axis scrolling events, by translating the smooth motion in scroll increments using some primitive assumptions about line height and number of lines to scroll. -- v11: wip! winewayland.drv: Try to support smooth scroll events https://gitlab.winehq.org/wine/wine/-/merge_requests/4809

6 13

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) 07 May '25

07 May '25

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8

[PATCH 0/1] MR4635: ntdll: Avoid abort process when internal string printing function used for debugging.
by 江仪陈 (＠meshine) 30 Apr '25

30 Apr '25

Description: The printing function (non-Windows application call) used by Wine developers is unnecessary to abort process when the string is super long. For example, the developer prints a long commandline of wwmapp.exe by MESSAGE. As a result, the process cannot be started, and the conference function cannot be used. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: If06f0309f9745777f89b07dff8d302cb34b2a90e -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4635

3 2

[PATCH 0/2] MR5285: AMD Radeon Vega 7 Renoir pci-ids
by Carlos Rodriguez (＠mrdeathjr28) 24 Apr '25

24 Apr '25

With this patch wine can recognize amd radeon vega 7 renoir (actually appears like radeon RX 5600) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5285

4 5

[PATCH v2 0/2] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) 07 Apr '25

07 Apr '25

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- v2: win32u: NtGdiExtTextOutW() should translate x,y from logical to device units at the last step. win32u: Fix device<->world width/height converters. https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

4 16

[PATCH 0/1] MR4740: ntdll: Don't hardcode pagesize when allocating handles
by Fabian Maurer (＠DarkShadow44) 02 Apr '25

02 Apr '25

Not really needed for 16k pages, but since the comment says "one page" the logic should reflect that. Not 100% sure about that since I don't know why it should use exactly one page, so please double check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4740

2 2

[PATCH 0/2] MR4738: ntdll/unix: Don't hardcode page_size, page_shift and page_mask
by Fabian Maurer (＠DarkShadow44) 31 Mar '25

31 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52715 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4738

3 4

[PATCH v2 0/1] MR4739: ntdll: Don't hardcode page size
by Fabian Maurer (＠DarkShadow44) 31 Mar '25

31 Mar '25

While this is not needed for 16k pages to work, it does seem sensible. -- v2: ntdll: Don't hardcode page size https://gitlab.winehq.org/wine/wine/-/merge_requests/4739

3 3

[PATCH v2 0/1] MR3868: user32/tests: Account for some messages from dual-monitor setups.
by Esme Povirk (＠madewokherd) 28 Mar '25

28 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54031 -- v2: user32/tests: Account for some messages from dual-monitor setups. https://gitlab.winehq.org/wine/wine/-/merge_requests/3868

3 2

[PATCH v67 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 25 Mar '25

25 Mar '25

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v67: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

8 22

[PATCH v7 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 24 Mar '25

24 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v7: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

5 13

[PATCH v7 0/1] MR5145: opengl32: speed up wow64 mapping
by Etaash Mathamsetty (＠etaash.mathamsetty) 19 Mar '25

19 Mar '25

My hardware is Ryzen 7 4700u with the integrated graphics Flatout (Direct3D 9): 20 fps (renders correctly) Unigine Heaven (OpenGL): ~40-60 fps (renders correctly) Unigine Heaven (Direct3D 9): 20-30 fps (renders correctly) Unigine Heaven (Direct3D 11): 20-30 fps as well (renders correctly) Elder Scrolls IV (Direct3D 9): 20 fps (renders correctly) BeamNG Tech Demo 0.3 (Direct3D 9): 2 fps (renders correctly, but still runs poorly) Massive step up from getting 2 fps across many wined3d games, but it's still pretty bad, ~~and sometimes runs worse than the original code~~. Now with a combination of using the new and old code dynamically you can get the best of both worlds! Unfortunately, we lose the ability to get lucky with the mapping just happening to be in the 32 bit range. -- v7: opengl32: speed up wow64 mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/5145

5 6

[PATCH 0/1] MR3862: user32/tests: Ignore other messages in test_broadcast.
by Esme Povirk (＠madewokherd) 18 Mar '25

18 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54194 If the SendMessageTimeout call takes a long time, we can get other messages which also set the observed wparam value. Apparently, this is especially likely on Windows 7. This also removes the (wParam == 0xbaadbeef) check which may have been intended to serve the same goal but doesn't work because the observed wParam value is still assigned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3862

3 2

[PATCH 0/1] MR3857: d3d11/tests: Properly mark the indexed sample position test as succeeding with the Vulkan backend.
by Henri Verbeet (＠hverbeet) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3857

4 4

[PATCH v3 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- v3: iphlpapi/tests: Call GetExtendedTcp/UdpTable() in a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

3 4

[PATCH v2 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- v2: iphlpapi/tests: Call GetExtendedTcp/UdpTable() in a loop. iphlpapi/tests: Call GetAdaptersAddresses() in a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

4 6

[PATCH 0/1] MR3838: kernel32/tests: Allow a 0 removed entry count in the completion test.
by Francois Gouget (＠fgouget) 16 Mar '25

16 Mar '25

This matches the ntdll:file fix. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54554 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3838

3 2

[PATCH 0/1] MR3837: quartz/tests: Fix segfault in changed3ddevice test.
by Alfred Agrell (＠Alcaro) 16 Mar '25

16 Mar '25

Fixes regression from https://gitlab.winehq.org/wine/wine/-/merge_requests/3792 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3837

4 4

[PATCH 0/1] MR3835: winscard/tests: Skip tests when SCardListReadersA() returns an empty list.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3835

3 2

[PATCH 0/1] MR3834: wpcap/tests: Accept another return value from pcap_can_set_rfmon().
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3834

3 2

[PATCH 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test.
by Hans Leidekker (＠hans) 16 Mar '25

16 Mar '25

As shown by the testbot, doubling is not always sufficient. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

4 6

[PATCH 0/2] MR3822: user32/tests: Account for ignored messages during wait.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53435 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3822

3 4

[PATCH 0/1] MR3818: Draft: urlmon: test http with auto redirect disabled, and CreateBinding
by Yuxuan Shui (＠yshui) 15 Mar '25

15 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3818

4 9

[PATCH 0/1] MR3817: ntdll/test: Updated link test to reflect Windows 11 behaviour.
by Joel Holdsworth (＠jhol) 15 Mar '25

15 Mar '25

Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3817

3 2

[PATCH 0/1] MR3801: user32/tests: Detect win7's broken GetQueueStatus behavior.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Unlike most of these user32:msg failures, this one is consistent. No bug report for this specifically but https://bugs.winehq.org/show_bug.cgi?id=53434 comments 3 and 4 has related info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3801

3 2

[PATCH v2 0/1] MR3783: user32/tests: Register test_hvredraw class in temp desktop.
by Esme Povirk (＠madewokherd) 15 Mar '25

15 Mar '25

Windows v1709 has a bug that breaks GetClassLong on a different desktop from where the class was registered. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55539 -- v2: user32/tests: Register test_hvredraw class in temp desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3783

3 3

[PATCH 0/2] MR3788: iphlpapi/tests: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 15 Mar '25

15 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54588 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3788

4 4

[PATCH 0/1] MR3783: user32/tests: Register test_hvredraw class in temp desktop.
by Esme Povirk (＠madewokherd) 10 Mar '25

10 Mar '25

Windows v1709 has a bug that breaks GetClassLong on a different desktop from where the class was registered. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55539 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3783

4 5

[PATCH v2 0/1] MR3774: gdiplus/tests: Extend DrawImage scaling tests.
by Bartosz Kosiorek (＠gang65) 10 Mar '25

10 Mar '25

Changing the colour of the second pixel of the source bitmap clarifies the incorrect behaviour of PixelOffsetMode Half and HighQuality. This also provides better proof that PixelOffsetMode None and Fast are implemented correctly. Extending tests is starting point for further improvements of implementation pixel offset modes to match implementation from native gdiplus. -- v2: gdiplus/tests: Extend DrawImage scaling tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3774

4 4

[PATCH 0/2] MR3735: user32/tests: Wait for GetMessage call to complete.
by Esme Povirk (＠madewokherd) 09 Mar '25

09 Mar '25

It's possible otherwise for the second message to be sent before GetMessage removes a posted message from the queue, in which case GetMessage processes both sent messages. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54407 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3735

3 3

[PATCH 0/1] MR3720: wtsapi/tests: Use a heap buffer for the user SID.
by Hans Leidekker (＠hans) 09 Mar '25

09 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55227 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3720

3 2

[PATCH 0/1] MR3721: webservices/tests: Fully initialize xmlstr.
by Hans Leidekker (＠hans) 09 Mar '25

09 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3721

3 2

[PATCH 0/1] MR3719: d3d9/tests: Don't fail d3d9ex if the window manager restores focus too soon.
by Stefan Dösinger (＠stefan) 09 Mar '25

09 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3719

5 5

[PATCH v4 0/4] MR3675: dmsynth/tests: Test the synthesizer components and render some samples from MIDI.
by Rémi Bernon (＠rbernon) 09 Mar '25

09 Mar '25

-- v4: dmsynth/tests: Test DirectMusicSynth class in isolation. dmsynth/tests: Test DirectMusicSynthSink class in isolation. dmsynth/tests: Import and use a check_interface helper. dmsynth/tests: Avoid dynamic format string. https://gitlab.winehq.org/wine/wine/-/merge_requests/3675

4 10

[PATCH 0/9] MR5057: Draft: winewayland.drv: Use virtual display devices to implement mode change emulation
by Alexandros Frantzis (＠afrantzis) 07 Mar '25

07 Mar '25

This WIP branch prototypes the usage of virtual display devices (through "virtual desktop" mode at the moment) to support display mode emulation in the Wayland driver. It works by allowing the driver to mark each host adapter with a virtual_id, which, if present, signals to win32u that it should include the adapter in the virtual display configuration. The virtual configuration (along with the virtual ids) is reported back to the driver though a new user driver function. If none of the host adapters is marked with a virtual id (i.e., all other drivers) we fall back to the single virtual display mode as before. Some deficiencies and open questions with the prototype: 1. Virtual desktop mode implies a lot of behavior that we don't want at this point the Wayland driver (e.g., taskbar window, changing the display mode to the virtual desktop resolution at startup, some changes in fsclip behavior). One way forward would be to have a "virtual display devices" mode separate from the "virtual desktop" mode, so that drivers can opt in only to the desired behavior (virtual desktop would imply virtual devices, to maintain the current behavior). 2. It's not clear to me what would be the best way for a driver to opt in or out of certain core behavior. Perhaps the driver would change some volatile registry key which other components would consult? Or introduce a user driver function for core to query the driver about such features on demand? Is there some precedence I can get inspiration from? 3. At the moment, the prototype calls the new "NotifyVirtualDevices" user driver callback only in the process which the display update occurred. This means that other processes don't get notified of the virtual devices mapping to host devices, so, in the Wayland driver case, we are not able to scale windows from those processes properly. One approach would be for core to ensure that the NotifyVirtualDevices callback is called once in all processes, but I am not sure what's the best way to achieve this (or even if this is the preferred approach). Another way would be to have a mechanism for the driver to query the virtual device info (+mappings) on demand, and just broadcast a message to all windows. In this case it could even be done internally by the driver (so more in line with what the part-12 MR is doing), if we don't want to introduce a more global behavior. Perhaps there is some even better mechanism, which would also be more fitting to how we envision the virtual display/devic es to evolve going forward. Let me know what you think! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5057

5 25

[PATCH 0/1] MR3131: gdiplus: Fix gif shows misplaced.
by Jiajin Cui (＠jin-king1) 04 Mar '25

04 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54271 Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3131

3 6

[PATCH 0/1] MR4662: properly track refcount and dependencies with forwarded exports.
by YUAN RUI (＠number201724) 25 Feb '25

25 Feb '25

fix: https://bugs.winehq.org/show_bug.cgi?id=52094 tests: ``` #include <Windows.h> #ifdef FROM_IMPORT #pragma comment(lib, "python3.lib") extern "C" int Py_IsInitialized(); #endif int main() { #ifdef FROM_IMPORT // test from import table Py_IsInitialized( ); #else // //Test ref count int (*Py_IsInitialized)(); HMODULE hmod_310 = LoadLibraryA( "C:\\Python310\\python310.dll" ); HMODULE hmod = LoadLibraryA( "C:\\Python310\\python3.dll" ); if ( !hmod ) return 0; *(FARPROC*)&Py_IsInitialized = GetProcAddress( hmod, "Py_IsInitialized" ); FreeLibrary( hmod_310 ); Py_IsInitialized( ); FreeLibrary( hmod ); // test dependencies hmod = LoadLibraryA( "C:\\Python310\\python3.dll" ); if ( !hmod ) return 0; *(FARPROC*)&Py_IsInitialized = GetProcAddress( hmod, "Py_IsInitialized" ); Py_IsInitialized(); FreeLibrary( hmod ); #endif return 0; } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4662

5 5

[PATCH 0/3] MR3124: Move periodic registry save out of wineserver
by Paul Gofman (＠gofman) 25 Feb '25

25 Feb '25

The problem is that registry save is a very heavy operation (scheduled each 30sec in wineserver) during which server doesn't process any requests and the whole prefix is stalled for the duration of the operation. For some reference, the process takes from 50-100ms here up to 1-1.5sec with default initial registry (after some registry modifications which trigger actual registry flush), depending on the filesystem type and state (as huge time may be spent in file close / rename). With the same registry after this patchset the server part (flush_key returning the whole registry data) is taking ~4-5mcs, measured from the client side so that already includes data transfer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3124

5 9

[PATCH v9 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 25 Feb '25

25 Feb '25

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- v9: ntdll: Add NtGetNextProcess stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

2 3

[PATCH 0/5] MR4894: setupapi: implement CM_Locate_DevNode
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Feb '25

17 Feb '25

This api is used by libxess on intel GPUs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4894

3 8

[PATCH v3 0/2] MR5360: gdiplus: Check for empty height in bonding box calculation
by James McDonnell (＠ElementalWarrior) 16 Feb '25

16 Feb '25

This resolves the issue in StudioTax where the bounding box dimensions is reported as 0. Because the height is less than 0, the check for height in GdipAddPathRectangle fails, and the X and Y coordinates of the points is never set. I am fairly ignorant of this code, this seems like a good approach, however I am happy for guidance from others more familiar in how gdiplus works. -- v3: gdiplus: Fix text height calculation when exceeding rect gdiplus: Check for NoClip in text height calculation https://gitlab.winehq.org/wine/wine/-/merge_requests/5360

3 6

[PATCH v6 0/2] MR4518: ntdll: Integrate with GDB using r_debug.
by Rémi Bernon (＠rbernon) 15 Feb '25

15 Feb '25

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- v6: ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose the standard debugging symbols for GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

6 12

[PATCH v7 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 15 Feb '25

15 Feb '25

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v7: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

5 9

[PATCH v5 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu (＠insn) 31 Jan '25

31 Jan '25

-- v5: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

3 9

[PATCH 0/1] MR3109: imm32: Don't export internal variables.
by Alex Henrie (＠alexhenrie) 24 Jan '25

24 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3109

6 22

[PATCH 0/12] MR5680: win32u: Implement per-monitor DPI scaling for virtual display modes.
by Rémi Bernon (＠rbernon) 24 Jan '25

24 Jan '25

For winewayland display modes emulation, instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/5057. Also this could be a move toward implementing some kind of fshack upstream. (Also includes !5679, I'll rebase it when it is merged). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5680

4 16

[PATCH v2 0/2] MR825: winex11.drv: optimize repeated ClipCursor calls
by Jan Klötzke (＠jkloetzke) 18 Dec '24

18 Dec '24

At least Doom 64 calls ClipCursor() with identical parameters repeatedly, which seems to cause a considerable overhead. Together with high polling rate mouse input this causes the game to almost freeze while the mouse is being moved. So if the clipping did not change we can bail out early because it will not cause any observable difference anyway. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46976 Signed-off-by: Jan Klötzke <jan(a)kloetzke.net> -- v2: winex11.drv: optimize repeated ClipCursor calls winex11.drv: create win32 clipping window only once https://gitlab.winehq.org/wine/wine/-/merge_requests/825

5 8

[PATCH v2 0/2] MR475: server: Fix object name resolution of \Device\Null.
by Jinoh Kang (＠iamahuman) 05 Dec '24

05 Dec '24

This simplifies future tests that check for object name of devices. -- v2: server: Fix object name resolution of \Device\Null. server: Make explicit the ownership of the unix_name buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/475

3 4

[PATCH 0/3] MR5814: d3dx9, d3dcompiler: Do not emit implicit truncation warnings before version 42.
by Elizabeth Figura (＠zfigura) 05 Dec '24

05 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5814

5 17

[PATCH 0/3] MR5712: winewayland.drv: Update key state from Wayland information.
by Alexandros Frantzis (＠afrantzis) 01 Dec '24

01 Dec '24

Recent changes allowed the Wayland driver to properly deal with numpad keys depending on numlock status. This MR ensures that numlock and other lock state is properly synced, and concludes the fix for https://bugs.winehq.org/show_bug.cgi?id=56397. This MR also syncs the key press state when a window gains keyboard focus, including any modifier press state. Note that we currently ignore the modifier press information from the `modifier` event, since: 1. it doesn't differentiate between left-right keys, 2. mod press state changes will be normally preceded by a matching key event, so we are able to sync properly. However, if we find that we need to handle mod press state changes without corresponding key events, we will need to implement some sensible way to sync these, too. Although I would like for the driver work exclusively in terms of scancodes, I still needed to use vkeys in this case, since this is how wineserver expresses keyboard state at the moment. This means that I had to introduce/duplicate some extra scan->vkey logic in the driver (e.g., numpad keys based on numlock state) to get things right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5712

5 15

[PATCH v2 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) 01 Dec '24

01 Dec '24

-- v2: d2d1: Implement nodes connection for ID2D1TransformGraph. d2d1: Implement nodes adding and removal for ID2D1TransformGraph. d2d1/tests: Add more tests for ID2D1TransformGraph. https://gitlab.winehq.org/wine/wine/-/merge_requests/698

2 6

[PATCH v2 0/11] MR5085: jscript: Implement Typed Arrays.
by Gabriel Ivăncescu (＠insn) 28 Nov '24

28 Nov '24

-- v2: jscript: Implement Uint8ClampedArray. jscript: Implement 'set' for Typed Arrays. jscript: Implement 'subarray' for Typed Arrays. jscript: Implement Typed Array construction from objects. jscript: Implement ArrayBuffer.isView. jscript: Implement Typed Array construction on ArrayBuffers. jscript: Add initial implementation of Typed Arrays. jscript: Use DISP_E_UNKNOWNNAME when looking up a prop that doesn't exist. jscript: Avoid allocating props for indexed props unless necessary. jscript: Move the indexed prop idx lookup into a helper. mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5085

4 20

[PATCH 0/1] MR3226: comctl32/edit: Scroll caret on Ctrl+A.
by Vladislav Timonin (＠vt) 28 Nov '24

28 Nov '24

Every other use of `EDIT_EM_SetSel` updates caret position by calling `EDIT_EM_ScrollCaret` or `EDIT_SetCaretPos`. Fixes caret blinking in the middle when selecting all text. ![changes](/uploads/019bce6c12e0378d391e1253ecbaf9c6/changes.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3226

4 6

[PATCH 0/1] MR1121: winhttp: Fix missing reference upcount
by Yuan Yao (＠yaoyuan.0553) 28 Nov '24

28 Nov '24

The reference count of host is supposed to go up by one in netconn_create. The missing ref increment causes error handling paths where netconn_close or release_host is called to prematurely decrement the ref count of host to zero. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1121

4 6

[PATCH v6 0/4] MR4761: ntdll: Implement NtContinueEx()
by Dāvis Mosāns (davispuh) (＠davispuh) 27 Nov '24

27 Nov '24

This MR implements `NtContinueEx(PCONTEXT, PCONTINUE_OPTIONS)` which was added in Windows 10 20H1. Also added basic test reusing existing `test_continue()` (included from !4720) League of Legends game hooks `NtContinue()` and `NtContinueEx()` by putting `jmp` instruction in front of it. Note that LoL doesn't actually use `NtContinueEx()` itself and game will work fine without it but if game doesn't find `NtContinueEx()` it will permanently ban your account due to detecting "scripting program" -- v6: ntdll/tests: Implement APC test for NtContinue() ntdll/tests: Add basic test for NtContinueEx() ntdll: Implement NtContinueEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/4761

4 11

[PATCH v5 0/2] MR3718: dwrite: Fix incorrect position of glyph when using BitmapRenderTarget in HiDPI
by Tingzhong Luo (＠tzluo) 26 Nov '24

26 Nov '24

The "GdiInterop" is a sample application (source code is avaiable in [Github][source_code], relative guide in [MSDN][msdn_guide]) that demostracts how to display DirectWrite text on a GDI surface. After set dpi to 168 in `winecfg`, and run sample application with wine, the font size is normal, but the position of glyph is incorrect. | Dpi: 96 | Dpi: 168 | |:----------------:|:-----------------:| | ![ss1][sc_96dpi] | ![ss2][sc_168dpi] | There is the sample application after compile: [Release_x64.tar.gz](/uploads/c70e32824efcaa5d16ab39bbb4b86e30/Release_x64.tar.gz) After change transform matrix that pass to `IDWriteFactory7_CreateGlyphRunAnalysis`, it can display glyph correctly. [source_code]: https://github.com/microsoft/Windows-classic-samples/blob/main/Samples/Win7… [msdn_guide]: https://learn.microsoft.com/en-us/windows/win32/directwrite/render-to-a-gdi… [sc_96dpi]: /uploads/59cc343cfaa025f4ff4c32a84ab8cfeb/图片.png [sc_168dpi]: /uploads/938be653362bb6ac58471b69ab66099a/图片.png -- v5: dwrite: Fix incorrect position of glyph when rendering with BitmapRenderTarget in HiDPI dwrite: Return render bounds if text not intersect to BitmapRenderTarget https://gitlab.winehq.org/wine/wine/-/merge_requests/3718

3 5

[PATCH 0/1] MR5041: ntdll/tests: Unify APC test functions
by Dāvis Mosāns (davispuh) (＠davispuh) 26 Nov '24

26 Nov '24

Currently there are several places that test APC but they use duplicated/similar `apc_func()` so merge all those into single implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5041

3 3

[PATCH 0/1] MR4851: kernelbase: Add naive SystemTimeToTzSpecificLocalTimeEx implementation
by Russell Greene (＠russelltg) 26 Nov '24

26 Nov '24

The cast there seems safe from looking at the struct definitions, and is also used elsewhere in the codebase (dlls/kernelbase/locale.c:5682). It's obviously not a full implementation, but works well enough for my usecase and maybe others as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4851

3 3

[PATCH v4 0/3] MR3547: Common Controls: Fix balloon tooltips
by Carl Bialorucki (＠cbialorucki) 26 Nov '24

26 Nov '24

Fixes balloon tooltips so that they can be drawn outside of the work area (required for system tray icons) and improves the shape of the tooltips so that they resemble their shape on Windows. -- v4: Diff reduce https://gitlab.winehq.org/wine/wine/-/merge_requests/3547

4 4

[PATCH 0/7] MR4947: winewayland.drv: part 12: Display mode change emulation
by Alexandros Frantzis (＠afrantzis) 24 Nov '24

24 Nov '24

This MR uses the existing compositor side surface scaling in the driver (through wp_viewporter, currently used for Hi-DPI scaling) to emulate display mode changes. This works wonderfully in coordination with fullscreen since the compositor is required non only to scale the surface, but also to position it properly and provide opaque surroundings (note: some compositors don't implement the last two features properly!). Since: 1. Wayland doesn't allow clients to change the actual display configuration, and 2. there is no queryable service that holds the display information in a consistent manner (à la xrandr), the MR uses the win32 device settings as the source of truth for the current display mode. We let win32u handle the display mode change in the default manner (i.e., just updating the registry settings), and provide access to the current mode when updating the display devices through a new `gdi_display_manager.get_adapter()` function. In order to be able to consistently (across all processes) associate an adapter device with its corresponding `wl_output` the MR introduces per-adapter driver data. Note for people trying this out: many modern games don't change the hardware display settings, but rather scale themselves in right way to achieve the visual effect of a mode change (similarly to how this MR works, but they do it on the application side). To exercise most of the functionality in this MR you need an application that actually uses the `ChangeDisplaySettings` win32 API. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4947

16 48

[PATCH 0/1] MR5925: d2d: Added support for DXGI_FORMAT_R8G8B8A8_UNORM on wic render targets
by Agustin Principe (＠principeagustin) 21 Nov '24

21 Nov '24

Added suppot for DXGI_FORMAT_R8G8B8A8_UNORM to d2d_wic_render_target_init. For further testing i can provide and .exe that renders a red circle over a blue background. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5925

4 5

[PATCH v3 0/2] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory.
by Jinoh Kang (＠iamahuman) 20 Nov '24

20 Nov '24

Preparatory patch for revival of https://gitlab.winehq.org/wine/wine/-/merge_requests/498. -- v3: server: Don't crash when opening null path with a console server as RootDirectory. server: Don't crash when opening null path with a console handle as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

3 3

[PATCH v5 0/1] MR1139: ntoskrnl.exe: add KeNumberProcessors export.
by Etaash Mathamsetty (＠etaash.mathamsetty) 19 Nov '24

19 Nov '24

I haven't seen any software that uses this, but some older software out there might use it, so it's good idea to export it. -- v5: ntoskrnl.exe: add KeNumberProcessors export. https://gitlab.winehq.org/wine/wine/-/merge_requests/1139

4 4

[PATCH v12 0/1] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Nov '24

17 Nov '24

this should fix ubisoft connect outputting unknown timezone UTC in logs -- v12: wininet: Allow UTC as a timezone. https://gitlab.winehq.org/wine/wine/-/merge_requests/1989

2 2

[PATCH v7 0/4] MR359: mmdevapi: copy ContainerID property from audio driver if available
by Claire (＠ClearlyClaire) 16 Nov '24

16 Nov '24

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR allows this information to be accessible from the IMMDevice's property store when the audio driver provides it (none for now, but I intend to add that feature to `winepulse.drv` and maybe `winealsa.drv`) This is made specific to containerId rather than supporting VT_CLSID on every property because Wine currently stores VT_BLOBs directly in the registry value, which does not allow us to safely disambiguate between VT_CLSID and VT_BLOB values when reading from registry. -- v7: mmdevapi: Invalidate ContainerID of unavailable audio devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/359

6 11

[PATCH v2 0/2] MR4794: comctl32/combo: Add tests for keypresses showing search functionality
by Fabian Maurer (＠DarkShadow44) 16 Nov '24

16 Nov '24

In preparation to fix https://bugs.winehq.org/show_bug.cgi?id=56104 and https://bugs.winehq.org/show_bug.cgi?id=42898 -- v2: comctl32/listbox: Add tests for keypresses showing search functionality comctl32/combo: Add tests for keypresses showing search functionality https://gitlab.winehq.org/wine/wine/-/merge_requests/4794

3 11

[PATCH 0/1] MR5232: rundll32: Allow DLL name and entrypoint to be separated by any combination of spaces/commas.
by Aida Jonikienė (＠DodoGTA) 15 Nov '24

15 Nov '24

This is one of the two rundll32 changes required for GeForce NOW installer to work (the other one is too hacky to upstream without major changes) This commit was originally found on https://github.com/aabgrall/wine-base-geforcenow (but the author never bothered to send it to the ML/GitLab) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5232

3 4

[PATCH v4 0/1] MR5236: ntdll: Implement NtdllDefWindowProc_A().
by Aida Jonikienė (＠DodoGTA) 13 Nov '24

13 Nov '24

I've tried implementing this before but importing user32 from ntdll isn't a reliable thing (so I recently rewrote it using the ntdll equivalents of LoadLibrary() and GetProcAddress()) Note: This is a weird way to implement this function (Windows implements this in ntdll instead) but that would probably require a user32/ntdll rewrite (so this is the next best tning to get the application working) -- v4: ntdll: Implement NtdllDefWindowProc_A(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5236

6 11

[PATCH v2 0/1] MR5449: Draft: regsvr32: Implement EXE registration.
by Aida Jonikienė (＠DodoGTA) 13 Nov '24

13 Nov '24

The Sims 2 installer calls regsvr32 with the /regserver flag (which isn't implemented on Wine) so that command fails. -- v2: regsvr32: Implement EXE registration. https://gitlab.winehq.org/wine/wine/-/merge_requests/5449

3 4

[PATCH 0/2] MR482: advapi32/tests: Test kernel object security with the primary token as well.
by Jinoh Kang (＠iamahuman) 09 Nov '24

09 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/482

2 3

[PATCH 0/1] MR474: server: Default the token owner to the token user.
by Jinoh Kang (＠iamahuman) 09 Nov '24

09 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/474

2 3

[PATCH v5 0/1] MR4504: cmd: fix for bug 55401
by Dmitry Sokolov (＠DmitrySokolov) 07 Nov '24

07 Nov '24

Visual Studio's native tool command prompt uses rare for loop variables: %%1, %%2. This test covers this case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- v5: cmd: added support of FOR loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop https://gitlab.winehq.org/wine/wine/-/merge_requests/4504

5 5

[PATCH v2 0/3] MR5242: cmd/tests: Add tests for calling special excuteable files.
by Haidong Yu (＠yhd986) 06 Nov '24

06 Nov '24

Signed-off-by: Haidong Yu <yuhaidong(a)uniontech.com> -- v2: cmd: Fix calling executable file failure, when filename with inbuilt keyword. cmd: Treat '+' as a delimiter in echo. https://gitlab.winehq.org/wine/wine/-/merge_requests/5242

5 7

[PATCH 0/2] MR5194: cmd/tests: Add tests for calling special excuteable files.
by Haidong Yu (＠yhd986) 06 Nov '24

06 Nov '24

Signed-off-by: Haidong Yu <yuhaidong(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5194

5 9

[PATCH 0/1] MR3270: winhlp32: truncate path in title bar
by Yukinari Mitsu (＠3ts75) 06 Nov '24

06 Nov '24

The buffer in the titlebar was small and the file path was truncated. Therefore, the buffer in the titlebar was expanded from 51 to 300. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3270

5 12

[PATCH 0/1] MR4237: Add Occitan translation
by joan-lucì Labòrda (＠joanluc) 06 Nov '24

06 Nov '24

Add Occitan translation Update Makefile.in -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4237

5 6

[PATCH 0/1] MR4238: Draft: Occitan translations for Wine
by joan-lucì Labòrda (＠joanluc) 06 Nov '24

06 Nov '24

Occitan translations for Wine Draft from French translation, updated until line #315 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4238

4 4

[PATCH v3 0/1] MR3668: cmd: fixed command chaining
by Dmitry Sokolov (＠DmitrySokolov) 06 Nov '24

06 Nov '24

Fixed the following code: ```plaintext echo 1. && echo ok || echo failed echo 2. || echo failed && echo --- & echo 3. ``` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55489 -- v3: cmd: fixed command chaining https://gitlab.winehq.org/wine/wine/-/merge_requests/3668

4 4

[PATCH 0/1] MR5574: explorer: Reset last error after loading drivers.
by Aida Jonikienė (＠DodoGTA) 06 Nov '24

06 Nov '24

I'm not sure if this is the best approach for this problem (resetting the last error right before loading a program's entrypoint could be better). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5574

5 9

[PATCH v19 0/11] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 06 Nov '24

06 Nov '24

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. -- v19: include: Add a comment explaining why all kernel callbacks must be in user32. user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Route kernel callbacks through user32. winex11.drv: Pass a struct to x11drv_ime_set_result. winex11.drv: Pass a struct to x11drv_dnd_post_drop. winemac.drv: Route kernel callbacks through user32. wineandroid.drv: Route kernel callbacks through user32. opengl32: Route kernel callbacks through user32. winevulkan: Route kernel callbacks through user32. user32: Add NtUserDispatchCallback kernel callback. user.exe16: Move kernel callbacks to wow_callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 14

[PATCH 0/1] MR5440: wow64: Add TokenIntegrityLevel surpport to wow64_NtSetInformationToken as...
by JiangYi Chen (＠meshine) 06 Nov '24

06 Nov '24

wow64: Add TokenIntegrityLevel surpport to wow64_NtSetInformationToken as NtSetInformationToken does. Description: synchronize wow64_NtSetInformationToken and NtSetInformationToken.Avoid crash of some application due to TokenIntegrityLevel failure in wow64 mode. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: I556ab5cc6531dfab2c404e6769e053f42ada70a7 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5440

3 3

[PATCH v4 0/2] MR3671: cmd: refactored setting of 'errorlevel'
by Dmitry Sokolov (＠DmitrySokolov) 06 Nov '24

06 Nov '24

Encapsulate setting of 'errorlevel' in a separate function as the first stage of fixing bug #32679 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32679 -- v4: cmd: fixed command chaining https://gitlab.winehq.org/wine/wine/-/merge_requests/3671

5 8

[PATCH 0/5] MR4614: msvcm80: Add missing function implementations
by Vijay Kiran Kamuju (＠infyquest) 26 Oct '24

26 Oct '24

This series adds _Cin, _Cout, _Cerr, _Clog, _Wcin, _Wcout, _Wcerr, _Wclog functions. Rest of the functions will be added later. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47304 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32091 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4614

4 10

[PATCH 0/1] MR5276: musl: Fix limiting the float precision in intermediates.
by Martin Storsjö (＠mstorsjo) 15 Oct '24

15 Oct '24

musl itself expects to be configured to compile with either -ffloat-store or -fexcess-precision=standard - but when imported into Wine, those flags aren't used. This seems to be essential for getting reasonable precision from some math functions such as exp2() - without the expected precision truncation, the output value of exp2() can be off by as much as 0.2% in some cases. As Wine doesn't build the musl sources with those flags, use volatile to force storing/reloading floats in order to limit their intermediate precision, as musl expects. Only do this on i386 where this is known be required. This fixes https://bugs.winehq.org/show_bug.cgi?id=56372. Apparently this issue only appears when compiled with GCC; with Clang, this already works as expected. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5276

4 6

[PATCH v6 0/5] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 03 Oct '24

03 Oct '24

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v6: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. server: Add stub lookup_name implementation for named_pipe_device_file_ops. server: Pass the object subpath to open_file instead of rejecting it. server: Inline open_named_object() call in open_file_object handler. ntdll/tests: Test opening a named pipe with \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

4 11

[PATCH 0/2] MR3421: win32u: Fix clip_fullscreen_window for Deus Ex
by Zsolt Vadász (＠zsoltiv) 03 Oct '24

03 Oct '24

These changes fix the camera rotation for Deus Ex. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3421

3 7

[PATCH 0/1] MR5787: winevulkan: Use an internal NtUser call to retrieve a GPU LUID.
by Rémi Bernon (＠rbernon) 13 Sep '24

13 Sep '24

Avoid taking the display_device_init mutex outside of win32u. Similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/5786, although this one doesn't cause any problems as far as I know. Still makes things simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5787

3 6

[PATCH 0/10] MR4201: widl: Cleanup and simplify expressions.
by Rémi Bernon (＠rbernon) 13 Sep '24

13 Sep '24

Some cleanup for expressions, sanitizing the structure a bit especially for abstract operations with multiple args. I also found out about named bison variables, implicit (as `$token` referring to `token`), or explicit (as `$name` referring to `token[name]`). I think it would make the rules much more readable so I started using them here. My plan is to add them progressively to the rules, unless there's some good reason not to (like idk how portable they are, if that's something we should be worried about). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4201

3 21

[PATCH v4 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon (＠rbernon) 10 Sep '24

10 Sep '24

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- v4: win32u: Use GDI blit to implement partial or other process presentation. winex11: Return an offscreen HDC from vulkan_surface_detach. win32u: Pass a HDC parameter to vulkan_surface_detach. winex11: Create a window surface even when there is client window. winex11: Also attach child client windows to their toplevel window. win32u: Make sure vulkan windows have a pixel format selected. win32u: Detach vulkan surfaces that aren't fully visible. win32u: Detach offscreen, child or vulkan surfaces for another process. win32u: Move vulkan surfaces to their new parent when reparenting. win32u: Introduce a new vulkan offscreen surfaces list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

7 20

[PATCH v2 0/1] MR5012: msi: Disable Browse Button when feature has no associated directory
by Fabian Maurer (＠DarkShadow44) 04 Sep '24

04 Sep '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56289 -- v2: msi: Disable Browse Button when feature has no associated directory https://gitlab.winehq.org/wine/wine/-/merge_requests/5012

3 8

[PATCH 0/3] MR5756: comdlg32: Fix a few issues with color dialog
by Fabian Maurer (＠DarkShadow44) 02 Sep '24

02 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5756

3 14

[PATCH v5 0/8] MR4817: shell32: Implement some functions of IFileOperation.
by Haoyang Chen (＠chenhaoyang) 27 Aug '24

27 Aug '24

IFileOperation_{SetOperationFlags, NewItem, CopyItem, MoveItem, DeleteItem, GetAnyOperationsAborted, PerformOperations, RenameItem, SetOwnerWindow} -- v5: shell32/tests: Add test for some functions of IFileOperation. shell32: Implement IFileOperation_NewItem. shell32: Implement IFileOperation_{RenameItem, MoveItem, DeleteItem}. shell32: Implement IFileOperation_{CopyItem, PerformOperations}. shell32: Implement IFileOperation_SetOwnerWindow. shell32: Implement IFileOperation_GetAnyOperationsAborted. shell32: Implement IFileOperation_SetOperationFlags. shell32: Use lists to manage multiple operations. https://gitlab.winehq.org/wine/wine/-/merge_requests/4817

3 10

[PATCH v2 0/4] MR4457: Add tests and implementation of FILE_{RENAME,LINK}_POSIX_SEMANTICS.
by Joel Holdsworth (＠jhol) 21 Aug '24

21 Aug '24

Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- v2: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS. ntdll: Factor out get_inode_open_sharing. ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS. ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS. https://gitlab.winehq.org/wine/wine/-/merge_requests/4457

4 10

[PATCH v2 0/1] MR4636: qcap: Add implementation of IAMVideoControl_GetFrameRateList.
by 江仪陈 (＠meshine) 20 Aug '24

20 Aug '24

Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> -- v2: qcap: Add implementation of IAMVideoControl_GetFrameRateList. https://gitlab.winehq.org/wine/wine/-/merge_requests/4636

3 2

[PATCH 0/4] MR5671: shell32: Implement some file_operation apis.
by Etaash Mathamsetty (＠etaash.mathamsetty) 15 Aug '24

15 Aug '24

Fixes the Netmarble launcher and allows installing games -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5671

2 6

[PATCH v41 0/8] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 09 Aug '24

09 Aug '24

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v41: win32u: Handle dbus notification balloons from system_tray_call win32u: Handle notification balloons through org.freedesktop.Notifications dbus interface win32u: Add a ShowBalloon driver interface win32u: Handle StatusNotifierItem management from system_tray_call win32u: Handle StatusNotifierWatcher owner changing and registering objects to a new watcher win32u: Add SNI driver for systray handling win32u: Add DBus event loop for SNI handling win32u: Add a SystrayRunLoop driver interface https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

5 19

[PATCH v2 0/1] MR2657: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth..
by Aleksey Komarov (＠q4a) 08 Aug '24

08 Aug '24

General idea of this test is to show that a lot of factors influence the fog when transformed and untransformed vertex format was used: - Directly changing z and w (which is not equal in the corners). - Changing projection matrix that change z and w. - Using different programmable/ff vs/ps shader. - Using different depth bias. - Chaging depth in pixel shader (oDepth) may or may not affect to colors depending on the vendor implementation. - And various combinations of above. This gives `succ` in all cases on this configs: - Windows 10 with Radeon HD 8400 or Ivy Bridge GT1 (Intel HD Graphics). - Windows 7 with Radeon HD 6450. - Windows XP with GeForce Go 7300. -- v2: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth.. https://gitlab.winehq.org/wine/wine/-/merge_requests/2657

8 17

[PATCH 0/1] MR5960: ntdll: Remove superflous null check (coverity)
by Fabian Maurer (＠DarkShadow44) 02 Aug '24

02 Aug '24

It's dereferenced later in create_window_handle anyways -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

3 4

2025

2024

2023

2022

wine-gitlab June 2024