June 2024 - wine-gitlab

[PATCH v3 0/5] MR5875: mmdevapi: Complete IAudioClient3 implementation.
by Davide Beatrici (＠davidebeatrici) 24 Jun '24

24 Jun '24

-- v3: mmdevapi: Implement IAudioClient3_GetCurrentSharedModeEnginePeriod. mmdevapi: Complete IAudioClient3_GetSharedModeEnginePeriod. mmdevapi: Complete IAudioClient3_InitializeSharedAudioStream. mmdevapi: Introduce helper stream_init(). mmdevapi: Return errors early in adjust_timing(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5875

4 7

[PATCH 0/1] MR5911: ntdll: Don't special-case default values in RtlQueryRegistryValues.
by Alex Henrie (＠alexhenrie) 24 Jun '24

24 Jun '24

Additional tests reveal that RTL_QUERY_REGISTRY_DIRECT does work with non-string default values, it just requires a pointer to the value and it doesn't infer the size automatically. That means that the same code can be used to handle both default and non-default values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5911

3 2

[PATCH v2 0/1] MR5911: ntdll: Don't special-case default values in RtlQueryRegistryValues.
by Alex Henrie (＠alexhenrie) 24 Jun '24

24 Jun '24

Additional tests reveal that RTL_QUERY_REGISTRY_DIRECT does work with non-string default values, it just requires a pointer to the value and it doesn't infer the size automatically. That means that the same code can be used to handle both default and non-default values. -- v2: ntdll: Don't special-case default values in RtlQueryRegistryValues. https://gitlab.winehq.org/wine/wine/-/merge_requests/5911

2 1

[PATCH 0/1] MR5909: comctl32/listview: Prevent LISTVIEW_GetNextItem failure after checking last item state in list
by Ilia Docin (＠IDocin) 23 Jun '24

23 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 1

[PATCH v8 0/2] MR5904: Improve color mode and paper source detection
by Ilia Docin (＠IDocin) 23 Jun '24

23 Jun '24

-- v8: Use whole words for possible option values on filtering https://gitlab.winehq.org/wine/wine/-/merge_requests/5904

2 8

[PATCH v2 0/2] MR5230: ntdll: Some NtRaiseHardError() changes.
by Aida Jonikienė (＠DodoGTA) 23 Jun '24

23 Jun '24

-- v2: ntdll: Add extra logging for NtRaiseHardError(). ntdll: Fix params_mask type in NtRaiseHardError(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5230

3 4

[PATCH v24 0/7] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 22 Jun '24

22 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v24: ntdll: Use PAGEMAP_SCAN to implement get_working_set_ex, if available. kernel32: Add tests for large page mapping support. ntdll: Support creating and mapping files backed by large pages (SEC_LARGE_PAGES). server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 8

[PATCH v7 0/1] MR5904: Improve color mode detection
by Ilia Docin (＠IDocin) 22 Jun '24

22 Jun '24

-- v7: sane.ds: Improve color mode and paper source detection https://gitlab.winehq.org/wine/wine/-/merge_requests/5904

3 8

[PATCH v5 0/1] MR5904: Improve color mode detection
by Ilia Docin (＠IDocin) 22 Jun '24

22 Jun '24

-- v5: sane.ds: Improve color mode and paper source detection https://gitlab.winehq.org/wine/wine/-/merge_requests/5904

3 2

[PATCH 0/1] MR5893: uniscribe: Update ETO_GLYPH_INDEX flag even if script cache is freed.
by Danyil Blyschak (＠blyss) 22 Jun '24

22 Jun '24

If the script cache was already freed before ScriptTextOut() runs and hence the sfnt member is not available, use the definition from init_script_cache() to conditionally apply the ETO_GLYPH_INDEX flag. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5893

5 8

[PATCH 0/7] MR5907: ntdll: Optimize NtQueryVirtualMemory(MemoryWorkingSetExInformation).
by Paul Gofman (＠gofman) 22 Jun '24

22 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5907

2 8

Re: [PATCH v4 0/3] MR2868: wine{alsa,coreaudio,oss}: Implement get_device_period in unixlib.
by Davide Beatrici (＠davidebeatrici) 22 Jun '24

22 Jun '24

On Mon May 22 19:01:15 2023 +0000, Davide Beatrici wrote: > Mmm... looks like a debugging leftover. @julliard > In any case, I'm going to set it back to `DefaultPeriod`. We can always > fix it in a dedicated commit. Done in 5c6e63bac21d3cbeed56ad76f45f16fa8fc76518. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2868#note_73995

1 0

[PATCH 0/6] MR5905: ntdll: Use complete_async() to handle all forms of completion where necessary.
by Elizabeth Figura (＠zfigura) 22 Jun '24

22 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5905

3 7

[PATCH v3 0/1] MR5904: Improve color mode detection
by Ilia Docin (＠IDocin) 21 Jun '24

21 Jun '24

-- v3: Improve color mode detection https://gitlab.winehq.org/wine/wine/-/merge_requests/5904

3 2

Re: [PATCH v6 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721

1 0

Re: [PATCH v2 0/3] MR5849: kernelbase: Add GetFileMUIInfo implementation. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5849

1 0

Re: [PATCH v2 0/2] MR5858: odbccp32: Look at the Setup key to find the driver of ODBC config functions. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5858

1 0

Re: [PATCH v2 0/5] MR5903: Cmd engine rewrite (part VIII) - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5903

1 0

Re: [PATCH v2 0/8] MR5896: win32u, server: Use the shared memory for GetClipCursor and GetAsyncKeyState. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5896

1 0

Re: [PATCH v2 0/2] MR5895: ntdll: Don't write partial strings with RTL_QUERY_REGISTRY_DIRECT. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5895

1 0

Re: [PATCH v2 0/5] MR5894: ntdll: Do not fill the IOSB or signal completion on failure. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5894

1 0

Re: [PATCH v2 0/5] MR5884: Use zerofill sections instead of preloader on macOS when building with Xcode 15.3. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5884

1 0

Re: [PATCH v2 0/2] MR5897: include: Add a couple of CRT declarations. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5897

1 0

Re: [PATCH v2 0/1] MR5902: kernel32: Add AppPolicyGetWindowingModel(). - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5902

1 0

Re: [PATCH v2 0/1] MR5900: apisetschema: Add api-ms-win-appmodel-runtime-internal-l1-1-1. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5900

1 0

Re: [PATCH v2 0/1] MR5899: bcp47langs: Add stub dll. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5899

1 0

Re: [PATCH v2 0/1] MR5901: profapi: Add stub dll. - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5901

1 0

Re: [PATCH v2 0/6] MR5891: include: Add some interface definitions in Windows.Graphics.Capture namespace - approved
by Alexandre Julliard (＠julliard) 21 Jun '24

21 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5891

1 0

[PATCH 0/1] MR5904: Improve color mode detection
by Ilia Docin (＠IDocin) 21 Jun '24

21 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5904

3 2

[PATCH v2 0/5] MR5875: mmdevapi: Complete IAudioClient3 implementation.
by Davide Beatrici (＠davidebeatrici) 21 Jun '24

21 Jun '24

-- v2: mmdevapi: Implement IAudioClient3_GetCurrentSharedModeEnginePeriod. mmdevapi: Complete IAudioClient3_GetSharedModeEnginePeriod. mmdevapi: Complete IAudioClient3_InitializeSharedAudioStream. mmdevapi: Introduce helper stream_init(). mmdevapi: Return errors early in adjust_timing(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5875

3 8

Re: [PATCH v3 0/1] MR5706: comctl32/rebar: Hide chevron if the full width of rebar is displayed
by Ilia Docin (＠IDocin) 21 Jun '24

21 Jun '24

To reproduce it, I moved gripper left and right to hide some buttons, then brought it back. On the first image chevron didn't disappear as expected. On the second one chevron went away as I applied fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_73935

1 0

Re: [PATCH v3 0/1] MR5706: comctl32/rebar: Hide chevron if the full width of rebar is displayed
by Ilia Docin (＠IDocin) 21 Jun '24

21 Jun '24

![21-06-2024_211736](/uploads/b2ddd5058f3f1c26004dc32f9e7e040e/21-06-2024_211736.jpg) ![21-06-2024_212110](/uploads/44a5e93157a4beceb2ba12afa10f3d1d/21-06-2024_212110.jpg) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_73934

1 0

[PATCH 0/5] MR5884: Use zerofill sections instead of preloader on macOS when building with Xcode 15.3.
by Brendan Shanks (＠bshanks) 21 Jun '24

21 Jun '24

Xcode 15.3 adds a new linker flag (`-no_huge`) which allows the loader to use zero-fill sections to reserve the areas currently being reserved by the preloader. This means the preloader is no longer needed (a good thing, since it's heavily dependent on private APIs). The preloader will still be used when Xcode <15.3 is being used, or when building for i386 (32-bit for 10.14 and earlier). I've also tested a 64-bit wineloader built with Xcode 15.3 on macOS 10.13 and found that it works correctly. The only user-visible change I've found is that `setprogname()` now correctly changes the process name, so a `ps` listing will now show (for example) `C:\windows\regedit.exe` (as it does on Linux) instead of `/Users/bshanks/wine/build64/loader/wine-preloader C:\windows\regedit.exe`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5884

4 16

[PATCH 0/8] MR5896: win32u, server: Use the shared memory for GetCursorPos and GetAsyncKeyState.
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5896

4 15

[PATCH 0/1] MR5902: kernel32: Add AppPolicyGetWindowingModel().
by Zhiyi Zhang (＠zhiyi) 21 Jun '24

21 Jun '24

Required by React Native apps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5902

3 2

[PATCH v3 0/1] MR5658: winevulkan: Make device memory wrapper available in callbacks.
by Arek Hiler (＠ivyl) 21 Jun '24

21 Jun '24

With [`VK_EXT_device_address_binding_report`](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_device_address_binding_report.html) we can get [debug_util](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/ht… callbacks used to track memory bindings. Since it's the host's implementation that starts the callback we have to be sure that we have a way of converting it to the client side's variant before it's added to the handle map - i.e. we don't know the host handle at that time yet. This is [used by vkd3d-proton](https://github.com/HansKristian-Work/vkd3d-proton/pull/1962). Requires Mesa with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28649. before (note the missing BIND for VkDevice which actually means `VkDeviceMemory`): ``` vkd3d-proton % VKD3D_TEST_FILTER=create_placed_resource_size VKD3D_CONFIG=fault VKD3D_DEBUG=trace ~/src/wine/build/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800100200000 || size 000000000019a000. trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800100200000 || size 000000000019a000. trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. :trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. ``` after: ``` % VKD3D_TEST_FILTER=create_placed_resource_size VKD3D_CONFIG=fault VKD3D_DEBUG=trace ~/src/wine/build/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback 232338.036:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.036:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800100200000 || size 000000000019a000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800100200000 || size 000000000019a000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. ``` [The spec guarantees](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/v… the following: > An application can receive multiple callbacks if multiple VkDebugUtilsMessengerEXT objects are created. A callback will always be executed in the same thread as the originating Vulkan call. As of TLS I went with a suggestion from IRC: ``` <ivyl_> There's an issue with how we handle callbacks related to VK_EXT_debug_utils and VK_EXT_debug_report. In wine_vkAllocateMemory() we call device->funcs.p_vkAllocateMemory() which may execute callback. <ivyl_> At this point we still don't have handle mapping added because we don't know what host_memory handle will be. <ivyl_> AFAIU there's a spec guarantee that callback will be executed in the same thread as the call causing it, so I was thinking about maybe keeping `memory` in a tls (if enable_wrapper_list) and using that? <ivyl_> but that's I don't see any precedent of using thread local storage on the unix side <ivyl_> tls value would be short-lived in such case - only for the duration of the call to `device->funcs.p_vkAllocateMemory()` <jacekc_> we usually use teb on unix side, see ntuser_thread_info ``` -- v3: winevulkan: Make device memory wrapper available in callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/5658

2 1

[PATCH 0/1] MR5901: profapi: Add stub dll.
by Zhiyi Zhang (＠zhiyi) 21 Jun '24

21 Jun '24

Required by React Native apps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5901

3 2

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c: > if (!len) > break; > > + if (status == noErr && deadKeyState) > + { > + for (i = 0; i < ARRAY_SIZE(dead_key_names); i++) > + { > + if (dead_key_names[i].wchar == buffer[0]) > + { > + len = min(strlen(vkey_names[i].name) + 1, size); ```suggestion:-0+0 len = min(strlen(dead_key_names[i].name) + 1, size); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73912

1 0

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c: > if (!len) > break; > > + if (status == noErr && len == 1) > + { > + CFStringRef stringRef = CFStringCreateWithCharacters(kCFAllocatorDefault, buffer, len); > + CFMutableStringRef mutableStringRef = CFStringCreateMutableCopy(kCFAllocatorDefault, 0, stringRef); > + > + CFStringUppercase(mutableStringRef, CFLocaleGetSystem()); > + if (CFStringGetLength(mutableStringRef) == 1) > + CFStringGetCharacters(mutableStringRef, CFRangeMake(0, 1), buffer); > + CFRelease(stringRef); > + CFRelease(mutableStringRef); > + } Does we need to support unicode? What about: ```suggestion:-10+0 if (status == noErr && len == 1 && buffer[0] >= 'a' && buffer[0] <= 'z') buffer[0] += 'A' - 'a'; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73911

1 0

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c: > done: > /* Null-terminate the buffer, if there's room. MSDN clearly states that the > caller must not assume this is done, but some programs (e.g. Audiosurf) do. */ > - if (1 <= ret && ret < bufW_size) > - bufW[ret] = 0; > + if (0 <= len && len < bufW_size) ```suggestion:-0+0 if (len < bufW_size) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73910

1 0

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c: > &savedDeadKeyState, bufW_size, &len, bufW); > if (status != noErr) > { > - ERR_(key)("Couldn't translate keycode 0x%04x, status %d\n", keyc, status); > + ERR_(key)("Couldn't translate dead keycode 0x%04x, status %d\n", keyc, status); > goto done; > } > > + if (len >= 1) Same, doesn't seem to be necessary? If len is 0, and dead = TRUE, we just return 0 anyway? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73909

1 0

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c: > UInt32 modifierKeyState; > OptionBits options; > UInt32 deadKeyState, savedDeadKeyState; > - UniCharCount len; > + UniCharCount len = 0; Doesn't seem to be needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73908

1 0

[PATCH 0/3] MR5898: winex11, winemac, winewayland: Move surface code to the window surface source file.
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5898

3 5

[PATCH 0/5] MR5903: Cmd engine rewrite (part VIII)
by eric pouech (＠epo) 21 Jun '24

21 Jun '24

This is part VIII of cmd engine rewrite. It covers: - introduction of a token based parser. For now, it produces the same (degenerated) list of commands as we currently do. Note: I opted for a pull mode for the parser while the lexer is in push mode. Long term plan is to move the lexer into pull mode too (and also converge the two different current methods of argument/token access). - introduction of return codes. It's not obvious from current tests that lots of these codes are actually the kernel32 ones, but tests in later MRs will clearly show it. - starting changing 'exit' and 'goto' builtin implementations to use return code. All builtins will have to adopt that scheme for command chaining to be properly supported. - add delayed expansion for IF command. That's not needed for now (as single command execution already takes care of it), but will be needed when we move IF and FOR commands out of single command in yet to come MR. Includes some test to cover that part. (in case someone asks, it was needed in previous MR regarding the FOR command, as the delayed expansion was only called on the body of the FOR command, not the control block) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5903

2 5

[PATCH v2 0/1] MR5658: winevulkan: Make device memory wrapper available in callbacks.
by Arek Hiler (＠ivyl) 21 Jun '24

21 Jun '24

With [`VK_EXT_device_address_binding_report`](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_device_address_binding_report.html) we can get [debug_util](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/ht… callbacks used to track memory bindings. Since it's the host's implementation that starts the callback we have to be sure that we have a way of converting it to the client side's variant before it's added to the handle map - i.e. we don't know the host handle at that time yet. This is [used by vkd3d-proton](https://github.com/HansKristian-Work/vkd3d-proton/pull/1962). Requires Mesa with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28649. before (note the missing BIND for VkDevice which actually means `VkDeviceMemory`): ``` vkd3d-proton % VKD3D_TEST_FILTER=create_placed_resource_size VKD3D_CONFIG=fault VKD3D_DEBUG=trace ~/src/wine/build/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800100200000 || size 000000000019a000. trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800100200000 || size 000000000019a000. trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. :trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. ``` after: ``` % VKD3D_TEST_FILTER=create_placed_resource_size VKD3D_CONFIG=fault VKD3D_DEBUG=trace ~/src/wine/build/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback 232338.036:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.036:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800100200000 || size 000000000019a000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800100200000 || size 000000000019a000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. ``` [The spec guarantees](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/v… the following: > An application can receive multiple callbacks if multiple VkDebugUtilsMessengerEXT objects are created. A callback will always be executed in the same thread as the originating Vulkan call. As of TLS I went with a suggestion from IRC: ``` <ivyl_> There's an issue with how we handle callbacks related to VK_EXT_debug_utils and VK_EXT_debug_report. In wine_vkAllocateMemory() we call device->funcs.p_vkAllocateMemory() which may execute callback. <ivyl_> At this point we still don't have handle mapping added because we don't know what host_memory handle will be. <ivyl_> AFAIU there's a spec guarantee that callback will be executed in the same thread as the call causing it, so I was thinking about maybe keeping `memory` in a tls (if enable_wrapper_list) and using that? <ivyl_> but that's I don't see any precedent of using thread local storage on the unix side <ivyl_> tls value would be short-lived in such case - only for the duration of the call to `device->funcs.p_vkAllocateMemory()` <jacekc_> we usually use teb on unix side, see ntuser_thread_info ``` -- v2: winevulkan: Make device memory wrapper available in callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/5658

4 4

[PATCH 0/6] MR5891: include: Add some interface definitions in Windows.Graphics.Capture namespace
by Biswapriyo Nath (＠Biswa96) 21 Jun '24

21 Jun '24

Required for gstreamer in Windows https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/1.24.4/subproject… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5891

3 7

[PATCH 0/1] MR5900: apisetschema: Add api-ms-win-appmodel-runtime-internal-l1-1-1.
by Zhiyi Zhang (＠zhiyi) 21 Jun '24

21 Jun '24

Required for React Native apps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5900

2 2

[PATCH 0/1] MR5899: bcp47langs: Add stub dll.
by Zhiyi Zhang (＠zhiyi) 21 Jun '24

21 Jun '24

Required for React Native apps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5899

2 2

[PATCH v4 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 21 Jun '24

21 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v4: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

4 5

[PATCH 0/2] MR5897: include: Add a couple of CRT declarations.
by Rémi Bernon (＠rbernon) 21 Jun '24

21 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5897

2 2

[PATCH 0/2] MR5851: Draft: dxgi: Handle D3D12 swapchain Present() commands by calling a dedicated present function in vkd3d.
by Conor McCarthy (＠cmccarthy) 21 Jun '24

21 Jun '24

The current implementation enqueues the vkQueuePresentKHR() command after waiting on a fence which was enqueued where this command should go. However, this occurs in a worker thread to avoid deadlock, so an arbitrary number of additional commands may be enqueued before vkQueuePresentKHR(). I haven't found a specific scenario where this is a problem, but it is not desirable if we can avoid it. This new implementation is just an RFC; it won't build because the vkd3d function is missing. That can be found [here](https://gitlab.winehq.org/cmccarthy/vkd3d/-/blob/present/libs/vkd3d/c… but I haven't raised an MR. The DXGI side meets all requirements: vkAcquireNextImageKHR() blocks there, but the driver unblocks it so deadlock is not possible. The vkd3d function waits only for the command queue op mutex and cannot deadlock either. The overall implementation should be less fragile, and doesn't need a worker thread. A few days ago I saw a performance increase in HZD from reverting DXGI to before the worker was added, but have never seen this again. Performance differences are minimal between old, current and this one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5851

4 6

Re: [PATCH v2 0/1] MR5706: comctl32/rebar: Hide chevron if the full width of rebar is displayed
by Zhiyi Zhang (＠zhiyi) 21 Jun '24

21 Jun '24

@IDocin -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_73883

1 0

Re: [PATCH v3 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Conor McCarthy (＠cmccarthy) 21 Jun '24

21 Jun '24

On Fri Jun 21 05:51:22 2024 +0000, Conor McCarthy wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5830/diffs?diff_id=118898&start_sha=0a098294aa1607350d8e382416546fe945fac98b#b8e9f5f67cc13143a0928d1e76d7519d0bab1bc3_1773_1764) I removed this from the MR as I think it should be separate. We need one semaphore per Vulkan image. Indexing the semaphore array is an issue because we have no `vk_image_index`, but `frame_number % swapchain->buffer_count` may be ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5830#note_73880

1 0

Re: [PATCH v3 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Conor McCarthy (＠cmccarthy) 21 Jun '24

21 Jun '24

On Fri Jun 21 05:51:23 2024 +0000, Conor McCarthy wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5830/diffs?diff_id=118898&start_sha=0a098294aa1607350d8e382416546fe945fac98b#b8e9f5f67cc13143a0928d1e76d7519d0bab1bc3_1282_1269) I replaced this with a wait for the blit before returning from `d3d12_swapchain_present()`. After a call to Present() returns, the client can render to the next buffer in sequence, so we must wait for completion of the blit read of that buffer. The old version using `vkAcquireNextImageKHR()` is not strict enough. HZD with vsync has frame pacing issues in some parts of the benchmark even on the old implementation, and this makes it a little bit worse. We can't really avoid that though, and the best fix is to improve frame times in vkd3d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5830#note_73879

1 0

Re: [PATCH v3 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Conor McCarthy (＠cmccarthy) 21 Jun '24

21 Jun '24

On Mon Jun 17 17:07:40 2024 +0000, Elizabeth Figura wrote: > Without doing any research myself... the other side is going to try to > enter the logic immediately [within SleepConditionVariableCS()] assuming > it's waiting, and I think usually wakes are fast enough [at least on > Linux] that the other thread will generally start executing before you > even return from the wake function. > Besides a poorly communicated warning that doesn't apply here, the first > comment in [1] also claims that it defeats a "wait morphing" > optimization, where instead of actually waking threads they're just > moved from the CV waitqueue to the mutex wait queue [if their associated > mutex is locked [by the calling thread?]]. That's not something we > currently implement in Wine; it may be possible to implement later though... > [1] https://stackoverflow.com/questions/52503361/unlock-the-mutex-after-conditi… I do see a small but measurable performance gain in HZD. It's only 0.7%, but that shoud be weighed that against the very simple change needed to gain it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5830#note_73878

1 0

[PATCH v2 0/4] MR5830: dxgi: Fix some d3d12 swapchain issues.
by Conor McCarthy (＠cmccarthy) 21 Jun '24

21 Jun '24

The last commit fixes glitches in Horizon Zero Dawn with vsync on, for reasons stated in the comment there. The wined3d implementation already blocks the client's call to `Present()` when `vkAcquireNextImageKHR()` blocks, so is roughly equivalent to this when frame latency and buffer count are equal. It has a frame latency implementation which unblocks after calling `vkQueuePresentKHR()`, rather than waiting for its execution to complete. I think the d3d12 implementation is supposed to do the latter, though using `KHR_present_wait` may be unnecessary overkill. Waiting on queue execution comes with a performance cost either way, so without a compelling reason for a strict implementation, something similar to wined3d makes sense. Another potential issue is after the call to `ID3D12CommandQueue_Signal()` in `d3d12_swapchain_present()`, the client is free to enqueue more commands when `Present()` returns, so by the time the signal is executed and the swapchain worker blits the image and calls `vkQueuePresentKHR()`, these commands are not necessarily enqueued immediately after the `Signal()`. This may not always be harmless. -- v2: dxgi: Wait for completion of a pending read of the next buffer before returning from d3d12_swapchain_Present(). dxgi: Wake the condition variable after leaving the critical section in d3d12_swapchain_resize_buffers(). dxgi: Wake the condition variable after leaving the critical section in d3d12_swapchain_present(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5830

2 4

[PATCH 0/2] MR5895: ntdll: Don't write partial strings with RTL_QUERY_REGISTRY_DIRECT.
by Alex Henrie (＠alexhenrie) 21 Jun '24

21 Jun '24

The new tests revealed only one case where too-small buffers were not already being handled correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5895

3 3

[PATCH 0/5] MR5894: ntdll: Do not fill the IOSB or signal completion on failure.
by Elizabeth Figura (＠zfigura) 21 Jun '24

21 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5894

2 5

Re: [PATCH v2 0/1] MR5886: maintainers: Remove myself as a winegstreamer maintainer.
by Alfred Agrell (＠Alcaro) 20 Jun '24

20 Jun '24

Huh. Okay. I've seen some of those discussions, and something in them did indeed feel strange. (I never understood the context well enough to determine exactly what, and it's not my place to question that, anyways.) I'll miss you 💔 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5886#note_73870

1 0

Re: [PATCH v2 0/2] MR5877: winex11: Create a global vulkan instance for xrandr. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5877

1 0

Re: [PATCH v2 0/4] MR5887: mshtml: Add support for using apply and call on (legacy) builtin function objects. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5887

1 0

Re: [PATCH v43 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

1 0

Re: [PATCH v2 0/4] MR5889: Cmd engine rewrite (part VII) - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5889

1 0

Re: [PATCH v4 0/2] MR5879: winegstreamer: Implement stubs for h264 encoder. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879

1 0

Re: [PATCH v2 0/1] MR5886: maintainers: Remove myself as a winegstreamer maintainer. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5886

1 0

Re: [PATCH v2 0/1] MR5888: ntdll: Fix handling of non-string types with RTL_QUERY_REGISTRY_DIRECT. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5888

1 0

Re: [PATCH v3 0/1] MR5871: ntdll: Fix macOS build errors with Xcode 16. - approved
by Alexandre Julliard (＠julliard) 20 Jun '24

20 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5871

1 0

[PATCH v3 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) 20 Jun '24

20 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v3: comclt32: Allow hotkeys for propsheet navigation https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 10

[PATCH 0/1] MR5890: winex11.drv: Fix a possible desktop window message queue hang.
by Zhiyi Zhang (＠zhiyi) 20 Jun '24

20 Jun '24

After an X11 event handler queues messages to another thread, TRUE should be returned and eventually propagated to X11DRV_ProcessEvents(). When FALSE is always returned in xrandr14_device_change_handler(), a possible hang can happen for the desktop message queue as follows: 1. The explorer.exe calls GetMessageW() -> NtUserGetMessage() -> wait_objects() -> wait_message(). 2. In wait_message(), user_driver->pProcessEvents() gets called in the desktop window thread to handle RRNotify events and calls xrandr14_device_change_handler() -> display_mode_changed(FALSE) -> send_message(get_desktop_window(), WM_DISPLAYCHANGE, ...) -> desktop_window_proc() -> send_message_timeout() -> send_client_message() -> process_message() -> broadcast_message() -> send_message_timeout() -> send_client_message() -> process_message() -> send_inter_thread_message() -> wait_message_reply() -> a server set_queue_mask() with skip_wait being 1 -> wake_mask and changed_mask are set to 0. 3. In wait_message(), user_driver->pProcessEvents() returns FALSE from xrandr14_device_change_handler(). So wait_message() continues to call NtWaitForMultipleObjects(). 4. Now NtWaitForMultipleObjects() hangs for INFINITE timeout because wake_mask and changed_mask for the message queue are set to 0 so the thread is not woke up. The hang is sensitive to message ordering and only happens in this specific case so it's hard to reproduce with tests. I believe some of the past test timeouts on TestBots can be attributed to this bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5890

2 2

[PATCH v3 0/2] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Ziqing Hui (＠zhui) 20 Jun '24

20 Jun '24

-- v3: winegstreamer: Implement stubs for h264 encoder. mf/tests: Add tests for H264 encoder types. https://gitlab.winehq.org/wine/wine/-/merge_requests/5879

4 5

[PATCH 0/4] MR5889: Cmd engine rewrite (part VII)
by eric pouech (＠epo) 20 Jun '24

20 Jun '24

This is part VII of cmd engine rewrite. It finishes spliting parsing from execution of FOR loops. And fixes reading from NUL for confirmation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5889

2 4

[PATCH 0/4] MR5875: mmdevapi: Complete IAudioClient3 implementation.
by Davide Beatrici (＠davidebeatrici) 20 Jun '24

20 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5875

3 11

[PATCH 0/1] MR5888: ntdll: Fix handling of non-string types with RTL_QUERY_REGISTRY_DIRECT.
by Alex Henrie (＠alexhenrie) 20 Jun '24

20 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5888

2 1

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Ziqing Hui (＠zhui) 20 Jun '24

20 Jun '24

> I don't want to be a blocker but to be honest I'm a bit annoyed with the idea of having to rewrite the patches I am trying to upstream with transform media types. I'm going to delay making changes to wg_transform until you upstream your transform patches. I can concentrate on implementing the frontside first. So I'll simply remove patch 3,4,5 in this MR for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73808

1 0

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Ziqing Hui (＠zhui) 20 Jun '24

20 Jun '24

On Wed Jun 19 15:58:14 2024 +0000, Elizabeth Figura wrote: > > Can we add an encoder element without changing all this code? It > doesn't look like you need all the complicated converter sequence, maybe > only a videoconvert (do you even need one?). > Yeah, in general the idea that we'd want the same sequence for decoding > and encoding is probably wrong. E.g. for decoding we may want > deinterlace, but we certainly don't want that for encoding. It's > probably better to handle them separately. Yeah, we can make things easy for encoder for now, only creating encoder element. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73807

1 0

[PATCH 0/4] MR5887: mshtml: Add support for using apply and call on (legacy) builtin function objects.
by Jacek Caban (＠jacek) 19 Jun '24

19 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5887

3 5

[PATCH v2 0/1] MR5871: ntdll: Fix macOS build errors with Xcode 16.
by Brendan Shanks (＠bshanks) 19 Jun '24

19 Jun '24

LLVM 17 or 18 no longer allow non-private labels to appear between .cfi_startproc/endproc when targeting Mach-O. Similar fixes as in commit 295d521b11644fb76c36854336b13c2155bb7d79. Since this is needed for 2 out of 4 architectures, would it be better to do it for all 4 and then modify the shared `__wine_syscall_dispatcher_return()` prototype? -- v2: ntdll: Make __wine_syscall_dispatcher_return a separate function to fix Xcode 16 build errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/5871

3 3

Re: [PATCH v2 0/2] MR5882: Fix WMA DMO media type regression - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5882

1 0

Re: [PATCH v10 0/7] MR5744: winegstreamer: Fix various Cinepak issues - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

1 0

Re: [PATCH v6 0/3] MR5584: mf: Fixes the missing MESessionClosed event in various scenarios. - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

1 0

Re: [PATCH v2 0/1] MR5883: odbc32: Rebind parameters when the result length array is resized. - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5883

1 0

Re: [PATCH v2 0/1] MR5880: msado15: Use the correct version when loading the typelib - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5880

1 0

Re: [PATCH v4 0/5] MR5844: opengl32: Add default implementations for wglGetPixelFormatAttrib{i,f}vARB. - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5844

1 0

Re: [PATCH v2 0/4] MR5868: Cmd engine rewrite (part VI) - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5868

1 0

Re: [PATCH v2 0/1] MR5873: dbghelp: Add ARM/ARM64 machine types for Mach-O. - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5873

1 0

Re: [PATCH v2 0/3] MR5874: ntdll/tests: Add more tests for WoW64 IOSB handling. - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5874

1 0

Re: [PATCH v6 0/1] MR5846: quartz: Set biSizeImage for WMV media type. - approved
by Alexandre Julliard (＠julliard) 19 Jun '24

19 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

1 0

[PATCH 0/1] MR5886: maintainers: Remove myself as a winegstreamer maintainer.
by Elizabeth Figura (＠zfigura) 19 Jun '24

19 Jun '24

I have been instructed by CodeWeavers, on behalf of the CodeWeavers and Wine leadership, to resign my position as winegstreamer maintainer. This comes because I have, for technical reasons, rejected or requested changes to several winegstreamer patches. While these technical objections have not been responded to, it is believed, in this case, committing patches tested against a wide range of games, and avoiding a difference against the Proton project, outweighs all technical problems I may potentially find. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5886

2 1

[PATCH 0/3] MR5885: ntdll: Add few Avl related stub functions.
by Vijay Kiran Kamuju (＠infyquest) 19 Jun '24

19 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56839 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5885

2 3

[PATCH 0/2] MR5882: Fix WMA DMO media type regression
by Alfred Agrell (＠Alcaro) 19 Jun '24

19 Jun '24

microkiri and Wagamama High Spec recently broke, most likely due to @rbernon's d05cd460. Here's a fix. (I didn't file a bugzilla, should I?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5882

5 5

[PATCH v7 0/6] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 19 Jun '24

19 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- v7: winemac: Remove unnecessary surface_clip_to_visible_rect. winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

2 9

[PATCH v3 0/9] MR5876: winegstreamer: Implement more Media Foundation compressed format mappings.
by Elizabeth Figura (＠zfigura) 19 Jun '24

19 Jun '24

-- v3: winegstreamer: Implement MPEG-1 audio to IMFMediaType conversion. winegstreamer: Implement WMA to IMFMediaType conversion. winegstreamer: Implement WMV to IMFMediaType conversion. winegstreamer: Implement AAC to IMFMediaType conversion. winegstreamer: Implement H.264 to IMFMediaType conversion. winegstreamer: Implement H.264 to wg_format conversion. winegstreamer: Implement MPEG-4 audio to wg_format conversion. winegstreamer: Check the version before calling wg_format_from_caps_video_mpeg1(). mfplat/tests: Add more tests for compressed formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5876

3 11

[PATCH v6 0/7] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 19 Jun '24

19 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- v6: winemac: Clip the surface rectangles to the virtual screen rect. winemac: Remove unnecessary surface_clip_to_visible_rect. winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

4 11

[PATCH v9 0/7] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) 19 Jun '24

19 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 -- v9: quartz/tests: Test that avi_decompressor_source_qc_Notify does not deadlock if called from a foreign thread during IMemInput_Receive. quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Make AVI splitter use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

4 10

[PATCH 0/1] MR5883: odbc32: Rebind parameters when the result length array is resized.
by Hans Leidekker (＠hans) 19 Jun '24

19 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5883

2 1

[PATCH v6 0/3] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) 19 Jun '24

19 Jun '24

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v6: server: Simplify mach write_process_memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 4

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Elizabeth Figura (＠zfigura) 19 Jun '24

19 Jun '24

> Can we add an encoder element without changing all this code? It doesn't look like you need all the complicated converter sequence, maybe only a videoconvert (do you even need one?). Yeah, in general the idea that we'd want the same sequence for decoding and encoding is probably wrong. E.g. for decoding we may want deinterlace, but we certainly don't want that for encoding. It's probably better to handle them separately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73748

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 19 Jun '24

19 Jun '24

On Tue Jun 18 21:28:01 2024 +0000, Jacek Caban wrote: > Current func info is more than (id,iid) carrier, it would only make > things more confusing to reuse it as an opaque with constrains like > that. We could introduce a new struct, if needed. Well yes but wouldn't it be an implementation detail on mshtml side? By new struct do you mean one in `func_info_t` and then passing its address out to jscript? (so a single pointer, rather than filling (id,iid) on jscript side) I'm asking because it's easier to just use a single pointer around in jscript (and even check it for NULL if, for instance, it's not a function but a custom prop). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_73737

1 0

[PATCH v5 0/3] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) 19 Jun '24

19 Jun '24

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v5: server: Simplify mach write_process_memory. server: Use mach_vm_read_overwrite in get_selector_entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 3

[PATCH v5 0/3] MR5584: mf: Fixes the missing MESessionClosed event in various scenarios.
by Brendan McGrath (＠redmcg) 19 Jun '24

19 Jun '24

Killsquad sends a MESessionClose at various times depending on user input. It always expects a MESessionClosed event and will wait indefinitely if not received. There are currently a number of scenarios where we don't report the MESessionClose event. This MR attempts to fix that. -- v5: mf: Handle an error during Media Session Close. mf: Handle MediaSession Close when state is SESSION_STATE_RESTARTING_SOURCES. mf/tests: Add additional tests for MESessionClosed event. https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

4 7

2025

2024

2023

2022

wine-gitlab June 2024