June 2024 - wine-gitlab

[PATCH v42 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 18 Jun '24

18 Jun '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v42: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open the desktop shared object in NtUserSetThreadDesktop. server: Return the desktop object locator in (get|set)_thread_desktop. server: Allocate shared session object for desktops. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 10

[PATCH v21 0/7] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 18 Jun '24

18 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v21: ntdll: Use PAGEMAP_SCAN to implement get_working_set_ex, if available. kernel32: Add tests for large page mapping support. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 8

[PATCH 0/2] MR5835: win32u, winex11: Avoid using the win32u vulkan driver interface.
by Rémi Bernon (＠rbernon) 18 Jun '24

18 Jun '24

It might be hooking some functions when we want to call into the host vulkan instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5835

3 10

[PATCH v3 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) 18 Jun '24

18 Jun '24

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- v3: winewayland.drv: Add mouse rawinput support server: Add send_hardware_message flags for rawinput translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

2 3

[PATCH v2 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) 18 Jun '24

18 Jun '24

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- v2: winewayland.drv: Add mouse rawinput support https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

3 4

[PATCH 0/3] MR5805: winegstreamer: Create transforms from MFVIDEOFORMAT / WAVEFORMATEX.
by Rémi Bernon (＠rbernon) 18 Jun '24

18 Jun '24

Instead of going through a custom intermediate format. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5805

5 8

[PATCH 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) 18 Jun '24

18 Jun '24

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

2 2

[PATCH v9 0/2] MR4698: Draft: winewayland.drv: Add unaccelerated pointer support
by Grigory Vasilyev (＠h0tc0d3) 18 Jun '24

18 Jun '24

Adds the registry key `HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\unaccelerated_pointer` witch allows raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, and sensitivity curves in libinput are more difficult to calculate than in the games themselves. Based on Proton and Wine-Staging patches by @rbernon. -- v9: winewayland.drv: Add unaccelerated pointer support server: Add send_hardware_message flags for rawinput translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4698

2 3

[PATCH v5 0/8] MR5801: d3dx9: Use new shared code in D3DXCreateTextureFromFileInMemoryEx().
by Connor McAdams (＠cmcadams) 18 Jun '24

18 Jun '24

This is the first step in moving the various D3DXCreateTextureFromFileInMemory functions over to using shared code. -- v5: d3dx9: Add support for specifying which mip level to get pixel data from to d3dx_image_get_pixels(). d3dx9: Cleanup texture value argument handling in D3DXCreateTextureFromFileInMemoryEx(). d3dx9: Add support for specifying a starting mip level when initializing a d3dx_image structure. d3dx9: Use struct volume inside of struct d3dx_image for storing dimensions. d3dx9: Use d3dx_image structure inside of D3DXCreateTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateTextureFromFileInMemoryEx(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5801

3 9

[PATCH v18 0/8] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 18 Jun '24

18 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v18: ntdll: Use PAGEMAP_SCAN to implement get_working_set_ex, if available. ntdll: Support mapping pages for views created with SEC_LARGE_PAGES. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 9

[PATCH 0/4] MR5868: Cmd engine rewrite (part VI)
by eric pouech (＠epo) 18 Jun '24

18 Jun '24

This is the part VI of the cmd engine rewrite. It starts splitting FOR loop parsing from its execution. This is done for numbers (/L) and filesets (/F) FOR loops. It also extends support for delay expansion of various parts of these loops. Next MR will tackle the tree oriented FOR loop handling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5868

2 4

[PATCH v2 0/1] MR5864: oledb32: When creating a Data Source, handle non fatal errors.
by Alistair Leslie-Hughes (＠alesliehughes) 18 Jun '24

18 Jun '24

The Jet4 driver doesn't handle the DBPROP_AUTH_PERSIST_SENSITIVE_AUTHINFO property which is passed in SetProperties. On return that property is marked as DBPROPSTATUS_NOTSUPPORTED and returns DB_S_ERRORSOCCURRED. In this case, we dont care that isn't not supported and should allow the DataSource to succeed. -- v2: oledb32: When creating a Data Source, handle non fatal errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/5864

3 3

[PATCH 0/1] MR5867: kernel32/tests: Break debugger loop on unexpected result.
by Rémi Bernon (＠rbernon) 18 Jun '24

18 Jun '24

Avoid infinite loop that sometimes happen on macOS and make the test spew hundred of thousand of "Test failed" lines. Split from !5866 and addressed https://gitlab.winehq.org/wine/wine/-/merge_requests/5866#note_73527 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5867

2 1

[PATCH v2 0/1] MR5866: dwrite: Tweak some tests to reduce test report sizes.
by Rémi Bernon (＠rbernon) 18 Jun '24

18 Jun '24

The two tests sometimes fail on macOS and produce >8MB test reports, which fail to upload to the test results page. -- v2: dwrite/tests: Ignore macOS specific "flip" sbix format. https://gitlab.winehq.org/wine/wine/-/merge_requests/5866

2 2

[PATCH 0/2] MR5866: kernel32, dwrite: Tweak some tests to reduce test report sizes.
by Rémi Bernon (＠rbernon) 18 Jun '24

18 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5866

4 7

[PATCH 0/1] MR5864: oledb32: When creating a Data Source, handle non fatal errors.
by Alistair Leslie-Hughes (＠alesliehughes) 18 Jun '24

18 Jun '24

The Jet4 driver doesn't handle the DBPROP_AUTH_PERSIST_SENSITIVE_AUTHINFO property which is passed in SetProperties. On return that property is marked as DBPROPSTATUS_NOTSUPPORTED and returns DB_S_ERRORSOCCURRED. In this case, we dont care that isn't not supported and should allow the DataSource to succeed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5864

3 3

[PATCH 0/3] MR5863: odbc32: Handle both directions for SQLBindParameter().
by Daniel Lehman (＠dlehman25) 18 Jun '24

18 Jun '24

Pointers can be filled after the call to SQLBindParameter() so it needs to be read at SQLExecute(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5863

3 4

[PATCH 0/2] MR5862: server: Take advantage of server-side ioctl handling to simplify IOCTL_SERIAL_WAIT_ON_MASK.
by Elizabeth Figura (＠zfigura) 17 Jun '24

17 Jun '24

Tested with a loopback serial pair. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5862

3 3

Re: [PATCH v3 0/5] MR5794: Cmd engine rewrite (part V) - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5794

1 0

Re: [PATCH v2 0/1] MR5860: win32u: Fix a deadlock when locking the same surface on different DCs. - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5860

1 0

Re: [PATCH v2 0/1] MR5859: win32u: Avoid setting the SWP_NOSIZE flag on the initial WM_DISPLAYCHANGE. - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5859

1 0

Re: [PATCH v2 0/1] MR5857: winewayland: Avoid crashing when the dummy window surface is used. - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5857

1 0

Re: [PATCH v2 0/2] MR5856: ntdll: Fixes for RtlQueryRegistryValues with multi-strings. - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5856

1 0

Re: [PATCH v2 0/1] MR5853: user32/tests: Fix spurious "Failed sequence" reports on Windows. - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5853

1 0

Re: [PATCH v5 0/2] MR5810: Set the default period to a minimum of 10 ms in mmdevapi instead of the audio driver. - approved
by Alexandre Julliard (＠julliard) 17 Jun '24

17 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5810

1 0

[PATCH v2 0/2] MR5854: win32u: get_char_dimensions set height to 1 when failed
by Fan WenJie (＠fanwenjie) 17 Jun '24

17 Jun '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> when get_char_dimensions failed, width not set, width may be undefined value and cause undefined behaviour -- v2: win32u: memset 0 to metric in get_text_metr_size https://gitlab.winehq.org/wine/wine/-/merge_requests/5854

2 2

[PATCH 0/1] MR5860: win32u: Fix a deadlock when locking the same surface on different DCs.
by Rémi Bernon (＠rbernon) 17 Jun '24

17 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56771 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5860

4 4

[PATCH v4 0/9] MR5665: For a CS_PARENTDC child use parent for visible region calculations.
by Dmitry Timoshkov (＠dmitry) 17 Jun '24

17 Jun '24

These patches fix painting in an application that draws outside of a CS_PARENTDC child client area in its WM_PAINT handler. Comments and suggestions are welcome. -- v4: win32u: Use parent rectangle for visible region calculations of a CS_PARENTDC child. win32u: Don't clip update region to the window client rectangle. win32u: GetUpdateRect() should clip update rectangle to the window client area. win32u: GetUpdateRgn() should clip update region to the window client area. win32u: Clip PAINTSTRUCT.rcPaint to the window client area. server: For a CS_PARENTDC child use parent for visible region calculations. server: If the being validated region covers whole window then validate everything. user32/tests: Add a message test for listbox redrawing after LB_SETCOUNT. user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC. https://gitlab.winehq.org/wine/wine/-/merge_requests/5665

6 18

[PATCH 0/1] MR5836: user32/tests: Test BeginPaint() clipbox of cropped window with CS_PARENTDC.
by Jinoh Kang (＠iamahuman) 17 Jun '24

17 Jun '24

The aim is to prevent regression in update region cropping of CS_PARENTDC windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5836

2 3

Re: [PATCH v5 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Akihiro Sagawa (＠sgwaki) 17 Jun '24

17 Jun '24

Rebased to Wine 9.11. Do you have any concerns about this MR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_73427

1 0

[PATCH v6 0/7] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon (＠rbernon) 17 Jun '24

17 Jun '24

-- v6: win32u: Avoid changing thread DPI context in process_hardware_message. win32u: Factor hardware message point DPI mapping together. win32u: Use map_window_points with explicit DPI over screen_to_client. win32u: Split hardware message window lookup to a separate helper. win32u: Use per-monitor DPI window_from_point in process_mouse_message. win32u: Parameterize window_from_point dpi. server: Pass window's per-monitor DPI in set_window_pos. https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

2 8

[PATCH 0/1] MR5859: win32u: Avoid setting the SWP_NOSIZE flag on the initial WM_DISPLAYCHANGE.
by Rémi Bernon (＠rbernon) 17 Jun '24

17 Jun '24

By initializing the desktop window proc virtual rect cache. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56841 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5859

2 1

[PATCH 0/2] MR5858: odbccp32: Look at the Setup key to find the driver of ODBC config functions.
by Alistair Leslie-Hughes (＠alesliehughes) 17 Jun '24

17 Jun '24

We need to look at the Setup key for the driver, as it can be different compare to the actually driver. For example, mysql uses the same Setup file to configure both the Ascii/Unicode vession but has a different file for the actual ODBC functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5858

2 2

Re: [PATCH v2 0/7] MR5833: win32u: Split window surface creation functions from windowing logic.
by Rémi Bernon (＠rbernon) 17 Jun '24

17 Jun '24

On Mon Jun 17 07:53:48 2024 +0000, darkblaze69 wrote: > With this MR since 71ff81b apps don't launch with wayland driver, > showing these errors after some timeouts. > So we can't use wayland now. > ``` > 0138:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 > "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread > 0138, blocked by 0134, retrying (60 sec) > 0144:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 > "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread > 0144, blocked by 0134, retrying (60 sec) > 014c:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 > "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread > 014c, blocked by 0134, retrying (60 sec) > ``` Sorry about that, https://gitlab.winehq.org/wine/wine/-/merge_requests/5857 should fix the problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5833#note_73393

1 0

[PATCH 0/1] MR5857: winewayland: Avoid crashing when the dummy window surface is used.
by Rémi Bernon (＠rbernon) 17 Jun '24

17 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56840 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5857

2 1

[PATCH v4 0/1] MR5231: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list.
by Aida Jonikienė (＠DodoGTA) 17 Jun '24

17 Jun '24

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example) on the Linux side can lead to some games under Wine failing to load (so treat that variable as special). -- v4: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

2 1

[PATCH 0/2] MR5856: ntdll: Fixes for RtlQueryRegistryValues with multi-strings.
by Alex Henrie (＠alexhenrie) 17 Jun '24

17 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5856

2 2

[PATCH 0/1] MR5855: winex11: Fix chinese path failure of conversion.
by Haoyang Chen (＠chenhaoyang) 17 Jun '24

17 Jun '24

Chinese word is negative, the high 4 bits are signed, right shift will remain signed，high 4 bits is filled by 1. Finally it will exceed the boundaries of hax_table. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5855

2 1

[PATCH 0/1] MR5854: win32u: get_char_dimensions set height to 1 when failed
by Fan WenJie (＠fanwenjie) 17 Jun '24

17 Jun '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> when get_char_dimensions failed, width not set, width may be undefined value and cause undefined behaviour -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5854

2 1

Re: [PATCH v2 0/7] MR5833: win32u: Split window surface creation functions from windowing logic.
by darkblaze69 (＠darkblaze69) 16 Jun '24

16 Jun '24

With this MR since 71ff81b apps don't launch with wayland driver, showing these errors after some timeouts. So we can't use wayland now. ``` 0138:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread 0138, blocked by 0134, retrying (60 sec) 0144:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread 0144, blocked by 0134, retrying (60 sec) 014c:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread 014c, blocked by 0134, retrying (60 sec) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5833#note_73375

1 0

[PATCH v17 0/7] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 16 Jun '24

16 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v17: ntdll: mlock mapped pages for views created with SEC_LARGE_PAGES. kernel32: Add tests for large page mapping support. ntdll: Validate parameters to NtCreateSection if large pages are requested. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

2 7

[PATCH 0/1] MR5853: user32/tests: Fix spurious "Failed sequence" reports on Windows.
by Esme Povirk (＠madewokherd) 15 Jun '24

15 Jun '24

It turns out that message sequences with "wine_only" messages, although they don't cause a test failure on Windows, do cause `ok_sequence_` to log a failure, so that it dumps the sequence. We need `ok_sequence_` to treat these as skippable messages on Windows so that it ignores the failure to match them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5853

2 1

[PATCH v4 0/2] MR5810: Cap default period in mmdevapi instead of the audio driver.
by Davide Beatrici (＠davidebeatrici) 15 Jun '24

15 Jun '24

Trace output with PulseAudio: ``` 0144:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0144:trace:mmdevapi:adjust_timing Device periods: 26666 default and 26666 minimum 0144:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v4: winepulse: Don't set a floor for the period(s). mmdevapi: Set the default period to a minimum of 10 ms. https://gitlab.winehq.org/wine/wine/-/merge_requests/5810

3 7

Re: [PATCH v2 0/2] MR5850: Add IME support to conhost. - approved
by Alexandre Julliard (＠julliard) 14 Jun '24

14 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5850

1 0

Re: [PATCH v2 0/1] MR5847: ntdll: Move IOCTL_SERIAL_WAIT_ON_MASK to the server. - approved
by Alexandre Julliard (＠julliard) 14 Jun '24

14 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5847

1 0

Re: [PATCH v3 0/1] MR5839: ntdll: Treat XDG_SESSION_TYPE as special env variable. - approved
by Alexandre Julliard (＠julliard) 14 Jun '24

14 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5839

1 0

Re: [PATCH v2 0/4] MR5848: ntdll: More fixes for RTL_QUERY_REGISTRY_DIRECT. - approved
by Alexandre Julliard (＠julliard) 14 Jun '24

14 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5848

1 0

Re: [PATCH v4 0/3] MR5845: opcservices: Provide memory allocator functions to zlib - approved
by Alexandre Julliard (＠julliard) 14 Jun '24

14 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5845

1 0

Re: [PATCH v7 0/6] MR5773: mmdevapi: Implent a few IAudioSessionControl2 methods - approved
by Alexandre Julliard (＠julliard) 14 Jun '24

14 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

1 0

[PATCH v3 0/2] MR5810: Cap default period in mmdevapi instead of the audio driver.
by Davide Beatrici (＠davidebeatrici) 14 Jun '24

14 Jun '24

Trace output with PulseAudio: ``` 0144:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0144:trace:mmdevapi:adjust_timing Device periods: 26666 default and 26666 minimum 0144:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v3: winepulse: Don't cap period(s). mmdevapi: Cap default period to 10 ms. https://gitlab.winehq.org/wine/wine/-/merge_requests/5810

3 4

[PATCH 0/1] MR5852: win32u: Implement EVENT_OBJECT_DESTROY.
by Esme Povirk (＠madewokherd) 14 Jun '24

14 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5852

2 1

[PATCH v5 0/5] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 14 Jun '24

14 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- v5: winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

2 7

[PATCH v2 0/2] MR5810: Cap default period in mmdevapi instead of the audio driver.
by Davide Beatrici (＠davidebeatrici) 14 Jun '24

14 Jun '24

Trace output with PulseAudio: ``` 0144:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0144:trace:mmdevapi:adjust_timing Device periods: 26666 default and 26666 minimum 0144:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- v2: winepulse: Don't cap period(s). mmdevapi: Cap default period to 10 ms. https://gitlab.winehq.org/wine/wine/-/merge_requests/5810

4 7

[PATCH v4 0/5] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 14 Jun '24

14 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- v4: winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

3 9

[PATCH 0/3] MR5849: kernelbase: Add GetFileMUIInfo implementation.
by Piotr Caban (＠piotr) 14 Jun '24

14 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5849

3 7

[PATCH v2 0/5] MR5794: Cmd engine rewrite (part V)
by eric pouech (＠epo) 14 Jun '24

14 Jun '24

The aim of this serie is to split FOR loop instruction parsing from it's execution. In more details: - introduces CMD_FOR_CONTROL structure to hold parsed FOR instruction - improves the support of FOR loop variables (%0-%9 are now available) - fixes a couple of issues in FOR instruction parsing (missing \t detection in a couple of places, quotes management), - fixes a couple of issues in FOR execution (mainly missing delayed substitution of some constructs) - code refactoring with helpers -- v2: programs/cmd: Introduce helpers to handle directory walk. programs/cmd: Enable '%0' through '%9' as valid FOR loop variables. programs/cmd: Introduce helpers to save and restore FOR loop contexts. programs/cmd: Introduce helpers to handle FOR variables. programs/cmd: Add more tests about FOR loops. https://gitlab.winehq.org/wine/wine/-/merge_requests/5794

2 6

[PATCH v8 0/2] MR4698: Draft: winewayland.drv: Add unaccelerated pointer support
by Grigory Vasilyev (＠h0tc0d3) 14 Jun '24

14 Jun '24

Adds the registry key `HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\unaccelerated_pointer` witch allows raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, and sensitivity curves in libinput are more difficult to calculate than in the games themselves. Based on Proton and Wine-Staging patches by @rbernon. -- v8: winewayland.drv: Add unaccelerated pointer support server: Add send_hardware_message flags for rawinput translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4698

3 4

[PATCH 0/4] MR5844: opengl32: Add default implementations for wglGetPixelFormatAttrib{i,f}vARB.
by Alexandros Frantzis (＠afrantzis) 14 Jun '24

14 Jun '24

This MR extends the `wgl_pixel_format` struct with extra fields required to implement `wglGetPixelFormatAttribivARB` in opengl32.dll. I have added only fields that are relevant to the current needs of the drivers. The default implementation will be used automatically if the driver populates the extra fields, which this MR does for the winex11 driver. The new winex11 implementation tries to remain faithful to the previous behavior in terms of error handling and fallbacks. To achieve this the `wgl_pixel_format` extra fields can be marked as invalid in order for the default implementation to return errors accordingly. Note, however, that error handling around `glXGetFBConfigAttrib` is not very consistent (e.g., the parts of `describe_pixel_format` dealing with PIXELFORMATDESCRIPTOR generally disregard errors). The MR also adds a default implementation for `wglGetPixelFormatAttribfvARB` which piggy-backs on the integer variant of this function, and removes the need for the corresponding code in the drivers. Note that we could potentially remove this function completely from `struct opengl_funcs` (i.e., place it in `manual_win_functions` in `make_opengl`), but it seems the pattern is to maintain a complete list of extension functions (and wined3d also populates the field internally, although it doesn't seem to do anything with it). Finally, the `winex11.drv/opengl.c` file contains a mix of coding styles. I chose to be consistent with the style of the closest context (e.g., the function) I was making changes/additions in. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5844

3 10

[PATCH 0/6] MR5794: Cmd engine rewrite (part V)
by eric pouech (＠epo) 14 Jun '24

14 Jun '24

The aim of this serie is to split FOR loop instruction parsing from it's execution. In more details: - introduces CMD_FOR_CONTROL structure to hold parsed FOR instruction - improves the support of FOR loop variables (%0-%9 are now available) - fixes a couple of issues in FOR instruction parsing (missing \t detection in a couple of places, quotes management), - fixes a couple of issues in FOR execution (mainly missing delayed substitution of some constructs) - code refactoring with helpers -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5794

3 8

[PATCH 0/2] MR5850: Add IME support to conhost.
by eric pouech (＠epo) 14 Jun '24

14 Jun '24

This MR lets conhost support IME input window mode. Note: this MR doesn't include support for properly displaying the glyphs when they fall out of charset of current code page. It also lets some diacritics to work. Note: for these, the generated INPUT_RECORD sequence still widely differs from native: - it matches the key down INPUT_RECORD + unicode char (which is what most app will use) - it differs on the rest (no key-up, no dead char...) but that shouldn't matter too much -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5850

2 2

[PATCH 0/2] MR5810: Cap default period in mmdevapi instead of the audio driver.
by Davide Beatrici (＠davidebeatrici) 14 Jun '24

14 Jun '24

Trace output with PulseAudio: ``` 0144:trace:mmdevapi:adjust_timing Requested duration 1000000 and period 0 0144:trace:mmdevapi:adjust_timing Device periods: 26666 default and 26666 minimum 0144:trace:mmdevapi:adjust_timing Adjusted duration 1000000 and period 100000 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5810

4 5

[PATCH v6 0/6] MR5773: mmdevapi: Implent a few IAudioSessionControl2 methods
by Fabian Maurer (＠DarkShadow44) 14 Jun '24

14 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763 -- v6: mmdevapi: Implement IAudioSessionControl2 GetGroupingParam SetGroupingParam mmdevapi: Implement IAudioSessionControl2 GetIconPath / SetIconPath mmdevapi: Implement IAudioSessionControl2 GetDisplayName / SetDisplayName https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

4 9

[PATCH 0/4] MR5848: ntdll: More fixes for RTL_QUERY_REGISTRY_DIRECT.
by Alex Henrie (＠alexhenrie) 14 Jun '24

14 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5848

2 4

Re: [PATCH v3 0/3] MR5845: opcservices: Provide memory allocator functions to zlib - approved
by Nikolay Sivov (＠nsivov) 14 Jun '24

14 Jun '24

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5845

1 0

Re: [PATCH v3 0/3] MR5845: opcservices: Provide memory allocator functions to zlib
by Nikolay Sivov (＠nsivov) 14 Jun '24

14 Jun '24

On Fri Jun 14 00:42:35 2024 +0000, Danyil Blyschak wrote: > Should I change them? I did it this way since that's what > `dlls/cabinet/fci.c` does (it similarly provides these functions to zlib). No, that's fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5845#note_73146

1 0

[PATCH v4 0/1] MR5817: oledb32: Support Multiple values when parsing the property Mode.
by Alistair Leslie-Hughes (＠alesliehughes) 13 Jun '24

13 Jun '24

The "Mode" can be a mix of any of the flags. -- v4: oledb32: Support Multiple values when parsing the property Mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5817

2 1

[PATCH v4 0/2] MR5812: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first
by Alistair Leslie-Hughes (＠alesliehughes) 13 Jun '24

13 Jun '24

If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE part of the registry not HKEY_CURRENT_USER which it's currently doing. -- v4: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first odbccp32: Support System wide ODBC DSN keys https://gitlab.winehq.org/wine/wine/-/merge_requests/5812

2 2

Re: [PATCH v2 0/1] MR5839: ntdll: Treat XDG_SESSION_TYPE as special env variable.
by Brendan McGrath (＠redmcg) 13 Jun '24

13 Jun '24

On Thu Jun 13 19:52:06 2024 +0000, Alex Henrie wrote: > And the same for > [appwiz.cpl/addons.c](https://gitlab.winehq.org/wine/wine/-/blob/e6f9cb1e093…, > [shell32/recyclebin.c](https://gitlab.winehq.org/wine/wine/-/blob/e6f9cb1e09…, > and > [shell32/shellpath.c](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls…. > So maybe that would be more trouble than it's worth. Thanks @alexhenrie. I went through the same process and came to the same conclusion. After finding `XDG_` being used in the PE side of wine, and given `XDG_SESSION_TYPE` is the only variable I'm aware of causing issues, I figured it was safer to target just that one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5839#note_73141

1 0

[PATCH v2 0/1] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) 13 Jun '24

13 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- v2: quartz: Set biSizeImage for WMV media type in AMT. https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

2 1

Re: [PATCH v3 0/3] MR5845: opcservices: Provide memory allocator functions to zlib
by Danyil Blyschak (＠blyss) 13 Jun '24

13 Jun '24

Rebased to address macos build failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5845#note_73131

1 0

[PATCH 0/1] MR5847: ntdll: Move IOCTL_SERIAL_WAIT_ON_MASK to the server.
by Elizabeth Figura (＠zfigura) 13 Jun '24

13 Jun '24

Many thanks to Alex Henrie for donating test equipment and helping me to understand and properly test this functionality. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5847

2 1

[PATCH 0/1] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) 13 Jun '24

13 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

3 2

Re: [PATCH v4 0/1] MR5831: dnsapi: Add a stub for DnsServiceBrowse
by Lucas Chollet (＠LucasChollet) 13 Jun '24

13 Jun '24

That was quick! Thank you all! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5831#note_73128

1 0

Re: [PATCH v2 0/3] MR5823: Quartz' basic fullscreen fallback. - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5823

1 0

Re: [PATCH v2 0/1] MR5820: quartz/tests: Fix typo in tests. - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5820

1 0

Re: [PATCH v2 0/1] MR5843: win32u: Move WM_WINE_DESKTOP_RESIZED into driver internal messages range. - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5843

1 0

Re: [PATCH v2 0/7] MR5833: win32u: Split window surface creation functions from windowing logic. - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5833

1 0

Re: [PATCH v2 0/1] MR5838: win32u: Implement EVENT_SYSTEM_MINIMIZESTART/END. - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5838

1 0

Re: [PATCH v2 0/2] MR5840: ntdll: Calculate the default size even without RTL_QUERY_REGISTRY_DIRECT. - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5840

1 0

Re: [PATCH v2 0/2] MR5842: ws2_32/tests: Test fromlen for recvfrom(). - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5842

1 0

Re: [PATCH v4 0/1] MR5831: dnsapi: Add a stub for DnsServiceBrowse - approved
by Alexandre Julliard (＠julliard) 13 Jun '24

13 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5831

1 0

[PATCH v2 0/3] MR5845: opcservices: Provide memory allocator functions to zlib
by Danyil Blyschak (＠blyss) 13 Jun '24

13 Jun '24

Provide memory allocator functions to zlib so that it is able to allocate memory and then deflate later. Also, some minor error-handling things. -- v2: opcservices: Check for memory allocation failure before deflating. https://gitlab.winehq.org/wine/wine/-/merge_requests/5845

2 4

[PATCH 0/3] MR5845: opcservices: Provide memory allocator functions to zlib
by Danyil Blyschak (＠blyss) 13 Jun '24

13 Jun '24

Provide memory allocator functions to zlib so that it is able to allocate memory and then deflate later. Also, some minor error-handling things. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5845

3 10

[PATCH 0/2] MR5842: ws2_32/tests: Test fromlen for recvfrom().
by Zhiyi Zhang (＠zhiyi) 13 Jun '24

13 Jun '24

Test that specifying a too small or too large fromlen for recvfrom() shouldn't write unnecessary data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5842

3 4

[PATCH v3 0/5] MR5798: winemac: Push window surface updates to the main thread.
by Rémi Bernon (＠rbernon) 13 Jun '24

13 Jun '24

Instead of accessing the surface with macdrv_get_surface_display_image. -- v3: winemac: Remove now unnecessary cocoa window surface pointer. winemac: Push window surface image updates to the main thread. winemac: Create window surface CGImageRef on surface flush. winemac: Create a provider for the surface and a HBITMAP wrapping it. winemac: Remove unused macdrv_get_surface_display_image copy_data parameter. https://gitlab.winehq.org/wine/wine/-/merge_requests/5798

3 10

Re: [PATCH v2 0/1] MR5839: ntdll: Treat XDG_SESSION_TYPE as special env variable.
by Alex Henrie (＠alexhenrie) 13 Jun '24

13 Jun '24

On Thu Jun 13 19:48:10 2024 +0000, Alex Henrie wrote: > If we do that, > [winemenubuilder.c](https://gitlab.winehq.org/wine/wine/-/blob/master/progra… > will have to be updated at the same time to look for variables that > start with `WINE_XDG_` instead of `XDG_`. And the same for [appwiz.cpl/addons.c](https://gitlab.winehq.org/wine/wine/-/blob/e6f9cb1e093…, [shell32/recyclebin.c](https://gitlab.winehq.org/wine/wine/-/blob/e6f9cb1e09…, and [shell32/shellpath.c](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls…. So maybe that would be more trouble than it's worth. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5839#note_73103

1 0

Re: [PATCH v2 0/1] MR5839: ntdll: Treat XDG_SESSION_TYPE as special env variable.
by Alex Henrie (＠alexhenrie) 13 Jun '24

13 Jun '24

On Thu Jun 13 18:05:39 2024 +0000, Alex Henrie wrote: > I suspect we should treat any variable that starts with `XDG_` > specially, not just `XDG_SESSION_TYPE`. If we do that, [winemenubuilder.c](https://gitlab.winehq.org/wine/wine/-/blob/master/progra… will have to be updated at the same time to look for variables that start with `WINE_XDG_` instead of `XDG_`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5839#note_73102

1 0

[PATCH v7 0/7] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) 13 Jun '24

13 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 -- v7: quartz/tests: Test that avi_decompressor_source_qc_Notify does not deadlock if called from a foreign thread during IMemInput_Receive. quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Make AVI splitter use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

4 10

Re: [PATCH v2 0/1] MR5839: ntdll: Treat XDG_SESSION_TYPE as special env variable.
by Alex Henrie (＠alexhenrie) 13 Jun '24

13 Jun '24

Alex Henrie (@alexhenrie) commented about dlls/ntdll/unix/env.c: > STARTS_WITH( var, "TEMP=" ) || > STARTS_WITH( var, "TMP=" ) || > STARTS_WITH( var, "QT_" ) || > - STARTS_WITH( var, "VK_" )); > + STARTS_WITH( var, "VK_" ) || > + STARTS_WITH( var, "XDG_SESSION_TYPE=" )); I suspect we should treat any variable that starts with `XDG_` specially, not just `XDG_SESSION_TYPE`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5839#note_73092

1 0

[PATCH 0/3] MR5823: Quartz' basic fullscreen fallback.
by eric pouech (＠epo) 13 Jun '24

13 Jun '24

A game creates a vmr7 filter, inserts it in a IFilterGraph2 and calls put_FullScreenMode(OAFALSE) on the graph's IVideoWindow. This currently returns E_NOTIMPL in Wine and the game quits on that error code. A full solution would likely require to implement IFullScreenVideoEx filter, and other bits, but this simpler approach let the game move forward. Also tested & fixed calling put_FullScreenMode on the current mode returns S_FALSE instead of S_OK. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5823

3 4

[PATCH 0/1] MR5820: quartz/tests: Fix typo in tests.
by eric pouech (＠epo) 13 Jun '24

13 Jun '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5820

3 2

[PATCH v4 0/8] MR5801: d3dx9: Use new shared code in D3DXCreateTextureFromFileInMemoryEx().
by Connor McAdams (＠cmcadams) 13 Jun '24

13 Jun '24

This is the first step in moving the various D3DXCreateTextureFromFileInMemory functions over to using shared code. -- v4: d3dx9: Add support for specifying which mip level to get pixel data from to d3dx_image_get_pixels(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5801

3 10

[PATCH v16 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 13 Jun '24

13 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v16: kernel32: Add tests for large page mapping support. ntdll: Validate parameters to NtCreateSection if large pages are requested. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

2 6

[PATCH v3 0/8] MR5801: d3dx9: Use new shared code in D3DXCreateTextureFromFileInMemoryEx().
by Connor McAdams (＠cmcadams) 13 Jun '24

13 Jun '24

This is the first step in moving the various D3DXCreateTextureFromFileInMemory functions over to using shared code. -- v3: d3dx9: Add support for specifying which mip level to get pixel data from to d3dx_image_get_pixels(). d3dx9: Cleanup texture value argument handling in D3DXCreateTextureFromFileInMemoryEx(). d3dx9: Add support for specifying a starting mip level when initializing a d3dx_image structure. d3dx9: Use struct volume inside of struct d3dx_image for storing dimensions. d3dx9: Use d3dx_image structure inside of D3DXCreateTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateTextureFromFileInMemoryEx(). d3dx9/tests: Add more tests for loading files with multiple mip levels into textures. d3dx9/tests: Add tests for the source info argument of D3DXCreateTextureFromFileInMemoryEx(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5801

2 15

[PATCH v5 0/6] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon (＠rbernon) 13 Jun '24

13 Jun '24

-- v5: win32u: Avoid changing thread DPI context in process_hardware_message. win32u: Factor hardware message point DPI mapping together. win32u: Use map_window_points with explicit DPI over screen_to_client. win32u: Split hardware message window lookup to a separate helper. win32u: Use per-monitor DPI window_from_point in process_mouse_message. win32u: Parameterize window_from_point dpi. https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

2 7

[PATCH 0/1] MR5843: win32u: Move WM_WINE_DESKTOP_RESIZED into driver internal messages range.
by Rémi Bernon (＠rbernon) 13 Jun '24

13 Jun '24

It is otherwise ignored and not passed to the drivers WindowMessage callback. Fixes: b89c9c60d50cf21650331d1528ff965c319a1217 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5843

2 1

[PATCH 0/7] MR5833: win32u: Split window surface creation functions from windowing logic.
by Rémi Bernon (＠rbernon) 13 Jun '24

13 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5833

4 9

[PATCH 0/2] MR5841: Draft: win32u: Look for the font from the second name also.
by Haoyang Chen (＠chenhaoyang) 13 Jun '24

13 Jun '24

If the font is not found in Family_name_tree, but in Family_second_name_tree, then it must exist in the font_subst_list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5841

3 3

[PATCH v5 0/6] MR5773: mmdevapi: Implent a few IAudioSessionControl2 methods
by Fabian Maurer (＠DarkShadow44) 13 Jun '24

13 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763 -- v5: mmdevapi: Implement IAudioSessionControl2 GetGroupingParam SetGroupingParam mmdevapi: Implement IAudioSessionControl2 GetIconPath / SetIconPath mmdevapi: Implement IAudioSessionControl2 GetDisplayName / SetDisplayName mmdevapi/tests: Add tests for IAudioSessionControl2 GetGroupingParam / SetGroupingParam mmdevapi/tests: Add tests for IAudioSessionControl2 GetIconPath / SetIconPath mmdevapi/tests: Add tests for IAudioSessionControl2 GetDisplayName / SetDisplayName https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

4 9

[PATCH v3 0/1] MR5831: dnsapi: Add a stub for DnsServiceBrowse
by Lucas Chollet (＠LucasChollet) 13 Jun '24

13 Jun '24

This is needed by Moku (software for scientific instrument): https://www.liquidinstruments.com/products/desktop-apps/ Related to: Wine-Bug: https://forum.winehq.org/viewtopic.php?p=143283 --- First contribution here, I will happily make change if needed! -- v3: dnsapi: Add a stub for DnsServiceBrowse https://gitlab.winehq.org/wine/wine/-/merge_requests/5831

3 3

2025

2024

2023

2022

wine-gitlab June 2024