June 2024 - wine-gitlab

[PATCH v4 0/1] MR5827: shell32: Fix possible handle leak
by Ruslan Garipov (＠ruslangaripov) 13 Jun '24

13 Jun '24

If the malloc(3) has failed to allocate the memory in the init_xdg_dirs(), the latter returns nonzero value, but the 'file' handle is kept open. This closes the handle before return from the init_xdg_dirs() if the malloc(3) has failed. -- v4: shell32: Fix possible handle leak https://gitlab.winehq.org/wine/wine/-/merge_requests/5827

2 1

[PATCH 0/2] MR5840: ntdll: Calculate the default size even without RTL_QUERY_REGISTRY_DIRECT.
by Alex Henrie (＠alexhenrie) 13 Jun '24

13 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5840

2 2

[PATCH 0/1] MR5831: dnsapi: Add a stub for DnsServiceBrowse
by Lucas Chollet (＠LucasChollet) 13 Jun '24

13 Jun '24

This is needed by Moku (software for scientific instrument): https://www.liquidinstruments.com/products/desktop-apps/ Related to: Wine-Bug: https://forum.winehq.org/viewtopic.php?p=143283 --- First contribution here, I will happily make change if needed! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5831

5 8

[PATCH v3 0/8] MR5665: For a CS_PARENTDC child use parent for visible region calculations.
by Dmitry Timoshkov (＠dmitry) 12 Jun '24

12 Jun '24

These patches fix painting in an application that draws outside of a CS_PARENTDC child client area in its WM_PAINT handler. Comments and suggestions are welcome. -- v3: win32u: Use parent rectangle for visible region calculations of a CS_PARENTDC child. win32u: Don't clip update region to the window client rectangle. win32u: GetUpdateRect() should clip update rectangle to the window client area. win32u: GetUpdateRgn() should clip update region to the window client area. win32u: Clip PAINTSTRUCT.rcPaint to the window client area. server: For a CS_PARENTDC child use parent for visible region calculations. server: If the being validated region covers whole window then validate everything. user32/tests: Add a message test for listbox redrawing after LB_SETCOUNT. https://gitlab.winehq.org/wine/wine/-/merge_requests/5665

4 27

[PATCH 0/1] MR5838: win32u: Implement EVENT_SYSTEM_MINIMIZESTART/END.
by Esme Povirk (＠madewokherd) 12 Jun '24

12 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5838

3 2

Re: [PATCH v2 0/1] MR5834: winscard: Pass ATR buffer to unixlib in SCardStatusA(). - approved
by Alexandre Julliard (＠julliard) 12 Jun '24

12 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5834

1 0

Re: [PATCH v3 0/3] MR5832: ntdll: Fix RtlQueryRegistryValues test cases that crash on Wine. - approved
by Alexandre Julliard (＠julliard) 12 Jun '24

12 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5832

1 0

Re: [PATCH v2 0/1] MR5837: msvcrt: Fix _libm_sse2_sqrt_precise not using SSE2 sqrt - approved
by Alexandre Julliard (＠julliard) 12 Jun '24

12 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5837

1 0

Re: [PATCH v40 0/6] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt - approved
by Alexandre Julliard (＠julliard) 12 Jun '24

12 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

1 0

Re: [PATCH v3 0/3] MR5690: secur32: Allow overriding GnuTLS debug level. - approved
by Alexandre Julliard (＠julliard) 12 Jun '24

12 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5690

1 0

[PATCH 0/1] MR5837: msvcrt: Fix _libm_sse2_sqrt_precise not using SSE2 sqrt
by Fabian Maurer (＠DarkShadow44) 12 Jun '24

12 Jun '24

See [bug 56824](https://bugs.winehq.org/show_bug.cgi?id=56824) Commit 2fc773199080dedbe64a33ef66be02a4f44bcd08 unified the sqrt handling across architectures, this lead to _libm_sse2_sqrt_precise calling the x87 version instead of the SSE2 version. I don't think we need to do a call at all, this function is i386 exclusive, so just use the SSE2 instruction for sqrt directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5837

4 3

[PATCH v3 0/5] MR5818: d3d11/tests: Other tests for NV12 textures.
by Giovanni Mascellani (＠giomasce) 12 Jun '24

12 Jun '24

-- v3: d3d11/tests: Teste UpdateSubresource() for NV12 textures. d3d11/tests: Test without render target. tests/d3d11: Do not check pitches. d3d11/tests: Check for NV12 texture support before testing them. d3d11/tests: Check the result of compiling HLSL shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

3 7

[PATCH v2 0/3] MR5832: ntdll: Fix RtlQueryRegistryValues test cases that crash on Wine.
by Alex Henrie (＠alexhenrie) 12 Jun '24

12 Jun '24

-- v2: ntdll/tests: Remove unused WINE_CRASH flag. ntdll: Don't call a null QueryRoutine in RtlQueryRegistryValues. https://gitlab.winehq.org/wine/wine/-/merge_requests/5832

2 3

[PATCH v2 0/8] MR5801: d3dx9: Use new shared code in D3DXCreateTextureFromFileInMemoryEx().
by Connor McAdams (＠cmcadams) 12 Jun '24

12 Jun '24

This is the first step in moving the various D3DXCreateTextureFromFileInMemory functions over to using shared code. -- v2: d3dx9: Add support for specifying which mip level to get pixel data from to d3dx_image_get_pixels(). d3dx9: Cleanup texture value argument handling in D3DXCreateTextureFromFileInMemoryEx(). d3dx9: Add support for specifying a starting mip level when initializing a d3dx_image structure. d3dx9: Use struct volume inside of struct d3dx_image for storing dimensions. d3dx9: Use d3dx_image structure inside of D3DXCreateTextureFromFileInMemoryEx(). d3dx9: Refactor texture creation and cleanup in D3DXCreateTextureFromFileInMemoryEx(). d3dx9/tests: Add more tests for loading files with multiple mip levels into textures. d3dx9/tests: Add tests for the source info argument of D3DXCreateTextureFromFileInMemoryEx(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5801

3 19

[PATCH v39 0/6] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 12 Jun '24

12 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v39: ucrtbase: Fix FILE _flag values. ucrtbase: Always use CRITICAL_SECTION for FILE locking. msvcrt: Don't use custom standard streams definition. ucrtbase: Add FILE structure tests. ucrtbase: Fix _iobuf struct layout. msvcp140: Use _get_stream_buffer_pointers() to access FILE internal buffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

5 9

[PATCH v2 0/3] MR5690: secur32: Allow overriding GnuTLS debug level.
by Daniel Lehman (＠dlehman25) 12 Jun '24

12 Jun '24

-- v2: crypt32: Allow overriding GnuTLS debug level. bcrypt: Allow overriding GnuTLS debug level. secur32: Allow overriding GnuTLS debug level. https://gitlab.winehq.org/wine/wine/-/merge_requests/5690

4 5

[PATCH 0/1] MR5834: winscard: Pass ATR buffer to unixlib in SCardStatusA().
by Hans Leidekker (＠hans) 12 Jun '24

12 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5834

2 1

[PATCH 0/1] MR5829: winewayland.drv: Implement WAYLAND_GetCursorPos
by Zsolt Vadász (＠zsoltiv) 12 Jun '24

12 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5829

3 4

[PATCH 0/3] MR5832: ntdll: Fix RtlQueryRegistryValues test cases that crash on Wine.
by Alex Henrie (＠alexhenrie) 12 Jun '24

12 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5832

2 3

Re: [PATCH v2 0/5] MR5826: winemac, winewayland, winex11: Force thread DPI awareness when calling NtUserSetWindowPos. - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5826

1 0

Re: [PATCH v2 0/1] MR5822: msvcrt/tests: Don't print a NULL string. - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5822

1 0

Re: [PATCH v2 0/1] MR5828: gdiplus: Fix DIB stride calculation in GdipDrawImagePointsRect. - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5828

1 0

Re: [PATCH v2 0/4] MR4424: ntdll: Implement reading multiple entries in NtQueryDirectoryObject. (#52585) - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4424

1 0

Re: [PATCH v5 0/1] MR3908: wineserver: Report non-zero exit code for abnormal process termination - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3908

1 0

Re: [PATCH v2 0/3] MR5728: ntdll/tests: Rewrite the RtlQueryRegistryValues tests and succeed on direct query of nonexistent value. - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5728

1 0

Re: [PATCH v2 0/4] MR5825: odbc32 fixes - approved
by Alexandre Julliard (＠julliard) 11 Jun '24

11 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5825

1 0

[PATCH 0/1] MR5822: msvcrt/tests: Don't print a NULL string.
by eric pouech (＠epo) 11 Jun '24

11 Jun '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5822

3 2

[PATCH 0/1] MR5828: gdiplus: Fix DIB stride calculation in GdipDrawImagePointsRect.
by Esme Povirk (＠madewokherd) 11 Jun '24

11 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56800 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5828

3 2

[PATCH v2 0/4] MR5818: d3d11/tests: Other tests for NV12 textures.
by Giovanni Mascellani (＠giomasce) 11 Jun '24

11 Jun '24

-- v2: d3d11/tests: Teste UpdateSubresource() for NV12 textures. d3d11/tests: Test without render target. tests/d3d11: Do not check pitches. d3d11/tests: Mark NV12 textures as broken on Windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

3 6

[PATCH 0/1] MR5827: shell32: Fix possible handle leak
by Ruslan Garipov (＠ruslangaripov) 11 Jun '24

11 Jun '24

If the malloc(3) had failed to allocate the memory, it returned nonzero value, but the 'file' handle was kept open. This closes the handle before return from the `init_xdg_dirs()` if the malloc(3) has failed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5827

2 1

[PATCH 0/5] MR5826: winemac, winewayland, winex11: Force thread DPI awareness when calling NtUserSetWindowPos.
by Rémi Bernon (＠rbernon) 11 Jun '24

11 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5826

3 6

[PATCH 0/4] MR5825: odbc32 fixes
by Hans Leidekker (＠hans) 11 Jun '24

11 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5825

3 5

Re: [PATCH v6 0/1] MR4174: shell32: Add Internet Explorer toolbar icons.
by Alex Henrie (＠alexhenrie) 11 Jun '24

11 Jun '24

Any comments? I didn't think this patch would be controversial. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4174#note_72844

1 0

[PATCH v2 0/1] MR5811: user32/tests: Print regions in test_swp_paint_regions failure cases.
by Jinoh Kang (＠iamahuman) 10 Jun '24

10 Jun '24

Follow-up to !3989. -- v2: user32/tests: Print regions in test_swp_paint_regions failure cases. https://gitlab.winehq.org/wine/wine/-/merge_requests/5811

4 3

Re: [PATCH v2 0/3] MR5824: win32u: Parameterize NtUserMapWindowPoints dpi. - approved
by Alexandre Julliard (＠julliard) 10 Jun '24

10 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5824

1 0

Re: [PATCH v2 0/1] MR5813: win32u: Implement EVENT_OBJECT_LOCATIONCHANGE. - approved
by Alexandre Julliard (＠julliard) 10 Jun '24

10 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5813

1 0

Re: [PATCH v2 0/1] MR5821: kernelbase/tests: Fix typo in tests. - approved
by Alexandre Julliard (＠julliard) 10 Jun '24

10 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5821

1 0

[PATCH v4 0/1] MR4443: Do not release media session topologies until the media session is shutdown.
by Santino Mazza (＠tati1454) 10 Jun '24

10 Jun '24

-- v4: mf: Release topologies when shutting down the session. https://gitlab.winehq.org/wine/wine/-/merge_requests/4443

3 3

[PATCH 0/3] MR5824: win32u: Parameterize NtUserMapWindowPoints dpi.
by Rémi Bernon (＠rbernon) 10 Jun '24

10 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5824

2 3

[PATCH v3 0/3] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon (＠rbernon) 10 Jun '24

10 Jun '24

-- v3: win32u: Use per-monitor DPI window_from_point in process_mouse_message. win32u: Parameterize window_from_point dpi. win32u: Restore DPI awareness context in process_mouse_message. https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

2 4

[PATCH v2 0/1] MR5817: oledb32: Support Multiple values when parsing the property Mode.
by Alistair Leslie-Hughes (＠alesliehughes) 10 Jun '24

10 Jun '24

The "Mode" can be a mix of any of the flags. -- v2: oledb32: Support Multiple values when parsing the property Mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5817

2 1

[PATCH 0/1] MR5821: kernelbase/tests: Fix typo in tests.
by eric pouech (＠epo) 10 Jun '24

10 Jun '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5821

2 1

[PATCH 0/2] MR5818: d3d11/tests: Other tests for NV12 textures.
by Giovanni Mascellani (＠giomasce) 10 Jun '24

10 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5818

3 3

[PATCH 0/2] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon (＠rbernon) 10 Jun '24

10 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

2 4

[PATCH v41 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 10 Jun '24

10 Jun '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v41: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open the desktop shared object in NtUserSetThreadDesktop. server: Return the desktop object locator in (get|set)_thread_desktop. server: Allocate shared session object for desktops. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 10

[PATCH 0/1] MR5817: oledb32: Support Multiple values when parsing the property Mode.
by Alistair Leslie-Hughes (＠alesliehughes) 10 Jun '24

10 Jun '24

The "Mode" can be a mix of any of the flags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5817

3 2

[PATCH v2 0/2] MR5812: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first
by Alistair Leslie-Hughes (＠alesliehughes) 09 Jun '24

09 Jun '24

If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE part of the registry not HKEY_CURRENT_USER which it's currently doing. -- v2: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first odbccp32: Support System wide ODBC DSN keys https://gitlab.winehq.org/wine/wine/-/merge_requests/5812

2 3

[PATCH 0/1] MR5816: wined3d: Implement wined3d_check_device_format_conversion().
by Elizabeth Figura (＠zfigura) 09 Jun '24

09 Jun '24

This should reflect what we actually support, while still being a superset of what native drivers actually support. Native driver support varies, but, as the comments document, native drivers (at least as of windows 10) support only RGB -> RGB, YUV -> RGB, and BC -> RGB conversions. The actual formats supported are a more limited subset than exposed (despite that the video cards should be perfectly capable of supporting more conversions) but erring on the side of overreporting seems safer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5816

3 2

[PATCH 0/1] MR5813: win32u: Implement EVENT_OBJECT_LOCATIONCHANGE.
by Esme Povirk (＠madewokherd) 08 Jun '24

08 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5813

3 2

[PATCH 0/1] MR5811: user32/tests: Print regions in test_swp_paint_regions failure cases.
by Jinoh Kang (＠iamahuman) 08 Jun '24

08 Jun '24

Follow-up to !3989. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5811

4 3

[PATCH 0/2] MR5812: odbccp32: SQLWritePrivateProfileStringW check for existing DSN first
by Alistair Leslie-Hughes (＠alesliehughes) 08 Jun '24

08 Jun '24

If a DSN is System wide, we need to write to the HKEY_LOCAL_MACHINE part of the registry not HKEY_CURRENT_USER which it's currently doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5812

3 7

Re: [PATCH v7 0/4] MR5741: server: Implement key auto-repeat. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5741

1 0

Re: [PATCH v2 0/5] MR5804: win32u: Support custom DPI in curcor clipping related functions. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5804

1 0

Re: [PATCH v2 0/2] MR5806: odbccp32: Check for full path being supplied before append - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5806

1 0

Re: [PATCH v8 0/1] MR3518: wininet: unify timeout values closer to hInternet - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

1 0

Re: [PATCH v2 0/1] MR5807: include: Add and fix some WGL prototypes. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5807

1 0

Re: [PATCH v2 0/2] MR5808: winevulkan: Fix size mismatch when writing to return pointer. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5808

1 0

Re: [PATCH v5 0/1] MR5788: d3d11/tests: Add a test for NV12 textures. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

1 0

Re: [PATCH v3 0/3] MR5797: wined3d: Miscellaneous. - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5797

1 0

Re: [PATCH v3 0/1] MR5803: wined3d: Handle a null vertex declaration in glsl_vertex_pipe_vdecl(). - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5803

1 0

Re: [PATCH v3 0/12] MR5796: kernelbase, ntdll: Implement DOS wildcards matching in NtQueryDirectoryFile and use that in FindFirstFile(). - approved
by Alexandre Julliard (＠julliard) 07 Jun '24

07 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5796

1 0

Re: [PATCH v2 0/1] MR5803: wined3d: Handle a null vertex declaration in glsl_vertex_pipe_vdecl(). - approved
by Jan Sikorski (＠jsikorski) 07 Jun '24

07 Jun '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5803

1 0

[PATCH v4 0/1] MR5788: d3d11/tests: Add a test for NV12 textures.
by Giovanni Mascellani (＠giomasce) 07 Jun '24

07 Jun '24

-- v4: d3d11/tests: Add a test for NV12 textures. https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

5 5

Re: [PATCH v2 0/3] MR5797: wined3d: Miscellaneous. - approved
by Jan Sikorski (＠jsikorski) 07 Jun '24

07 Jun '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5797

1 0

[PATCH 0/2] MR5809: winecrt0, msvcrt: Implement static constructor support.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5809

2 2

[PATCH v15 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 07 Jun '24

07 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v15: kernel32: Add tests for large page mapping support. ntdll: Validate parameters to NtCreateSection if large pages are requested. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 7

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 07 Jun '24

07 Jun '24

On Thu Jun 6 19:38:37 2024 +0000, Jacek Caban wrote: > > Well, I expect them to behave like JS functions. If it were a JS > function, it would check to see if the object type matches, and then do > its thing. If you think of it like this, it wouldn't make much sense for > it to use another object type's function. > I'm not talking about another objects' functions, I'm talking about > separate objects having the same prototypes in JS sense but being > otherwise separate implementations of the same interfaces in C. I see, if you look at it that way it makes sense to use IID, yeah (I was thinking of the functions as complete separate entities rather than interface implementations). I still think it's slightly better to just pass/store func_info_t as a container though—it's not just the args but everywhere else we need to store it (like in ProxyFunction as I mentioned), now it's one less field to worry about. And besides, if we ever do need to change it at some point later, it will be much easier without affecting call sites. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72649

1 0

[PATCH 0/2] MR5808: winevulkan: Fix size mismatch when writing to return pointer.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5808

2 2

[PATCH 0/1] MR5807: include: Add and fix some WGL prototypes.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5807

2 1

[PATCH v4 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Akihiro Sagawa (＠sgwaki) 07 Jun '24

07 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56658 -- v4: win32u: Use the first vertical alternates table regardless of script. gdi32/tests: Add tests for script-independent vertical glyph lookup. https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

2 3

[PATCH 0/2] MR5806: odbccp32: Check for full path being supplied before append
by Alistair Leslie-Hughes (＠alesliehughes) 07 Jun '24

07 Jun '24

Installer can provide a Full path to the Driver, instead of provide the install path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5806

3 3

[PATCH v7 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 07 Jun '24

07 Jun '24

Also: Add new timeouts to NETCON calls impacted by change Timeout values are able to be set on all hInternet handles, so they should be able to set in a unified way. Submitting what I have so far for review. Known TODO: Tests, verify timeouts are set where NETCON is used, verify ULONG vs DWORD usage rules. -- v7: wininet: unify timeout values closer to hInternet https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

4 5

[PATCH 0/5] MR5804: win32u: Support custom DPI in curcor clipping related functions.
by Rémi Bernon (＠rbernon) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5804

2 5

[PATCH v14 0/6] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 07 Jun '24

07 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v14: kernel32: Add tests for large page mapping support. ntdll: Validate parameters to NtCreateSection if large pages are requested. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 7

[PATCH 0/1] MR5803: wined3d: Handle a null vertex declaration in glsl_vertex_pipe_vdecl().
by Elizabeth Figura (＠zfigura) 07 Jun '24

07 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5803

2 1

[PATCH v5 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 06 Jun '24

06 Jun '24

Also: Add new timeouts to NETCON calls impacted by change Timeout values are able to be set on all hInternet handles, so they should be able to set in a unified way. Submitting what I have so far for review. Known TODO: Tests, verify timeouts are set where NETCON is used, verify ULONG vs DWORD usage rules. -- v5: wininet: unify timeout values closer to hInternet https://gitlab.winehq.org/wine/wine/-/merge_requests/3518

2 1

Re: [PATCH v3 0/3] MR5793: server: Inherit the source token's label in token_duplicate(). - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5793

1 0

Re: [PATCH v4 0/7] MR5732: winegstreamer: Get rid of the wg_transform internal output_format. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5732

1 0

Re: [PATCH v4 0/7] MR5717: Improve dmo_wrapper_sink_Receive. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5717

1 0

Re: [PATCH v2 0/1] MR5800: gdi32/text: Handle null partial extents pointer in GetTextExtentExPointW(). - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5800

1 0

Re: [PATCH v2 0/1] MR5802: dwrite/tests: Fix a test failure on some Win10 machines with CJK locales. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5802

1 0

Re: [PATCH v4 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

1 0

Re: [PATCH v3 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

1 0

Re: [PATCH v3 0/1] MR5789: server: Remove limitation for waiting on idle_event of the current process. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5789

1 0

Re: [PATCH v4 0/5] MR5776: win32u: Parameterize DPI in some driver calls. - approved
by Alexandre Julliard (＠julliard) 06 Jun '24

06 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5776

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 06 Jun '24

06 Jun '24

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Setting the timeout on the socket is quite expensive (requires a > wineserver call). Maybe we could store the last set timeout separate > from configure timeout and update socket timeout only when they don't match? Would this proposal be only for `read_more_data` or in the broader scope of any call to `NETCON_set_timeout`? If it is for the latter, it could be tracked in `netconn_t`. I can add that into a separate merge. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72609

1 0

Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
by Jacob Pfeiffer (＠Cthuflu) 06 Jun '24

06 Jun '24

On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote: > Do we still need it? I think that with implementation in both > `set_global_option` and `INET_SetOption`, we could simply remove those > cases from `InternetSetOptionW` fallback. If we can assume that `vtbl->SetOption` is guaranteed to handle its own implementation of each timeout (or fallback to `INET_SetOption`), I could see dropping these cases from `InternetSetOptionW`. I'll amend those changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72608

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 06 Jun '24

06 Jun '24

> Well, I expect them to behave like JS functions. If it were a JS function, it would check to see if the object type matches, and then do its thing. If you think of it like this, it wouldn't make much sense for it to use another object type's function. I'm not talking about another objects' functions, I'm talking about separate objects having the same prototypes in JS sense but being otherwise separate implementations of the same interfaces in C. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72607

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Thu Jun 6 19:05:56 2024 +0000, Jacek Caban wrote: > > In such case, instead of failing, it would call the other function > that was looked up, since it matches in IID and DISPID. It won't crash, > but I don't think it would be quite correct, either. > That's the whole point, the reason it's safe and I don't see why you > think it's incorrect. BTW, IID is intentionally abstract in my proposal; > a bit closer to the actual meaning would be to use something like > prototype ID once we have those (interface ID is just already available > and close enough). > > Continuing the above, IMO the following would make it the most robust: > we look it up as mentioned from the func_info_t's dispid and IID, and > then compare to see if it's the same `func_info_t` pointer. > Sure, but it can't compare `func_info_t`s by a pointer, it would need to > compare IID or something like that anyway. So in your proposal, the > opaque pointer serves as (ID,IID) carrier, nothing else. > > BTW, is there a reason you renamed `IWineJSDispatchHost` to just > `IJSDispatchHost` when it's Wine's own interface? I thought it's better > to avoid ambiguity with a native interface, especially if we're to > extend it (obviously we can't touch native interfaces), makes it a lot > more obvious. > It's all Wine code, I don't see how putting "wine" in random places > makes it any cleaner, but it's not a strong preference and I won't > insist either way. Well, I expect them to behave like JS functions. If it were a JS function, it would check to see if the object type matches, and then do its thing. If you think of it like this, it wouldn't make much sense for it to use another object type's function. As for Wine prefix, we typically have that already for our own custom interfaces in mshtml, and even though it's all Wine code, it makes it clearer for someone unfamiliar to understand that the interface is not something from Windows—so they can find its documentation/code in Wine code with grep instead of a Google search, and can freely change them around, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72606

1 0

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 06 Jun '24

06 Jun '24

> In such case, instead of failing, it would call the other function that was looked up, since it matches in IID and DISPID. It won't crash, but I don't think it would be quite correct, either. That's the whole point, the reason it's safe and I don't see why you think it's incorrect. BTW, IID is intentionally abstract in my proposal; a bit closer to the actual meaning would be to use something like prototype ID once we have those (interface ID is just already available and close enough). > Continuing the above, IMO the following would make it the most robust: we look it up as mentioned from the func_info_t's dispid and IID, and then compare to see if it's the same `func_info_t` pointer. Sure, but it can't compare `func_info_t`s by a pointer, it would need to compare IID or something like that anyway. So in your proposal, the opaque pointer serves as (ID,IID) carrier, nothing else. > BTW, is there a reason you renamed `IWineJSDispatchHost` to just `IJSDispatchHost` when it's Wine's own interface? I thought it's better to avoid ambiguity with a native interface, especially if we're to extend it (obviously we can't touch native interfaces), makes it a lot more obvious. It's all Wine code, I don't see how putting "wine" in random places makes it any cleaner, but it's not a strong preference and I won't insist either way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72605

1 0

[PATCH v2 0/12] MR5796: kernelbase, ntdll: Implement DOS wildcards matching in NtQueryDirectoryFile and use that in FindFirstFile().
by Paul Gofman (＠gofman) 06 Jun '24

06 Jun '24

-- v2: kernelbase: Preprocess wildcarded mask and pass it with NtQueryDirectoryFile(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5796

3 14

[PATCH v36 0/2] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 06 Jun '24

06 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v36: ucrtbase: Fix incorrect layout of FILE. ucrtbase: Add FILE structure tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 3

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Thu Jun 6 15:55:43 2024 +0000, Gabriel Ivăncescu wrote: > Actually you don't even need to query IID anymore. Just look up the > function by dispid, and then check if it's same func_info_t, that's enough. BTW, is there a reason you renamed `IWineJSDispatchHost` to just `IJSDispatchHost` when it's Wine's own interface? I thought it's better to avoid ambiguity with a native interface, especially if we're to extend it (obviously we can't touch native interfaces), makes it a lot more obvious. And to add to what I said above, what I meant with "retrieving a potentially different function" is mostly theoretical, because as you said current mshtml likely has only one struct layout per interface. **But** if we were to assume this is not the case (addressing the original concern), then two objects could have same IID but different struct layouts and different functions. In such case, instead of failing, it would call the other function that was looked up, since it matches in IID and DISPID. It won't crash, but I don't think it would be quite correct, either. And it still makes the code simpler anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72601

1 0

[PATCH v3 0/7] MR5732: winegstreamer: Get rid of the wg_transform internal output_format.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

-- v3: winegstreamer: Request the new transform output format explicitly. winegstreamer: Use a caps to store the desired output format. winegstreamer: Only report format changes when frontend supports it. winegstreamer: Rename allow_size_change to allow_format_change. winegstreamer: Enforce default stride presence in the video processor. winegstreamer: Enforce default stride value in the video decoder. winegstreamer: Allow to clear video decoder input/output types. https://gitlab.winehq.org/wine/wine/-/merge_requests/5732

4 10

[PATCH v3 0/7] MR5717: Improve dmo_wrapper_sink_Receive.
by Ziqing Hui (＠zhui) 06 Jun '24

06 Jun '24

This reduce the chance of buffer allocating issue for Kirikiri2 games(eg. Super Naughty Maid) when the game is trying to play videos. -- v3: qasf/dmowrapper: Sync Stop() and Receive() for dmo wrapper filter. qasf/dmowrapper: Return VFW_E_WRONG_STATE in dmo_wrapper_sink_Receive. qasf/dmowrapper: Allocate output samples before calling ProcessInput(). qasf/dmowrapper: Return failure in dmo_wrapper_sink_Receive if samples allocating fails. qasf/dmowrapper: Introduce release_output_samples. qasf/dmowrapper: Introduce get_output_samples. qasf/tests: Add more tests for dmo_wrapper_sink_Receive. https://gitlab.winehq.org/wine/wine/-/merge_requests/5717

3 8

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

On Thu Jun 6 15:51:53 2024 +0000, Gabriel Ivăncescu wrote: > > But then you assume that all objects implementing the interface will > use the same struct layout for that. I can't think of an example inside > MSHTML where it's currently not the case, but that's not generally a > promise that QI gives. > In theory, there's a similar concern when looking up the function via > IID and DISPID, specifically, that it might find a different function. > In practice as you said it probably doesn't happen but… > > So what's the point of it then? Avoiding one argument in a call? > Continuing the above, IMO the following would make it the most robust: > we look it up as mentioned from the func_info_t's dispid and IID, and > then compare to see if it's the same `func_info_t` pointer. If not, > return E_UNEXPECTED since it's the wrong function. And yes, one less > argument to keep track of, but also one less thing to keep track of (in > the ProxyFunction for instance, and everywhere else). > > I think that you misinterprets your observations. Here is a test > proving that currentStyle should have a setter that throws an error > (unless used for modifiable style object): > Okay, thanks for the test, I guess there's more at play here indeed. Actually you don't even need to query IID anymore. Just look up the function by dispid, and then check if it's same func_info_t, that's enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72595

1 0

[PATCH v3 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

Didn't notice that it was failing until I did the same for winemac with https://gitlab.winehq.org/wine/wine/-/merge_requests/5798. It was silently falling back to copies while winemac can't do that. -- v3: gdi.exe16: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory. winex11: Wrap more window surface formats with NtGdiDdDDICreateDCFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

2 3

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu (＠insn) 06 Jun '24

06 Jun '24

> But then you assume that all objects implementing the interface will use the same struct layout for that. I can't think of an example inside MSHTML where it's currently not the case, but that's not generally a promise that QI gives. In theory, there's a similar concern when looking up the function via IID and DISPID, specifically, that it might find a different function. In practice as you said it probably doesn't happen but… > So what's the point of it then? Avoiding one argument in a call? Continuing the above, IMO the following would make it the most robust: we look it up as mentioned from the func_info_t's dispid and IID, and then compare to see if it's the same `func_info_t` pointer. If not, return E_UNEXPECTED since it's the wrong function. And yes, one less argument to keep track of, but also one less thing to keep track of (in the ProxyFunction for instance, and everywhere else). > I think that you misinterprets your observations. Here is a test proving that currentStyle should have a setter that throws an error (unless used for modifiable style object): Okay, thanks for the test, I guess there's more at play here indeed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72591

1 0

[PATCH 0/3] MR5799: winex11: Fix some incorrect usage of NtGdiDdDDICreateDCFromMemory.
by Rémi Bernon (＠rbernon) 06 Jun '24

06 Jun '24

Didn't notice that it was failing until I did the same for winemac with https://gitlab.winehq.org/wine/wine/-/merge_requests/5798. It was silently falling back to copies while winemac can't do that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5799

3 5

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) 06 Jun '24

06 Jun '24

> Yeah, I forgot to validate it in my branch. In BuiltinFuncCall, something like this would work: But then you assume that all objects implementing the interface will use the same struct layout for that. I can't think of an example inside MSHTML where it's currently not the case, but that's not generally a promise that QI gives. > Alternatively, we can pass around `func_info_t` instead of dispid and tid, but still look it up like in your branch. So what's the point of it then? Avoiding one argument in a call? > I mean the test will simply start failing if it picks `IHTMLCSSStyleDeclaration` because the assignment does not throw exception anymore (when it should be!). I think that you misinterprets your observations. Here is a test proving that currentStyle should have a setter that throws an error (unless used for modifiable style object): ``` sync_test("currentStyle", function() { if (document.documentMode < 9) return; var s = document.body.currentStyle; var d = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(Object.getPrototypeOf(s)), "zoom"); ok(typeof(d.get) === "function", "d.get = " + d.get); ok(typeof(d.set) === "function", "d.set = " + d.set); d.set.call(document.body.style, "1"); try { d.set.call(s, "1"); ok(false, "exception expected"); }catch(e) { trace("MSG: " + e.message); } }); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_72588

1 0

2025

2024

2023

2022

wine-gitlab June 2024