June 2024 - wine-gitlab

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Sun Jun 2 22:51:59 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3173_3164) It should be fixed. Please review it again -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72397

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Sun Jun 2 22:59:20 2024 +0000, cqwrteur wrote: > changed this line in [version 22 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116244&start_sha=f9ce09a15be1de01f4b8f3f2c25cf9c722a4b2d8#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3144_3149) It was always different in layout. This is a bug for years. UCRT does not have the same layout of FILE compared to msvcrt. However wine just assumes they are the same, which is wrong. MSVC allows you to pass FILE* from a statically linked ucrt to a dynamic linked ucrt provided by the operating system and that is of course causing abi break. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72396

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Sun Jun 2 22:51:59 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3171_3164) It is not. The problem is that ucrt can be statically linked from Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. And fast_io library is exploiting that to gain huge performance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72395

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Sun Jun 2 22:51:57 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3153_3158) Of course, there is. The problem is that ucrt can be statically linked from Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. And fast_io library is using that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72394

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

Please merge it. Ty. This ABI issue is a big issue for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72393

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 04 Jun '24

04 Jun '24

On Fri May 31 21:52:56 2024 +0000, cqwrteur wrote: > Add a test. I think this should be ok now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72392

1 0

Re: [PATCH v3 0/4] MR5774: win32u: Move desktop resize on WM_DISPLAYCHANGE of the drivers. - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5774

1 0

Re: [PATCH v2 0/4] MR5780: mshtml: Unify document node IDispatchEx implementation. - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5780

1 0

Re: [PATCH v2 0/1] MR5770: wined3d: Update multisample state when the sample count changes. - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5770

1 0

Re: [PATCH v3 0/4] MR5784: win32u: Fix a couple of window surface regressions. - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5784

1 0

Re: [PATCH v2 0/1] MR5783: ntdll: Provide fallback values for DMI fields only readable by root. - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5783

1 0

Re: [PATCH v6 0/5] MR5641: Cmd engine rewrite (part IV) - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5641

1 0

Re: [PATCH v2 0/1] MR5781: include: Add more types to windows.networking.connectivity.idl. - approved
by Alexandre Julliard (＠julliard) 04 Jun '24

04 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5781

1 0

[PATCH 0/1] MR5779: win32u: Send EVENT_OBJECT_FOCUS in more cases.
by Esme Povirk (＠madewokherd) 04 Jun '24

04 Jun '24

This adds some wine-only messages, but most of those are cases that follow an existing EVENT_SYSTEM_FOREGROUND wine-only message, so likely correctly reflecting a thing Wine is already known to do wrong. The exception is WmRestore_3. https://testbot.winehq.org/JobDetails.pl?Key=146025 suggests that's also a case where focuses the window and shouldn't. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5779

4 5

[PATCH 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792

2 1

[PATCH 0/1] MR5790: makedep: Support building only tools, headers and import libs.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

I think this would be useful to build a subset of Wine that could then be used to build third-party modules without having to build everything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5790

3 4

[PATCH 5/5] wineps.drv: Add partial support for changing page size.
by Piotr Caban 04 Jun '24

04 Jun '24

From: Piotr Caban <piotr(a)codeweavers.com> --- dlls/wineps.drv/printproc.c | 2 ++ dlls/wineps.drv/ps.c | 14 ++++++++++++-- dlls/wineps.drv/psdrv.h | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c index db2979f0fbe..84f4b9f5900 100644 --- a/dlls/wineps.drv/printproc.c +++ b/dlls/wineps.drv/printproc.c @@ -3110,6 +3110,8 @@ BOOL WINAPI PrintDocumentOnPrintProcessor(HANDLE pp, WCHAR *doc_name) if (ret) ret = PSDRV_ResetDC(data->ctx, devmode); + if (ret && devmode && (devmode->dmFields & DM_PAPERSIZE)) + ret = PSDRV_WritePageSize(data->ctx); free(devmode); if (!ret) goto cleanup; diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index d48370acef7..31e8c5bdebb 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -396,6 +396,17 @@ static void write_cups_job_ticket( print_ctx *ctx, const struct ticket_info *inf write_spool( ctx, cups_ap_d_inputslot, sizeof(cups_ap_d_inputslot) - 1 ); } +INT PSDRV_WritePageSize( print_ctx *ctx ) +{ + PAGESIZE *page = find_pagesize( ctx->pi->ppd, &ctx->Devmode->dmPublic ); + + if (page && page->InvocationString) + PSDRV_WriteFeature( ctx, "*PageSize", page->Name, page->InvocationString ); + else + WARN("Page size not set\n"); + return 1; +} + INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) { char *buf, *escaped_title; @@ -443,8 +454,7 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) if (slot && slot->InvocationString) PSDRV_WriteFeature( ctx, "*InputSlot", slot->Name, slot->InvocationString ); - if (page && page->InvocationString) - PSDRV_WriteFeature( ctx, "*PageSize", page->Name, page->InvocationString ); + PSDRV_WritePageSize( ctx ); if (duplex && duplex->InvocationString) PSDRV_WriteFeature( ctx, "*Duplex", duplex->Name, duplex->InvocationString ); diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index d1ac2cc06cd..2c4703de942 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -466,6 +466,7 @@ extern char PSDRV_UnicodeToANSI(int u); extern INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ); extern INT PSDRV_WriteFooter( print_ctx *ctx ); +extern INT PSDRV_WritePageSize( print_ctx *ctx ); extern INT PSDRV_WriteNewPage( print_ctx *ctx ); extern INT PSDRV_WriteEndPage( print_ctx *ctx ); extern BOOL PSDRV_WriteMoveTo(print_ctx *ctx, INT x, INT y); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

1 0

[PATCH 4/5] wineps.drv: Write PageBoundingBox for every page.
by Piotr Caban 04 Jun '24

04 Jun '24

From: Piotr Caban <piotr(a)codeweavers.com> --- dlls/wineps.drv/ps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 8d3db610647..d48370acef7 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -95,6 +95,7 @@ static const char psendfeature[] = static const char psnewpage[] = /* name, number, xres, yres, xtrans, ytrans, rot */ "%%%%Page: %s %d\n" +"%%%%PageBoundingBox: %ld %ld %ld %ld\n" "%%%%PageOrientation: %s\n" "%%%%BeginPageSetup\n" "/pgsave save def\n" @@ -560,6 +561,7 @@ INT PSDRV_WriteNewPage( print_ctx *ctx ) } sprintf(buf, psnewpage, name, ctx->job.PageNo, + bbox.left, bbox.top, bbox.right, bbox.bottom, ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE ? "Landscape" : "Portrait", GetDeviceCaps(ctx->hdc, ASPECTX), GetDeviceCaps(ctx->hdc, ASPECTY), xtrans, ytrans, rotation); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

1 0

[PATCH 3/5] wineps.drv: Take all pages into account when computing bounding box.
by Piotr Caban 04 Jun '24

04 Jun '24

From: Piotr Caban <piotr(a)codeweavers.com> --- dlls/wineps.drv/ps.c | 85 +++++++++++++++++++++++------------------ dlls/wineps.drv/psdrv.h | 1 + 2 files changed, 49 insertions(+), 37 deletions(-) diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 744bda62497..8d3db610647 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -54,7 +54,7 @@ static const char cups_ap_d_inputslot[] = "%cupsJobTicket: AP_D_InputSlot=\n"; / static const char psheader[] = /* title llx lly urx ury orientation */ "%%%%Creator: Wine PostScript Driver\n" "%%%%Title: %s\n" -"%%%%BoundingBox: %d %d %d %d\n" +"%%%%BoundingBox: (atend)\n" "%%%%Pages: (atend)\n" "%%%%EndComments\n"; @@ -110,6 +110,7 @@ static const char psendpage[] = static const char psfooter[] = /* pages */ "%%%%Trailer\n" +"%%%%BoundingBox: %ld %ld %ld %ld\n" "%%%%Pages: %d\n" "%%%%EOF\n"; @@ -400,7 +401,6 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) INPUTSLOT *slot = find_slot( ctx->pi->ppd, &ctx->Devmode->dmPublic ); PAGESIZE *page = find_pagesize( ctx->pi->ppd, &ctx->Devmode->dmPublic ); DUPLEX *duplex = find_duplex( ctx->pi->ppd, &ctx->Devmode->dmPublic ); - int llx, lly, urx, ury; int ret, len; struct ticket_info ticket_info = { page, duplex }; @@ -419,46 +419,14 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) escaped_title = escape_title(title); buf = HeapAlloc( GetProcessHeap(), 0, sizeof(psheader) + - strlen(escaped_title) + 30 ); + strlen(escaped_title) ); if(!buf) { WARN("HeapAlloc failed\n"); HeapFree(GetProcessHeap(), 0, escaped_title); return 0; } - /* BBox co-ords are in default user co-ord system so urx < ury even in - landscape mode */ - if ((ctx->Devmode->dmPublic.dmFields & DM_PAPERSIZE) && page) - { - if (page->ImageableArea) - { - llx = page->ImageableArea->llx; - lly = page->ImageableArea->lly; - urx = page->ImageableArea->urx; - ury = page->ImageableArea->ury; - } - else - { - llx = lly = 0; - urx = page->PaperDimension->x; - ury = page->PaperDimension->y; - } - } - else if ((ctx->Devmode->dmPublic.dmFields & DM_PAPERLENGTH) && - (ctx->Devmode->dmPublic.dmFields & DM_PAPERWIDTH)) - { - /* Devmode sizes in 1/10 mm */ - llx = lly = 0; - urx = ctx->Devmode->dmPublic.dmPaperWidth * 72.0 / 254.0; - ury = ctx->Devmode->dmPublic.dmPaperLength * 72.0 / 254.0; - } - else - { - llx = lly = urx = ury = 0; - } - /* FIXME should do something better with BBox */ - - sprintf(buf, psheader, escaped_title, llx, lly, urx, ury); + sprintf(buf, psheader, escaped_title); HeapFree(GetProcessHeap(), 0, escaped_title); @@ -498,7 +466,8 @@ INT PSDRV_WriteFooter( print_ctx *ctx ) return 0; } - sprintf(buf, psfooter, ctx->job.PageNo); + sprintf(buf, psfooter, ctx->bbox.left, ctx->bbox.top, + ctx->bbox.right, ctx->bbox.bottom, ctx->job.PageNo); if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); @@ -520,15 +489,57 @@ INT PSDRV_WriteEndPage( print_ctx *ctx ) } +static void get_bounding_box( print_ctx *ctx, RECT *bbox) +{ + PAGESIZE *page; + + /* BBox co-ords are in default user co-ord system so urx < ury even in + landscape mode */ + if ((ctx->Devmode->dmPublic.dmFields & DM_PAPERSIZE) && + (page = find_pagesize( ctx->pi->ppd, &ctx->Devmode->dmPublic ))) + { + if (page->ImageableArea) + { + bbox->left = page->ImageableArea->llx; + bbox->top = page->ImageableArea->lly; + bbox->right = page->ImageableArea->urx; + bbox->bottom = page->ImageableArea->ury; + } + else + { + bbox->left = bbox->top = 0; + bbox->right = page->PaperDimension->x; + bbox->bottom = page->PaperDimension->y; + } + } + else if ((ctx->Devmode->dmPublic.dmFields & DM_PAPERLENGTH) && + (ctx->Devmode->dmPublic.dmFields & DM_PAPERWIDTH)) + { + /* Devmode sizes in 1/10 mm */ + bbox->left = bbox->top = 0; + bbox->right = ctx->Devmode->dmPublic.dmPaperWidth * 72.0 / 254.0; + bbox->bottom = ctx->Devmode->dmPublic.dmPaperLength * 72.0 / 254.0; + } + else + { + bbox->left = bbox->top = bbox->right = bbox->bottom = 0; + } + /* FIXME should do something better with BBox */ +} + INT PSDRV_WriteNewPage( print_ctx *ctx ) { signed int xtrans, ytrans, rotation; char buf[256], name[16]; + RECT bbox; sprintf(name, "%d", ctx->job.PageNo); + get_bounding_box( ctx, &bbox ); + UnionRect( &ctx->bbox, &bbox, &ctx->bbox ); + if(ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE) { if(ctx->pi->ppd->LandscapeOrientation == -90) { xtrans = GetDeviceCaps(ctx->hdc, PHYSICALHEIGHT) - diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index 31adc36adfc..d1ac2cc06cd 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -368,6 +368,7 @@ typedef struct PSDRV_DEVMODE *Devmode; PRINTERINFO *pi; int pathdepth; + RECT bbox; } print_ctx; extern print_ctx *create_print_ctx( HDC hdc, const WCHAR *device, -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

1 0

[PATCH 2/5] wineps.drv: Write page orientation hint for every page.
by Piotr Caban 04 Jun '24

04 Jun '24

From: Piotr Caban <piotr(a)codeweavers.com> --- dlls/wineps.drv/ps.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 149bfc81c36..744bda62497 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -56,7 +56,6 @@ static const char psheader[] = /* title llx lly urx ury orientation */ "%%%%Title: %s\n" "%%%%BoundingBox: %d %d %d %d\n" "%%%%Pages: (atend)\n" -"%%%%Orientation: %s\n" "%%%%EndComments\n"; static const char psbeginprolog[] = @@ -96,6 +95,7 @@ static const char psendfeature[] = static const char psnewpage[] = /* name, number, xres, yres, xtrans, ytrans, rot */ "%%%%Page: %s %d\n" +"%%%%PageOrientation: %s\n" "%%%%BeginPageSetup\n" "/pgsave save def\n" "72 %d div 72 %d div scale\n" @@ -402,7 +402,6 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) DUPLEX *duplex = find_duplex( ctx->pi->ppd, &ctx->Devmode->dmPublic ); int llx, lly, urx, ury; int ret, len; - const char * dmOrientation; struct ticket_info ticket_info = { page, duplex }; @@ -459,8 +458,7 @@ INT PSDRV_WriteHeader( print_ctx *ctx, LPCWSTR title ) } /* FIXME should do something better with BBox */ - dmOrientation = (ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE ? "Landscape" : "Portrait"); - sprintf(buf, psheader, escaped_title, llx, lly, urx, ury, dmOrientation); + sprintf(buf, psheader, escaped_title, llx, lly, urx, ury); HeapFree(GetProcessHeap(), 0, escaped_title); @@ -551,8 +549,9 @@ INT PSDRV_WriteNewPage( print_ctx *ctx ) } sprintf(buf, psnewpage, name, ctx->job.PageNo, - GetDeviceCaps(ctx->hdc, ASPECTX), GetDeviceCaps(ctx->hdc, ASPECTY), - xtrans, ytrans, rotation); + ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE ? "Landscape" : "Portrait", + GetDeviceCaps(ctx->hdc, ASPECTX), GetDeviceCaps(ctx->hdc, ASPECTY), + xtrans, ytrans, rotation); if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

1 0

[PATCH 1/5] wineps.drv: Don't use dynamic buffer when writing new page info.
by Piotr Caban 04 Jun '24

04 Jun '24

From: Piotr Caban <piotr(a)codeweavers.com> --- dlls/wineps.drv/ps.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index 59e245b9b6c..149bfc81c36 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -526,19 +526,11 @@ INT PSDRV_WriteEndPage( print_ctx *ctx ) INT PSDRV_WriteNewPage( print_ctx *ctx ) { - char *buf; - char name[100]; signed int xtrans, ytrans, rotation; - int ret = 1; + char buf[256], name[16]; sprintf(name, "%d", ctx->job.PageNo); - buf = HeapAlloc( GetProcessHeap(), 0, sizeof(psnewpage) + 200 ); - if(!buf) { - WARN("HeapAlloc failed\n"); - return 0; - } - if(ctx->Devmode->dmPublic.dmOrientation == DMORIENT_LANDSCAPE) { if(ctx->pi->ppd->LandscapeOrientation == -90) { xtrans = GetDeviceCaps(ctx->hdc, PHYSICALHEIGHT) - @@ -564,10 +556,9 @@ INT PSDRV_WriteNewPage( print_ctx *ctx ) if( write_spool( ctx, buf, strlen(buf) ) != strlen(buf) ) { WARN("WriteSpool error\n"); - ret = 0; + return 0; } - HeapFree( GetProcessHeap(), 0, buf ); - return ret; + return 1; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5791

1 0

[PATCH 0/1] MR5785: gdiplus: Remove record container from metafile object
by David Kahurani (＠ReDress) 04 Jun '24

04 Jun '24

This list is best suited as a local object Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5785

4 5

[PATCH v2 0/1] MR5788: d3d11/tests: Add a test for NV12 textures.
by Giovanni Mascellani (＠giomasce) 04 Jun '24

04 Jun '24

-- v2: d3d11/tests: Add a test for NV12 textures. https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

4 4

[PATCH 0/4] MR5780: mshtml: Unify document node IDispatchEx implementation.
by Jacek Caban (＠jacek) 04 Jun '24

04 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5780

3 5

[PATCH v2 0/6] MR5773: mmdevapi: Fake success in a few IAudioSessionControl2 methods
by Fabian Maurer (＠DarkShadow44) 04 Jun '24

04 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763 -- v2: mmdevapi: Implement IAudioSessionControl2 GetGroupingParam SetGroupingParam mmdevapi: Implement IAudioSessionControl2 GetIconPath / SetIconPath mmdevapi: Implement IAudioSessionControl2 GetDisplayName / SetDisplayName mmdevapi/tests: Add tests for IAudioSessionControl2 GetGroupingParam / SetGroupingParam mmdevapi/tests: Add tests for IAudioSessionControl2 GetIconPath / SetIconPath mmdevapi/tests: Add tests for IAudioSessionControl2 GetDisplayName / SetDisplayName https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

5 18

[PATCH 0/1] MR5770: wined3d: Update multisample state when the sample count changes.
by Elizabeth Figura (＠zfigura) 04 Jun '24

04 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5770

3 2

Re: [PATCH v3 0/9] MR5782: win32u: Move UpdateLayeredWindow implementation to win32u. - approved
by Huw Davies (＠huw) 04 Jun '24

04 Jun '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5782

1 0

[PATCH 0/1] MR5788: d3d11/tests: Add a test for NV12 textures.
by Giovanni Mascellani (＠giomasce) 04 Jun '24

04 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5788

3 2

[PATCH 0/1] MR5786: gdi32: Use an internal NtUser call for D3DKMTOpenAdapterFromGdiDisplayName.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

Fixes a deadlock with display_device_init mutex and display_lock when trying to open the D3DKMT adapter while holding the mutex in the caller. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56764 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5786

4 3

Re: [PATCH v3 0/9] MR5782: win32u: Move UpdateLayeredWindow implementation to win32u.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

On Tue Jun 4 12:09:04 2024 +0000, Huw Davies wrote: > ```suggestion:-0+0 > ``` > There's a trailing space here. Thanks, fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5782#note_72307

1 0

[PATCH v2 0/9] MR5782: win32u: Move UpdateLayeredWindow implementation to win32u.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

-- v2: win32u: Move UpdateLayeredWindow implementation out of the drivers. win32u: Introduce a new CreateLayeredWindow driver entry. winex11: Use the surface bitmap directly in UpdateLayeredWindow. winex11: Always clear UpdateLayeredWindow target rectangle. winemac: Blend alpha with NtGdiAlphaBlend instead of window opacity. winemac: Use the surface bitmap directly in UpdateLayeredWindow. winemac: Always clear UpdateLayeredWindow target rectangle. wineandroid: Use the surface bitmap directly in UpdateLayeredWindow. wineandroid: Always clear UpdateLayeredWindow target rectangle. https://gitlab.winehq.org/wine/wine/-/merge_requests/5782

3 11

[PATCH v2 0/4] MR5784: win32u: Fix a couple of window surface regressions.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

Fixes a regression from 5d0efbcc6e88e2b7886f2a0cfb58c9100b452160, and 0d2fa879d735cd39e72c15014686001c13a089b8 (https://bugs.winehq.org/show_bug.cgi?id=56766). -- v2: win32u: Get rid of move_window_bits_parent, using move_window_bits. win32u: Don't map points to the parent window in move_window_bits_parent. win32u: Use a dedicated helper to move bits from a previous surface. win32u: Restore surface rect, which may offsetted from the window rect. https://gitlab.winehq.org/wine/wine/-/merge_requests/5784

2 5

[PATCH 0/1] MR5783: ntdll: Provide fallback values for DMI fields only readable by root.
by Hans Leidekker (＠hans) 04 Jun '24

04 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56744 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5783

2 1

[PATCH v2 0/4] MR5774: win32u: Move desktop resize on WM_DISPLAYCHANGE of the drivers.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

-- v2: win32u: Move desktop resize on WM_DISPLAYCHANGE out of the drivers. win32u: Send display change messages when host display mode changes. win32u: Fix a restorer_str typo. winemac: Merge RESET_DEVICE_METRICS and DISPLAYCHANGE internal messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/5774

4 9

[PATCH v5 0/5] MR5641: Cmd engine rewrite (part IV)
by eric pouech (＠epo) 04 Jun '24

04 Jun '24

This is the fourth part in cmd.exe's engine rewrite. It concerns: - start of decoupling parsing from execution by introducing ad hoc structure to hold parsing result to be passed for execution (done here for redirection, and if conditions), - refactor execution code with putting into helpers: + change of input/output streams + save / restore of input/output streams before / after execution Note: - the handling of fd > 2 is clearly wrong, but it just mimics the current implementation. More work will be required afterwards (likely using directly CRT low level I/O), - I kept a few specific debug channels in place. They will be removed (or simplified at some point), but they could be useful to debug remaining issues. -- v5: programs/cmd: Separate IF command parsing from execution. programs/cmd: Let errorlevel be a signed integer. programs/cmd: Create helper to execute a command. programs/cmd: Introduce structure CMD_REDIRECTION. programs/cmd: Introduce a helper to set std handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/5641

2 6

[PATCH v4 0/5] MR5641: Cmd engine rewrite (part IV)
by eric pouech (＠epo) 04 Jun '24

04 Jun '24

This is the fourth part in cmd.exe's engine rewrite. It concerns: - start of decoupling parsing from execution by introducing ad hoc structure to hold parsing result to be passed for execution (done here for redirection, and if conditions), - refactor execution code with putting into helpers: + change of input/output streams + save / restore of input/output streams before / after execution Note: - the handling of fd > 2 is clearly wrong, but it just mimics the current implementation. More work will be required afterwards (likely using directly CRT low level I/O), - I kept a few specific debug channels in place. They will be removed (or simplified at some point), but they could be useful to debug remaining issues. -- v4: programs/cmd: Separate IF command parsing from execution. programs/cmd: Let errorlevel be a signed integer. programs/cmd: Create helper to execute a command. programs/cmd: Introduce structure CMD_REDIRECTION. programs/cmd: Introduce a helper to set std handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/5641

3 8

[PATCH 0/9] MR5782: win32u: Move UpdateLayeredWindow implementation to win32u.
by Rémi Bernon (＠rbernon) 04 Jun '24

04 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5782

2 10

[PATCH 0/4] MR5717: Improve dmo_wrapper_sink_Receive.
by Ziqing Hui (＠zhui) 04 Jun '24

04 Jun '24

This reduce the chance of buffer allocating issue for Kirikiri2 games(eg. Super Naughty Maid) when the game is trying to play videos. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5717

3 10

[PATCH 0/1] MR5781: include: Add more types to windows.networking.connectivity.idl.
by Elizabeth Figura (＠zfigura) 03 Jun '24

03 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5781

3 2

Re: [PATCH v4 0/6] MR5764: win32u: Create bitmaps for window surface pixels. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5764

1 0

Re: [PATCH v2 0/2] MR5775: wmic: Add csproduct and systemenclosure aliases. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5775

1 0

Re: [PATCH v2 0/1] MR5778: wineps.drv: Call ResetDCW() to update Devmode in the Unix interface. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5778

1 0

Re: [PATCH v7 0/7] MR5666: d3dx9: More refactoring in preparation for shared code. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5666

1 0

Re: [PATCH v2 0/1] MR5772: windowscodecs: Add conversions from PixelFormat32bppBGRA->PixelFormat16bppBGRA5551 and a test. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5772

1 0

Re: [PATCH v3 0/4] MR5746: coremessaging: Add CreateDispatcherQueueController() stub. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5746

1 0

Re: [PATCH v4 0/6] MR5724: widl: Various fixes. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724

1 0

[PATCH 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build.
by Dmitry Timoshkov (＠dmitry) 03 Jun '24

03 Jun '24

I have a .Net application that during handling of WM_NCPAINT for one of its windows genarates exception "Arithmetic operation resulted in an overflow.". This happens only in a 64-bit prefix and only for WPARAM that contains an HRGN handle with value over than 0x7fffffff. The application does the following: public static IntPtr GetNativeDC(Message m, IntPtr handle) { if (m.Msg != 0x85) // WM_NCPAINT { return NUser32.GetWindowDC(handle); } int num = 0x200013; // DCX_VALIDATE | DCX_CLIPSIBLINGS | DCX_CACHE | DCX_WINDOW IntPtr intPtr = IntPtr.Zero; IntPtr wParam = m.WParam; if (wParam.ToInt32() != 1) { num |= 0x80; // DCX_INTERSECTRGN intPtr = CreateRectRgn(0, 0, 1, 1); CombineRgn(intPtr, wParam, IntPtr.Zero, 5); // RGN_COPY } return NUser32.GetDCEx(handle, intPtr, num); } The exception is generated by wParam.ToInt32(). MSDN description for ToInt32() https://learn.microsoft.com/en-us/dotnet/api/system.intptr.toint32?view=net… states Exceptions OverflowException In a 64-bit process, the value of this instance is too large or too small to represent as a 32-bit signed integer. MSDN also has a reference to ToInt32() source: https://github.com/dotnet/runtime/blob/5535e31a712343a63f5d7d796cd874e563e5… public int ToInt32() { #if TARGET_64BIT return checked((int)_value); #else return (int)_value; #endif } It's not clear why a sign extension may lead to an overflow exception. This patch fixes the problem, and provides a test case that confirms that entry.Generation field of a GDI32 object is limited by 127 on a 64-bit platform, while 32-bit Windows doesn't have such a limitation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

4 5

[PATCH 0/1] MR5778: wineps.drv: Call ResetDCW() to update Devmode in the Unix interface.
by Danyil Blyschak (＠blyss) 03 Jun '24

03 Jun '24

Previously, PSDRV_ResetDC() only updated the devmode contained in the print context, which could cause the devmode in the unix interface to be inconsistent with the print context's devmode. This can cause problems later when PostScript is being outputted, as get_device_caps() in the unix interface would reference this inconsistent devmode. By calling ResetDCW() in PSDRV_ResetDC(), these two devmodes remain in-sync. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5778

4 3

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Paul Gofman (＠gofman) 03 Jun '24

03 Jun '24

On Mon Jun 3 16:19:12 2024 +0000, Vibhav Pant wrote: > I'm sorry, what are the "earlier patches" in this context? Also, I was > not entirely sure what the component modified would be, as both > NtCreationSection and CreateFileMapping would be affected by the patch, > which are in different components. Would wineserver be appropriate? Your MR at each moment should be the set of finalized patches. If you are changing something in existing patches you update / replace those without adding new patches. You set the component which your patch is directly modifying. If there is more than one (rare occasion which often means you need to split your patches) you specify higher level component. I'd really suggest to view some commit history for the related components for examples. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72236

1 0

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 03 Jun '24

03 Jun '24

On Mon Jun 3 16:19:12 2024 +0000, Paul Gofman wrote: > As a general note, please don't put the changes to earlier patches on > top, just modify the patches. We also start the patch names from the > name of the component the patch is modifying, like: "ntdll: Support xxx > in NtYYY()." It would probably help to look at some merged MRs and > commit history for examples. I'm sorry, what are the "earlier patches" in this context? Also, I was not entirely sure what the component modified would be, as both NtCreationSection and CreateFileMapping would be affected by the patch, which are in different components. Would wineserver be appropriate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72234

1 0

[PATCH v3 0/6] MR5764: win32u: Create bitmaps for window surface pixels.
by Rémi Bernon (＠rbernon) 03 Jun '24

03 Jun '24

This should help unifying the interface and get rid of the get_info callback. Later, I think we could create bitmaps over sections shared with some DWM process and/or host compositor. -- v3: win32u: Create a HBITMAP backing the window surface pixels. winex11: Create a HBITMAP for the allocated surface pixels. winex11: Create XImage before initializing the window surface. winex11: Simplify the XSHM extension function calls. win32u: Pass BITMAPINFO and a HBITMAP to window_surface_init. win32u: Move the window surface color bits to the common struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/5764

2 7

[PATCH 0/1] MR5772: windowscodecs: Add conversions from PixelFormat32bppBGRA->PixelFormat16bppBGRA5551 and a test.
by Ben (＠Czahrien) 03 Jun '24

03 Jun '24

Bugzilla Issue - https://bugs.winehq.org/show_bug.cgi?id=56755 This addresses an issue in EverQuest with some older models having white textures since a game patch earlier in the year. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5772

6 5

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Paul Gofman (＠gofman) 03 Jun '24

03 Jun '24

As a general note, please don't put the changes to earlier patches on top, just modify the patches. We also start the patch names from the name of the component the patch is modifying, like: "ntdll: Support xxx in NtYYY()." It would probably help to look at some merged MRs and commit history for examples. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72228

1 0

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Paul Gofman (＠gofman) 03 Jun '24

03 Jun '24

On Sun Jun 2 15:41:59 2024 +0000, Vibhav Pant wrote: > From what I understand, THP support is ultimately immaterial here, as > we're **requiring** a huge page allocation, rather than depending on > `khugepaged`to compact `madvise`-ed ranges. Still, are the large page sizes on Windows match those on Linux? I think in Wine we have to support what Windows supports and report the same minimum page size that Windows reports. If that can be backed by actual huge pages then great but I am not sure if we can sacrifice compatibility here. Depends on usage pattern probably but I wouldn't expect the actually backing the range with huge pages to have all that great performance impact. Also, just as a note, mind that those huge pages allocation on Windows have other specifics, like IIRC they are always locked in memory. That potentially can have more impact than actual backing pages layout. I am wondering what does the app which uses it actually does with this mapping? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72227

1 0

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Paul Gofman (＠gofman) 03 Jun '24

03 Jun '24

On Mon Jun 3 12:33:42 2024 +0000, Vibhav Pant wrote: > changed this line in [version 7 of the diff](/wine/wine/-/merge_requests/5769/diffs?diff_id=116330&start_sha=d9cab6b6298f63cccffebb8a71e6ca56d4a3f871#2b37d5dc1c3bb6a637f043480c038caea64531bb_342_342) While of course memfd can be accessed quicker than disk storage that doesn't justify backing all the anonymous mappings with memfd. Even for executable images only it may be very lot. In the other thread you are mentioning Proton patch doing something similar. I think that was motivated as a workaround for a specific problems with specific types of mappings and probably would be better to be changed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72226

1 0

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 03 Jun '24

03 Jun '24

Just discovered Valve's Proton Wine fork seems to use memfds for anonymous mappings too (without the large pages support though yet), interesting :slight_smile:: https://github.com/ValveSoftware/wine/blob/a8514f9606ee3fdc3d912c988f651edc… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72223

1 0

[PATCH 0/3] MR5773: mmdevapi: Fake success in a few IAudioSessionControl2 methods
by Fabian Maurer (＠DarkShadow44) 03 Jun '24

03 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

3 4

[PATCH v10 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 03 Jun '24

03 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v10: make_memfd_name: Fix format specifiers. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

1 0

[PATCH v2 0/5] MR5764: win32u: Create bitmaps for window surface pixels.
by Rémi Bernon (＠rbernon) 03 Jun '24

03 Jun '24

This should help unifying the interface and get rid of the get_info callback. Later, I think we could create bitmaps over sections shared with some DWM process and/or host compositor. -- v2: win32u: Create a HBITMAP backing the window surface pixels. winex11: Create a HBITMAP for the allocated surface pixels. winex11: Create XImage before initializing the window surface. win32u: Pass BITMAPINFO and a HBITMAP to window_surface_init. win32u: Move the window surface color bits to the common struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/5764

3 13

[PATCH v9 0/20] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 03 Jun '24

03 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v9: create_memfd: Use ftruncate to set memfd size. create_mapping: Fix argument order to create_temp_file. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

1 0

[PATCH v8 0/18] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 03 Jun '24

03 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v8: create_temp_file: Return fd when create_memfd was successful. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

1 0

Re: [PATCH v6 0/7] MR5666: d3dx9: More refactoring in preparation for shared code.
by Connor McAdams (＠cmcadams) 03 Jun '24

03 Jun '24

The test-linux-32 pipeline failures are unrelated to this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5666#note_72203

1 0

[PATCH 0/5] MR5776: win32u: Parameterize DPI in some driver calls.
by Rémi Bernon (＠rbernon) 03 Jun '24

03 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5776

3 8

[PATCH 0/2] MR5774: win32u: Move desktop resize on WM_DISPLAYCHANGE of the drivers.
by Rémi Bernon (＠rbernon) 03 Jun '24

03 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5774

4 11

[PATCH 0/1] MR5353: ddraw: Allow table to grow
by David Kahurani (＠ReDress) 03 Jun '24

03 Jun '24

This table doesn't really grow when the total number of handles exceeds the initial size. It will instead try to wrap and lead to an access violation. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5353

6 9

[PATCH 0/1] MR4773: ntdll: Derive not readable DMI's serial numbers from machine's GUID.
by eric pouech (＠epo) 03 Jun '24

03 Jun '24

Project Kunai associates cloud account with a mix of various items, including board serial number, resulting in several machines being bound to the same cloud account because the momo serial number is always empty. Note: this patch doesn't follow the systemd guidelines of not exposing directly /etc/machine-id content (but Wine already exposes /etc/machine-id as Windows machine GUID). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4773

2 2

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux. - closed
by eric pouech (＠epo) 03 Jun '24

03 Jun '24

This merge request was closed by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108

1 0

[PATCH 0/2] MR5775: wmic: Add csproduct and systemenclosure aliases.
by Hans Leidekker (＠hans) 03 Jun '24

03 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5775

2 2

Re: [PATCH v5 0/3] MR5737: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 03 Jun '24

03 Jun '24

Those comm test failures under Windows do not look related to this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737#note_72165

1 0

Re: [PATCH v26 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by Piotr Caban (＠piotr) 03 Jun '24

03 Jun '24

Please move the test to `dlls/ucrtbase/tests/file.c`. Also please add tests in separate patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72163

1 0

[PATCH 0/5] MR5732: winegstreamer: Get rid of the wg_transform internal output_format.
by Rémi Bernon (＠rbernon) 03 Jun '24

03 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5732

4 12

[PATCH v24 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 02 Jun '24

02 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v24: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

2 1

[PATCH v23 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 02 Jun '24

02 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v23: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 2

[PATCH v22 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 02 Jun '24

02 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v22: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 2

[PATCH v6 0/15] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 02 Jun '24

02 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v6: make_memfd_name: fix format specifiers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 20

[PATCH 0/1] MR5748: winegcc: do not add timestamp to allow reproducible builds
by Marcus Meissner (＠msmeissn) 02 Jun '24

02 Jun '24

The PE abi does not require them for binaries. Signed-off-by: Marcus Meissner <meissner(a)suse.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5748

5 6

[PATCH v21 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 02 Jun '24

02 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v21: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 8

[PATCH v7 0/1] MR4698: winewayland.drv: Add unaccelerated pointer support
by Grigory Vasilyev (＠h0tc0d3) 01 Jun '24

01 Jun '24

Adds the registry key `HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\unaccelerated_pointer` witch allows raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, and sensitivity curves in libinput are more difficult to calculate than in the games themselves. -- v7: winewayland.drv: Add unaccelerated pointer support https://gitlab.winehq.org/wine/wine/-/merge_requests/4698

3 2

[PATCH 0/1] MR5771: wintypes: Report UniversalApiContract version 7 as present.
by Vijay Kiran Kamuju (＠infyquest) 01 Jun '24

01 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52092 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5771

2 1

[PATCH v3 0/6] MR5724: widl: Various fixes.
by Elizabeth Figura (＠zfigura) 01 Jun '24

01 Jun '24

-- v3: widl: Do not write type definitions for types defined in an imported header. widl: Update the type location in define_type(). widl: Factor out a define_type() helper. widl: Invert "declonly". widl: Allow using UDTs with the keyword even when the identifier is also a typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/5724

3 12

Re: [PATCH v2 0/2] MR5424: faudio: Fix deadlock in voice callbacks
by Stanislau Tsitsianok (＠tsmx) 01 Jun '24

01 Jun '24

@julliard the fix is in 24.06 and it's just out, reminding just in case -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5424#note_72094

1 0

[PATCH v5 0/14] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 01 Jun '24

01 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v5: create_user_data_mapping: Set the LargePageMinimum field. Remove declaration for wine_unix_get_min_large_page_size. Add checks for linux/memfd.h and memfd_create on Linux. :NtCreateSection: remove trailing whitespace. Remove virtual_get_large_page_min_size and its exported wine syscall https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

2 14

[PATCH v19 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) 01 Jun '24

01 Jun '24

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v19: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 2

2025

2024

2023

2022

wine-gitlab June 2024