GStreamer uses _SC_NPROCESSORS_CONF to determine 'max-threads'. On the
Steam Deck, this is configured to be 16 (which is double its number
of logical cores).
_SC_NPROCESSORS_CONF also disregards a process's CPU affinity, thus it
can create more threads than is useful, which ultimately wastes memory
resources.
Using affinity to set 'max-threads' addresses both these problems.
--
v2: winegstreamer: Set MAX_THREADS to 4 for i386.
winegstreamer: Use thread_count to determine 'max-threads' value.
winegstreamer: Provide thread_count to init_gstreamer.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5923
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c:
> {
> if ((infoPtr->uView == LV_VIEW_LIST) || (infoPtr->uView == LV_VIEW_DETAILS))
> {
> - while (nItem < infoPtr->nItemCount)
> + while (nItem < infoPtr->nItemCount - 1)
This looks correct at first glance. Do you have an application affected by this? It seems to me changing this only reduces some time and -1 will be returned if it's the last item.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_74440
On Wed Jun 26 07:15:20 2024 +0000, Ilia Docin wrote:
> To reproduce it, I moved gripper left and right to hide some buttons,
> then brought it back. On the first image chevron didn't disappear as
> expected. On the second one chevron went away as I applied fix.
Do you have a link to the software you used to demonstrate?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_74439
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/rebar.c:
> lpBand->rcChild.top, lpBand->rcChild.right + CHEVRON_WIDTH,
Please also change the commit message title to "comctl32/rebar: Hide chevron if rebar's band is resized back to full size with gripper.". Note the dot at the end of the title.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_74438
Mostly race condition fixes.
"winegstreamer: Do waits for samples on stream-specific work queues." works around a Gstreamer bug that I'll try to write a minimal reproducer for and submit to their bug tracker. For now, doing sample waits actually concurrently works around the problem.
"winegstreamer: Fixate caps in autoplug_continue_cb." so far I've only seen relevant when the source is a uridecodebin (in Proton), but I though it couldn't hurt to upstream it too.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5917