> I don't want to be a blocker but to be honest I'm a bit annoyed with the idea of having to rewrite the patches I am trying to upstream with transform media types.
I'm going to delay making changes to wg_transform until you upstream your transform patches. I can concentrate on implementing the frontside first. So I'll simply remove patch 3,4,5 in this MR for now.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73808
On Wed Jun 19 15:58:14 2024 +0000, Elizabeth Figura wrote:
> > Can we add an encoder element without changing all this code? It
> doesn't look like you need all the complicated converter sequence, maybe
> only a videoconvert (do you even need one?).
> Yeah, in general the idea that we'd want the same sequence for decoding
> and encoding is probably wrong. E.g. for decoding we may want
> deinterlace, but we certainly don't want that for encoding. It's
> probably better to handle them separately.
Yeah, we can make things easy for encoder for now, only creating encoder element.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73807
LLVM 17 or 18 no longer allow non-private labels to appear between
.cfi_startproc/endproc when targeting Mach-O.
Similar fixes as in commit 295d521b11644fb76c36854336b13c2155bb7d79.
Since this is needed for 2 out of 4 architectures, would it be better to do it for all 4 and then modify the shared `__wine_syscall_dispatcher_return()` prototype?
--
v2: ntdll: Make __wine_syscall_dispatcher_return a separate function to fix Xcode 16 build errors.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5871