On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote:
> Setting the timeout on the socket is quite expensive (requires a
> wineserver call). Maybe we could store the last set timeout separate
> from configure timeout and update socket timeout only when they don't match?
Would this proposal be only for `read_more_data` or in the broader scope of any call to `NETCON_set_timeout`?
If it is for the latter, it could be tracked in `netconn_t`. I can add that into a separate merge.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72609
On Wed Jun 5 23:33:45 2024 +0000, Jacek Caban wrote:
> Do we still need it? I think that with implementation in both
> `set_global_option` and `INET_SetOption`, we could simply remove those
> cases from `InternetSetOptionW` fallback.
If we can assume that `vtbl->SetOption` is guaranteed to handle its own implementation of each timeout (or fallback to `INET_SetOption`), I could see dropping these cases from `InternetSetOptionW`.
I'll amend those changes.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72608